9d4a32596c
Summary:
Qt has its own thing where a type might also have corresponding list
alias, e.g. QObject and QObjectList, QWidget and QWidgetList. I don't
know why Qt does that, maybe for some historical reasons, but what
matters is that we copy this pattern here in KWin. While this pattern
might be useful with some long list types, for example
QList<QWeakPointer<TabBoxClient>> TabBoxClientList
in general, it causes more harm than good. For example, we've got two
new client types, do we need corresponding list typedefs for them? If
no, why do we have ClientList and so on?
Another problem with these typedefs is that you need to include utils.h
header in order to use them. A better way to handle such things is to
just forward declare a client class (if that's possible) and use it
directly with QList or QVector. This way translation units don't get
"bloated" with utils.h stuff for no apparent reason.
So, in order to make code more consistent and easier to follow, this
change drops some of our custom typedefs. Namely ConstClientList,
ClientList, DeletedList, UnmanagedList, ToplevelList, and GroupList.
Test Plan: Compiles.
Reviewers: #kwin
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D24950
97 lines
2.3 KiB
C++
97 lines
2.3 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 1999, 2000 Matthias Ettrich <ettrich@kde.org>
|
|
Copyright (C) 2003 Lubos Lunak <l.lunak@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_GROUP_H
|
|
#define KWIN_GROUP_H
|
|
|
|
#include "utils.h"
|
|
#include <netwm.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class EffectWindowGroupImpl;
|
|
class X11Client;
|
|
|
|
class Group
|
|
{
|
|
public:
|
|
Group(xcb_window_t leader);
|
|
~Group();
|
|
xcb_window_t leader() const;
|
|
const X11Client *leaderClient() const;
|
|
X11Client *leaderClient();
|
|
const QList<X11Client *> &members() const;
|
|
QIcon icon() const;
|
|
void addMember(X11Client *member);
|
|
void removeMember(X11Client *member);
|
|
void gotLeader(X11Client *leader);
|
|
void lostLeader();
|
|
void updateUserTime(xcb_timestamp_t time);
|
|
xcb_timestamp_t userTime() const;
|
|
void ref();
|
|
void deref();
|
|
EffectWindowGroupImpl* effectGroup();
|
|
private:
|
|
void startupIdChanged();
|
|
QList<X11Client *> _members;
|
|
X11Client *leader_client;
|
|
xcb_window_t leader_wid;
|
|
NETWinInfo* leader_info;
|
|
xcb_timestamp_t user_time;
|
|
int refcount;
|
|
EffectWindowGroupImpl* effect_group;
|
|
};
|
|
|
|
inline xcb_window_t Group::leader() const
|
|
{
|
|
return leader_wid;
|
|
}
|
|
|
|
inline const X11Client *Group::leaderClient() const
|
|
{
|
|
return leader_client;
|
|
}
|
|
|
|
inline X11Client *Group::leaderClient()
|
|
{
|
|
return leader_client;
|
|
}
|
|
|
|
inline const QList<X11Client *> &Group::members() const
|
|
{
|
|
return _members;
|
|
}
|
|
|
|
inline xcb_timestamp_t Group::userTime() const
|
|
{
|
|
return user_time;
|
|
}
|
|
|
|
inline
|
|
EffectWindowGroupImpl* Group::effectGroup()
|
|
{
|
|
return effect_group;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
#endif
|