7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
136 lines
4.3 KiB
C++
136 lines
4.3 KiB
C++
/*
|
|
SPDX-FileCopyrightText: 2020 Aleix Pol Gonzalez <aleixpol@kde.org>
|
|
|
|
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
|
|
*/
|
|
|
|
#include "xdgactivation_v1_interface.h"
|
|
#include "display.h"
|
|
#include "seat_interface.h"
|
|
#include "surface_interface.h"
|
|
|
|
#include "qwayland-server-xdg-activation-v1.h"
|
|
|
|
namespace KWaylandServer
|
|
{
|
|
static const int s_version = 1;
|
|
|
|
class XdgActivationTokenV1Interface : public QtWaylandServer::xdg_activation_token_v1
|
|
{
|
|
public:
|
|
XdgActivationTokenV1Interface(XdgActivationV1Interface::CreatorFunction creator, ClientConnection *client, uint32_t newId)
|
|
: QtWaylandServer::xdg_activation_token_v1(*client, newId, s_version)
|
|
, m_creator(creator)
|
|
, m_client(client)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
void xdg_activation_token_v1_set_serial(Resource *resource, uint32_t serial, struct ::wl_resource *seat) override;
|
|
void xdg_activation_token_v1_set_app_id(Resource *resource, const QString &app_id) override;
|
|
void xdg_activation_token_v1_set_surface(QtWaylandServer::xdg_activation_token_v1::Resource *resource, struct ::wl_resource *surface) override;
|
|
void xdg_activation_token_v1_commit(Resource *resource) override;
|
|
void xdg_activation_token_v1_destroy(Resource *resource) override;
|
|
void xdg_activation_token_v1_destroy_resource(Resource *resource) override;
|
|
|
|
const XdgActivationV1Interface::CreatorFunction m_creator;
|
|
QPointer<SurfaceInterface> m_surface;
|
|
uint m_serial = 0;
|
|
struct ::wl_resource *m_seat = nullptr;
|
|
QString m_appId;
|
|
bool m_committed = false;
|
|
ClientConnection *const m_client;
|
|
};
|
|
|
|
void XdgActivationTokenV1Interface::xdg_activation_token_v1_set_serial(Resource *resource, uint32_t serial, struct ::wl_resource *seat)
|
|
{
|
|
m_serial = serial;
|
|
m_seat = seat;
|
|
}
|
|
|
|
void XdgActivationTokenV1Interface::xdg_activation_token_v1_set_app_id(Resource *resource, const QString &app_id)
|
|
{
|
|
m_appId = app_id;
|
|
}
|
|
|
|
void XdgActivationTokenV1Interface::xdg_activation_token_v1_set_surface(Resource *resource, struct ::wl_resource *surface)
|
|
{
|
|
m_surface = SurfaceInterface::get(surface);
|
|
}
|
|
|
|
void XdgActivationTokenV1Interface::xdg_activation_token_v1_commit(Resource *resource)
|
|
{
|
|
QString token;
|
|
if (m_creator) {
|
|
token = m_creator(m_client, m_surface, m_serial, SeatInterface::get(m_seat), m_appId);
|
|
}
|
|
|
|
m_committed = true;
|
|
send_done(resource->handle, token);
|
|
}
|
|
|
|
void XdgActivationTokenV1Interface::xdg_activation_token_v1_destroy(Resource *resource)
|
|
{
|
|
if (!m_committed) {
|
|
send_done(resource->handle, {});
|
|
}
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
void XdgActivationTokenV1Interface::xdg_activation_token_v1_destroy_resource(Resource *resource)
|
|
{
|
|
delete this;
|
|
}
|
|
|
|
class XdgActivationV1InterfacePrivate : public QtWaylandServer::xdg_activation_v1
|
|
{
|
|
public:
|
|
XdgActivationV1InterfacePrivate(Display *display, XdgActivationV1Interface *q)
|
|
: QtWaylandServer::xdg_activation_v1(*display, s_version)
|
|
, q(q)
|
|
, m_display(display)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
void xdg_activation_v1_get_activation_token(Resource *resource, uint32_t id) override;
|
|
void xdg_activation_v1_activate(Resource *resource, const QString &token, struct ::wl_resource *surface) override;
|
|
void xdg_activation_v1_destroy(Resource *resource) override;
|
|
|
|
public:
|
|
XdgActivationV1Interface::CreatorFunction m_creator;
|
|
XdgActivationV1Interface *const q;
|
|
Display *const m_display;
|
|
};
|
|
|
|
void XdgActivationV1InterfacePrivate::xdg_activation_v1_get_activation_token(Resource *resource, uint32_t id)
|
|
{
|
|
new XdgActivationTokenV1Interface(m_creator, m_display->getConnection(resource->client()), id);
|
|
}
|
|
|
|
void XdgActivationV1InterfacePrivate::xdg_activation_v1_activate(Resource *resource, const QString &token, struct ::wl_resource *surface)
|
|
{
|
|
Q_EMIT q->activateRequested(SurfaceInterface::get(surface), token);
|
|
}
|
|
|
|
void XdgActivationV1InterfacePrivate::xdg_activation_v1_destroy(Resource *resource)
|
|
{
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
XdgActivationV1Interface::XdgActivationV1Interface(Display *display, QObject *parent)
|
|
: QObject(parent)
|
|
, d(new XdgActivationV1InterfacePrivate(display, this))
|
|
{
|
|
}
|
|
|
|
XdgActivationV1Interface::~XdgActivationV1Interface()
|
|
{
|
|
}
|
|
|
|
void XdgActivationV1Interface::setActivationTokenCreator(const CreatorFunction &creator)
|
|
{
|
|
d->m_creator = creator;
|
|
}
|
|
|
|
}
|