563e372440
X11-specific code path was overlooked in
79a4733dc5
.
390 lines
14 KiB
C++
390 lines
14 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2018 Martin Flöser <mgraesslin@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
|
|
*/
|
|
#include "config-kwin.h"
|
|
|
|
#include "kwin_wayland_test.h"
|
|
#include "abstract_client.h"
|
|
#include "atoms.h"
|
|
#include "x11client.h"
|
|
#include "deleted.h"
|
|
#include "platform.h"
|
|
#include "rules.h"
|
|
#include "virtualdesktops.h"
|
|
#include "wayland_server.h"
|
|
#include "workspace.h"
|
|
|
|
#include <KWayland/Client/surface.h>
|
|
|
|
#include <QDBusArgument>
|
|
#include <QDBusConnection>
|
|
#include <QDBusMessage>
|
|
#include <QDBusPendingReply>
|
|
#include <QUuid>
|
|
|
|
#include <netwm.h>
|
|
#include <xcb/xcb_icccm.h>
|
|
|
|
using namespace KWin;
|
|
using namespace KWayland::Client;
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_dbus_interface-0");
|
|
|
|
const QString s_destination{QStringLiteral("org.kde.KWin")};
|
|
const QString s_path{QStringLiteral("/KWin")};
|
|
const QString s_interface{QStringLiteral("org.kde.KWin")};
|
|
|
|
class TestDbusInterface : public QObject
|
|
{
|
|
Q_OBJECT
|
|
private Q_SLOTS:
|
|
void initTestCase();
|
|
void init();
|
|
void cleanup();
|
|
|
|
void testGetWindowInfoInvalidUuid();
|
|
void testGetWindowInfoXdgShellClient();
|
|
void testGetWindowInfoX11Client();
|
|
};
|
|
|
|
void TestDbusInterface::initTestCase()
|
|
{
|
|
qRegisterMetaType<KWin::Deleted*>();
|
|
qRegisterMetaType<KWin::AbstractClient*>();
|
|
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
|
QVERIFY(applicationStartedSpy.isValid());
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
|
QVERIFY(waylandServer()->init(s_socketName));
|
|
|
|
kwinApp()->start();
|
|
QVERIFY(applicationStartedSpy.wait());
|
|
Test::initWaylandWorkspace();
|
|
VirtualDesktopManager::self()->setCount(4);
|
|
}
|
|
|
|
void TestDbusInterface::init()
|
|
{
|
|
QVERIFY(Test::setupWaylandConnection());
|
|
}
|
|
|
|
void TestDbusInterface::cleanup()
|
|
{
|
|
Test::destroyWaylandConnection();
|
|
}
|
|
|
|
namespace {
|
|
QDBusPendingCall getWindowInfo(const QUuid &uuid)
|
|
{
|
|
auto msg = QDBusMessage::createMethodCall(s_destination, s_path, s_interface, QStringLiteral("getWindowInfo"));
|
|
msg.setArguments({uuid.toString()});
|
|
return QDBusConnection::sessionBus().asyncCall(msg);
|
|
}
|
|
}
|
|
|
|
void TestDbusInterface::testGetWindowInfoInvalidUuid()
|
|
{
|
|
QDBusPendingReply<QVariantMap> reply{getWindowInfo(QUuid::createUuid())};
|
|
reply.waitForFinished();
|
|
QVERIFY(reply.isValid());
|
|
QVERIFY(!reply.isError());
|
|
const auto windowData = reply.value();
|
|
QVERIFY(windowData.empty());
|
|
}
|
|
|
|
void TestDbusInterface::testGetWindowInfoXdgShellClient()
|
|
{
|
|
QSignalSpy clientAddedSpy(workspace(), &Workspace::clientAdded);
|
|
QVERIFY(clientAddedSpy.isValid());
|
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
|
shellSurface->set_app_id(QStringLiteral("org.kde.foo"));
|
|
shellSurface->set_title(QStringLiteral("Test window"));
|
|
|
|
// now let's render
|
|
Test::render(surface.data(), QSize(100, 50), Qt::blue);
|
|
QVERIFY(clientAddedSpy.isEmpty());
|
|
QVERIFY(clientAddedSpy.wait());
|
|
auto client = clientAddedSpy.first().first().value<AbstractClient *>();
|
|
QVERIFY(client);
|
|
|
|
const QVariantMap expectedData {
|
|
{ QStringLiteral("type"), int(NET::Normal) },
|
|
{ QStringLiteral("x"), client->x() },
|
|
{ QStringLiteral("y"), client->y() },
|
|
{ QStringLiteral("width"), client->width() },
|
|
{ QStringLiteral("height"), client->height() },
|
|
{ QStringLiteral("desktops"), client->desktopIds() },
|
|
{ QStringLiteral("minimized"), false },
|
|
{ QStringLiteral("shaded"), false },
|
|
{ QStringLiteral("fullscreen"), false },
|
|
{ QStringLiteral("keepAbove"), false },
|
|
{ QStringLiteral("keepBelow"), false },
|
|
{ QStringLiteral("skipTaskbar"), false },
|
|
{ QStringLiteral("skipPager"), false },
|
|
{ QStringLiteral("skipSwitcher"), false },
|
|
{ QStringLiteral("maximizeHorizontal"), false },
|
|
{ QStringLiteral("maximizeVertical"), false },
|
|
{ QStringLiteral("noBorder"), false },
|
|
{ QStringLiteral("clientMachine"), QString() },
|
|
{ QStringLiteral("localhost"), true },
|
|
{ QStringLiteral("role"), QString() },
|
|
{ QStringLiteral("resourceName"), QStringLiteral("testDbusInterface") },
|
|
{ QStringLiteral("resourceClass"), QStringLiteral("org.kde.foo") },
|
|
{ QStringLiteral("desktopFile"), QStringLiteral("org.kde.foo") },
|
|
{ QStringLiteral("caption"), QStringLiteral("Test window") },
|
|
#if KWIN_BUILD_ACTIVITIES
|
|
{ QStringLiteral("activities"), QStringList() },
|
|
#endif
|
|
};
|
|
|
|
// let's get the window info
|
|
QDBusPendingReply<QVariantMap> reply{getWindowInfo(client->internalId())};
|
|
reply.waitForFinished();
|
|
QVERIFY(reply.isValid());
|
|
QVERIFY(!reply.isError());
|
|
auto windowData = reply.value();
|
|
QCOMPARE(windowData, expectedData);
|
|
|
|
auto verifyProperty = [client] (const QString &name) {
|
|
QDBusPendingReply<QVariantMap> reply{getWindowInfo(client->internalId())};
|
|
reply.waitForFinished();
|
|
return reply.value().value(name).toBool();
|
|
};
|
|
|
|
QVERIFY(!client->isMinimized());
|
|
client->setMinimized(true);
|
|
QVERIFY(client->isMinimized());
|
|
QCOMPARE(verifyProperty(QStringLiteral("minimized")), true);
|
|
|
|
QVERIFY(!client->keepAbove());
|
|
client->setKeepAbove(true);
|
|
QVERIFY(client->keepAbove());
|
|
QCOMPARE(verifyProperty(QStringLiteral("keepAbove")), true);
|
|
|
|
QVERIFY(!client->keepBelow());
|
|
client->setKeepBelow(true);
|
|
QVERIFY(client->keepBelow());
|
|
QCOMPARE(verifyProperty(QStringLiteral("keepBelow")), true);
|
|
|
|
QVERIFY(!client->skipTaskbar());
|
|
client->setSkipTaskbar(true);
|
|
QVERIFY(client->skipTaskbar());
|
|
QCOMPARE(verifyProperty(QStringLiteral("skipTaskbar")), true);
|
|
|
|
QVERIFY(!client->skipPager());
|
|
client->setSkipPager(true);
|
|
QVERIFY(client->skipPager());
|
|
QCOMPARE(verifyProperty(QStringLiteral("skipPager")), true);
|
|
|
|
QVERIFY(!client->skipSwitcher());
|
|
client->setSkipSwitcher(true);
|
|
QVERIFY(client->skipSwitcher());
|
|
QCOMPARE(verifyProperty(QStringLiteral("skipSwitcher")), true);
|
|
|
|
// not testing shaded as that's X11
|
|
// not testing fullscreen, maximizeHorizontal, maximizeVertical and noBorder as those require window geometry changes
|
|
|
|
QCOMPARE(client->desktop(), 1);
|
|
workspace()->sendClientToDesktop(client, 2, false);
|
|
QCOMPARE(client->desktop(), 2);
|
|
reply = getWindowInfo(client->internalId());
|
|
reply.waitForFinished();
|
|
QCOMPARE(reply.value().value(QStringLiteral("desktops")).toStringList(), client->desktopIds());
|
|
|
|
client->move(QPoint(10, 20));
|
|
reply = getWindowInfo(client->internalId());
|
|
reply.waitForFinished();
|
|
QCOMPARE(reply.value().value(QStringLiteral("x")).toInt(), client->x());
|
|
QCOMPARE(reply.value().value(QStringLiteral("y")).toInt(), client->y());
|
|
// not testing width, height as that would require window geometry change
|
|
|
|
// finally close window
|
|
const auto id = client->internalId();
|
|
QSignalSpy windowClosedSpy(client, &AbstractClient::windowClosed);
|
|
QVERIFY(windowClosedSpy.isValid());
|
|
shellSurface.reset();
|
|
surface.reset();
|
|
QVERIFY(windowClosedSpy.wait());
|
|
QCOMPARE(windowClosedSpy.count(), 1);
|
|
|
|
reply = getWindowInfo(id);
|
|
reply.waitForFinished();
|
|
QVERIFY(reply.value().empty());
|
|
}
|
|
|
|
|
|
struct XcbConnectionDeleter
|
|
{
|
|
static inline void cleanup(xcb_connection_t *pointer)
|
|
{
|
|
xcb_disconnect(pointer);
|
|
}
|
|
};
|
|
|
|
void TestDbusInterface::testGetWindowInfoX11Client()
|
|
{
|
|
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
|
QVERIFY(!xcb_connection_has_error(c.data()));
|
|
const QRect windowGeometry(0, 0, 600, 400);
|
|
xcb_window_t w = xcb_generate_id(c.data());
|
|
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
|
windowGeometry.x(),
|
|
windowGeometry.y(),
|
|
windowGeometry.width(),
|
|
windowGeometry.height(),
|
|
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
|
xcb_size_hints_t hints;
|
|
memset(&hints, 0, sizeof(hints));
|
|
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
|
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
|
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
|
xcb_icccm_set_wm_class(c.data(), w, 7, "foo\0bar");
|
|
NETWinInfo winInfo(c.data(), w, rootWindow(), NET::Properties(), NET::Properties2());
|
|
winInfo.setName("Some caption");
|
|
winInfo.setDesktopFileName("org.kde.foo");
|
|
xcb_map_window(c.data(), w);
|
|
xcb_flush(c.data());
|
|
|
|
// we should get a client for it
|
|
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
|
QVERIFY(windowCreatedSpy.isValid());
|
|
QVERIFY(windowCreatedSpy.wait());
|
|
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
|
QVERIFY(client);
|
|
QCOMPARE(client->window(), w);
|
|
QCOMPARE(client->clientSize(), windowGeometry.size());
|
|
|
|
const QVariantMap expectedData {
|
|
{ QStringLiteral("type"), NET::Normal },
|
|
{ QStringLiteral("x"), client->x() },
|
|
{ QStringLiteral("y"), client->y() },
|
|
{ QStringLiteral("width"), client->width() },
|
|
{ QStringLiteral("height"), client->height() },
|
|
{ QStringLiteral("desktops"), client->desktopIds() },
|
|
{ QStringLiteral("minimized"), false },
|
|
{ QStringLiteral("shaded"), false },
|
|
{ QStringLiteral("fullscreen"), false },
|
|
{ QStringLiteral("keepAbove"), false },
|
|
{ QStringLiteral("keepBelow"), false },
|
|
{ QStringLiteral("skipTaskbar"), false },
|
|
{ QStringLiteral("skipPager"), false },
|
|
{ QStringLiteral("skipSwitcher"), false },
|
|
{ QStringLiteral("maximizeHorizontal"), false },
|
|
{ QStringLiteral("maximizeVertical"), false },
|
|
{ QStringLiteral("noBorder"), false },
|
|
{ QStringLiteral("role"), QString() },
|
|
{ QStringLiteral("resourceName"), QStringLiteral("foo") },
|
|
{ QStringLiteral("resourceClass"), QStringLiteral("bar") },
|
|
{ QStringLiteral("desktopFile"), QStringLiteral("org.kde.foo") },
|
|
{ QStringLiteral("caption"), QStringLiteral("Some caption") },
|
|
#if KWIN_BUILD_ACTIVITIES
|
|
{ QStringLiteral("activities"), QStringList() },
|
|
#endif
|
|
};
|
|
|
|
// let's get the window info
|
|
QDBusPendingReply<QVariantMap> reply{getWindowInfo(client->internalId())};
|
|
reply.waitForFinished();
|
|
QVERIFY(reply.isValid());
|
|
QVERIFY(!reply.isError());
|
|
auto windowData = reply.value();
|
|
// not testing clientmachine as that is system dependent due to that also not testing localhost
|
|
windowData.remove(QStringLiteral("clientMachine"));
|
|
windowData.remove(QStringLiteral("localhost"));
|
|
QCOMPARE(windowData, expectedData);
|
|
|
|
auto verifyProperty = [client] (const QString &name) {
|
|
QDBusPendingReply<QVariantMap> reply{getWindowInfo(client->internalId())};
|
|
reply.waitForFinished();
|
|
return reply.value().value(name).toBool();
|
|
};
|
|
|
|
QVERIFY(!client->isMinimized());
|
|
client->setMinimized(true);
|
|
QVERIFY(client->isMinimized());
|
|
QCOMPARE(verifyProperty(QStringLiteral("minimized")), true);
|
|
|
|
QVERIFY(!client->keepAbove());
|
|
client->setKeepAbove(true);
|
|
QVERIFY(client->keepAbove());
|
|
QCOMPARE(verifyProperty(QStringLiteral("keepAbove")), true);
|
|
|
|
QVERIFY(!client->keepBelow());
|
|
client->setKeepBelow(true);
|
|
QVERIFY(client->keepBelow());
|
|
QCOMPARE(verifyProperty(QStringLiteral("keepBelow")), true);
|
|
|
|
QVERIFY(!client->skipTaskbar());
|
|
client->setSkipTaskbar(true);
|
|
QVERIFY(client->skipTaskbar());
|
|
QCOMPARE(verifyProperty(QStringLiteral("skipTaskbar")), true);
|
|
|
|
QVERIFY(!client->skipPager());
|
|
client->setSkipPager(true);
|
|
QVERIFY(client->skipPager());
|
|
QCOMPARE(verifyProperty(QStringLiteral("skipPager")), true);
|
|
|
|
QVERIFY(!client->skipSwitcher());
|
|
client->setSkipSwitcher(true);
|
|
QVERIFY(client->skipSwitcher());
|
|
QCOMPARE(verifyProperty(QStringLiteral("skipSwitcher")), true);
|
|
|
|
QVERIFY(!client->isShade());
|
|
client->setShade(ShadeNormal);
|
|
QVERIFY(client->isShade());
|
|
QCOMPARE(verifyProperty(QStringLiteral("shaded")), true);
|
|
client->setShade(ShadeNone);
|
|
QVERIFY(!client->isShade());
|
|
|
|
QVERIFY(!client->noBorder());
|
|
client->setNoBorder(true);
|
|
QVERIFY(client->noBorder());
|
|
QCOMPARE(verifyProperty(QStringLiteral("noBorder")), true);
|
|
client->setNoBorder(false);
|
|
QVERIFY(!client->noBorder());
|
|
|
|
QVERIFY(!client->isFullScreen());
|
|
client->setFullScreen(true);
|
|
QVERIFY(client->isFullScreen());
|
|
QVERIFY(client->clientSize() != windowGeometry.size());
|
|
QCOMPARE(verifyProperty(QStringLiteral("fullscreen")), true);
|
|
reply = getWindowInfo(client->internalId());
|
|
reply.waitForFinished();
|
|
QCOMPARE(reply.value().value(QStringLiteral("width")).toInt(), client->width());
|
|
QCOMPARE(reply.value().value(QStringLiteral("height")).toInt(), client->height());
|
|
client->setFullScreen(false);
|
|
QVERIFY(!client->isFullScreen());
|
|
|
|
// maximize
|
|
client->setMaximize(true, false);
|
|
QCOMPARE(verifyProperty(QStringLiteral("maximizeVertical")), true);
|
|
QCOMPARE(verifyProperty(QStringLiteral("maximizeHorizontal")), false);
|
|
client->setMaximize(false, true);
|
|
QCOMPARE(verifyProperty(QStringLiteral("maximizeVertical")), false);
|
|
QCOMPARE(verifyProperty(QStringLiteral("maximizeHorizontal")), true);
|
|
|
|
const auto id = client->internalId();
|
|
// destroy the window
|
|
xcb_unmap_window(c.data(), w);
|
|
xcb_flush(c.data());
|
|
|
|
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
|
QVERIFY(windowClosedSpy.isValid());
|
|
QVERIFY(windowClosedSpy.wait());
|
|
xcb_destroy_window(c.data(), w);
|
|
c.reset();
|
|
|
|
reply = getWindowInfo(id);
|
|
reply.waitForFinished();
|
|
QVERIFY(reply.value().empty());
|
|
}
|
|
|
|
WAYLANDTEST_MAIN(TestDbusInterface)
|
|
#include "dbus_interface_test.moc"
|