8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
134 lines
4.2 KiB
C++
134 lines
4.2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2006 Lubos Lunak <l.lunak@kde.org>
|
|
Copyright (C) 2010 Sebastian Sauer <sebsauer@kdab.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_ZOOM_H
|
|
#define KWIN_ZOOM_H
|
|
|
|
#include <kwineffects.h>
|
|
#include <QTime>
|
|
#include <QTimeLine>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class GLTexture;
|
|
class XRenderPicture;
|
|
|
|
class ZoomEffect
|
|
: public Effect
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(qreal zoomFactor READ configuredZoomFactor)
|
|
Q_PROPERTY(int mousePointer READ configuredMousePointer)
|
|
Q_PROPERTY(int mouseTracking READ configuredMouseTracking)
|
|
Q_PROPERTY(bool enableFocusTracking READ isEnableFocusTracking)
|
|
Q_PROPERTY(bool followFocus READ isFollowFocus)
|
|
Q_PROPERTY(int focusDelay READ configuredFocusDelay)
|
|
Q_PROPERTY(qreal moveFactor READ configuredMoveFactor)
|
|
Q_PROPERTY(qreal targetZoom READ targetZoom)
|
|
public:
|
|
ZoomEffect();
|
|
~ZoomEffect() override;
|
|
void reconfigure(ReconfigureFlags flags) override;
|
|
void prePaintScreen(ScreenPrePaintData& data, int time) override;
|
|
void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
|
|
void postPaintScreen() override;
|
|
bool isActive() const override;
|
|
// for properties
|
|
qreal configuredZoomFactor() const {
|
|
return zoomFactor;
|
|
}
|
|
int configuredMousePointer() const {
|
|
return mousePointer;
|
|
}
|
|
int configuredMouseTracking() const {
|
|
return mouseTracking;
|
|
}
|
|
bool isEnableFocusTracking() const {
|
|
return enableFocusTracking;
|
|
}
|
|
bool isFollowFocus() const {
|
|
return followFocus;
|
|
}
|
|
int configuredFocusDelay() const {
|
|
return focusDelay;
|
|
}
|
|
qreal configuredMoveFactor() const {
|
|
return moveFactor;
|
|
}
|
|
qreal targetZoom() const {
|
|
return target_zoom;
|
|
}
|
|
private Q_SLOTS:
|
|
inline void zoomIn() { zoomIn(-1.0); };
|
|
void zoomIn(double to);
|
|
void zoomOut();
|
|
void actualSize();
|
|
void moveZoomLeft();
|
|
void moveZoomRight();
|
|
void moveZoomUp();
|
|
void moveZoomDown();
|
|
void moveMouseToFocus();
|
|
void moveMouseToCenter();
|
|
void timelineFrameChanged(int frame);
|
|
void focusChanged(int px, int py, int rx, int ry, int rwidth, int rheight);
|
|
void slotMouseChanged(const QPoint& pos, const QPoint& old,
|
|
Qt::MouseButtons buttons, Qt::MouseButtons oldbuttons,
|
|
Qt::KeyboardModifiers modifiers, Qt::KeyboardModifiers oldmodifiers);
|
|
void recreateTexture();
|
|
private:
|
|
void showCursor();
|
|
void hideCursor();
|
|
void moveZoom(int x, int y);
|
|
private:
|
|
double zoom;
|
|
double target_zoom;
|
|
double source_zoom;
|
|
bool polling; // Mouse polling
|
|
double zoomFactor;
|
|
enum MouseTrackingType { MouseTrackingProportional = 0, MouseTrackingCentred = 1, MouseTrackingPush = 2, MouseTrackingDisabled = 3 };
|
|
MouseTrackingType mouseTracking;
|
|
bool enableFocusTracking;
|
|
bool followFocus;
|
|
enum MousePointerType { MousePointerScale = 0, MousePointerKeep = 1, MousePointerHide = 2 };
|
|
MousePointerType mousePointer;
|
|
int focusDelay;
|
|
QPoint cursorPoint;
|
|
QPoint cursorHotSpot;
|
|
QPoint focusPoint;
|
|
QPoint prevPoint;
|
|
QTime lastMouseEvent;
|
|
QTime lastFocusEvent;
|
|
QScopedPointer<GLTexture> texture;
|
|
#ifdef KWIN_HAVE_XRENDER_COMPOSITING
|
|
QScopedPointer<XRenderPicture> xrenderPicture;
|
|
#endif
|
|
int imageWidth;
|
|
int imageHeight;
|
|
bool isMouseHidden;
|
|
QTimeLine timeline;
|
|
int xMove, yMove;
|
|
double moveFactor;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
#endif
|