8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
87 lines
2.7 KiB
C++
87 lines
2.7 KiB
C++
/*
|
|
* Copyright 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#ifndef KDECOARTIONS_PREVIEW_BUTTON_ITEM_H
|
|
#define KDECOARTIONS_PREVIEW_BUTTON_ITEM_H
|
|
|
|
#include <QQuickPaintedItem>
|
|
#include <QColor>
|
|
#include <QPointer>
|
|
#include <KDecoration2/DecorationButton>
|
|
|
|
namespace KDecoration2
|
|
{
|
|
class Decoration;
|
|
|
|
namespace Preview
|
|
{
|
|
class PreviewBridge;
|
|
class Settings;
|
|
|
|
class PreviewButtonItem : public QQuickPaintedItem
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(KDecoration2::Preview::PreviewBridge *bridge READ bridge WRITE setBridge NOTIFY bridgeChanged)
|
|
Q_PROPERTY(KDecoration2::Preview::Settings *settings READ settings WRITE setSettings NOTIFY settingsChanged)
|
|
Q_PROPERTY(int type READ typeAsInt WRITE setType NOTIFY typeChanged)
|
|
Q_PROPERTY(QColor color READ color WRITE setColor)
|
|
|
|
public:
|
|
explicit PreviewButtonItem(QQuickItem *parent = nullptr);
|
|
~PreviewButtonItem() override;
|
|
void paint(QPainter *painter) override;
|
|
|
|
PreviewBridge *bridge() const;
|
|
void setBridge(PreviewBridge *bridge);
|
|
|
|
Settings *settings() const;
|
|
void setSettings(Settings *settings);
|
|
|
|
KDecoration2::DecorationButtonType type() const;
|
|
int typeAsInt() const;
|
|
void setType(KDecoration2::DecorationButtonType type);
|
|
void setType(int type);
|
|
|
|
const QColor &color() const { return m_color; }
|
|
void setColor(const QColor color);
|
|
|
|
Q_SIGNALS:
|
|
void bridgeChanged();
|
|
void typeChanged();
|
|
void settingsChanged();
|
|
|
|
protected:
|
|
void componentComplete() override;
|
|
|
|
private:
|
|
void createButton();
|
|
void syncGeometry();
|
|
QColor m_color;
|
|
QPointer<KDecoration2::Preview::PreviewBridge> m_bridge;
|
|
QPointer<KDecoration2::Preview::Settings> m_settings;
|
|
KDecoration2::Decoration *m_decoration = nullptr;
|
|
KDecoration2::DecorationButton *m_button = nullptr;
|
|
KDecoration2::DecorationButtonType m_type = KDecoration2::DecorationButtonType::Custom;
|
|
|
|
};
|
|
|
|
} // Preview
|
|
} // KDecoration2
|
|
|
|
#endif
|