e9ab34854d
Summary: Currently, effects like Maximize, Slide Back have problems with setting WindowForceBlurRole. They store previous state of WindowForceBlurRole. This is wrong. Instead they should either ignore previous state of WindowForceBlur or refcount forced role. There's no need for refcounting right now. For example, if several effects force blur or background contrast, they are most likely in a conflict. Please notice that the Desktop Grid effect uses the Present Windows effect only to calculate transformations. Some other problems with the code that sets WindowForceBlurRole: * Maximize effect stores previous state of WindowForceBlurRole only for one window. It ignores the fact that there could be several active maximize animations; * Desktop Grid/Present Windows/Slide back don't clean after themselves. So, after using those effects for good amount of times, memory usage will bump. Test Plan: * Enabled blur for Konsole * Maximized Konsole * Activated Present Windows * Activated Desktop Grid * Raised another window(to trigger Slide Back) Reviewers: #kwin, fredrik Reviewed By: fredrik Subscribers: fredrik, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13479
103 lines
3.9 KiB
JavaScript
103 lines
3.9 KiB
JavaScript
/********************************************************************
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2012 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
/*global effect, effects, animate, animationTime, Effect*/
|
|
var maximizeEffect = {
|
|
duration: animationTime(250),
|
|
loadConfig: function () {
|
|
"use strict";
|
|
maximizeEffect.duration = animationTime(250);
|
|
},
|
|
maximizeChanged: function (window) {
|
|
"use strict";
|
|
if (!window.oldGeometry) {
|
|
return;
|
|
}
|
|
window.setData(Effect.WindowForceBlurRole, true);
|
|
var oldGeometry, newGeometry;
|
|
oldGeometry = window.oldGeometry;
|
|
newGeometry = window.geometry;
|
|
if (oldGeometry.width == newGeometry.width && oldGeometry.height == newGeometry.height)
|
|
oldGeometry = window.olderGeometry;
|
|
window.olderGeometry = window.oldGeometry;
|
|
window.oldGeometry = newGeometry;
|
|
window.maximizeAnimation1 = animate({
|
|
window: window,
|
|
duration: maximizeEffect.duration,
|
|
animations: [{
|
|
type: Effect.Size,
|
|
to: {
|
|
value1: newGeometry.width,
|
|
value2: newGeometry.height
|
|
},
|
|
from: {
|
|
value1: oldGeometry.width,
|
|
value2: oldGeometry.height
|
|
}
|
|
}, {
|
|
type: Effect.Translation,
|
|
to: {
|
|
value1: 0,
|
|
value2: 0
|
|
},
|
|
from: {
|
|
value1: oldGeometry.x - newGeometry.x - (newGeometry.width / 2 - oldGeometry.width / 2),
|
|
value2: oldGeometry.y - newGeometry.y - (newGeometry.height / 2 - oldGeometry.height / 2)
|
|
}
|
|
}]
|
|
});
|
|
if (!window.resize) {
|
|
window.maximizeAnimation2 =animate({
|
|
window: window,
|
|
duration: maximizeEffect.duration,
|
|
animations: [{
|
|
type: Effect.CrossFadePrevious,
|
|
to: 1.0,
|
|
from: 0.0
|
|
}]
|
|
});
|
|
}
|
|
},
|
|
restoreForceBlurState: function(window) {
|
|
window.setData(Effect.WindowForceBlurRole, null);
|
|
},
|
|
geometryChange: function (window, oldGeometry) {
|
|
"use strict";
|
|
if (window.maximizeAnimation1) {
|
|
if (window.geometry.width != window.oldGeometry.width ||
|
|
window.geometry.height != window.oldGeometry.height) {
|
|
cancel(window.maximizeAnimation1);
|
|
delete window.maximizeAnimation1;
|
|
if (window.maximizeAnimation2) {
|
|
cancel(window.maximizeAnimation2);
|
|
delete window.maximizeAnimation2;
|
|
}
|
|
}
|
|
}
|
|
window.oldGeometry = window.geometry;
|
|
window.olderGeometry = oldGeometry;
|
|
},
|
|
init: function () {
|
|
"use strict";
|
|
effect.configChanged.connect(maximizeEffect.loadConfig);
|
|
effects.windowGeometryShapeChanged.connect(maximizeEffect.geometryChange);
|
|
effects.windowMaximizedStateChanged.connect(maximizeEffect.maximizeChanged);
|
|
effect.animationEnded.connect(maximizeEffect.restoreForceBlurState);
|
|
}
|
|
};
|
|
maximizeEffect.init();
|