kwin/src/keyboard_layout_switching.h
Vlad Zahorodnii 7fffe99328 build: Add -Wno-unused-parameter compiler option
Due to being a compositor, kwin has to conform to some certain
interfaces. It means a lot of virtual functions and function tables to
integrate with C APIs. Naturally, we not always want to use every
argument in such functions.

Since we get -Wunused-parameter from -Wall, we have to plumb those
unused arguments in order to suppress compiler warnings at the moment.

However, I don't think that extra work is worth it. We cannot change or
alter prototypes in any way to fix the warning the desired way. Q_UNUSED
and similar macros are not good indicators of whether an argument is
used too, we tend to overlook putting or removing those macros. I've
also noticed that Q_UNUSED are not used to guide us with the removal no
longer needed parameters.

Therefore, I think it's worth adding -Wno-unused-parameter compiler
option to stop the compiler producing warnings about unused parameters.
It changes nothing except that we don't need to put Q_UNUSED anymore,
which can be really cumbersome sometimes. Note that it doesn't affect
unused variables, you'll still get a -Wunused-variable compiler warning
if a variable is unused.
2022-10-31 15:50:37 +00:00

146 lines
2.9 KiB
C++

/*
KWin - the KDE window manager
This file is part of the KDE project.
SPDX-FileCopyrightText: 2017 Martin Gräßlin <mgraesslin@kde.org>
SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef KWIN_KEYBOARD_LAYOUT_SWITCHING_H
#define KWIN_KEYBOARD_LAYOUT_SWITCHING_H
#include <KConfigGroup>
#include <QHash>
#include <QObject>
#include <memory>
namespace KWin
{
class Window;
class KeyboardLayout;
class Xkb;
class VirtualDesktop;
namespace KeyboardLayoutSwitching
{
class Policy : public QObject
{
Q_OBJECT
public:
~Policy() override;
virtual QString name() const = 0;
static std::unique_ptr<Policy> create(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config, const QString &policy);
protected:
explicit Policy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config = KConfigGroup());
virtual void clearCache() = 0;
virtual void layoutChanged(uint index) = 0;
void setLayout(uint index);
KConfigGroup m_config;
virtual const QString defaultLayoutEntryKey() const;
void clearLayouts();
static const char defaultLayoutEntryKeyPrefix[];
Xkb *m_xkb;
private:
KeyboardLayout *m_layout;
};
class GlobalPolicy : public Policy
{
Q_OBJECT
public:
explicit GlobalPolicy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config);
~GlobalPolicy() override;
QString name() const override
{
return QStringLiteral("Global");
}
protected:
void clearCache() override
{
}
void layoutChanged(uint index) override
{
}
private:
const QString defaultLayoutEntryKey() const override;
};
class VirtualDesktopPolicy : public Policy
{
Q_OBJECT
public:
explicit VirtualDesktopPolicy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config);
~VirtualDesktopPolicy() override;
QString name() const override
{
return QStringLiteral("Desktop");
}
protected:
void clearCache() override;
void layoutChanged(uint index) override;
private:
void desktopChanged();
QHash<VirtualDesktop *, quint32> m_layouts;
};
class WindowPolicy : public Policy
{
Q_OBJECT
public:
explicit WindowPolicy(Xkb *xkb, KeyboardLayout *layout);
~WindowPolicy() override;
QString name() const override
{
return QStringLiteral("Window");
}
protected:
void clearCache() override;
void layoutChanged(uint index) override;
private:
QHash<Window *, quint32> m_layouts;
};
class ApplicationPolicy : public Policy
{
Q_OBJECT
public:
explicit ApplicationPolicy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config);
~ApplicationPolicy() override;
QString name() const override
{
return QStringLiteral("WinClass");
}
protected:
void clearCache() override;
void layoutChanged(uint index) override;
private:
void windowActivated(Window *window);
QHash<Window *, quint32> m_layouts;
QHash<QString, quint32> m_layoutsRestored;
};
}
}
#endif