kwin/kcmkwin/kwinrules
Ismael Asensio db7fb26eed [kcm/kwinrules] Fix size properties not being stored
Summary:
Use `QSize`/`QPoint` to handle and store coordinate values (size and position)

Previously, the rules model stored the "coordinate" type properties as a
`QString` with format `x, y`.

This fails when setting the properties to the config schema, as it requires
a proper `QPoint` or `QSize` value, specially the latter which can't be
convert from such a string.

BUG: 421055
FIXED-IN: 5.19.0

Test Plan:
- Add a new rule and set its position and size properties
- Hitting apply stores the right values in `~\.config\kwinrulesrc`
- Close the kcm and reopen, the values are loaded
- Property detection still works for size and position

Please note that there is a pre-existing bug of some position/sizes not being
applied to the windows in some cases, when using `Apply Initially`.
Better try using the `Force` policy.

Reviewers: ngraham, #kwin, #plasma, zzag

Reviewed By: #kwin, #plasma, zzag

Subscribers: zzag, ltoscano, yurchor, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D29764
2020-05-15 19:45:11 +02:00
..
package [kcm/kwinrules] Fix size properties not being stored 2020-05-15 19:45:11 +02:00
CMakeLists.txt [kcmkwin/kwinrules] Change translation domain 2020-05-12 10:58:30 +02:00
kcm_kwinrules.desktop KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
kcmrules.cpp KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
kcmrules.h KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
kwinsrc.cpp Reduce the amount of objects that are compiled several times 2020-04-02 00:41:55 +02:00
main.cpp KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
Messages.sh [kcmkwin/kwinrules] Change translation domain 2020-05-12 10:58:30 +02:00
optionsmodel.cpp KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
optionsmodel.h KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
rulebookmodel.cpp KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
rulebookmodel.h KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
ruleitem.cpp [kcm/kwinrules] Fix size properties not being stored 2020-05-15 19:45:11 +02:00
ruleitem.h [kcm/kwinrules] Fix size properties not being stored 2020-05-15 19:45:11 +02:00
rulesdialog.cpp KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
rulesdialog.h KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00
rulesmodel.cpp [kcm/kwinrules] Fix size properties not being stored 2020-05-15 19:45:11 +02:00
rulesmodel.h KWinRules KCM Redesign 2020-04-22 21:34:48 +02:00