2211a951e7
Summary:
A while ago desktop effects and compositing settings lived under the
same roof
{F6584639}
{F6584642}
but time has passed and now those two have their own kcms. This causes
some issues:
* for newcomers it's harder to find code of the Desktop Effects KCM;
* git history doesn't look good, e.g. "[kcmkwin/compositing] Add some
bugs to Desktop Effects KCM to fix later";
* in general, the mix of two doesn't look good in the code.
This change splits out the Desktop Effects KCM. Unfortunately, in order
to have more nicer code I had to refactor EffectModel a little bit.
Before:
{F6584669}
After:
{F6587570}
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, ltoscano, mart, ngraham, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D18703
58 lines
1.5 KiB
C++
58 lines
1.5 KiB
C++
/*
|
|
* Copyright (C) 2019 Vlad Zagorodniy <vladzzag@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <KQuickAddons/ConfigModule>
|
|
|
|
#include <QAbstractItemModel>
|
|
#include <QQuickItem>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class EffectModel;
|
|
|
|
class DesktopEffectsKCM : public KQuickAddons::ConfigModule
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(QAbstractItemModel *effectsModel READ effectsModel CONSTANT)
|
|
|
|
public:
|
|
explicit DesktopEffectsKCM(QObject *parent = nullptr, const QVariantList &list = {});
|
|
~DesktopEffectsKCM() override;
|
|
|
|
QAbstractItemModel *effectsModel() const;
|
|
|
|
public Q_SLOTS:
|
|
void load() override;
|
|
void save() override;
|
|
void defaults() override;
|
|
|
|
void openGHNS(QQuickItem *context);
|
|
void configure(const QString &pluginId, QQuickItem *context);
|
|
|
|
private Q_SLOTS:
|
|
void updateNeedsSave();
|
|
|
|
private:
|
|
EffectModel *m_model;
|
|
|
|
Q_DISABLE_COPY(DesktopEffectsKCM)
|
|
};
|
|
|
|
} // namespace KWin
|