My KWIN fork where I work on features like per-output virtual desktops
Find a file
David Edmundson fbb71f9c0b XWayland: Don't dispatch xwayland events in QAbstractEventDispatcher sleeps
QAbstractEventDispatcher blocks and waits constantly on every external event
processed; every timer or update from an X or wayland client, mouse
move or DRM event.

Right now every time this happens we go and check Xwayland for new
events, this is a system call (poll) that based on strace will
unsurprisingly immediately return with EAGAIN as there's nothing to read
from X. If there is something to read our socket notifier will fire. On block we do still need to read any events read in the meantime that weren't dispatched.

This cuts down our system calls significantly, which hopefully should have a
noticeable impact on performance especially when the kernel is under
load.

---

Found whilst analysing strace (by accident whilst looking for something else!)

In a simple case of xwayland nested running glxgears we go from 28 calls per frame to 21. With many many clients and more input events it'll be an even higher percentage.
2023-02-08 10:34:20 +00:00
autotests effects: Drop legacy EffectsHandler::desktopChanged overloads 2023-02-07 18:10:52 +02:00
cmake/modules Fix some tests not building with Qt 6 2022-10-20 09:37:00 +00:00
data Run clang-tidy with -checks=readability-braces-around-statements fixit 2022-03-28 10:54:11 +00:00
doc Update decoration kcm docbook 2023-02-05 02:22:14 +00:00
kconf_update kconf_update: replace cascaded by zero-cornered placement 2022-12-02 14:05:32 +00:00
LICENSES Remove unused license file 2022-08-23 17:41:55 +02:00
po GIT_SILENT Sync po/docbooks with svn 2023-02-08 03:29:52 +00:00
src XWayland: Don't dispatch xwayland events in QAbstractEventDispatcher sleeps 2023-02-08 10:34:20 +00:00
tests build: Add -Wno-unused-parameter compiler option 2022-10-31 15:50:37 +00:00
.clang-format Run clang-format 2022-03-25 13:25:15 +02:00
.gitignore Run clang-format 2022-03-25 13:25:15 +02:00
.gitlab-ci.yml Add Qt 6 FreeBSD CI 2022-10-22 12:34:49 +00:00
.kde-ci.yml ci: Sort dependencies in alphabetical order 2022-12-17 22:29:22 +00:00
CMakeLists.txt Update version number for 5.27.80 2023-01-27 14:55:36 +00:00
CONTRIBUTING.md add more debugging information to CONTRIBUTING.md 2023-01-09 13:40:31 +00:00
KWinDBusInterfaceConfig.cmake.in Expose org.kde.kwin.ColorCorrect.xml dbus file 2022-01-05 01:33:01 +00:00
logo.png
Mainpage.dox
plasma-kwin_wayland.service.in Re-enable systemd managed kwin 2021-12-02 13:25:50 +00:00
plasma-kwin_x11.service.in [systemd] Fix X11 service file 2022-01-20 16:18:48 +00:00
README.md doc: modernise HACKING -> CONTRIBUTING guidelines and information 2021-08-31 22:10:58 +00:00

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contributing to KWin

Please refer to the contributing document for everything you need to know to get started contributing to KWin.

Contacting KWin development team

  • mailing list: kwin@kde.org
  • IRC: #kde-kwin on irc.libera.chat

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.