abedb464d5
Summary: The test DontCrashUseractionsMenu (Waylandonly) found an issue in our screen handling implementation in the QPA. The code exposed a short time frame between the dummy screen getting destroyed and the first screen being added. This could result in a crash of KWin. There is actually no need to implement Screen on top of Wayland screen. KWin has all the knowledge, so we can also base this on top of the Screens API. Advantages: * no delays due to Wayland roundtrips * handle screen getting removed (was a TODO) * handle resolution changes (was a TODO) The new implementation has a disadvantage that it destroys and readds all screens whenever something around the screen changes. This shouldn't be an issue in practice as it's only for the internal QPA and thus only affects KWin internal windows which is placed in global coordinates anyway. If it turns out to be a problem we need to track better the screen changes - so far those were not tracked at all. Test Plan: Run a few unit tests which change screens Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8345 |
||
|---|---|---|
| .. | ||
| integration | ||
| libinput | ||
| libkwineffects | ||
| libxrenderutils | ||
| tabbox | ||
| abstract_client.h | ||
| client.h | ||
| CMakeLists.txt | ||
| fakeeffectplugin.cpp | ||
| fakeeffectplugin.json | ||
| fakeeffectplugin_version.cpp | ||
| fakeeffectplugin_version.json | ||
| mock_abstract_client.cpp | ||
| mock_abstract_client.h | ||
| mock_client.cpp | ||
| mock_client.h | ||
| mock_effectshandler.cpp | ||
| mock_effectshandler.h | ||
| mock_screens.cpp | ||
| mock_screens.h | ||
| mock_workspace.cpp | ||
| mock_workspace.h | ||
| onscreennotificationtest.cpp | ||
| onscreennotificationtest.h | ||
| opengl_context_attribute_builder_test.cpp | ||
| test_builtin_effectloader.cpp | ||
| test_client_machine.cpp | ||
| test_gbm_surface.cpp | ||
| test_gestures.cpp | ||
| test_plugin_effectloader.cpp | ||
| test_screen_edges.cpp | ||
| test_screen_paint_data.cpp | ||
| test_screens.cpp | ||
| test_scripted_effectloader.cpp | ||
| test_virtual_desktops.cpp | ||
| test_virtualkeyboard_dbus.cpp | ||
| test_window_paint_data.cpp | ||
| test_x11_timestamp_update.cpp | ||
| test_xcb_size_hints.cpp | ||
| test_xcb_window.cpp | ||
| test_xcb_wrapper.cpp | ||
| test_xkb.cpp | ||
| test_xrandr_screens.cpp | ||
| testutils.h | ||
| workspace.h | ||