kwin/plugins/platforms/x11/standalone/effects_x11.h
Vlad Zagorodniy 38e22ce6d1 [platforms/x11] Properly unload effects on X11
Summary:
When Compositor finishes compositing, it destroys EffectsHandlerImpl,
which in its turn tries to unload all effects. But there is a problem...

EffectsHandlerImpl has platform-specific hooks to ungrab keyboard and
also stop mouse interception. Given that any call made to a virtual function
in the destructor of a base class(EffectsHandlerImpl) won't go to a derived
class(EffectsHandlerImplX11), keyboard won't be ungrabbed even if effect
that grabbed it is already gone.

BUG: 399572

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D19178
2019-03-11 09:23:24 +02:00

58 lines
1.7 KiB
C++

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2006 Lubos Lunak <l.lunak@kde.org>
Copyright (C) 2010, 2011, 2017 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_EFFECTS_X11_H
#define KWIN_EFFECTS_X11_H
#include "effects.h"
#include "xcbutils.h"
#include <memory.h>
namespace KWin
{
class EffectsMouseInterceptionX11Filter;
class EffectsHandlerImplX11 : public EffectsHandlerImpl
{
Q_OBJECT
public:
explicit EffectsHandlerImplX11(Compositor *compositor, Scene *scene);
~EffectsHandlerImplX11() override;
void defineCursor(Qt::CursorShape shape) override;
protected:
bool doGrabKeyboard() override;
void doUngrabKeyboard() override;
void doStartMouseInterception(Qt::CursorShape shape) override;
void doStopMouseInterception() override;
void doCheckInputWindowStacking() override;
private:
Xcb::Window m_mouseInterceptionWindow;
std::unique_ptr<EffectsMouseInterceptionX11Filter> m_x11MouseInterception;
};
}
#endif