kwin/src/dpmsinputeventfilter.cpp
Vlad Zahorodnii 7fffe99328 build: Add -Wno-unused-parameter compiler option
Due to being a compositor, kwin has to conform to some certain
interfaces. It means a lot of virtual functions and function tables to
integrate with C APIs. Naturally, we not always want to use every
argument in such functions.

Since we get -Wunused-parameter from -Wall, we have to plumb those
unused arguments in order to suppress compiler warnings at the moment.

However, I don't think that extra work is worth it. We cannot change or
alter prototypes in any way to fix the warning the desired way. Q_UNUSED
and similar macros are not good indicators of whether an argument is
used too, we tend to overlook putting or removing those macros. I've
also noticed that Q_UNUSED are not used to guide us with the removal no
longer needed parameters.

Therefore, I think it's worth adding -Wno-unused-parameter compiler
option to stop the compiler producing warnings about unused parameters.
It changes nothing except that we don't need to put Q_UNUSED anymore,
which can be really cumbersome sometimes. Note that it doesn't affect
unused variables, you'll still get a -Wunused-variable compiler warning
if a variable is unused.
2022-10-31 15:50:37 +00:00

106 lines
2.6 KiB
C++

/*
KWin - the KDE window manager
This file is part of the KDE project.
SPDX-FileCopyrightText: 2015 Martin Gräßlin <mgraesslin@kde.org>
SPDX-License-Identifier: GPL-2.0-or-later
*/
#include "dpmsinputeventfilter.h"
#include "core/output.h"
#include "main.h"
#include "wayland/seat_interface.h"
#include "wayland_server.h"
#include "workspace.h"
#include <QGuiApplication>
#include <QKeyEvent>
namespace KWin
{
DpmsInputEventFilter::DpmsInputEventFilter()
: InputEventFilter()
{
KSharedConfig::Ptr kwinSettings = kwinApp()->config();
m_enableDoubleTap = kwinSettings->group("Wayland").readEntry<bool>("DoubleTapWakeup", true);
}
DpmsInputEventFilter::~DpmsInputEventFilter() = default;
bool DpmsInputEventFilter::pointerEvent(QMouseEvent *event, quint32 nativeButton)
{
notify();
return true;
}
bool DpmsInputEventFilter::wheelEvent(QWheelEvent *event)
{
notify();
return true;
}
bool DpmsInputEventFilter::keyEvent(QKeyEvent *event)
{
if (event->type() == QKeyEvent::KeyPress) {
notify();
}
return true;
}
bool DpmsInputEventFilter::touchDown(qint32 id, const QPointF &pos, quint32 time)
{
if (m_enableDoubleTap) {
if (m_touchPoints.isEmpty()) {
if (!m_doubleTapTimer.isValid()) {
// this is the first tap
m_doubleTapTimer.start();
} else {
if (m_doubleTapTimer.elapsed() < qApp->doubleClickInterval()) {
m_secondTap = true;
} else {
// took too long. Let's consider it a new click
m_doubleTapTimer.restart();
}
}
} else {
// not a double tap
m_doubleTapTimer.invalidate();
m_secondTap = false;
}
m_touchPoints << id;
}
return true;
}
bool DpmsInputEventFilter::touchUp(qint32 id, quint32 time)
{
if (m_enableDoubleTap) {
m_touchPoints.removeAll(id);
if (m_touchPoints.isEmpty() && m_doubleTapTimer.isValid() && m_secondTap) {
if (m_doubleTapTimer.elapsed() < qApp->doubleClickInterval()) {
waylandServer()->seat()->setTimestamp(time);
notify();
}
m_doubleTapTimer.invalidate();
m_secondTap = false;
}
}
return true;
}
bool DpmsInputEventFilter::touchMotion(qint32 id, const QPointF &pos, quint32 time)
{
// ignore the event
return true;
}
void DpmsInputEventFilter::notify()
{
const QList<Output *> outputs = workspace()->outputs();
for (Output *output : outputs) {
output->setDpmsMode(Output::DpmsMode::On);
}
}
}