yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/CMakeLists.txt

234 lines
6.5 KiB
CMake
Raw Normal View History

[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 08:48:07 +00:00
add_definitions(-DKWIN_UNIT_TEST)
optimize string operations -use qstringliteral only when necessary (i.e. not in concat or comparison) -use qbytearray instead of qstring when dealing with latin1 input and output (glplatform) -use qstringref to extract numbers from strings (glplatform) -define qt_use_qstringbuilder to optimize all string concatenations -anidata: use ctor init lists, add windowType member initialization REVIEW: 125933
2015-11-05 14:14:06 +00:00
remove_definitions(-DQT_USE_QSTRINGBUILDER)
[autotests] Move libkwineffects/autotests to autotests/libkwineffects All autotests shall be in autotests subdirectory.
2016-07-18 06:47:45 +00:00
add_subdirectory(libkwineffects)
[libkwinxrenderutils] Clean up static blend picture before going down Summary: The method xRenderBlendPicture created a static XRenderPicture on first usage. To cleanup a XRenderPicture an xcb_connection_t* is needed. As it's static the cleanup happens on exit handler and at that time Qt already destroyed the xcb_connection_t*. With a certain chance this will crash. To expose the problem a Q_ASSERT(qApp) is added in the destructor of XRenderPicture. Using xrenderBlendPicture() will hit this assert on application exit. This is demonstrated by the added auto test. The actual fix to the problem is moving the static variable out of the method and introduce a global cleanup method just like the init method. This is now called from Workspace dtor, so before application goes down. CCBUG: 363251 Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1731
2016-06-01 08:21:19 +00:00
add_subdirectory(libxrenderutils)
Rename autotests/wayland to autotests/integration It's not about Wayland, but more about Integration. It can test both Wayland and X11 windows. Reviewed-By: Bhushan Shah
2016-06-29 08:29:45 +00:00
add_subdirectory(integration)
Require libinput and udev Summary: The main reason for not having it as a mandatory dependency was that BSD doesn't support it. But as I learned recently it is available on our CI system. So BSDs have support now. Even more it showed that the code doesn't compile if the dependency is missing. And there's one thing I hate: broken build configuration options. So let's make UDEV and libinput a required dependency and get rid of the problems. Test Plan: Compiles Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D10057
2018-01-23 16:28:18 +00:00
add_subdirectory(libinput)
Move tabbox/autotests to autotests/tabbox Let's have all autotests in autotests subdirectory instead of spread out over the source tree.
2016-06-29 08:38:17 +00:00
add_subdirectory(tabbox)
[kwin-wayland] Create dedicated thread for wayland connection The Wayland event queue is moved into a dedicated thread and a new class is created for just creating the connection and listening for events. The WaylandBackend creates the thread and uses an event queue for the main thread. REVIEW: 119761
2014-08-13 10:54:02 +00:00
Adding unit test for ScreenPaintData and WindowPaintData
2012-06-03 07:15:10 +00:00
########################################################
# Test ScreenPaintData
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testScreenPaintData_SRCS test_screen_paint_data.cpp)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
add_executable(testScreenPaintData ${testScreenPaintData_SRCS})
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
target_link_libraries(testScreenPaintData kwineffects Qt::Test Qt::Widgets KF5::WindowSystem)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testScreenPaintData COMMAND testScreenPaintData)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testScreenPaintData)
Adding unit test for ScreenPaintData and WindowPaintData
2012-06-03 07:15:10 +00:00
########################################################
# Test WindowPaintData
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testWindowPaintData_SRCS test_window_paint_data.cpp)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
add_executable(testWindowPaintData ${testWindowPaintData_SRCS})
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
target_link_libraries(testWindowPaintData kwineffects Qt::Widgets Qt::Test )
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testWindowPaintData COMMAND testWindowPaintData)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testWindowPaintData)
Move handling of Virtual Desktops into a VirtualDesktopManager The ownership for virtual desktops is moved from Workspace into a new VirtualDesktopManager. The manager is responsible for providing the count of virtual desktops and keeping track of the currently used virtual desktop. All methods related to moving between desktops are also moved from Workspace to the new manager, though all methods related to Clients on Virtual Desktops remain in Workspace for the time being. This is to have the new manager as independent from KWin core as possible. An rather important change for the handling of virtual desktops is that the count and the id of a desktop is now an unsinged integer instead of an integer. The reason for that is that we cannot have a negative count of desktops as well as it is not possible to be on a desktop with a negative identifier. In that regard it is important to remember that a Client can be on a desktop with a negative identifier. The special value for a Client being on all desktops is handled by using -1 as a desktop. For the time being this is not adjusted but instead of comparing the virtual desktop ids one should prefer to use the convenient methods like isOnDesktop and isOnAllDesktops. This would allow in future to internally change the representation for on all desktops.
2012-11-16 07:23:47 +00:00
########################################################
# Test VirtualDesktopManager
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testVirtualDesktops_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../src/virtualdesktops.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
test_virtual_desktops.cpp
[kwin] Fix TestVirtualDesktops * enable compilation * Remove KActionCollection
2014-01-07 12:45:25 +00:00
)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
add_executable(testVirtualDesktops ${testVirtualDesktops_SRCS})
[kwin] Fix TestVirtualDesktops * enable compilation * Remove KActionCollection
2014-01-07 12:45:25 +00:00
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
target_link_libraries(testVirtualDesktops
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Qt::Widgets
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
KF5::ConfigCore
KF5::GlobalAccel
KF5::I18n
Port KWin to KWaylandServer Summary: Away from KWayland::Server and KF5WaylandServer. Test Plan: Builds, ran nested session Reviewers: #kwin, #plasma, #frameworks, davidedmundson, zzag Reviewed By: #kwin, #plasma, davidedmundson, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D29278
2020-04-29 15:18:41 +00:00
Plasma::KWaylandServer
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
KF5::WindowSystem
[kwin] Fix TestVirtualDesktops * enable compilation * Remove KActionCollection
2014-01-07 12:45:25 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testVirtualDesktops COMMAND testVirtualDesktops)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testVirtualDesktops)
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 07:07:27 +00:00
########################################################
# Test ClientMachine
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testClientMachine_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../src/client_machine.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
test_client_machine.cpp
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 07:07:27 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testClientMachine ${testClientMachine_SRCS})
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 16:47:58 +00:00
set_target_properties(testClientMachine PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 07:07:27 +00:00
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
target_link_libraries(testClientMachine
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Concurrent
Qt::Test
Qt::Widgets
Qt::X11Extras
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
KF5::WindowSystem
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
XCB::XCB
XCB::XFIXES
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
${X11_X11_LIB} # to make jenkins happy
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 07:07:27 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testClientMachine COMMAND testClientMachine)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testClientMachine)
Do not use a shared pointer for the Xcb::Wrapper It's not really needed, the required functionality can be achieved in a more implicit way. The reply pointer is managed by the Wrapper class as long as the method take() is not invoked. This method follows the semantics of QScopedPointer::take(). That is the pointer is set to null and the responsibility to free the pointer is passed to the callee. By this change we do not have the overhead of creating a QSharedPointer. In addition the Wrapper provides a copy ctor and assignment operator also using the semantics of take().
2013-01-14 08:20:59 +00:00
########################################################
# Test XcbWrapper
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testXcbWrapper_SRCS
test_xcb_wrapper.cpp
Do not use a shared pointer for the Xcb::Wrapper It's not really needed, the required functionality can be achieved in a more implicit way. The reply pointer is managed by the Wrapper class as long as the method take() is not invoked. This method follows the semantics of QScopedPointer::take(). That is the pointer is set to null and the responsibility to free the pointer is passed to the callee. By this change we do not have the overhead of creating a QSharedPointer. In addition the Wrapper provides a copy ctor and assignment operator also using the semantics of take().
2013-01-14 08:20:59 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testXcbWrapper ${testXcbWrapper_SRCS})
target_link_libraries(testXcbWrapper
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Qt::Widgets
Qt::X11Extras
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
KF5::WindowSystem
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
XCB::XCB
Do not use a shared pointer for the Xcb::Wrapper It's not really needed, the required functionality can be achieved in a more implicit way. The reply pointer is managed by the Wrapper class as long as the method take() is not invoked. This method follows the semantics of QScopedPointer::take(). That is the pointer is set to null and the responsibility to free the pointer is passed to the callee. By this change we do not have the overhead of creating a QSharedPointer. In addition the Wrapper provides a copy ctor and assignment operator also using the semantics of take().
2013-01-14 08:20:59 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testXcbWrapper COMMAND testXcbWrapper)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testXcbWrapper)
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 13:03:05 +00:00
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 13:54:20 +00:00
if (XCB_ICCCM_FOUND)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testXcbSizeHints test_xcb_size_hints.cpp)
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 16:47:58 +00:00
set_target_properties(testXcbSizeHints PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
target_link_libraries(testXcbSizeHints
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Qt::Widgets
Qt::X11Extras
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
KF5::WindowSystem
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
XCB::ICCCM
XCB::XCB
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 13:54:20 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testXcbSizeHints COMMAND testXcbSizeHints)
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 13:54:20 +00:00
ecm_mark_as_test(testXcbSizeHints)
endif()
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 13:03:05 +00:00
########################################################
# Test XcbWindow
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testXcbWindow_SRCS
test_xcb_window.cpp
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 13:03:05 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testXcbWindow ${testXcbWindow_SRCS})
target_link_libraries(testXcbWindow
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Qt::Widgets
Qt::X11Extras
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
KF5::WindowSystem
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
XCB::XCB
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 13:03:05 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testXcbWindow COMMAND testXcbWindow)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testXcbWindow)
[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 08:48:07 +00:00
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
include_directories(${KWin_SOURCE_DIR}/src)
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 08:29:03 +00:00
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 10:53:50 +00:00
########################################################
# Test OnScreenNotification
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testOnScreenNotification_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../src/input_event_spy.cpp
../src/onscreennotification.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
onscreennotificationtest.cpp
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 10:53:50 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testOnScreenNotification ${testOnScreenNotification_SRCS})
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 10:53:50 +00:00
target_link_libraries(testOnScreenNotification
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::DBus
Qt::Quick
Qt::Test
Qt::Widgets # QAction include
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 10:53:50 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testOnScreenNotification COMMAND testOnScreenNotification)
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 10:53:50 +00:00
ecm_mark_as_test(testOnScreenNotification)
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 10:00:30 +00:00
########################################################
# Test Gestures
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testGestures_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../src/gestures.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
test_gestures.cpp
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 10:00:30 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testGestures ${testGestures_SRCS})
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 10:00:30 +00:00
target_link_libraries(testGestures
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 10:00:30 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testGestures COMMAND testGestures)
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 10:00:30 +00:00
ecm_mark_as_test(testGestures)
Merge branch 'Plasma/5.9'
2017-05-05 17:16:38 +00:00
Improve the x11 timestamp handling Summary: So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates problems when the 32 bit msec based time stamp wraps around which happens after running an X server for 49 days. After the timestamp wrapped around KWin would not update the timestamp any more and thus some calls might fail. Most prominent victims are keyboard and pointer grab which fails as the timestamp is either larger than the server timestamp or smaller than the last grab timestamp. Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh which used to send a timestamp as unix time which is larger than the x timestamp and thus our timestamp gets too large. This change addresses these problems by allowing to reset the timestamp. This is only used from updateXTime (which is normally invoked before we do things like grabKeyboard). Thus we make QX11Info::getTimestamp the ultimate trusted source for timestamps. BUG: 377901 BUG: 348569 FIXED-IN: 5.8.7 Test Plan: As I cannot wait 50 days: unit tests for the two conditions added. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5704
2017-05-03 19:17:25 +00:00
########################################################
# Test X11 TimestampUpdate
########################################################
add_executable(testX11TimestampUpdate test_x11_timestamp_update.cpp)
target_link_libraries(testX11TimestampUpdate
[autotests] Fix testX11TimestampUpdate after latest change We need to init the X11 standalone platform plugin now.
2017-08-24 19:48:29 +00:00
KF5::CoreAddons
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Improve the x11 timestamp handling Summary: So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates problems when the 32 bit msec based time stamp wraps around which happens after running an X server for 49 days. After the timestamp wrapped around KWin would not update the timestamp any more and thus some calls might fail. Most prominent victims are keyboard and pointer grab which fails as the timestamp is either larger than the server timestamp or smaller than the last grab timestamp. Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh which used to send a timestamp as unix time which is larger than the x timestamp and thus our timestamp gets too large. This change addresses these problems by allowing to reset the timestamp. This is only used from updateXTime (which is normally invoked before we do things like grabKeyboard). Thus we make QX11Info::getTimestamp the ultimate trusted source for timestamps. BUG: 377901 BUG: 348569 FIXED-IN: 5.8.7 Test Plan: As I cannot wait 50 days: unit tests for the two conditions added. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5704
2017-05-03 19:17:25 +00:00
kwin
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testX11TimestampUpdate COMMAND testX11TimestampUpdate)
Improve the x11 timestamp handling Summary: So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates problems when the 32 bit msec based time stamp wraps around which happens after running an X server for 49 days. After the timestamp wrapped around KWin would not update the timestamp any more and thus some calls might fail. Most prominent victims are keyboard and pointer grab which fails as the timestamp is either larger than the server timestamp or smaller than the last grab timestamp. Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh which used to send a timestamp as unix time which is larger than the x timestamp and thus our timestamp gets too large. This change addresses these problems by allowing to reset the timestamp. This is only used from updateXTime (which is normally invoked before we do things like grabKeyboard). Thus we make QX11Info::getTimestamp the ultimate trusted source for timestamps. BUG: 377901 BUG: 348569 FIXED-IN: 5.8.7 Test Plan: As I cannot wait 50 days: unit tests for the two conditions added. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5704
2017-05-03 19:17:25 +00:00
ecm_mark_as_test(testX11TimestampUpdate)
Refactor the specification of OpenGL context attributes Summary: The current way to specify the OpenGL context attributes does no longer scale as can be seen in D6344. There are too many different context attribute sets and with every addition we grow lots of copied code. The chances to introduce errors in that code which is difficult to debug are very high. As can be seen in the glx backend which defines major 1, minor 2, but it should be major 2, minor 1. This change reworks this code by creating a builder class which contains only an abstract definition of what needs to be in the attributes. E.g. the version, whether it's robust and so on. Now we can just have a list of possible attributes in a well described way: auto builder; builder.setVersion(3, 1); builder.setRobust(true); All possible builders are added to a list and operated on in a for loop which tries to creat a context. Once it succeeded it breaks the list. In addition a debug statement is added which prints out the set of options which went into the context. So far this is only done for EGL, GLX can follow once D6344 is merged. Test Plan: New unit test added, kwin_wayland OpenGL tests run and verified Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6396
2017-06-26 04:56:55 +00:00
[platforms/x11] Use a GlxContextAttributeBuilder Summary: Based on the work of 3f4995fb9b4fd753a304ea65020bbafdd174936b this change introduces a GlxContextAttributeBuilder to make the requesting of context attributes cleaner, more verbose and less error prone copy and paste. Test Plan: Switched between Core and legacy and verified the output; extended auto test Reviewers: #kwin, #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D6411
2017-06-27 19:08:19 +00:00
set(testOpenGLContextAttributeBuilder_SRCS
Move opengl context attribute builders to utils directory
2022-01-13 14:02:41 +00:00
../src/utils/abstract_opengl_context_attribute_builder.cpp
../src/utils/egl_context_attribute_builder.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
opengl_context_attribute_builder_test.cpp
[platforms/x11] Use a GlxContextAttributeBuilder Summary: Based on the work of 3f4995fb9b4fd753a304ea65020bbafdd174936b this change introduces a GlxContextAttributeBuilder to make the requesting of context attributes cleaner, more verbose and less error prone copy and paste. Test Plan: Switched between Core and legacy and verified the output; extended auto test Reviewers: #kwin, #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D6411
2017-06-27 19:08:19 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
if (HAVE_EPOXY_GLX)
Move platform backends to backends directory This improves file organization in kwin by putting backends in a single directory. It also makes easier to discover kwin's low level components for new contributors because the plugins directory may come as the last place to look for. When one hears "plugin", the first thing that comes to mind is regular plugins, not low level backends.
2021-10-31 17:25:26 +00:00
set(testOpenGLContextAttributeBuilder_SRCS ${testOpenGLContextAttributeBuilder_SRCS} ../src/backends/x11/standalone/glx_context_attribute_builder.cpp)
[platforms/x11] Use a GlxContextAttributeBuilder Summary: Based on the work of 3f4995fb9b4fd753a304ea65020bbafdd174936b this change introduces a GlxContextAttributeBuilder to make the requesting of context attributes cleaner, more verbose and less error prone copy and paste. Test Plan: Switched between Core and legacy and verified the output; extended auto test Reviewers: #kwin, #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D6411
2017-06-27 19:08:19 +00:00
endif()
add_executable(testOpenGLContextAttributeBuilder ${testOpenGLContextAttributeBuilder_SRCS})
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
target_link_libraries(testOpenGLContextAttributeBuilder Qt::Test)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testOpenGLContextAttributeBuilder COMMAND testOpenGLContextAttributeBuilder)
Refactor the specification of OpenGL context attributes Summary: The current way to specify the OpenGL context attributes does no longer scale as can be seen in D6344. There are too many different context attribute sets and with every addition we grow lots of copied code. The chances to introduce errors in that code which is difficult to debug are very high. As can be seen in the glx backend which defines major 1, minor 2, but it should be major 2, minor 1. This change reworks this code by creating a builder class which contains only an abstract definition of what needs to be in the attributes. E.g. the version, whether it's robust and so on. Now we can just have a list of possible attributes in a well described way: auto builder; builder.setVersion(3, 1); builder.setRobust(true); All possible builders are added to a list and operated on in a for loop which tries to creat a context. Once it succeeded it breaks the list. In addition a debug statement is added which prints out the set of options which went into the context. So far this is only done for EGL, GLX can follow once D6344 is merged. Test Plan: New unit test added, kwin_wayland OpenGL tests run and verified Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6396
2017-06-26 04:56:55 +00:00
ecm_mark_as_test(testOpenGLContextAttributeBuilder)
[autotests] Add test case for Xkb::toQtKey Tests all key codes KKeyServer is able to map to Qt.
2017-08-15 14:48:03 +00:00
set(testXkb_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../src/xkb.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
test_xkb.cpp
[autotests] Add test case for Xkb::toQtKey Tests all key codes KKeyServer is able to map to Qt.
2017-08-15 14:48:03 +00:00
)
add_executable(testXkb ${testXkb_SRCS})
target_link_libraries(testXkb
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Gui
Qt::Test
Qt::Widgets
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
Port KWin to KWaylandServer Summary: Away from KWayland::Server and KF5WaylandServer. Test Plan: Builds, ran nested session Reviewers: #kwin, #plasma, #frameworks, davidedmundson, zzag Reviewed By: #kwin, #plasma, davidedmundson, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D29278
2020-04-29 15:18:41 +00:00
Plasma::KWaylandServer
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::WindowSystem
Move Xkb::LEDs enum to KWin namespace With the LEDs enum being defined in kwinglobals.h, wayland_server.h won't need to include keyboard_input.h, which is good for compilation times and wayland_server.h will drag less stuff, e.g. QtWidgets (input.h includes QAction)
2021-10-04 16:36:32 +00:00
kwineffects
Revert "cmake: Get XKB information directly from PkgConfig" This reverts commit 3c97cecdb0dc402fc6edae959fb24e9922e77978. It seems to break on the CI and I don't understand why.
2021-03-02 01:14:39 +00:00
XKB::XKB
fix global shortcuts for non-Latin symbols Re-use Qt's implementation of handling non-Latin layouts here For full ASCII range support (Alt+`, etc.) Qt needs to be patched still, see QTBUG-90611 BUG: 375518
2021-03-15 17:34:41 +00:00
Qt5::XkbCommonSupportPrivate
[autotests] Add test case for Xkb::toQtKey Tests all key codes KKeyServer is able to map to Qt.
2017-08-15 14:48:03 +00:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testXkb COMMAND testXkb)
[autotests] Add test case for Xkb::toQtKey Tests all key codes KKeyServer is able to map to Qt.
2017-08-15 14:48:03 +00:00
ecm_mark_as_test(testXkb)
[platforms/drm] Use a shared pointer for gbm_surface Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152
2017-10-05 16:58:57 +00:00
Add ftrace markers This logs to a tracefs filesystem which can be viewed in tools such as gpuvis to see precise timings of activities in relation to other trace markers in X or graphic drivers. This patch is loosely based on D23114. Though modified with thread safety, support for string building, and a RAII pattern for durations. Ultimately that expanded it somewhat.
2020-09-07 08:11:47 +00:00
########################################################
# Test FTrace
########################################################
add_executable(testFtrace test_ftrace.cpp)
target_link_libraries(testFtrace
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Test
Add ftrace markers This logs to a tracefs filesystem which can be viewed in tools such as gpuvis to see precise timings of activities in relation to other trace markers in X or graphic drivers. This patch is loosely based on D23114. Though modified with thread safety, support for string building, and a RAII pattern for durations. Ultimately that expanded it somewhat.
2020-09-07 08:11:47 +00:00
kwin
)
add_test(NAME kwin-testFtrace COMMAND testFtrace)
ecm_mark_as_test(testFtrace)
Reference in a new issue Copy permalink