2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2014-07-22 11:11:19 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
|
2014-07-22 11:11:19 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2014-07-22 11:11:19 +00:00
|
|
|
#ifndef KWIN_DECORATION_RENDERER_H
|
|
|
|
#define KWIN_DECORATION_RENDERER_H
|
|
|
|
|
|
|
|
#include <QObject>
|
|
|
|
#include <QRegion>
|
|
|
|
|
2017-08-10 16:13:42 +00:00
|
|
|
#include <kwin_export.h>
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
2014-07-23 07:20:28 +00:00
|
|
|
class Deleted;
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
namespace Decoration
|
|
|
|
{
|
|
|
|
|
|
|
|
class DecoratedClientImpl;
|
|
|
|
|
2017-08-10 16:13:42 +00:00
|
|
|
class KWIN_EXPORT Renderer : public QObject
|
2014-07-22 11:11:19 +00:00
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~Renderer() override;
|
2014-07-22 11:11:19 +00:00
|
|
|
|
|
|
|
void schedule(const QRect &rect);
|
|
|
|
|
2014-07-23 07:20:28 +00:00
|
|
|
/**
|
|
|
|
* Reparents this Renderer to the @p deleted.
|
|
|
|
* After this call the Renderer is no longer able to render
|
|
|
|
* anything, client() returns a nullptr.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-07-23 07:20:28 +00:00
|
|
|
virtual void reparent(Deleted *deleted);
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
Q_SIGNALS:
|
|
|
|
void renderScheduled(const QRect &geo);
|
|
|
|
|
|
|
|
protected:
|
|
|
|
explicit Renderer(DecoratedClientImpl *client);
|
|
|
|
/**
|
|
|
|
* @returns the scheduled paint region and resets
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-07-22 11:11:19 +00:00
|
|
|
QRegion getScheduled();
|
|
|
|
|
|
|
|
virtual void render() = 0;
|
|
|
|
|
|
|
|
DecoratedClientImpl *client() {
|
|
|
|
return m_client;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool areImageSizesDirty() const {
|
|
|
|
return m_imageSizesDirty;
|
|
|
|
}
|
|
|
|
void resetImageSizesDirty() {
|
|
|
|
m_imageSizesDirty = false;
|
|
|
|
}
|
|
|
|
QImage renderToImage(const QRect &geo);
|
[scene] Fix decoration texture bleeding
Summary:
Quite long time ago, window decorations were painted on real X11 windows.
The nicest thing about that approach is that we get both contents of the
client and the frame window at the same time. However, somewhere around
KDE 4.2 - 4.3 times, decoration rendering architecture had been changed
to what we have now.
I've mentioned the previous decoration rendering design because it didn't
have a problem that the new design has, namely the texture bleeding issue.
In the name of better performance, opengl scene puts all decoration parts
to an atlas. This is totally reasonable, however we must be super cautious
about things such as the GL_LINEAR filter.
The GL_LINEAR filter may need to sample a couple of neighboring texels
in order to produce the final texel value. However, since all decoration
parts now live in a single texture, we have to make sure that we don't
sample texels that belong to another decoration part.
This patch fixes the texture bleeding problem by padding each individual
decoration part in the atlas. There is another solution for this problem
though. We could render a window into an offscreen texture and then map
that texture on the transformed window geometry. This would work well and
we definitely need an offscreen rendering path in the opengl scene,
however it's not feasible at the moment since we need to break the window
quads API. Also, it would be great to have as less as possible stuff going
on between invocation of Scene::Window::performPaint() and getting the
corresponding pixel data on the screen.
There is a good chance that the new padding stuff may make you vomit. If
it does so, I'm all ears for the suggestions how to make the code more
nicer.
BUG: 257566
BUG: 360549
CCBUG: 412573
FIXED-IN: 5.18.0
Reviewers: #kwin
Subscribers: fredrik, kwin, fvogt
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D25611
2019-11-28 12:00:58 +00:00
|
|
|
void renderToPainter(QPainter *painter, const QRect &rect);
|
2014-07-22 11:11:19 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
DecoratedClientImpl *m_client;
|
|
|
|
QRegion m_scheduled;
|
|
|
|
bool m_imageSizesDirty;
|
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|