yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/wayland/server/test_display.cpp

184 lines
6 KiB
C++
Raw Normal View History

KWayland: Convert license headers to SPDX Summary: Convert license headers to SPDX expressions and add license files as required by REUSE specification. Reviewers: zzag Reviewed By: zzag Subscribers: kde-frameworks-devel Tags: #frameworks Maniphest Tasks: T11550 Differential Revision: https://phabricator.kde.org/D28058
2020-03-15 15:19:28 +00:00
/*
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
KWayland: Convert license headers to SPDX Summary: Convert license headers to SPDX expressions and add license files as required by REUSE specification. Reviewers: zzag Reviewed By: zzag Subscribers: kde-frameworks-devel Tags: #frameworks Maniphest Tasks: T11550 Differential Revision: https://phabricator.kde.org/D28058
2020-03-15 15:19:28 +00:00
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
*/
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
// Qt
Don't use QtTest => use QTest + missing include
2023-07-03 19:28:19 +00:00
#include <QSignalSpy>
#include <QTest>
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
// WaylandServer
Integrate kwaylandserver This makes KWin switch to in-tree copy of KWaylandServer codebase. KWaylandServer namespace has been left as is. It will be addressed later by renaming classes in order to fit in the KWin namespace.
2022-04-22 09:27:33 +00:00
#include "wayland/clientconnection.h"
#include "wayland/display.h"
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
// Wayland
#include <wayland-server.h>
// system
#include <sys/socket.h>
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
#include <sys/types.h>
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
#include <unistd.h>
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
using namespace KWin;
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
class TestWaylandServerDisplay : public QObject
{
Q_OBJECT
private Q_SLOTS:
void testSocketName();
void testStartStop();
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
void testClientConnection();
Display::start takes a StartMode argument If one passes StartMode::ConnectClientsOnly the socket in XDG_RUNTIME_DIR is not created and instead one can only connect to this server using the Display::createClient method. A very nice solution to just have a Server and one dedicated Client talk to each other.
2014-11-27 15:42:16 +00:00
void testConnectNoSocket();
Add option to use wl_display_add_socket_auto Summary: If automaticSocketNaming is enabled, it will use wl_display_add_socket_auto to allocate the next free socket. The resulting name can be retrieved using socketName after a successful start afterwards. Test Plan: Ran the new autotest, passes. kwin_wayland still uses the old behaviour. Reviewers: #kwin, #plasma, romangg Reviewed By: #kwin, #plasma, romangg Subscribers: davidedmundson, zzag, romangg, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17122
2018-11-23 13:42:18 +00:00
void testAutoSocketName();
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
};
void TestWaylandServerDisplay::testSocketName()
{
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
KWin::Display display;
QSignalSpy changedSpy(&display, &KWin::Display::socketNamesChanged);
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
QCOMPARE(display.socketNames(), QStringList());
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
const QString testSName = QStringLiteral("fooBar");
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
display.addSocketName(testSName);
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QCOMPARE(display.socketNames(), QStringList{testSName});
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
QCOMPARE(changedSpy.count(), 1);
// changing to same name again should not emit signal
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
display.addSocketName(testSName);
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
QCOMPARE(changedSpy.count(), 1);
}
void TestWaylandServerDisplay::testStartStop()
{
const QString testSocketName = QStringLiteral("kwin-wayland-server-display-test-0");
QDir runtimeDir(qgetenv("XDG_RUNTIME_DIR"));
QVERIFY(runtimeDir.exists());
QVERIFY(!runtimeDir.exists(testSocketName));
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
std::unique_ptr<KWin::Display> display(new KWin::Display);
QSignalSpy runningSpy(display.get(), &KWin::Display::runningChanged);
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
display->addSocketName(testSocketName);
Allow creating global objects before Display is started It can be especially useful if the compositor wants to ensure that all globals have been created before starting to accept client connections. Unfortunately, start() and terminate() stuff doesn't align well with it, so the terminate() method was dropped to ensure that Display always returns the same wl_display object.
2020-07-06 09:36:25 +00:00
QVERIFY(!display->isRunning());
display->start();
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
// QVERIFY(runningSpy.wait());
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
QCOMPARE(runningSpy.count(), 1);
QVERIFY(runningSpy.first().first().toBool());
Allow creating global objects before Display is started It can be especially useful if the compositor wants to ensure that all globals have been created before starting to accept client connections. Unfortunately, start() and terminate() stuff doesn't align well with it, so the terminate() method was dropped to ensure that Display always returns the same wl_display object.
2020-07-06 09:36:25 +00:00
QVERIFY(display->isRunning());
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
QVERIFY(runtimeDir.exists(testSocketName));
Allow creating global objects before Display is started It can be especially useful if the compositor wants to ensure that all globals have been created before starting to accept client connections. Unfortunately, start() and terminate() stuff doesn't align well with it, so the terminate() method was dropped to ensure that Display always returns the same wl_display object.
2020-07-06 09:36:25 +00:00
display.reset();
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
QVERIFY(!runtimeDir.exists(testSocketName));
}
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
void TestWaylandServerDisplay::testClientConnection()
{
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
KWin::Display display;
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
display.addSocketName(QStringLiteral("kwin-wayland-server-display-test-client-connection"));
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
display.start();
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
QSignalSpy connectedSpy(&display, &KWin::Display::clientConnected);
QSignalSpy disconnectedSpy(&display, &KWin::Display::clientDisconnected);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
int sv[2];
QVERIFY(socketpair(AF_UNIX, SOCK_STREAM, 0, sv) >= 0);
auto client = wl_client_create(display, sv[0]);
QVERIFY(client);
QVERIFY(connectedSpy.isEmpty());
Expose all ClientConnections in Display
2014-11-17 17:13:28 +00:00
QVERIFY(display.connections().isEmpty());
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
ClientConnection *connection = display.getConnection(client);
QVERIFY(connection);
QCOMPARE(connection->client(), client);
[autotests/server] Check whether test is run as root If the test is run as root we cannot compare the user id to not be 0. Thus let's check for that and expect fail.
2017-07-01 15:01:18 +00:00
if (getuid() == 0) {
QEXPECT_FAIL("", "Please don't run test as root", Continue);
}
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QVERIFY(connection->userId() != 0);
[autotests/server] Check whether test is run as root If the test is run as root we cannot compare the user id to not be 0. Thus let's check for that and expect fail.
2017-07-01 15:01:18 +00:00
if (getgid() == 0) {
QEXPECT_FAIL("", "Please don't run test as root", Continue);
}
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QVERIFY(connection->groupId() != 0);
QVERIFY(connection->processId() != 0);
Add test condition in test_display.cpp
2014-11-17 15:21:54 +00:00
QCOMPARE(connection->display(), &display);
Make unittest independent from the location of the executable. Summary: This fixes the check in the unittest when doing set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin") which I intend to do globally at some point. Turns out it's comparing with its own executable location, so we can use QCoreApplication to get it generically. Test Plan: Verified to work with ctest and with "./testWaylandServerDisplay" Reviewers: graesslin, mart Reviewed By: graesslin, mart Subscribers: plasma-devel, #frameworks Tags: #plasma_on_wayland, #frameworks Differential Revision: https://phabricator.kde.org/D6974
2017-07-29 06:40:11 +00:00
QCOMPARE(connection->executablePath(), QCoreApplication::applicationFilePath());
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QCOMPARE((wl_client *)*connection, client);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
const ClientConnection &constRef = *connection;
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QCOMPARE((wl_client *)constRef, client);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QCOMPARE(connectedSpy.count(), 1);
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QCOMPARE(connectedSpy.first().first().value<ClientConnection *>(), connection);
Expose all ClientConnections in Display
2014-11-17 17:13:28 +00:00
QCOMPARE(display.connections().count(), 1);
QCOMPARE(display.connections().first(), connection);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QCOMPARE(connection, display.getConnection(client));
QCOMPARE(connectedSpy.count(), 1);
// create a second client
int sv2[2];
QVERIFY(socketpair(AF_UNIX, SOCK_STREAM, 0, sv2) >= 0);
ConnectionThread can connect to a socket fd instead of name This allows connecting a client without going via the socket name. E.g. to create a socketpair in the server and fork to exec the client.
2014-11-27 15:16:54 +00:00
auto client2 = display.createClient(sv2[0]);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QVERIFY(client2);
ConnectionThread can connect to a socket fd instead of name This allows connecting a client without going via the socket name. E.g. to create a socketpair in the server and fork to exec the client.
2014-11-27 15:16:54 +00:00
ClientConnection *connection2 = display.getConnection(client2->client());
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QVERIFY(connection2);
ConnectionThread can connect to a socket fd instead of name This allows connecting a client without going via the socket name. E.g. to create a socketpair in the server and fork to exec the client.
2014-11-27 15:16:54 +00:00
QCOMPARE(connection2, client2);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QCOMPARE(connectedSpy.count(), 2);
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QCOMPARE(connectedSpy.first().first().value<ClientConnection *>(), connection);
QCOMPARE(connectedSpy.last().first().value<ClientConnection *>(), connection2);
QCOMPARE(connectedSpy.last().first().value<ClientConnection *>(), client2);
Expose all ClientConnections in Display
2014-11-17 17:13:28 +00:00
QCOMPARE(display.connections().count(), 2);
QCOMPARE(display.connections().first(), connection);
QCOMPARE(display.connections().last(), connection2);
ConnectionThread can connect to a socket fd instead of name This allows connecting a client without going via the socket name. E.g. to create a socketpair in the server and fork to exec the client.
2014-11-27 15:16:54 +00:00
QCOMPARE(display.connections().last(), client2);
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
// and destroy
QVERIFY(disconnectedSpy.isEmpty());
wl_client_destroy(client);
QCOMPARE(disconnectedSpy.count(), 1);
[server] Use deleteLater when a ClientConnection gets destroyed Summary: In the situation that a wl_client gets destroyed while still wl_resources are around it can happen that one of them calls into the ClientConnection during the cleanup handling which gets triggered at the same time. This can then trigger a crash. This change uses deleteLater for the ClientConnection and sets the hold wl_client pointer to null instead of deleting directly. So the ClientConnection is still around while the Resources gets cleaned up. This is similar to the cleanup of Resource where on unbind the wl_resource pointer is set to null and the Resource gets delete later. BUG: 370232 FIXED-IN: 5.28 Reviewers: #plasma, bshah Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D3004
2016-10-10 11:41:42 +00:00
QSignalSpy clientDestroyedSpy(client2, &QObject::destroyed);
[server] Add a convenient ClientConnection::destroy Wrapper around wl_client_destroy. In case the ClientConnection got created through Display::createClient we need to destroy the ClientConnection again. The exiting client will not cause it to be destroyed. Reviewed-By: Bhushan Shah
2015-11-10 12:27:27 +00:00
client2->destroy();
[server] Use deleteLater when a ClientConnection gets destroyed Summary: In the situation that a wl_client gets destroyed while still wl_resources are around it can happen that one of them calls into the ClientConnection during the cleanup handling which gets triggered at the same time. This can then trigger a crash. This change uses deleteLater for the ClientConnection and sets the hold wl_client pointer to null instead of deleting directly. So the ClientConnection is still around while the Resources gets cleaned up. This is similar to the cleanup of Resource where on unbind the wl_resource pointer is set to null and the Resource gets delete later. BUG: 370232 FIXED-IN: 5.28 Reviewers: #plasma, bshah Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D3004
2016-10-10 11:41:42 +00:00
QVERIFY(clientDestroyedSpy.wait());
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
QCOMPARE(disconnectedSpy.count(), 2);
close(sv[0]);
close(sv[1]);
close(sv2[0]);
close(sv2[1]);
Expose all ClientConnections in Display
2014-11-17 17:13:28 +00:00
QVERIFY(display.connections().isEmpty());
Adding a new ClientConnection class for wrapping wl_client The ClientConnection is managed by Display. Whenever one tries to get a ClientConnection for a wl_client* and it doesn't exist yet a new one will be created and a clientConnected signal will be emitted. Also there is a clientDisconnected signal. ClientConnection provides access to pid, uid and gid. The idea is to extend it to provide access to all the resources created for the client.
2014-11-17 15:01:18 +00:00
}
Display::start takes a StartMode argument If one passes StartMode::ConnectClientsOnly the socket in XDG_RUNTIME_DIR is not created and instead one can only connect to this server using the Display::createClient method. A very nice solution to just have a Server and one dedicated Client talk to each other.
2014-11-27 15:42:16 +00:00
void TestWaylandServerDisplay::testConnectNoSocket()
{
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
KWin::Display display;
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
display.start();
Display::start takes a StartMode argument If one passes StartMode::ConnectClientsOnly the socket in XDG_RUNTIME_DIR is not created and instead one can only connect to this server using the Display::createClient method. A very nice solution to just have a Server and one dedicated Client talk to each other.
2014-11-27 15:42:16 +00:00
QVERIFY(display.isRunning());
// let's try connecting a client
int sv[2];
QVERIFY(socketpair(AF_UNIX, SOCK_STREAM, 0, sv) >= 0);
auto client = display.createClient(sv[0]);
QVERIFY(client);
wl_client_destroy(client->client());
close(sv[0]);
close(sv[1]);
}
Add option to use wl_display_add_socket_auto Summary: If automaticSocketNaming is enabled, it will use wl_display_add_socket_auto to allocate the next free socket. The resulting name can be retrieved using socketName after a successful start afterwards. Test Plan: Ran the new autotest, passes. kwin_wayland still uses the old behaviour. Reviewers: #kwin, #plasma, romangg Reviewed By: #kwin, #plasma, romangg Subscribers: davidedmundson, zzag, romangg, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17122
2018-11-23 13:42:18 +00:00
void TestWaylandServerDisplay::testAutoSocketName()
{
QTemporaryDir runtimeDir;
QVERIFY(runtimeDir.isValid());
QVERIFY(qputenv("XDG_RUNTIME_DIR", runtimeDir.path().toUtf8()));
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
KWin::Display display0;
QSignalSpy socketNameChangedSpy0(&display0, &KWin::Display::socketNamesChanged);
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
QVERIFY(socketNameChangedSpy0.isValid());
QVERIFY(display0.addSocketName());
Add option to use wl_display_add_socket_auto Summary: If automaticSocketNaming is enabled, it will use wl_display_add_socket_auto to allocate the next free socket. The resulting name can be retrieved using socketName after a successful start afterwards. Test Plan: Ran the new autotest, passes. kwin_wayland still uses the old behaviour. Reviewers: #kwin, #plasma, romangg Reviewed By: #kwin, #plasma, romangg Subscribers: davidedmundson, zzag, romangg, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17122
2018-11-23 13:42:18 +00:00
display0.start();
QVERIFY(display0.isRunning());
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
QCOMPARE(socketNameChangedSpy0.count(), 1);
Add option to use wl_display_add_socket_auto Summary: If automaticSocketNaming is enabled, it will use wl_display_add_socket_auto to allocate the next free socket. The resulting name can be retrieved using socketName after a successful start afterwards. Test Plan: Ran the new autotest, passes. kwin_wayland still uses the old behaviour. Reviewers: #kwin, #plasma, romangg Reviewed By: #kwin, #plasma, romangg Subscribers: davidedmundson, zzag, romangg, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17122
2018-11-23 13:42:18 +00:00
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
KWin::Display display1;
QSignalSpy socketNameChangedSpy1(&display1, &KWin::Display::socketNamesChanged);
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
QVERIFY(socketNameChangedSpy1.isValid());
QVERIFY(display1.addSocketName());
Add option to use wl_display_add_socket_auto Summary: If automaticSocketNaming is enabled, it will use wl_display_add_socket_auto to allocate the next free socket. The resulting name can be retrieved using socketName after a successful start afterwards. Test Plan: Ran the new autotest, passes. kwin_wayland still uses the old behaviour. Reviewers: #kwin, #plasma, romangg Reviewed By: #kwin, #plasma, romangg Subscribers: davidedmundson, zzag, romangg, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17122
2018-11-23 13:42:18 +00:00
display1.start();
QVERIFY(display1.isRunning());
QCOMPARE(socketNameChangedSpy1.count(), 1);
}
Switch all auto tests to QTEST_GUILESS_MAIN We don't need a QGuiApplication in the tests.
2014-09-23 10:00:17 +00:00
QTEST_GUILESS_MAIN(TestWaylandServerDisplay)
[kwin_wayland] Initial addition of the WaylandServer module So far this new module contains: * Display * OutputInterface Display manages the server socket and server event loop. In general it's the entry point to any part of the server. OutputInterface is the abstraction for the wl_output interface on server side. An OutputInterface is created through the Display. The auto tests for ConnectionThread and Output are adjusted to use the internal server instead of starting Weston. Especially the Output test could be extended to test much more as we have absolute control over the server now.
2014-08-26 14:07:39 +00:00
#include "test_display.moc"
Reference in a new issue Copy permalink