kwin/geometry.cpp

3396 lines
136 KiB
C++
Raw Normal View History

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 1999, 2000 Matthias Ettrich <ettrich@kde.org>
Copyright (C) 2003 Lubos Lunak <l.lunak@kde.org>
Copyright (C) 2009 Lucas Murray <lmurray@undefinedfire.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
/*
This file contains things relevant to geometry, i.e. workspace size,
window positions and window sizes.
*/
#include "x11client.h"
#include "composite.h"
#include "cursor.h"
#include "netinfo.h"
#include "workspace.h"
#include "placement.h"
#include "geometrytip.h"
#include "rules.h"
#include "screens.h"
#include "effects.h"
#include "screenedge.h"
#include "internal_client.h"
#include <QApplication>
#include <QDebug>
#include <QVarLengthArray>
#include "outline.h"
#include "xdgshellclient.h"
#include "wayland_server.h"
#include <KDecoration2/Decoration>
#include <KDecoration2/DecoratedClient>
namespace KWin
{
static inline int sign(int v) {
return (v > 0) - (v < 0);
}
//********************************************
// Workspace
//********************************************
extern int screen_number;
extern bool is_multihead;
/**
* Resizes the workspace after an XRANDR screen size change
*/
void Workspace::desktopResized()
2011-01-30 14:34:42 +00:00
{
QRect geom = screens()->geometry();
if (rootInfo()) {
NETSize desktop_geometry;
desktop_geometry.width = geom.width();
desktop_geometry.height = geom.height();
rootInfo()->setDesktopGeometry(desktop_geometry);
}
updateClientArea();
saveOldScreenSizes(); // after updateClientArea(), so that one still uses the previous one
// TODO: emit a signal instead and remove the deep function calls into edges and effects
ScreenEdges::self()->recreateEdges();
if (effects) {
static_cast<EffectsHandlerImpl*>(effects)->desktopResized(geom.size());
}
2011-01-30 14:34:42 +00:00
}
void Workspace::saveOldScreenSizes()
{
olddisplaysize = screens()->displaySize();
oldscreensizes.clear();
for( int i = 0;
i < screens()->count();
++i )
oldscreensizes.append( screens()->geometry( i ));
}
/**
* Updates the current client areas according to the current clients.
*
* If the area changes or force is @c true, the new areas are propagated to the world.
*
* The client area is the area that is available for clients (that
* which is not taken by windows like panels, the top-of-screen menu
* etc).
*
* @see clientArea()
*/
2011-01-30 14:34:42 +00:00
void Workspace::updateClientArea(bool force)
{
const Screens *s = Screens::self();
int nscreens = s->count();
const int numberOfDesktops = VirtualDesktopManager::self()->count();
QVector< QRect > new_wareas(numberOfDesktops + 1);
QVector< StrutRects > new_rmoveareas(numberOfDesktops + 1);
QVector< QVector< QRect > > new_sareas(numberOfDesktops + 1);
2011-01-30 14:34:42 +00:00
QVector< QRect > screens(nscreens);
QRect desktopArea;
for (int i = 0; i < nscreens; i++) {
desktopArea |= s->geometry(i);
}
2011-01-30 14:34:42 +00:00
for (int iS = 0;
iS < nscreens;
2011-01-30 14:34:42 +00:00
iS ++) {
screens [iS] = s->geometry(iS);
2011-01-30 14:34:42 +00:00
}
for (int i = 1;
i <= numberOfDesktops;
2011-01-30 14:34:42 +00:00
++i) {
new_wareas[ i ] = desktopArea;
2011-01-30 14:34:42 +00:00
new_sareas[ i ].resize(nscreens);
for (int iS = 0;
iS < nscreens;
iS ++)
new_sareas[ i ][ iS ] = screens[ iS ];
2011-01-30 14:34:42 +00:00
}
for (ClientList::ConstIterator it = clients.constBegin(); it != clients.constEnd(); ++it) {
if (!(*it)->hasStrut())
continue;
2011-01-30 14:34:42 +00:00
QRect r = (*it)->adjustedClientArea(desktopArea, desktopArea);
// sanity check that a strut doesn't exclude a complete screen geometry
// this is a violation to EWMH, as KWin just ignores the strut
for (int i = 0; i < Screens::self()->count(); i++) {
if (!r.intersects(Screens::self()->geometry(i))) {
qCDebug(KWIN_CORE) << "Adjusted client area would exclude a complete screen, ignore";
r = desktopArea;
break;
}
}
StrutRects strutRegion = (*it)->strutRects();
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
const QRect clientsScreenRect = KWin::screens()->geometry((*it)->screen());
for (auto strut = strutRegion.begin(); strut != strutRegion.end(); strut++) {
*strut = StrutRect((*strut).intersected(clientsScreenRect), (*strut).area());
}
// Ignore offscreen xinerama struts. These interfere with the larger monitors on the setup
// and should be ignored so that applications that use the work area to work out where
// windows can go can use the entire visible area of the larger monitors.
// This goes against the EWMH description of the work area but it is a toss up between
// having unusable sections of the screen (Which can be quite large with newer monitors)
// or having some content appear offscreen (Relatively rare compared to other).
bool hasOffscreenXineramaStrut = (*it)->hasOffscreenXineramaStrut();
2011-01-30 14:34:42 +00:00
if ((*it)->isOnAllDesktops()) {
for (int i = 1;
i <= numberOfDesktops;
2011-01-30 14:34:42 +00:00
++i) {
if (!hasOffscreenXineramaStrut)
new_wareas[ i ] = new_wareas[ i ].intersected(r);
new_rmoveareas[ i ] += strutRegion;
2011-01-30 14:34:42 +00:00
for (int iS = 0;
iS < nscreens;
iS ++) {
const auto geo = new_sareas[ i ][ iS ].intersected(
2011-01-30 14:34:42 +00:00
(*it)->adjustedClientArea(desktopArea, screens[ iS ]));
2018-08-29 18:02:16 +00:00
// ignore the geometry if it results in the screen getting removed completely
if (!geo.isEmpty()) {
new_sareas[ i ][ iS ] = geo;
}
}
}
2011-01-30 14:34:42 +00:00
} else {
if (!hasOffscreenXineramaStrut)
new_wareas[(*it)->desktop()] = new_wareas[(*it)->desktop()].intersected(r);
new_rmoveareas[(*it)->desktop()] += strutRegion;
for (int iS = 0;
iS < nscreens;
iS ++) {
2013-11-01 11:29:05 +00:00
// qDebug() << "adjusting new_sarea: " << screens[ iS ];
const auto geo = new_sareas[(*it)->desktop()][ iS ].intersected(
2011-01-30 14:34:42 +00:00
(*it)->adjustedClientArea(desktopArea, screens[ iS ]));
2018-08-29 18:02:16 +00:00
// ignore the geometry if it results in the screen getting removed completely
if (!geo.isEmpty()) {
new_sareas[(*it)->desktop()][ iS ] = geo;
}
}
}
2011-01-30 14:34:42 +00:00
}
if (waylandServer()) {
auto updateStrutsForWaylandClient = [&] (XdgShellClient *c) {
// assuming that only docks have "struts" and that all docks have a strut
if (!c->hasStrut()) {
return;
}
auto margins = [c] (const QRect &geometry) {
QMargins margins;
if (!geometry.intersects(c->frameGeometry())) {
return margins;
}
// figure out which areas of the overall screen setup it borders
const bool left = c->frameGeometry().left() == geometry.left();
const bool right = c->frameGeometry().right() == geometry.right();
const bool top = c->frameGeometry().top() == geometry.top();
const bool bottom = c->frameGeometry().bottom() == geometry.bottom();
const bool horizontal = c->frameGeometry().width() >= c->frameGeometry().height();
if (left && ((!top && !bottom) || !horizontal)) {
margins.setLeft(c->frameGeometry().width());
}
if (right && ((!top && !bottom) || !horizontal)) {
margins.setRight(c->frameGeometry().width());
}
if (top && ((!left && !right) || horizontal)) {
margins.setTop(c->frameGeometry().height());
}
if (bottom && ((!left && !right) || horizontal)) {
margins.setBottom(c->frameGeometry().height());
}
return margins;
};
auto marginsToStrutArea = [] (const QMargins &margins) {
if (margins.left() != 0) {
return StrutAreaLeft;
}
if (margins.right() != 0) {
return StrutAreaRight;
}
if (margins.top() != 0) {
return StrutAreaTop;
}
if (margins.bottom() != 0) {
return StrutAreaBottom;
}
return StrutAreaInvalid;
};
const auto strut = margins(KWin::screens()->geometry(c->screen()));
const StrutRects strutRegion = StrutRects{StrutRect(c->frameGeometry(), marginsToStrutArea(strut))};
QRect r = desktopArea - margins(KWin::screens()->geometry());
if (c->isOnAllDesktops()) {
for (int i = 1; i <= numberOfDesktops; ++i) {
new_wareas[ i ] = new_wareas[ i ].intersected(r);
for (int iS = 0; iS < nscreens; ++iS) {
new_sareas[ i ][ iS ] = new_sareas[ i ][ iS ].intersected(screens[iS] - margins(screens[iS]));
}
new_rmoveareas[ i ] += strutRegion;
}
} else {
new_wareas[c->desktop()] = new_wareas[c->desktop()].intersected(r);
for (int iS = 0; iS < nscreens; iS++) {
new_sareas[c->desktop()][ iS ] = new_sareas[c->desktop()][ iS ].intersected(screens[iS] - margins(screens[iS]));
}
new_rmoveareas[ c->desktop() ] += strutRegion;
}
};
const auto clients = waylandServer()->clients();
for (auto c : clients) {
updateStrutsForWaylandClient(c);
}
}
#if 0
2011-01-30 14:34:42 +00:00
for (int i = 1;
i <= numberOfDesktops();
2011-01-30 14:34:42 +00:00
++i) {
for (int iS = 0;
iS < nscreens;
iS ++)
qCDebug(KWIN_CORE) << "new_sarea: " << new_sareas[ i ][ iS ];
2011-01-30 14:34:42 +00:00
}
#endif
bool changed = force;
2011-01-30 14:34:42 +00:00
if (screenarea.isEmpty())
changed = true;
2011-01-30 14:34:42 +00:00
for (int i = 1;
!changed && i <= numberOfDesktops;
2011-01-30 14:34:42 +00:00
++i) {
if (workarea[ i ] != new_wareas[ i ])
changed = true;
2011-01-30 14:34:42 +00:00
if (restrictedmovearea[ i ] != new_rmoveareas[ i ])
changed = true;
2011-01-30 14:34:42 +00:00
if (screenarea[ i ].size() != new_sareas[ i ].size())
changed = true;
2011-01-30 14:34:42 +00:00
for (int iS = 0;
!changed && iS < nscreens;
iS ++)
if (new_sareas[ i ][ iS ] != screenarea [ i ][ iS ])
changed = true;
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
if (changed) {
workarea = new_wareas;
oldrestrictedmovearea = restrictedmovearea;
restrictedmovearea = new_rmoveareas;
screenarea = new_sareas;
if (rootInfo()) {
NETRect r;
for (int i = 1; i <= numberOfDesktops; i++) {
r.pos.x = workarea[ i ].x();
r.pos.y = workarea[ i ].y();
r.size.width = workarea[ i ].width();
r.size.height = workarea[ i ].height();
rootInfo()->setWorkArea(i, r);
}
2011-01-30 14:34:42 +00:00
}
for (auto it = m_allClients.constBegin();
it != m_allClients.constEnd();
2011-01-30 14:34:42 +00:00
++it)
(*it)->checkWorkspacePosition();
oldrestrictedmovearea.clear(); // reset, no longer valid or needed
}
2011-01-30 14:34:42 +00:00
}
void Workspace::updateClientArea()
2011-01-30 14:34:42 +00:00
{
updateClientArea(false);
}
/**
* Returns the area available for clients. This is the desktop
* geometry minus windows on the dock. Placement algorithms should
* refer to this rather than Screens::geometry.
*/
2011-01-30 14:34:42 +00:00
QRect Workspace::clientArea(clientAreaOption opt, int screen, int desktop) const
{
if (desktop == NETWinInfo::OnAllDesktops || desktop == 0)
desktop = VirtualDesktopManager::self()->current();
2011-01-30 14:34:42 +00:00
if (screen == -1)
screen = screens()->current();
const QSize displaySize = screens()->displaySize();
2011-01-30 14:34:42 +00:00
QRect sarea, warea;
if (is_multihead) {
sarea = (!screenarea.isEmpty()
2011-01-30 14:34:42 +00:00
&& screen < screenarea[ desktop ].size()) // screens may be missing during KWin initialization or screen config changes
? screenarea[ desktop ][ screen_number ]
: screens()->geometry(screen_number);
warea = workarea[ desktop ].isNull()
? screens()->geometry(screen_number)
: workarea[ desktop ];
} else {
sarea = (!screenarea.isEmpty()
&& screen < screenarea[ desktop ].size()) // screens may be missing during KWin initialization or screen config changes
? screenarea[ desktop ][ screen ]
: screens()->geometry(screen);
warea = workarea[ desktop ].isNull()
? QRect(0, 0, displaySize.width(), displaySize.height())
: workarea[ desktop ];
}
2011-01-30 14:34:42 +00:00
switch(opt) {
case MaximizeArea:
case PlacementArea:
2011-01-30 14:34:42 +00:00
return sarea;
case MaximizeFullArea:
case FullScreenArea:
case MovementArea:
case ScreenArea:
if (is_multihead)
return screens()->geometry(screen_number);
2011-01-30 14:34:42 +00:00
else
return screens()->geometry(screen);
2011-01-30 14:34:42 +00:00
case WorkArea:
if (is_multihead)
return sarea;
else
return warea;
2011-01-30 14:34:42 +00:00
case FullArea:
return QRect(0, 0, displaySize.width(), displaySize.height());
}
2011-01-30 14:34:42 +00:00
abort();
}
2011-01-30 14:34:42 +00:00
QRect Workspace::clientArea(clientAreaOption opt, const QPoint& p, int desktop) const
{
return clientArea(opt, screens()->number(p), desktop);
2011-01-30 14:34:42 +00:00
}
QRect Workspace::clientArea(clientAreaOption opt, const AbstractClient* c) const
2011-01-30 14:34:42 +00:00
{
return clientArea(opt, c->frameGeometry().center(), c->desktop());
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
QRegion Workspace::restrictedMoveArea(int desktop, StrutAreas areas) const
{
if (desktop == NETWinInfo::OnAllDesktops || desktop == 0)
desktop = VirtualDesktopManager::self()->current();
QRegion region;
2011-01-30 14:34:42 +00:00
foreach (const StrutRect & rect, restrictedmovearea[desktop])
if (areas & rect.area())
region += rect;
return region;
2011-01-30 14:34:42 +00:00
}
bool Workspace::inUpdateClientArea() const
{
return !oldrestrictedmovearea.isEmpty();
}
2011-01-30 14:34:42 +00:00
QRegion Workspace::previousRestrictedMoveArea(int desktop, StrutAreas areas) const
{
if (desktop == NETWinInfo::OnAllDesktops || desktop == 0)
desktop = VirtualDesktopManager::self()->current();
QRegion region;
2011-01-30 14:34:42 +00:00
foreach (const StrutRect & rect, oldrestrictedmovearea.at(desktop))
if (areas & rect.area())
region += rect;
return region;
2011-01-30 14:34:42 +00:00
}
QVector< QRect > Workspace::previousScreenSizes() const
{
return oldscreensizes;
}
int Workspace::oldDisplayWidth() const
{
return olddisplaysize.width();
}
int Workspace::oldDisplayHeight() const
{
return olddisplaysize.height();
}
/**
* Client \a c is moved around to position \a pos. This gives the
* workspace the opportunity to interveniate and to implement
* snap-to-windows functionality.
*
* The parameter \a snapAdjust is a multiplier used to calculate the
* effective snap zones. When 1.0, it means that the snap zones will be
* used without change.
*/
QPoint Workspace::adjustClientPosition(AbstractClient* c, QPoint pos, bool unrestricted, double snapAdjust)
2011-01-30 14:34:42 +00:00
{
QSize borderSnapZone(options->borderSnapZone(), options->borderSnapZone());
QRect maxRect;
int guideMaximized = MaximizeRestore;
if (c->maximizeMode() != MaximizeRestore) {
maxRect = clientArea(MaximizeArea, pos + c->rect().center(), c->desktop());
QRect geo = c->frameGeometry();
if (c->maximizeMode() & MaximizeHorizontal && (geo.x() == maxRect.left() || geo.right() == maxRect.right())) {
guideMaximized |= MaximizeHorizontal;
borderSnapZone.setWidth(qMax(borderSnapZone.width() + 2, maxRect.width() / 16));
}
if (c->maximizeMode() & MaximizeVertical && (geo.y() == maxRect.top() || geo.bottom() == maxRect.bottom())) {
guideMaximized |= MaximizeVertical;
borderSnapZone.setHeight(qMax(borderSnapZone.height() + 2, maxRect.height() / 16));
}
}
if (options->windowSnapZone() || !borderSnapZone.isNull() || options->centerSnapZone()) {
const bool sOWO = options->isSnapOnlyWhenOverlapping();
const int screen = screens()->number(pos + c->rect().center());
if (maxRect.isNull())
maxRect = clientArea(MovementArea, screen, c->desktop());
const int xmin = maxRect.left();
2011-01-30 14:34:42 +00:00
const int xmax = maxRect.right() + 1; //desk size
const int ymin = maxRect.top();
2011-01-30 14:34:42 +00:00
const int ymax = maxRect.bottom() + 1;
const int cx(pos.x());
const int cy(pos.y());
const int cw(c->width());
const int ch(c->height());
2011-01-30 14:34:42 +00:00
const int rx(cx + cw);
const int ry(cy + ch); //these don't change
int nx(cx), ny(cy); //buffers
int deltaX(xmax);
int deltaY(ymax); //minimum distance to other clients
int lx, ly, lrx, lry; //coords and size for the comparison client, l
2011-01-30 14:34:42 +00:00
// border snap
const int snapX = borderSnapZone.width() * snapAdjust; //snap trigger
const int snapY = borderSnapZone.height() * snapAdjust;
if (snapX || snapY) {
QRect geo = c->frameGeometry();
QMargins frameMargins = c->frameMargins();
// snap to titlebar / snap to window borders on inner screen edges
AbstractClient::Position titlePos = c->titlebarPosition();
if (frameMargins.left() && (titlePos == AbstractClient::PositionLeft || (c->maximizeMode() & MaximizeHorizontal) ||
screens()->intersecting(geo.translated(maxRect.x() - (frameMargins.left() + geo.x()), 0)) > 1)) {
frameMargins.setLeft(0);
}
if (frameMargins.right() && (titlePos == AbstractClient::PositionRight || (c->maximizeMode() & MaximizeHorizontal) ||
screens()->intersecting(geo.translated(maxRect.right() + frameMargins.right() - geo.right(), 0)) > 1)) {
frameMargins.setRight(0);
}
if (frameMargins.top() && (titlePos == AbstractClient::PositionTop || (c->maximizeMode() & MaximizeVertical) ||
screens()->intersecting(geo.translated(0, maxRect.y() - (frameMargins.top() + geo.y()))) > 1)) {
frameMargins.setTop(0);
}
if (frameMargins.bottom() && (titlePos == AbstractClient::PositionBottom || (c->maximizeMode() & MaximizeVertical) ||
screens()->intersecting(geo.translated(0, maxRect.bottom() + frameMargins.bottom() - geo.bottom())) > 1)) {
frameMargins.setBottom(0);
}
if ((sOWO ? (cx < xmin) : true) && (qAbs(xmin - cx) < snapX)) {
deltaX = xmin - cx;
nx = xmin - frameMargins.left();
2011-01-30 14:34:42 +00:00
}
if ((sOWO ? (rx > xmax) : true) && (qAbs(rx - xmax) < snapX) && (qAbs(xmax - rx) < deltaX)) {
deltaX = rx - xmax;
nx = xmax - cw + frameMargins.right();
2011-01-30 14:34:42 +00:00
}
if ((sOWO ? (cy < ymin) : true) && (qAbs(ymin - cy) < snapY)) {
deltaY = ymin - cy;
ny = ymin - frameMargins.top();
2011-01-30 14:34:42 +00:00
}
if ((sOWO ? (ry > ymax) : true) && (qAbs(ry - ymax) < snapY) && (qAbs(ymax - ry) < deltaY)) {
deltaY = ry - ymax;
ny = ymax - ch + frameMargins.bottom();
}
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
// windows snap
int snap = options->windowSnapZone() * snapAdjust;
2011-01-30 14:34:42 +00:00
if (snap) {
for (auto l = m_allClients.constBegin(); l != m_allClients.constEnd(); ++l) {
if ((*l) == c)
continue;
if ((*l)->isMinimized())
continue; // is minimized
if (!(*l)->isShown(false))
continue;
if (!((*l)->isOnDesktop(c->desktop()) || c->isOnDesktop((*l)->desktop())))
continue; // wrong virtual desktop
if (!(*l)->isOnCurrentActivity())
continue; // wrong activity
if ((*l)->isDesktop() || (*l)->isSplash())
continue;
lx = (*l)->x();
ly = (*l)->y();
lrx = lx + (*l)->width();
lry = ly + (*l)->height();
if (!(guideMaximized & MaximizeHorizontal) &&
(((cy <= lry) && (cy >= ly)) || ((ry >= ly) && (ry <= lry)) || ((cy <= ly) && (ry >= lry)))) {
if ((sOWO ? (cx < lrx) : true) && (qAbs(lrx - cx) < snap) && (qAbs(lrx - cx) < deltaX)) {
deltaX = qAbs(lrx - cx);
nx = lrx;
2011-01-30 14:34:42 +00:00
}
if ((sOWO ? (rx > lx) : true) && (qAbs(rx - lx) < snap) && (qAbs(rx - lx) < deltaX)) {
deltaX = qAbs(rx - lx);
nx = lx - cw;
2011-01-30 14:34:42 +00:00
}
}
if (!(guideMaximized & MaximizeVertical) &&
(((cx <= lrx) && (cx >= lx)) || ((rx >= lx) && (rx <= lrx)) || ((cx <= lx) && (rx >= lrx)))) {
if ((sOWO ? (cy < lry) : true) && (qAbs(lry - cy) < snap) && (qAbs(lry - cy) < deltaY)) {
deltaY = qAbs(lry - cy);
ny = lry;
2011-01-30 14:34:42 +00:00
}
//if ( (qAbs( ry-ly ) < snap) && (qAbs( ry - ly ) < deltaY ))
if ((sOWO ? (ry > ly) : true) && (qAbs(ry - ly) < snap) && (qAbs(ry - ly) < deltaY)) {
deltaY = qAbs(ry - ly);
ny = ly - ch;
2011-01-30 14:34:42 +00:00
}
}
// Corner snapping
if (!(guideMaximized & MaximizeVertical) && (nx == lrx || nx + cw == lx)) {
if ((sOWO ? (ry > lry) : true) && (qAbs(lry - ry) < snap) && (qAbs(lry - ry) < deltaY)) {
deltaY = qAbs(lry - ry);
ny = lry - ch;
2011-01-30 14:34:42 +00:00
}
if ((sOWO ? (cy < ly) : true) && (qAbs(cy - ly) < snap) && (qAbs(cy - ly) < deltaY)) {
deltaY = qAbs(cy - ly);
ny = ly;
}
}
if (!(guideMaximized & MaximizeHorizontal) && (ny == lry || ny + ch == ly)) {
if ((sOWO ? (rx > lrx) : true) && (qAbs(lrx - rx) < snap) && (qAbs(lrx - rx) < deltaX)) {
deltaX = qAbs(lrx - rx);
nx = lrx - cw;
2011-01-30 14:34:42 +00:00
}
if ((sOWO ? (cx < lx) : true) && (qAbs(cx - lx) < snap) && (qAbs(cx - lx) < deltaX)) {
deltaX = qAbs(cx - lx);
nx = lx;
}
}
}
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
// center snap
snap = options->centerSnapZone() * snapAdjust; //snap trigger
2011-01-30 14:34:42 +00:00
if (snap) {
int diffX = qAbs((xmin + xmax) / 2 - (cx + cw / 2));
int diffY = qAbs((ymin + ymax) / 2 - (cy + ch / 2));
if (diffX < snap && diffY < snap && diffX < deltaX && diffY < deltaY) {
// Snap to center of screen
nx = (xmin + xmax) / 2 - cw / 2;
ny = (ymin + ymax) / 2 - ch / 2;
} else if (options->borderSnapZone()) {
2011-01-30 14:34:42 +00:00
// Enhance border snap
if ((nx == xmin || nx == xmax - cw) && diffY < snap && diffY < deltaY) {
// Snap to vertical center on screen edge
ny = (ymin + ymax) / 2 - ch / 2;
} else if (((unrestricted ? ny == ymin : ny <= ymin) || ny == ymax - ch) &&
diffX < snap && diffX < deltaX) {
// Snap to horizontal center on screen edge
nx = (xmin + xmax) / 2 - cw / 2;
}
}
2011-01-30 14:34:42 +00:00
}
pos = QPoint(nx, ny);
}
2011-01-30 14:34:42 +00:00
return pos;
}
QRect Workspace::adjustClientSize(AbstractClient* c, QRect moveResizeGeom, int mode)
2011-01-30 14:34:42 +00:00
{
//adapted from adjustClientPosition on 29May2004
//this function is called when resizing a window and will modify
//the new dimensions to snap to other windows/borders if appropriate
if (options->windowSnapZone() || options->borderSnapZone()) { // || options->centerSnapZone )
const bool sOWO = options->isSnapOnlyWhenOverlapping();
const QRect maxRect = clientArea(MovementArea, c->rect().center(), c->desktop());
const int xmin = maxRect.left();
const int xmax = maxRect.right(); //desk size
const int ymin = maxRect.top();
const int ymax = maxRect.bottom();
const int cx(moveResizeGeom.left());
const int cy(moveResizeGeom.top());
const int rx(moveResizeGeom.right());
const int ry(moveResizeGeom.bottom());
int newcx(cx), newcy(cy); //buffers
int newrx(rx), newry(ry);
int deltaX(xmax);
int deltaY(ymax); //minimum distance to other clients
int lx, ly, lrx, lry; //coords and size for the comparison client, l
2011-01-30 14:34:42 +00:00
// border snap
int snap = options->borderSnapZone(); //snap trigger
2011-01-30 14:34:42 +00:00
if (snap) {
deltaX = int(snap);
deltaY = int(snap);
#define SNAP_BORDER_TOP \
2011-01-30 14:34:42 +00:00
if ((sOWO?(newcy<ymin):true) && (qAbs(ymin-newcy)<deltaY)) \
{ \
deltaY = qAbs(ymin-newcy); \
newcy = ymin; \
}
#define SNAP_BORDER_BOTTOM \
2011-01-30 14:34:42 +00:00
if ((sOWO?(newry>ymax):true) && (qAbs(ymax-newry)<deltaY)) \
{ \
deltaY = qAbs(ymax-newcy); \
newry = ymax; \
}
#define SNAP_BORDER_LEFT \
2011-01-30 14:34:42 +00:00
if ((sOWO?(newcx<xmin):true) && (qAbs(xmin-newcx)<deltaX)) \
{ \
deltaX = qAbs(xmin-newcx); \
newcx = xmin; \
}
#define SNAP_BORDER_RIGHT \
2011-01-30 14:34:42 +00:00
if ((sOWO?(newrx>xmax):true) && (qAbs(xmax-newrx)<deltaX)) \
{ \
deltaX = qAbs(xmax-newrx); \
newrx = xmax; \
}
switch(mode) {
case AbstractClient::PositionBottomRight:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_BOTTOM
SNAP_BORDER_RIGHT
break;
case AbstractClient::PositionRight:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_RIGHT
break;
case AbstractClient::PositionBottom:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_BOTTOM
break;
case AbstractClient::PositionTopLeft:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_TOP
SNAP_BORDER_LEFT
break;
case AbstractClient::PositionLeft:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_LEFT
break;
case AbstractClient::PositionTop:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_TOP
break;
case AbstractClient::PositionTopRight:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_TOP
SNAP_BORDER_RIGHT
break;
case AbstractClient::PositionBottomLeft:
2011-01-30 14:34:42 +00:00
SNAP_BORDER_BOTTOM
SNAP_BORDER_LEFT
break;
default:
abort();
break;
}
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
// windows snap
snap = options->windowSnapZone();
2011-01-30 14:34:42 +00:00
if (snap) {
deltaX = int(snap);
deltaY = int(snap);
for (auto l = m_allClients.constBegin(); l != m_allClients.constEnd(); ++l) {
if ((*l)->isOnDesktop(VirtualDesktopManager::self()->current()) &&
2011-01-30 14:34:42 +00:00
!(*l)->isMinimized()
&& (*l) != c) {
lx = (*l)->x() - 1;
ly = (*l)->y() - 1;
lrx = (*l)->x() + (*l)->width();
lry = (*l)->y() + (*l)->height();
#define WITHIN_HEIGHT ((( newcy <= lry ) && ( newcy >= ly )) || \
2011-01-30 14:34:42 +00:00
(( newry >= ly ) && ( newry <= lry )) || \
(( newcy <= ly ) && ( newry >= lry )) )
#define WITHIN_WIDTH ( (( cx <= lrx ) && ( cx >= lx )) || \
2011-01-30 14:34:42 +00:00
(( rx >= lx ) && ( rx <= lrx )) || \
(( cx <= lx ) && ( rx >= lrx )) )
#define SNAP_WINDOW_TOP if ( (sOWO?(newcy<lry):true) \
2011-01-30 14:34:42 +00:00
&& WITHIN_WIDTH \
&& (qAbs( lry - newcy ) < deltaY) ) { \
deltaY = qAbs( lry - newcy ); \
newcy=lry; \
}
#define SNAP_WINDOW_BOTTOM if ( (sOWO?(newry>ly):true) \
2011-01-30 14:34:42 +00:00
&& WITHIN_WIDTH \
&& (qAbs( ly - newry ) < deltaY) ) { \
deltaY = qAbs( ly - newry ); \
newry=ly; \
}
#define SNAP_WINDOW_LEFT if ( (sOWO?(newcx<lrx):true) \
2011-01-30 14:34:42 +00:00
&& WITHIN_HEIGHT \
&& (qAbs( lrx - newcx ) < deltaX)) { \
deltaX = qAbs( lrx - newcx ); \
newcx=lrx; \
}
#define SNAP_WINDOW_RIGHT if ( (sOWO?(newrx>lx):true) \
2011-01-30 14:34:42 +00:00
&& WITHIN_HEIGHT \
&& (qAbs( lx - newrx ) < deltaX)) \
{ \
deltaX = qAbs( lx - newrx ); \
newrx=lx; \
}
#define SNAP_WINDOW_C_TOP if ( (sOWO?(newcy<ly):true) \
2011-01-30 14:34:42 +00:00
&& (newcx == lrx || newrx == lx) \
&& qAbs(ly-newcy) < deltaY ) { \
deltaY = qAbs( ly - newcy + 1 ); \
newcy = ly + 1; \
}
#define SNAP_WINDOW_C_BOTTOM if ( (sOWO?(newry>lry):true) \
2011-01-30 14:34:42 +00:00
&& (newcx == lrx || newrx == lx) \
&& qAbs(lry-newry) < deltaY ) { \
deltaY = qAbs( lry - newry - 1 ); \
newry = lry - 1; \
}
#define SNAP_WINDOW_C_LEFT if ( (sOWO?(newcx<lx):true) \
2011-01-30 14:34:42 +00:00
&& (newcy == lry || newry == ly) \
&& qAbs(lx-newcx) < deltaX ) { \
deltaX = qAbs( lx - newcx + 1 ); \
newcx = lx + 1; \
}
#define SNAP_WINDOW_C_RIGHT if ( (sOWO?(newrx>lrx):true) \
2011-01-30 14:34:42 +00:00
&& (newcy == lry || newry == ly) \
&& qAbs(lrx-newrx) < deltaX ) { \
deltaX = qAbs( lrx - newrx - 1 ); \
newrx = lrx - 1; \
}
switch(mode) {
case AbstractClient::PositionBottomRight:
SNAP_WINDOW_BOTTOM
SNAP_WINDOW_RIGHT
SNAP_WINDOW_C_BOTTOM
SNAP_WINDOW_C_RIGHT
break;
case AbstractClient::PositionRight:
SNAP_WINDOW_RIGHT
SNAP_WINDOW_C_RIGHT
break;
case AbstractClient::PositionBottom:
SNAP_WINDOW_BOTTOM
SNAP_WINDOW_C_BOTTOM
break;
case AbstractClient::PositionTopLeft:
SNAP_WINDOW_TOP
SNAP_WINDOW_LEFT
SNAP_WINDOW_C_TOP
SNAP_WINDOW_C_LEFT
break;
case AbstractClient::PositionLeft:
SNAP_WINDOW_LEFT
SNAP_WINDOW_C_LEFT
break;
case AbstractClient::PositionTop:
SNAP_WINDOW_TOP
SNAP_WINDOW_C_TOP
break;
case AbstractClient::PositionTopRight:
SNAP_WINDOW_TOP
SNAP_WINDOW_RIGHT
SNAP_WINDOW_C_TOP
SNAP_WINDOW_C_RIGHT
break;
case AbstractClient::PositionBottomLeft:
SNAP_WINDOW_BOTTOM
SNAP_WINDOW_LEFT
SNAP_WINDOW_C_BOTTOM
SNAP_WINDOW_C_LEFT
break;
2011-01-30 14:34:42 +00:00
default:
abort();
break;
}
}
}
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
// center snap
//snap = options->centerSnapZone;
//if (snap)
// {
// // Don't resize snap to center as it interferes too much
// // There are two ways of implementing this if wanted:
// // 1) Snap only to the same points that the move snap does, and
// // 2) Snap to the horizontal and vertical center lines of the screen
// }
2011-01-30 14:34:42 +00:00
moveResizeGeom = QRect(QPoint(newcx, newcy), QPoint(newrx, newry));
}
2011-01-30 14:34:42 +00:00
return moveResizeGeom;
}
/**
* Marks the client as being moved or resized by the user.
*/
void Workspace::setMoveResizeClient(AbstractClient *c)
2011-01-30 14:34:42 +00:00
{
Q_ASSERT(!c || !movingClient); // Catch attempts to move a second
// window while still moving the first one.
movingClient = c;
if (movingClient)
++block_focus;
else
--block_focus;
2011-01-30 14:34:42 +00:00
}
// When kwin crashes, windows will not be gravitated back to their original position
// and will remain offset by the size of the decoration. So when restarting, fix this
// (the property with the size of the frame remains on the window after the crash).
void Workspace::fixPositionAfterCrash(xcb_window_t w, const xcb_get_geometry_reply_t *geometry)
2011-01-30 14:34:42 +00:00
{
NETWinInfo i(connection(), w, rootWindow(), NET::WMFrameExtents, NET::Properties2());
NETStrut frame = i.frameExtents();
if (frame.left != 0 || frame.top != 0) {
// left and top needed due to narrowing conversations restrictions in C++11
const uint32_t left = frame.left;
const uint32_t top = frame.top;
const uint32_t values[] = { geometry->x - left, geometry->y - top };
xcb_configure_window(connection(), w, XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y, values);
}
2011-01-30 14:34:42 +00:00
}
//********************************************
// Client
//********************************************
/**
* Returns \a area with the client's strut taken into account.
*
* Used from Workspace in updateClientArea.
*/
// TODO move to Workspace?
QRect X11Client::adjustedClientArea(const QRect &desktopArea, const QRect& area) const
2011-01-30 14:34:42 +00:00
{
QRect r = area;
NETExtendedStrut str = strut();
QRect stareaL = QRect(
2011-01-30 14:34:42 +00:00
0,
str . left_start,
str . left_width,
str . left_end - str . left_start + 1);
QRect stareaR = QRect(
desktopArea . right() - str . right_width + 1,
str . right_start,
str . right_width,
str . right_end - str . right_start + 1);
QRect stareaT = QRect(
str . top_start,
0,
str . top_end - str . top_start + 1,
str . top_width);
QRect stareaB = QRect(
str . bottom_start,
desktopArea . bottom() - str . bottom_width + 1,
str . bottom_end - str . bottom_start + 1,
str . bottom_width);
QRect screenarea = workspace()->clientArea(ScreenArea, this);
// HACK: workarea handling is not xinerama aware, so if this strut
// reserves place at a xinerama edge that's inside the virtual screen,
// ignore the strut for workspace setting.
if (area == QRect(QPoint(0, 0), screens()->displaySize())) {
2011-01-30 14:34:42 +00:00
if (stareaL.left() < screenarea.left())
stareaL = QRect();
2011-01-30 14:34:42 +00:00
if (stareaR.right() > screenarea.right())
stareaR = QRect();
2011-01-30 14:34:42 +00:00
if (stareaT.top() < screenarea.top())
stareaT = QRect();
2011-01-30 14:34:42 +00:00
if (stareaB.bottom() < screenarea.bottom())
stareaB = QRect();
2011-01-30 14:34:42 +00:00
}
// Handle struts at xinerama edges that are inside the virtual screen.
// They're given in virtual screen coordinates, make them affect only
// their xinerama screen.
2011-01-30 14:34:42 +00:00
stareaL.setLeft(qMax(stareaL.left(), screenarea.left()));
stareaR.setRight(qMin(stareaR.right(), screenarea.right()));
stareaT.setTop(qMax(stareaT.top(), screenarea.top()));
stareaB.setBottom(qMin(stareaB.bottom(), screenarea.bottom()));
2011-01-30 14:34:42 +00:00
if (stareaL . intersects(area)) {
2013-11-01 11:29:05 +00:00
// qDebug() << "Moving left of: " << r << " to " << stareaL.right() + 1;
2011-01-30 14:34:42 +00:00
r . setLeft(stareaL . right() + 1);
}
2011-01-30 14:34:42 +00:00
if (stareaR . intersects(area)) {
2013-11-01 11:29:05 +00:00
// qDebug() << "Moving right of: " << r << " to " << stareaR.left() - 1;
2011-01-30 14:34:42 +00:00
r . setRight(stareaR . left() - 1);
}
2011-01-30 14:34:42 +00:00
if (stareaT . intersects(area)) {
2013-11-01 11:29:05 +00:00
// qDebug() << "Moving top of: " << r << " to " << stareaT.bottom() + 1;
2011-01-30 14:34:42 +00:00
r . setTop(stareaT . bottom() + 1);
}
2011-01-30 14:34:42 +00:00
if (stareaB . intersects(area)) {
2013-11-01 11:29:05 +00:00
// qDebug() << "Moving bottom of: " << r << " to " << stareaB.top() - 1;
2011-01-30 14:34:42 +00:00
r . setBottom(stareaB . top() - 1);
}
return r;
2011-01-30 14:34:42 +00:00
}
NETExtendedStrut X11Client::strut() const
2011-01-30 14:34:42 +00:00
{
NETExtendedStrut ext = info->extendedStrut();
NETStrut str = info->strut();
const QSize displaySize = screens()->displaySize();
2011-01-30 14:34:42 +00:00
if (ext.left_width == 0 && ext.right_width == 0 && ext.top_width == 0 && ext.bottom_width == 0
&& (str.left != 0 || str.right != 0 || str.top != 0 || str.bottom != 0)) {
// build extended from simple
2011-01-30 14:34:42 +00:00
if (str.left != 0) {
ext.left_width = str.left;
ext.left_start = 0;
ext.left_end = displaySize.height();
2011-01-30 14:34:42 +00:00
}
if (str.right != 0) {
ext.right_width = str.right;
ext.right_start = 0;
ext.right_end = displaySize.height();
2011-01-30 14:34:42 +00:00
}
if (str.top != 0) {
ext.top_width = str.top;
ext.top_start = 0;
ext.top_end = displaySize.width();
2011-01-30 14:34:42 +00:00
}
if (str.bottom != 0) {
ext.bottom_width = str.bottom;
ext.bottom_start = 0;
ext.bottom_end = displaySize.width();
}
}
2011-01-30 14:34:42 +00:00
return ext;
}
StrutRect X11Client::strutRect(StrutArea area) const
2011-01-30 14:34:42 +00:00
{
Q_ASSERT(area != StrutAreaAll); // Not valid
const QSize displaySize = screens()->displaySize();
NETExtendedStrut strutArea = strut();
2011-01-30 14:34:42 +00:00
switch(area) {
case StrutAreaTop:
if (strutArea.top_width != 0)
return StrutRect(QRect(
strutArea.top_start, 0,
strutArea.top_end - strutArea.top_start, strutArea.top_width
), StrutAreaTop);
break;
case StrutAreaRight:
if (strutArea.right_width != 0)
return StrutRect(QRect(
displaySize.width() - strutArea.right_width, strutArea.right_start,
2011-01-30 14:34:42 +00:00
strutArea.right_width, strutArea.right_end - strutArea.right_start
), StrutAreaRight);
break;
case StrutAreaBottom:
if (strutArea.bottom_width != 0)
return StrutRect(QRect(
strutArea.bottom_start, displaySize.height() - strutArea.bottom_width,
2011-01-30 14:34:42 +00:00
strutArea.bottom_end - strutArea.bottom_start, strutArea.bottom_width
), StrutAreaBottom);
break;
case StrutAreaLeft:
if (strutArea.left_width != 0)
return StrutRect(QRect(
0, strutArea.left_start,
strutArea.left_width, strutArea.left_end - strutArea.left_start
), StrutAreaLeft);
break;
default:
abort(); // Not valid
}
2011-01-30 14:34:42 +00:00
return StrutRect(); // Null rect
}
StrutRects X11Client::strutRects() const
2011-01-30 14:34:42 +00:00
{
StrutRects region;
2011-01-30 14:34:42 +00:00
region += strutRect(StrutAreaTop);
region += strutRect(StrutAreaRight);
region += strutRect(StrutAreaBottom);
region += strutRect(StrutAreaLeft);
return region;
2011-01-30 14:34:42 +00:00
}
bool X11Client::hasStrut() const
2011-01-30 14:34:42 +00:00
{
NETExtendedStrut ext = strut();
2011-01-30 14:34:42 +00:00
if (ext.left_width == 0 && ext.right_width == 0 && ext.top_width == 0 && ext.bottom_width == 0)
return false;
return true;
2011-01-30 14:34:42 +00:00
}
bool X11Client::hasOffscreenXineramaStrut() const
2011-01-30 14:34:42 +00:00
{
// Get strut as a QRegion
QRegion region;
2011-01-30 14:34:42 +00:00
region += strutRect(StrutAreaTop);
region += strutRect(StrutAreaRight);
region += strutRect(StrutAreaBottom);
region += strutRect(StrutAreaLeft);
// Remove all visible areas so that only the invisible remain
for (int i = 0; i < screens()->count(); i ++)
region -= screens()->geometry(i);
// If there's anything left then we have an offscreen strut
return !region.isEmpty();
2011-01-30 14:34:42 +00:00
}
void AbstractClient::checkWorkspacePosition(QRect oldGeometry, int oldDesktop, QRect oldClientGeometry)
2011-01-30 14:34:42 +00:00
{
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
enum { Left = 0, Top, Right, Bottom };
const int border[4] = { borderLeft(), borderTop(), borderRight(), borderBottom() };
if( !oldGeometry.isValid())
oldGeometry = frameGeometry();
if( oldDesktop == -2 )
oldDesktop = desktop();
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
if (!oldClientGeometry.isValid())
oldClientGeometry = oldGeometry.adjusted(border[Left], border[Top], -border[Right], -border[Bottom]);
2011-01-30 14:34:42 +00:00
if (isDesktop())
return;
2011-01-30 14:34:42 +00:00
if (isFullScreen()) {
QRect area = workspace()->clientArea(FullScreenArea, this);
if (frameGeometry() != area)
setFrameGeometry(area);
return;
2011-01-30 14:34:42 +00:00
}
if (isDock())
return;
if (maximizeMode() != MaximizeRestore) {
2011-01-30 14:34:42 +00:00
// TODO update geom_restore?
changeMaximize(false, false, true); // adjust size
const QRect screenArea = workspace()->clientArea(ScreenArea, this);
QRect geom = frameGeometry();
checkOffscreenPosition(&geom, screenArea);
setFrameGeometry(geom);
return;
}
if (quickTileMode() != QuickTileMode(QuickTileFlag::None)) {
setFrameGeometry(electricBorderMaximizeGeometry(frameGeometry().center(), desktop()));
return;
}
// this can be true only if this window was mapped before KWin
// was started - in such case, don't adjust position to workarea,
// because the window already had its position, and if a window
// with a strut altering the workarea would be managed in initialization
// after this one, this window would be moved
if (!workspace() || workspace()->initializing())
return;
// If the window was touching an edge before but not now move it so it is again.
// Old and new maximums have different starting values so windows on the screen
// edge will move when a new strut is placed on the edge.
QRect oldScreenArea;
if( workspace()->inUpdateClientArea()) {
// we need to find the screen area as it was before the change
oldScreenArea = QRect( 0, 0, workspace()->oldDisplayWidth(), workspace()->oldDisplayHeight());
int distance = INT_MAX;
foreach(const QRect &r, workspace()->previousScreenSizes()) {
int d = r.contains( oldGeometry.center()) ? 0 : ( r.center() - oldGeometry.center()).manhattanLength();
if( d < distance ) {
distance = d;
oldScreenArea = r;
}
}
} else {
oldScreenArea = workspace()->clientArea(ScreenArea, oldGeometry.center(), oldDesktop);
}
const QRect oldGeomTall = QRect(oldGeometry.x(), oldScreenArea.y(), oldGeometry.width(), oldScreenArea.height()); // Full screen height
const QRect oldGeomWide = QRect(oldScreenArea.x(), oldGeometry.y(), oldScreenArea.width(), oldGeometry.height()); // Full screen width
int oldTopMax = oldScreenArea.y();
int oldRightMax = oldScreenArea.x() + oldScreenArea.width();
int oldBottomMax = oldScreenArea.y() + oldScreenArea.height();
int oldLeftMax = oldScreenArea.x();
const QRect screenArea = workspace()->clientArea(ScreenArea, geometryRestore().center(), desktop());
int topMax = screenArea.y();
int rightMax = screenArea.x() + screenArea.width();
int bottomMax = screenArea.y() + screenArea.height();
int leftMax = screenArea.x();
QRect newGeom = geometryRestore(); // geometry();
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
QRect newClientGeom = newGeom.adjusted(border[Left], border[Top], -border[Right], -border[Bottom]);
const QRect newGeomTall = QRect(newGeom.x(), screenArea.y(), newGeom.width(), screenArea.height()); // Full screen height
const QRect newGeomWide = QRect(screenArea.x(), newGeom.y(), screenArea.width(), newGeom.height()); // Full screen width
// Get the max strut point for each side where the window is (E.g. Highest point for
// the bottom struts bounded by the window's left and right sides).
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
// These 4 compute old bounds ...
auto moveAreaFunc = workspace()->inUpdateClientArea() ?
&Workspace::previousRestrictedMoveArea : //... the restricted areas changed
&Workspace::restrictedMoveArea; //... when e.g. active desktop or screen changes
for (const QRect &r : (workspace()->*moveAreaFunc)(oldDesktop, StrutAreaTop)) {
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
QRect rect = r & oldGeomTall;
if (!rect.isEmpty())
oldTopMax = qMax(oldTopMax, rect.y() + rect.height());
}
for (const QRect &r : (workspace()->*moveAreaFunc)(oldDesktop, StrutAreaRight)) {
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
QRect rect = r & oldGeomWide;
if (!rect.isEmpty())
oldRightMax = qMin(oldRightMax, rect.x());
}
for (const QRect &r : (workspace()->*moveAreaFunc)(oldDesktop, StrutAreaBottom)) {
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
QRect rect = r & oldGeomTall;
if (!rect.isEmpty())
oldBottomMax = qMin(oldBottomMax, rect.y());
}
for (const QRect &r : (workspace()->*moveAreaFunc)(oldDesktop, StrutAreaLeft)) {
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
QRect rect = r & oldGeomWide;
if (!rect.isEmpty())
oldLeftMax = qMax(oldLeftMax, rect.x() + rect.width());
}
// These 4 compute new bounds
for (const QRect &r : workspace()->restrictedMoveArea(desktop(), StrutAreaTop)) {
QRect rect = r & newGeomTall;
if (!rect.isEmpty())
topMax = qMax(topMax, rect.y() + rect.height());
}
for (const QRect &r : workspace()->restrictedMoveArea(desktop(), StrutAreaRight)) {
QRect rect = r & newGeomWide;
if (!rect.isEmpty())
rightMax = qMin(rightMax, rect.x());
}
for (const QRect &r : workspace()->restrictedMoveArea(desktop(), StrutAreaBottom)) {
QRect rect = r & newGeomTall;
if (!rect.isEmpty())
bottomMax = qMin(bottomMax, rect.y());
}
for (const QRect &r : workspace()->restrictedMoveArea(desktop(), StrutAreaLeft)) {
QRect rect = r & newGeomWide;
if (!rect.isEmpty())
leftMax = qMax(leftMax, rect.x() + rect.width());
}
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
// Check if the sides were inside or touching but are no longer
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
bool keep[4] = {false, false, false, false};
bool save[4] = {false, false, false, false};
int padding[4] = {0, 0, 0, 0};
if (oldGeometry.x() >= oldLeftMax)
save[Left] = newGeom.x() < leftMax;
if (oldGeometry.x() == oldLeftMax)
keep[Left] = newGeom.x() != leftMax;
else if (oldClientGeometry.x() == oldLeftMax && newClientGeom.x() != leftMax) {
padding[0] = border[Left];
keep[Left] = true;
}
if (oldGeometry.y() >= oldTopMax)
save[Top] = newGeom.y() < topMax;
if (oldGeometry.y() == oldTopMax)
keep[Top] = newGeom.y() != topMax;
else if (oldClientGeometry.y() == oldTopMax && newClientGeom.y() != topMax) {
padding[1] = border[Left];
keep[Top] = true;
}
if (oldGeometry.right() <= oldRightMax - 1)
save[Right] = newGeom.right() > rightMax - 1;
if (oldGeometry.right() == oldRightMax - 1)
keep[Right] = newGeom.right() != rightMax - 1;
else if (oldClientGeometry.right() == oldRightMax - 1 && newClientGeom.right() != rightMax - 1) {
padding[2] = border[Right];
keep[Right] = true;
}
if (oldGeometry.bottom() <= oldBottomMax - 1)
save[Bottom] = newGeom.bottom() > bottomMax - 1;
if (oldGeometry.bottom() == oldBottomMax - 1)
keep[Bottom] = newGeom.bottom() != bottomMax - 1;
else if (oldClientGeometry.bottom() == oldBottomMax - 1 && newClientGeom.bottom() != bottomMax - 1) {
padding[3] = border[Bottom];
keep[Bottom] = true;
}
// if randomly touches opposing edges, do not favor either
if (keep[Left] && keep[Right]) {
keep[Left] = keep[Right] = false;
padding[0] = padding[2] = 0;
}
if (keep[Top] && keep[Bottom]) {
keep[Top] = keep[Bottom] = false;
padding[1] = padding[3] = 0;
}
if (save[Left] || keep[Left])
newGeom.moveLeft(qMax(leftMax, screenArea.x()) - padding[0]);
if (padding[0] && screens()->intersecting(newGeom) > 1)
newGeom.moveLeft(newGeom.left() + padding[0]);
if (save[Top] || keep[Top])
newGeom.moveTop(qMax(topMax, screenArea.y()) - padding[1]);
if (padding[1] && screens()->intersecting(newGeom) > 1)
newGeom.moveTop(newGeom.top() + padding[1]);
if (save[Right] || keep[Right])
newGeom.moveRight(qMin(rightMax - 1, screenArea.right()) + padding[2]);
if (padding[2] && screens()->intersecting(newGeom) > 1)
newGeom.moveRight(newGeom.right() - padding[2]);
if (oldGeometry.x() >= oldLeftMax && newGeom.x() < leftMax)
newGeom.setLeft(qMax(leftMax, screenArea.x()));
else if (oldClientGeometry.x() >= oldLeftMax && newGeom.x() + border[Left] < leftMax) {
newGeom.setLeft(qMax(leftMax, screenArea.x()) - border[Left]);
if (screens()->intersecting(newGeom) > 1)
newGeom.setLeft(newGeom.left() + border[Left]);
}
if (save[Bottom] || keep[Bottom])
newGeom.moveBottom(qMin(bottomMax - 1, screenArea.bottom()) + padding[3]);
if (padding[3] && screens()->intersecting(newGeom) > 1)
newGeom.moveBottom(newGeom.bottom() - padding[3]);
if (oldGeometry.y() >= oldTopMax && newGeom.y() < topMax)
newGeom.setTop(qMax(topMax, screenArea.y()));
else if (oldClientGeometry.y() >= oldTopMax && newGeom.y() + border[Top] < topMax) {
newGeom.setTop(qMax(topMax, screenArea.y()) - border[Top]);
if (screens()->intersecting(newGeom) > 1)
newGeom.setTop(newGeom.top() + border[Top]);
}
checkOffscreenPosition(&newGeom, screenArea);
// Obey size hints. TODO: We really should make sure it stays in the right place
if (!isShade())
newGeom.setSize(adjustedSize(newGeom.size()));
if (newGeom != frameGeometry())
setFrameGeometry(newGeom);
2011-01-30 14:34:42 +00:00
}
void AbstractClient::checkOffscreenPosition(QRect* geom, const QRect& screenArea)
{
if (geom->left() > screenArea.right()) {
geom->moveLeft(screenArea.right() - screenArea.width()/4);
} else if (geom->right() < screenArea.left()) {
geom->moveRight(screenArea.left() + screenArea.width()/4);
}
if (geom->top() > screenArea.bottom()) {
geom->moveTop(screenArea.bottom() - screenArea.height()/4);
} else if (geom->bottom() < screenArea.top()) {
geom->moveBottom(screenArea.top() + screenArea.width()/4);
}
}
QSize AbstractClient::adjustedSize(const QSize& frame, Sizemode mode) const
2011-01-30 14:34:42 +00:00
{
// first, get the window size for the given frame size s
QSize wsize(frame.width() - (borderLeft() + borderRight()),
frame.height() - (borderTop() + borderBottom()));
2011-01-30 14:34:42 +00:00
if (wsize.isEmpty())
wsize = QSize(qMax(wsize.width(), 1), qMax(wsize.height(), 1));
2011-01-30 14:34:42 +00:00
return sizeForClientSize(wsize, mode, false);
}
// this helper returns proper size even if the window is shaded
// see also the comment in X11Client::setGeometry()
QSize AbstractClient::adjustedSize() const
2011-01-30 14:34:42 +00:00
{
return sizeForClientSize(clientSize());
}
/**
* Calculate the appropriate frame size for the given client size \a
* wsize.
*
* \a wsize is adapted according to the window's size hints (minimum,
* maximum and incremental size changes).
*/
QSize X11Client::sizeForClientSize(const QSize& wsize, Sizemode mode, bool noframe) const
2011-01-30 14:34:42 +00:00
{
int w = wsize.width();
int h = wsize.height();
2011-01-30 14:34:42 +00:00
if (w < 1 || h < 1) {
qCWarning(KWIN_CORE) << "sizeForClientSize() with empty size!" ;
2011-01-30 14:34:42 +00:00
}
if (w < 1) w = 1;
if (h < 1) h = 1;
// basesize, minsize, maxsize, paspect and resizeinc have all values defined,
// even if they're not set in flags - see getWmNormalHints()
QSize min_size = minSize();
QSize max_size = maxSize();
if (isDecorated()) {
QSize decominsize(0, 0);
QSize border_size(borderLeft() + borderRight(), borderTop() + borderBottom());
2011-01-30 14:34:42 +00:00
if (border_size.width() > decominsize.width()) // just in case
decominsize.setWidth(border_size.width());
if (border_size.height() > decominsize.height())
decominsize.setHeight(border_size.height());
if (decominsize.width() > min_size.width())
min_size.setWidth(decominsize.width());
if (decominsize.height() > min_size.height())
min_size.setHeight(decominsize.height());
}
w = qMin(max_size.width(), w);
h = qMin(max_size.height(), h);
w = qMax(min_size.width(), w);
h = qMax(min_size.height(), h);
int w1 = w;
int h1 = h;
int width_inc = m_geometryHints.resizeIncrements().width();
int height_inc = m_geometryHints.resizeIncrements().height();
int basew_inc = m_geometryHints.baseSize().width();
int baseh_inc = m_geometryHints.baseSize().height();
if (!m_geometryHints.hasBaseSize()) {
basew_inc = m_geometryHints.minSize().width();
baseh_inc = m_geometryHints.minSize().height();
}
2011-01-30 14:34:42 +00:00
w = int((w - basew_inc) / width_inc) * width_inc + basew_inc;
h = int((h - baseh_inc) / height_inc) * height_inc + baseh_inc;
// code for aspect ratios based on code from FVWM
/*
* The math looks like this:
*
* minAspectX dwidth maxAspectX
* ---------- <= ------- <= ----------
* minAspectY dheight maxAspectY
*
* If that is multiplied out, then the width and height are
* invalid in the following situations:
*
* minAspectX * dheight > minAspectY * dwidth
* maxAspectX * dheight < maxAspectY * dwidth
*
*/
if (m_geometryHints.hasAspect()) {
double min_aspect_w = m_geometryHints.minAspect().width(); // use doubles, because the values can be MAX_INT
double min_aspect_h = m_geometryHints.minAspect().height(); // and multiplying would go wrong otherwise
double max_aspect_w = m_geometryHints.maxAspect().width();
double max_aspect_h = m_geometryHints.maxAspect().height();
// According to ICCCM 4.1.2.3 PMinSize should be a fallback for PBaseSize for size increments,
// but not for aspect ratio. Since this code comes from FVWM, handles both at the same time,
// and I have no idea how it works, let's hope nobody relies on that.
const QSize baseSize = m_geometryHints.baseSize();
w -= baseSize.width();
h -= baseSize.height();
int max_width = max_size.width() - baseSize.width();
int min_width = min_size.width() - baseSize.width();
int max_height = max_size.height() - baseSize.height();
int min_height = min_size.height() - baseSize.height();
#define ASPECT_CHECK_GROW_W \
2011-01-30 14:34:42 +00:00
if ( min_aspect_w * h > min_aspect_h * w ) \
{ \
int delta = int( min_aspect_w * h / min_aspect_h - w ) / width_inc * width_inc; \
if ( w + delta <= max_width ) \
w += delta; \
}
#define ASPECT_CHECK_SHRINK_H_GROW_W \
if ( min_aspect_w * h > min_aspect_h * w ) \
{ \
int delta = int( h - w * min_aspect_h / min_aspect_w ) / height_inc * height_inc; \
if ( h - delta >= min_height ) \
h -= delta; \
else \
{ \
int delta = int( min_aspect_w * h / min_aspect_h - w ) / width_inc * width_inc; \
2011-01-30 14:34:42 +00:00
if ( w + delta <= max_width ) \
w += delta; \
2011-01-30 14:34:42 +00:00
} \
}
#define ASPECT_CHECK_GROW_H \
2011-01-30 14:34:42 +00:00
if ( max_aspect_w * h < max_aspect_h * w ) \
{ \
int delta = int( w * max_aspect_h / max_aspect_w - h ) / height_inc * height_inc; \
if ( h + delta <= max_height ) \
h += delta; \
}
#define ASPECT_CHECK_SHRINK_W_GROW_H \
if ( max_aspect_w * h < max_aspect_h * w ) \
{ \
int delta = int( w - max_aspect_w * h / max_aspect_h ) / width_inc * width_inc; \
if ( w - delta >= min_width ) \
w -= delta; \
else \
{ \
int delta = int( w * max_aspect_h / max_aspect_w - h ) / height_inc * height_inc; \
2011-01-30 14:34:42 +00:00
if ( h + delta <= max_height ) \
h += delta; \
2011-01-30 14:34:42 +00:00
} \
}
switch(mode) {
case SizemodeAny:
#if 0 // make SizemodeAny equal to SizemodeFixedW - prefer keeping fixed width,
2011-01-30 14:34:42 +00:00
// so that changing aspect ratio to a different value and back keeps the same size (#87298)
{
ASPECT_CHECK_SHRINK_H_GROW_W
ASPECT_CHECK_SHRINK_W_GROW_H
ASPECT_CHECK_GROW_H
ASPECT_CHECK_GROW_W
break;
}
2011-01-30 14:34:42 +00:00
#endif
case SizemodeFixedW: {
// the checks are order so that attempts to modify height are first
ASPECT_CHECK_GROW_H
ASPECT_CHECK_SHRINK_H_GROW_W
ASPECT_CHECK_SHRINK_W_GROW_H
ASPECT_CHECK_GROW_W
break;
}
case SizemodeFixedH: {
ASPECT_CHECK_GROW_W
ASPECT_CHECK_SHRINK_W_GROW_H
ASPECT_CHECK_SHRINK_H_GROW_W
ASPECT_CHECK_GROW_H
break;
}
case SizemodeMax: {
// first checks that try to shrink
ASPECT_CHECK_SHRINK_H_GROW_W
ASPECT_CHECK_SHRINK_W_GROW_H
ASPECT_CHECK_GROW_W
ASPECT_CHECK_GROW_H
break;
}
}
#undef ASPECT_CHECK_SHRINK_H_GROW_W
#undef ASPECT_CHECK_SHRINK_W_GROW_H
#undef ASPECT_CHECK_GROW_W
#undef ASPECT_CHECK_GROW_H
w += baseSize.width();
h += baseSize.height();
2011-01-30 14:34:42 +00:00
}
if (!rules()->checkStrictGeometry(!isFullScreen())) {
2011-01-30 14:34:42 +00:00
// disobey increments and aspect by explicit rule
w = w1;
h = h1;
}
2011-01-30 14:34:42 +00:00
if (!noframe) {
w += borderLeft() + borderRight();
h += borderTop() + borderBottom();
}
2011-01-30 14:34:42 +00:00
return rules()->checkSize(QSize(w, h));
}
/**
* Gets the client's normal WM hints and reconfigures itself respectively.
*/
void X11Client::getWmNormalHints()
2011-01-30 14:34:42 +00:00
{
const bool hadFixedAspect = m_geometryHints.hasAspect();
// roundtrip to X server
m_geometryHints.fetch();
m_geometryHints.read();
if (!hadFixedAspect && m_geometryHints.hasAspect()) {
// align to eventual new contraints
maximize(max_mode);
}
2011-01-30 14:34:42 +00:00
if (isManaged()) {
// update to match restrictions
QSize new_size = adjustedSize();
2011-01-30 14:34:42 +00:00
if (new_size != size() && !isFullScreen()) {
QRect origClientGeometry(pos() + clientPos(), clientSize());
2011-01-30 14:34:42 +00:00
resizeWithChecks(new_size);
if ((!isSpecialWindow() || isToolbar()) && !isFullScreen()) {
// try to keep the window in its xinerama screen if possible,
// if that fails at least keep it visible somewhere
2011-01-30 14:34:42 +00:00
QRect area = workspace()->clientArea(MovementArea, this);
if (area.contains(origClientGeometry))
2011-01-30 14:34:42 +00:00
keepInArea(area);
area = workspace()->clientArea(WorkArea, this);
if (area.contains(origClientGeometry))
2011-01-30 14:34:42 +00:00
keepInArea(area);
}
}
}
2011-01-30 14:34:42 +00:00
updateAllowedActions(); // affects isResizeable()
}
QSize X11Client::minSize() const
2011-01-30 14:34:42 +00:00
{
return rules()->checkMinSize(m_geometryHints.minSize());
2011-01-30 14:34:42 +00:00
}
QSize X11Client::maxSize() const
2011-01-30 14:34:42 +00:00
{
return rules()->checkMaxSize(m_geometryHints.maxSize());
2011-01-30 14:34:42 +00:00
}
QSize X11Client::basicUnit() const
{
return m_geometryHints.resizeIncrements();
}
/**
* Auxiliary function to inform the client about the current window
* configuration.
*/
void X11Client::sendSyntheticConfigureNotify()
2011-01-30 14:34:42 +00:00
{
xcb_configure_notify_event_t c;
memset(&c, 0, sizeof(c));
c.response_type = XCB_CONFIGURE_NOTIFY;
c.event = window();
c.window = window();
c.x = x() + clientPos().x();
c.y = y() + clientPos().y();
c.width = clientSize().width();
c.height = clientSize().height();
c.border_width = 0;
c.above_sibling = XCB_WINDOW_NONE;
c.override_redirect = 0;
xcb_send_event(connection(), true, c.event, XCB_EVENT_MASK_STRUCTURE_NOTIFY, reinterpret_cast<const char*>(&c));
xcb_flush(connection());
2011-01-30 14:34:42 +00:00
}
const QPoint X11Client::calculateGravitation(bool invert, int gravity) const
2011-01-30 14:34:42 +00:00
{
int dx, dy;
dx = dy = 0;
2011-01-30 14:34:42 +00:00
if (gravity == 0) // default (nonsense) value for the argument
gravity = m_geometryHints.windowGravity();
// dx, dy specify how the client window moves to make space for the frame
2011-01-30 14:34:42 +00:00
switch(gravity) {
case XCB_GRAVITY_NORTH_WEST: // move down right
2011-01-30 14:34:42 +00:00
default:
dx = borderLeft();
dy = borderTop();
2011-01-30 14:34:42 +00:00
break;
case XCB_GRAVITY_NORTH: // move right
2011-01-30 14:34:42 +00:00
dx = 0;
dy = borderTop();
2011-01-30 14:34:42 +00:00
break;
case XCB_GRAVITY_NORTH_EAST: // move down left
dx = -borderRight();
dy = borderTop();
2011-01-30 14:34:42 +00:00
break;
case XCB_GRAVITY_WEST: // move right
dx = borderLeft();
2011-01-30 14:34:42 +00:00
dy = 0;
break;
case XCB_GRAVITY_CENTER:
2011-01-30 14:34:42 +00:00
break; // will be handled specially
case XCB_GRAVITY_STATIC: // don't move
2011-01-30 14:34:42 +00:00
dx = 0;
dy = 0;
break;
case XCB_GRAVITY_EAST: // move left
dx = -borderRight();
2011-01-30 14:34:42 +00:00
dy = 0;
break;
case XCB_GRAVITY_SOUTH_WEST: // move up right
dx = borderLeft() ;
dy = -borderBottom();
2011-01-30 14:34:42 +00:00
break;
case XCB_GRAVITY_SOUTH: // move up
2011-01-30 14:34:42 +00:00
dx = 0;
dy = -borderBottom();
2011-01-30 14:34:42 +00:00
break;
case XCB_GRAVITY_SOUTH_EAST: // move up left
dx = -borderRight();
dy = -borderBottom();
2011-01-30 14:34:42 +00:00
break;
}
if (gravity != XCB_GRAVITY_CENTER) {
2011-01-30 14:34:42 +00:00
// translate from client movement to frame movement
dx -= borderLeft();
dy -= borderTop();
2011-01-30 14:34:42 +00:00
} else {
// center of the frame will be at the same position client center without frame would be
dx = - (borderLeft() + borderRight()) / 2;
dy = - (borderTop() + borderBottom()) / 2;
}
2011-01-30 14:34:42 +00:00
if (!invert)
return QPoint(x() + dx, y() + dy);
else
return QPoint(x() - dx, y() - dy);
}
void X11Client::configureRequest(int value_mask, int rx, int ry, int rw, int rh, int gravity, bool from_tool)
2011-01-30 14:34:42 +00:00
{
const int configurePositionMask = XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y;
const int configureSizeMask = XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT;
const int configureGeometryMask = configurePositionMask | configureSizeMask;
// "maximized" is a user setting -> we do not allow the client to resize itself
// away from this & against the users explicit wish
qCDebug(KWIN_CORE) << this << bool(value_mask & configureGeometryMask) <<
bool(maximizeMode() & MaximizeVertical) <<
bool(maximizeMode() & MaximizeHorizontal);
// we want to (partially) ignore the request when the window is somehow maximized or quicktiled
bool ignore = !app_noborder && (quickTileMode() != QuickTileMode(QuickTileFlag::None) || maximizeMode() != MaximizeRestore);
// however, the user shall be able to force obedience despite and also disobedience in general
ignore = rules()->checkIgnoreGeometry(ignore);
if (!ignore) { // either we're not max'd / q'tiled or the user allowed the client to break that - so break it.
updateQuickTileMode(QuickTileFlag::None);
max_mode = MaximizeRestore;
emit quickTileModeChanged();
} else if (!app_noborder && quickTileMode() == QuickTileMode(QuickTileFlag::None) &&
(maximizeMode() == MaximizeVertical || maximizeMode() == MaximizeHorizontal)) {
// ignoring can be, because either we do, or the user does explicitly not want it.
// for partially maximized windows we want to allow configures in the other dimension.
// so we've to ask the user again - to know whether we just ignored for the partial maximization.
// the problem here is, that the user can explicitly permit configure requests - even for maximized windows!
// we cannot distinguish that from passing "false" for partially maximized windows.
ignore = rules()->checkIgnoreGeometry(false);
if (!ignore) { // the user is not interested, so we fix up dimensions
if (maximizeMode() == MaximizeVertical)
value_mask &= ~(XCB_CONFIG_WINDOW_Y | XCB_CONFIG_WINDOW_HEIGHT);
if (maximizeMode() == MaximizeHorizontal)
value_mask &= ~(XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_WIDTH);
if (!(value_mask & configureGeometryMask)) {
ignore = true; // the modification turned the request void
}
}
}
if (ignore) {
qCDebug(KWIN_CORE) << "DENIED";
return; // nothing to (left) to do for use - bugs #158974, #252314, #321491
}
qCDebug(KWIN_CORE) << "PERMITTED" << this << bool(value_mask & configureGeometryMask);
2011-01-30 14:34:42 +00:00
if (gravity == 0) // default (nonsense) value for the argument
gravity = m_geometryHints.windowGravity();
if (value_mask & configurePositionMask) {
2011-01-30 14:34:42 +00:00
QPoint new_pos = calculateGravitation(true, gravity); // undo gravitation
if (value_mask & XCB_CONFIG_WINDOW_X) {
2011-01-30 14:34:42 +00:00
new_pos.setX(rx);
}
if (value_mask & XCB_CONFIG_WINDOW_Y) {
2011-01-30 14:34:42 +00:00
new_pos.setY(ry);
}
// clever(?) workaround for applications like xv that want to set
// the location to the current location but miscalculate the
// frame size due to kwin being a double-reparenting window
// manager
2011-01-30 14:34:42 +00:00
if (new_pos.x() == x() + clientPos().x() && new_pos.y() == y() + clientPos().y()
&& gravity == XCB_GRAVITY_NORTH_WEST && !from_tool) {
2011-01-30 14:34:42 +00:00
new_pos.setX(x());
new_pos.setY(y());
}
int nw = clientSize().width();
int nh = clientSize().height();
if (value_mask & XCB_CONFIG_WINDOW_WIDTH) {
nw = rw;
}
if (value_mask & XCB_CONFIG_WINDOW_HEIGHT) {
nh = rh;
}
2011-01-30 14:34:42 +00:00
QSize ns = sizeForClientSize(QSize(nw, nh)); // enforces size if needed
new_pos = rules()->checkPosition(new_pos);
int newScreen = screens()->number(QRect(new_pos, ns).center());
if (newScreen != rules()->checkScreen(newScreen))
return; // not allowed by rule
QRect origClientGeometry(pos() + clientPos(), clientSize());
2011-01-30 14:34:42 +00:00
GeometryUpdatesBlocker blocker(this);
move(new_pos);
plainResize(ns);
setFrameGeometry(QRect(calculateGravitation(false, gravity), size()));
2011-01-30 14:34:42 +00:00
QRect area = workspace()->clientArea(WorkArea, this);
if (!from_tool && (!isSpecialWindow() || isToolbar()) && !isFullScreen()
&& area.contains(origClientGeometry))
2011-01-30 14:34:42 +00:00
keepInArea(area);
// this is part of the kicker-xinerama-hack... it should be
// safe to remove when kicker gets proper ExtendedStrut support;
// see Workspace::updateClientArea() and
// X11Client::adjustedClientArea()
2011-01-30 14:34:42 +00:00
if (hasStrut())
workspace() -> updateClientArea();
}
if (value_mask & configureSizeMask && !(value_mask & configurePositionMask)) { // pure resize
int nw = clientSize().width();
int nh = clientSize().height();
if (value_mask & XCB_CONFIG_WINDOW_WIDTH) {
nw = rw;
}
if (value_mask & XCB_CONFIG_WINDOW_HEIGHT) {
nh = rh;
}
2011-01-30 14:34:42 +00:00
QSize ns = sizeForClientSize(QSize(nw, nh));
2011-01-30 14:34:42 +00:00
if (ns != size()) { // don't restore if some app sets its own size again
QRect origClientGeometry(pos() + clientPos(), clientSize());
2011-01-30 14:34:42 +00:00
GeometryUpdatesBlocker blocker(this);
resizeWithChecks(ns, xcb_gravity_t(gravity));
2011-01-30 14:34:42 +00:00
if (!from_tool && (!isSpecialWindow() || isToolbar()) && !isFullScreen()) {
// try to keep the window in its xinerama screen if possible,
// if that fails at least keep it visible somewhere
2011-01-30 14:34:42 +00:00
QRect area = workspace()->clientArea(MovementArea, this);
if (area.contains(origClientGeometry))
2011-01-30 14:34:42 +00:00
keepInArea(area);
area = workspace()->clientArea(WorkArea, this);
if (area.contains(origClientGeometry))
2011-01-30 14:34:42 +00:00
keepInArea(area);
}
}
2011-01-30 14:34:42 +00:00
}
geom_restore = frameGeometry();
// No need to send synthetic configure notify event here, either it's sent together
// with geometry change, or there's no need to send it.
// Handling of the real ConfigureRequest event forces sending it, as there it's necessary.
2011-01-30 14:34:42 +00:00
}
void X11Client::resizeWithChecks(int w, int h, xcb_gravity_t gravity, ForceGeometry_t force)
2011-01-30 14:34:42 +00:00
{
Q_ASSERT(!shade_geometry_change);
2011-01-30 14:34:42 +00:00
if (isShade()) {
if (h == borderTop() + borderBottom()) {
qCWarning(KWIN_CORE) << "Shaded geometry passed for size:" ;
}
2011-01-30 14:34:42 +00:00
}
int newx = x();
int newy = y();
2011-01-30 14:34:42 +00:00
QRect area = workspace()->clientArea(WorkArea, this);
// don't allow growing larger than workarea
2011-01-30 14:34:42 +00:00
if (w > area.width())
w = area.width();
2011-01-30 14:34:42 +00:00
if (h > area.height())
h = area.height();
2011-01-30 14:34:42 +00:00
QSize tmp = adjustedSize(QSize(w, h)); // checks size constraints, including min/max size
w = tmp.width();
h = tmp.height();
if (gravity == 0) {
gravity = m_geometryHints.windowGravity();
}
switch(gravity) {
case XCB_GRAVITY_NORTH_WEST: // top left corner doesn't move
2011-01-30 14:34:42 +00:00
default:
break;
case XCB_GRAVITY_NORTH: // middle of top border doesn't move
2011-01-30 14:34:42 +00:00
newx = (newx + width() / 2) - (w / 2);
break;
case XCB_GRAVITY_NORTH_EAST: // top right corner doesn't move
2011-01-30 14:34:42 +00:00
newx = newx + width() - w;
break;
case XCB_GRAVITY_WEST: // middle of left border doesn't move
2011-01-30 14:34:42 +00:00
newy = (newy + height() / 2) - (h / 2);
break;
case XCB_GRAVITY_CENTER: // middle point doesn't move
2011-01-30 14:34:42 +00:00
newx = (newx + width() / 2) - (w / 2);
newy = (newy + height() / 2) - (h / 2);
break;
case XCB_GRAVITY_STATIC: // top left corner of _client_ window doesn't move
2011-01-30 14:34:42 +00:00
// since decoration doesn't change, equal to NorthWestGravity
break;
case XCB_GRAVITY_EAST: // // middle of right border doesn't move
2011-01-30 14:34:42 +00:00
newx = newx + width() - w;
newy = (newy + height() / 2) - (h / 2);
break;
case XCB_GRAVITY_SOUTH_WEST: // bottom left corner doesn't move
2011-01-30 14:34:42 +00:00
newy = newy + height() - h;
break;
case XCB_GRAVITY_SOUTH: // middle of bottom border doesn't move
2011-01-30 14:34:42 +00:00
newx = (newx + width() / 2) - (w / 2);
newy = newy + height() - h;
break;
case XCB_GRAVITY_SOUTH_EAST: // bottom right corner doesn't move
2011-01-30 14:34:42 +00:00
newx = newx + width() - w;
newy = newy + height() - h;
break;
}
setFrameGeometry(newx, newy, w, h, force);
2011-01-30 14:34:42 +00:00
}
// _NET_MOVERESIZE_WINDOW
void X11Client::NETMoveResizeWindow(int flags, int x, int y, int width, int height)
2011-01-30 14:34:42 +00:00
{
int gravity = flags & 0xff;
int value_mask = 0;
if (flags & (1 << 8)) {
value_mask |= XCB_CONFIG_WINDOW_X;
}
if (flags & (1 << 9)) {
value_mask |= XCB_CONFIG_WINDOW_Y;
}
if (flags & (1 << 10)) {
value_mask |= XCB_CONFIG_WINDOW_WIDTH;
}
if (flags & (1 << 11)) {
value_mask |= XCB_CONFIG_WINDOW_HEIGHT;
}
2011-01-30 14:34:42 +00:00
configureRequest(value_mask, x, y, width, height, gravity, true);
}
bool X11Client::isMovable() const
2011-01-30 14:34:42 +00:00
{
if (!hasNETSupport() && !m_motif.move()) {
return false;
}
if (isFullScreen())
return false;
2011-01-30 14:34:42 +00:00
if (isSpecialWindow() && !isSplash() && !isToolbar()) // allow moving of splashscreens :)
return false;
2011-01-30 14:34:42 +00:00
if (rules()->checkPosition(invalidPoint) != invalidPoint) // forced position
return false;
return true;
2011-01-30 14:34:42 +00:00
}
bool X11Client::isMovableAcrossScreens() const
2011-01-30 14:34:42 +00:00
{
if (!hasNETSupport() && !m_motif.move()) {
return false;
}
2011-01-30 14:34:42 +00:00
if (isSpecialWindow() && !isSplash() && !isToolbar()) // allow moving of splashscreens :)
return false;
2011-01-30 14:34:42 +00:00
if (rules()->checkPosition(invalidPoint) != invalidPoint) // forced position
return false;
return true;
2011-01-30 14:34:42 +00:00
}
bool X11Client::isResizable() const
2011-01-30 14:34:42 +00:00
{
if (!hasNETSupport() && !m_motif.resize()) {
return false;
}
if (isFullScreen())
return false;
2011-01-30 14:34:42 +00:00
if (isSpecialWindow() || isSplash() || isToolbar())
return false;
2011-01-30 14:34:42 +00:00
if (rules()->checkSize(QSize()).isValid()) // forced size
return false;
const Position mode = moveResizePointerMode();
if ((mode == PositionTop || mode == PositionTopLeft || mode == PositionTopRight ||
mode == PositionLeft || mode == PositionBottomLeft) && rules()->checkPosition(invalidPoint) != invalidPoint)
return false;
QSize min = minSize();
QSize max = maxSize();
return min.width() < max.width() || min.height() < max.height();
2011-01-30 14:34:42 +00:00
}
bool X11Client::isMaximizable() const
2011-01-30 14:34:42 +00:00
{
if (!isResizable() || isToolbar()) // SELI isToolbar() ?
return false;
if (rules()->checkMaximize(MaximizeRestore) == MaximizeRestore && rules()->checkMaximize(MaximizeFull) != MaximizeRestore)
return true;
return false;
2011-01-30 14:34:42 +00:00
}
/**
* Reimplemented to inform the client about the new window position.
*/
void X11Client::setFrameGeometry(int x, int y, int w, int h, ForceGeometry_t force)
2011-01-30 14:34:42 +00:00
{
// this code is also duplicated in X11Client::plainResize()
// Ok, the shading geometry stuff. Generally, code doesn't care about shaded geometry,
// simply because there are too many places dealing with geometry. Those places
// ignore shaded state and use normal geometry, which they usually should get
// from adjustedSize(). Such geometry comes here, and if the window is shaded,
// the geometry is used only for client_size, since that one is not used when
// shading. Then the frame geometry is adjusted for the shaded geometry.
// This gets more complicated in the case the code does only something like
// setGeometry( geometry()) - geometry() will return the shaded frame geometry.
// Such code is wrong and should be changed to handle the case when the window is shaded,
// for example using X11Client::clientSize()
2011-01-30 14:34:42 +00:00
if (shade_geometry_change)
; // nothing
2011-01-30 14:34:42 +00:00
else if (isShade()) {
if (h == borderTop() + borderBottom()) {
qCDebug(KWIN_CORE) << "Shaded geometry passed for size:";
2011-01-30 14:34:42 +00:00
} else {
client_size = QSize(w - borderLeft() - borderRight(), h - borderTop() - borderBottom());
h = borderTop() + borderBottom();
}
2011-01-30 14:34:42 +00:00
} else {
client_size = QSize(w - borderLeft() - borderRight(), h - borderTop() - borderBottom());
2011-01-30 14:34:42 +00:00
}
QRect g(x, y, w, h);
if (!areGeometryUpdatesBlocked() && g != rules()->checkGeometry(g)) {
qCDebug(KWIN_CORE) << "forced geometry fail:" << g << ":" << rules()->checkGeometry(g);
2011-01-30 14:34:42 +00:00
}
if (force == NormalGeometrySet && geom == g && pendingGeometryUpdate() == PendingGeometryNone)
return;
geom = g;
if (areGeometryUpdatesBlocked()) {
if (pendingGeometryUpdate() == PendingGeometryForced)
{} // maximum, nothing needed
2011-01-30 14:34:42 +00:00
else if (force == ForceGeometrySet)
setPendingGeometryUpdate(PendingGeometryForced);
else
setPendingGeometryUpdate(PendingGeometryNormal);
return;
2011-01-30 14:34:42 +00:00
}
QSize oldClientSize = m_frame.geometry().size();
bool resized = (geometryBeforeUpdateBlocking().size() != geom.size() || pendingGeometryUpdate() == PendingGeometryForced);
2011-01-30 14:34:42 +00:00
if (resized) {
resizeDecoration();
m_frame.setGeometry(x, y, w, h);
2011-01-30 14:34:42 +00:00
if (!isShade()) {
QSize cs = clientSize();
2013-09-09 08:42:01 +00:00
m_wrapper.setGeometry(QRect(clientPos(), cs));
2013-07-31 08:11:39 +00:00
if (!isResize() || syncRequest.counter == XCB_NONE)
m_client.setGeometry(0, 0, cs.width(), cs.height());
// SELI - won't this be too expensive?
// THOMAS - yes, but gtk+ clients will not resize without ...
sendSyntheticConfigureNotify();
}
2011-01-30 14:34:42 +00:00
updateShape();
} else {
if (isMoveResize()) {
if (compositing()) // Defer the X update until we leave this mode
needsXWindowMove = true;
else
m_frame.move(x, y); // sendSyntheticConfigureNotify() on finish shall be sufficient
} else {
m_frame.move(x, y);
sendSyntheticConfigureNotify();
}
// Unconditionally move the input window: it won't affect rendering
m_decoInputExtent.move(QPoint(x, y) + inputPos());
}
updateWindowRules(Rules::Position|Rules::Size);
2011-01-30 14:34:42 +00:00
// keep track of old maximize mode
// to detect changes
screens()->setCurrent(this);
workspace()->updateStackingOrder();
2011-01-30 14:34:42 +00:00
// need to regenerate decoration pixmaps when
// - size is changed
2011-01-30 14:34:42 +00:00
if (resized) {
if (oldClientSize != QSize(w,h))
discardWindowPixmap();
2011-01-30 14:34:42 +00:00
}
emit geometryShapeChanged(this, geometryBeforeUpdateBlocking());
addRepaintDuringGeometryUpdates();
updateGeometryBeforeUpdateBlocking();
// TODO: this signal is emitted too often
emit geometryChanged();
2011-01-30 14:34:42 +00:00
}
void X11Client::plainResize(int w, int h, ForceGeometry_t force)
2011-01-30 14:34:42 +00:00
{
// this code is also duplicated in X11Client::setGeometry(), and it's also commented there
2011-01-30 14:34:42 +00:00
if (shade_geometry_change)
; // nothing
2011-01-30 14:34:42 +00:00
else if (isShade()) {
if (h == borderTop() + borderBottom()) {
qCDebug(KWIN_CORE) << "Shaded geometry passed for size:";
2011-01-30 14:34:42 +00:00
} else {
client_size = QSize(w - borderLeft() - borderRight(), h - borderTop() - borderBottom());
h = borderTop() + borderBottom();
}
2011-01-30 14:34:42 +00:00
} else {
client_size = QSize(w - borderLeft() - borderRight(), h - borderTop() - borderBottom());
2011-01-30 14:34:42 +00:00
}
QSize s(w, h);
if (!areGeometryUpdatesBlocked() && s != rules()->checkSize(s)) {
qCDebug(KWIN_CORE) << "forced size fail:" << s << ":" << rules()->checkSize(s);
2011-01-30 14:34:42 +00:00
}
// resuming geometry updates is handled only in setGeometry()
Q_ASSERT(pendingGeometryUpdate() == PendingGeometryNone || areGeometryUpdatesBlocked());
2011-01-30 14:34:42 +00:00
if (force == NormalGeometrySet && geom.size() == s)
return;
2011-01-30 14:34:42 +00:00
geom.setSize(s);
if (areGeometryUpdatesBlocked()) {
if (pendingGeometryUpdate() == PendingGeometryForced)
{} // maximum, nothing needed
2011-01-30 14:34:42 +00:00
else if (force == ForceGeometrySet)
setPendingGeometryUpdate(PendingGeometryForced);
else
setPendingGeometryUpdate(PendingGeometryNormal);
return;
2011-01-30 14:34:42 +00:00
}
QSize oldClientSize = m_frame.geometry().size();
resizeDecoration();
m_frame.resize(w, h);
// resizeDecoration( s );
2011-01-30 14:34:42 +00:00
if (!isShade()) {
QSize cs = clientSize();
2013-09-09 08:42:01 +00:00
m_wrapper.setGeometry(QRect(clientPos(), cs));
m_client.setGeometry(0, 0, cs.width(), cs.height());
2011-01-30 14:34:42 +00:00
}
updateShape();
2011-01-30 14:34:42 +00:00
sendSyntheticConfigureNotify();
updateWindowRules(Rules::Position|Rules::Size);
screens()->setCurrent(this);
workspace()->updateStackingOrder();
if (oldClientSize != QSize(w,h))
discardWindowPixmap();
emit geometryShapeChanged(this, geometryBeforeUpdateBlocking());
addRepaintDuringGeometryUpdates();
updateGeometryBeforeUpdateBlocking();
// TODO: this signal is emitted too often
emit geometryChanged();
2011-01-30 14:34:42 +00:00
}
/**
* Reimplemented to inform the client about the new window position.
*/
void AbstractClient::move(int x, int y, ForceGeometry_t force)
2011-01-30 14:34:42 +00:00
{
// resuming geometry updates is handled only in setGeometry()
Q_ASSERT(pendingGeometryUpdate() == PendingGeometryNone || areGeometryUpdatesBlocked());
2011-01-30 14:34:42 +00:00
QPoint p(x, y);
if (!areGeometryUpdatesBlocked() && p != rules()->checkPosition(p)) {
qCDebug(KWIN_CORE) << "forced position fail:" << p << ":" << rules()->checkPosition(p);
2011-01-30 14:34:42 +00:00
}
if (force == NormalGeometrySet && geom.topLeft() == p)
return;
2011-01-30 14:34:42 +00:00
geom.moveTopLeft(p);
if (areGeometryUpdatesBlocked()) {
if (pendingGeometryUpdate() == PendingGeometryForced)
{} // maximum, nothing needed
2011-01-30 14:34:42 +00:00
else if (force == ForceGeometrySet)
setPendingGeometryUpdate(PendingGeometryForced);
else
setPendingGeometryUpdate(PendingGeometryNormal);
return;
2011-01-30 14:34:42 +00:00
}
doMove(x, y);
updateWindowRules(Rules::Position);
screens()->setCurrent(this);
workspace()->updateStackingOrder();
// client itself is not damaged
addRepaintDuringGeometryUpdates();
updateGeometryBeforeUpdateBlocking();
emit geometryChanged();
2011-01-30 14:34:42 +00:00
}
void X11Client::doMove(int x, int y)
{
m_frame.move(x, y);
sendSyntheticConfigureNotify();
}
void AbstractClient::blockGeometryUpdates(bool block)
2011-01-30 14:34:42 +00:00
{
if (block) {
if (m_blockGeometryUpdates == 0)
m_pendingGeometryUpdate = PendingGeometryNone;
++m_blockGeometryUpdates;
2011-01-30 14:34:42 +00:00
} else {
if (--m_blockGeometryUpdates == 0) {
if (m_pendingGeometryUpdate != PendingGeometryNone) {
2011-01-30 14:34:42 +00:00
if (isShade())
setFrameGeometry(QRect(pos(), adjustedSize()), NormalGeometrySet);
else
setFrameGeometry(frameGeometry(), NormalGeometrySet);
m_pendingGeometryUpdate = PendingGeometryNone;
}
}
}
2011-01-30 14:34:42 +00:00
}
void AbstractClient::maximize(MaximizeMode m)
2011-01-30 14:34:42 +00:00
{
setMaximize(m & MaximizeVertical, m & MaximizeHorizontal);
}
void AbstractClient::setMaximize(bool vertically, bool horizontally)
2011-01-30 14:34:42 +00:00
{
// changeMaximize() flips the state, so change from set->flip
const MaximizeMode oldMode = maximizeMode();
changeMaximize(
oldMode & MaximizeHorizontal ? !horizontally : horizontally,
oldMode & MaximizeVertical ? !vertically : vertically,
2011-01-30 14:34:42 +00:00
false);
const MaximizeMode newMode = maximizeMode();
if (oldMode != newMode) {
emit clientMaximizedStateChanged(this, newMode);
emit clientMaximizedStateChanged(this, vertically, horizontally);
}
2011-01-30 14:34:42 +00:00
}
static bool changeMaximizeRecursion = false;
void X11Client::changeMaximize(bool horizontal, bool vertical, bool adjust)
2011-01-30 14:34:42 +00:00
{
if (changeMaximizeRecursion)
return;
if (!isResizable() || isToolbar()) // SELI isToolbar() ?
return;
QRect clientArea;
if (isElectricBorderMaximizing())
clientArea = workspace()->clientArea(MaximizeArea, Cursor::pos(), desktop());
else
clientArea = workspace()->clientArea(MaximizeArea, this);
MaximizeMode old_mode = max_mode;
// 'adjust == true' means to update the size only, e.g. after changing workspace size
2011-01-30 14:34:42 +00:00
if (!adjust) {
if (vertical)
max_mode = MaximizeMode(max_mode ^ MaximizeVertical);
if (horizontal)
max_mode = MaximizeMode(max_mode ^ MaximizeHorizontal);
}
// if the client insist on a fix aspect ratio, we check whether the maximizing will get us
// out of screen bounds and take that as a "full maximization with aspect check" then
if (m_geometryHints.hasAspect() && // fixed aspect
(max_mode == MaximizeVertical || max_mode == MaximizeHorizontal) && // ondimensional maximization
rules()->checkStrictGeometry(true)) { // obey aspect
const QSize minAspect = m_geometryHints.minAspect();
const QSize maxAspect = m_geometryHints.maxAspect();
if (max_mode == MaximizeVertical || (old_mode & MaximizeVertical)) {
const double fx = minAspect.width(); // use doubles, because the values can be MAX_INT
const double fy = maxAspect.height(); // use doubles, because the values can be MAX_INT
if (fx*clientArea.height()/fy > clientArea.width()) // too big
max_mode = old_mode & MaximizeHorizontal ? MaximizeRestore : MaximizeFull;
} else { // max_mode == MaximizeHorizontal
const double fx = maxAspect.width();
const double fy = minAspect.height();
if (fy*clientArea.width()/fx > clientArea.height()) // too big
max_mode = old_mode & MaximizeVertical ? MaximizeRestore : MaximizeFull;
}
}
2011-01-30 14:34:42 +00:00
max_mode = rules()->checkMaximize(max_mode);
if (!adjust && max_mode == old_mode)
return;
2011-01-30 14:34:42 +00:00
GeometryUpdatesBlocker blocker(this);
// maximing one way and unmaximizing the other way shouldn't happen,
// so restore first and then maximize the other way
2011-01-30 14:34:42 +00:00
if ((old_mode == MaximizeVertical && max_mode == MaximizeHorizontal)
|| (old_mode == MaximizeHorizontal && max_mode == MaximizeVertical)) {
changeMaximize(false, false, false); // restore
}
// save sizes for restoring, if maximalizing
QSize sz;
if (isShade())
sz = sizeForClientSize(clientSize());
else
sz = size();
if (quickTileMode() == QuickTileMode(QuickTileFlag::None)) {
if (!adjust && !(old_mode & MaximizeVertical)) {
geom_restore.setTop(y());
geom_restore.setHeight(sz.height());
}
if (!adjust && !(old_mode & MaximizeHorizontal)) {
geom_restore.setLeft(x());
geom_restore.setWidth(sz.width());
}
2011-01-30 14:34:42 +00:00
}
// call into decoration update borders
if (isDecorated() && decoration()->client() && !(options->borderlessMaximizedWindows() && max_mode == KWin::MaximizeFull)) {
changeMaximizeRecursion = true;
const auto c = decoration()->client().data();
if ((max_mode & MaximizeVertical) != (old_mode & MaximizeVertical)) {
emit c->maximizedVerticallyChanged(max_mode & MaximizeVertical);
}
if ((max_mode & MaximizeHorizontal) != (old_mode & MaximizeHorizontal)) {
emit c->maximizedHorizontallyChanged(max_mode & MaximizeHorizontal);
}
if ((max_mode == MaximizeFull) != (old_mode == MaximizeFull)) {
emit c->maximizedChanged(max_mode & MaximizeFull);
}
changeMaximizeRecursion = false;
}
if (options->borderlessMaximizedWindows()) {
// triggers a maximize change.
// The next setNoBorder interation will exit since there's no change but the first recursion pullutes the restore geometry
changeMaximizeRecursion = true;
setNoBorder(rules()->checkNoBorder(app_noborder || (m_motif.hasDecoration() && m_motif.noBorder()) || max_mode == MaximizeFull));
changeMaximizeRecursion = false;
2011-01-30 14:34:42 +00:00
}
const ForceGeometry_t geom_mode = isDecorated() ? ForceGeometrySet : NormalGeometrySet;
// Conditional quick tiling exit points
if (quickTileMode() != QuickTileMode(QuickTileFlag::None)) {
2011-01-30 14:34:42 +00:00
if (old_mode == MaximizeFull &&
!clientArea.contains(geom_restore.center())) {
// Not restoring on the same screen
// TODO: The following doesn't work for some reason
//quick_tile_mode = QuickTileFlag::None; // And exit quick tile mode manually
2011-01-30 14:34:42 +00:00
} else if ((old_mode == MaximizeVertical && max_mode == MaximizeRestore) ||
(old_mode == MaximizeFull && max_mode == MaximizeHorizontal)) {
// Modifying geometry of a tiled window
updateQuickTileMode(QuickTileFlag::None); // Exit quick tile mode without restoring geometry
}
2011-01-30 14:34:42 +00:00
}
2011-01-30 14:34:42 +00:00
switch(max_mode) {
case MaximizeVertical: {
if (old_mode & MaximizeHorizontal) { // actually restoring from MaximizeFull
if (geom_restore.width() == 0 || !clientArea.contains(geom_restore.center())) {
// needs placement
plainResize(adjustedSize(QSize(width() * 2 / 3, clientArea.height()), SizemodeFixedH), geom_mode);
Placement::self()->placeSmart(this, clientArea);
2011-01-30 14:34:42 +00:00
} else {
setFrameGeometry(QRect(QPoint(geom_restore.x(), clientArea.top()),
adjustedSize(QSize(geom_restore.width(), clientArea.height()), SizemodeFixedH)), geom_mode);
2011-01-30 14:34:42 +00:00
}
} else {
QRect r(x(), clientArea.top(), width(), clientArea.height());
r.setTopLeft(rules()->checkPosition(r.topLeft()));
r.setSize(adjustedSize(r.size(), SizemodeFixedH));
setFrameGeometry(r, geom_mode);
2011-01-30 14:34:42 +00:00
}
info->setState(NET::MaxVert, NET::Max);
break;
}
case MaximizeHorizontal: {
if (old_mode & MaximizeVertical) { // actually restoring from MaximizeFull
if (geom_restore.height() == 0 || !clientArea.contains(geom_restore.center())) {
// needs placement
plainResize(adjustedSize(QSize(clientArea.width(), height() * 2 / 3), SizemodeFixedW), geom_mode);
Placement::self()->placeSmart(this, clientArea);
2011-01-30 14:34:42 +00:00
} else {
setFrameGeometry(QRect(QPoint(clientArea.left(), geom_restore.y()),
adjustedSize(QSize(clientArea.width(), geom_restore.height()), SizemodeFixedW)), geom_mode);
2011-01-30 14:34:42 +00:00
}
} else {
QRect r(clientArea.left(), y(), clientArea.width(), height());
r.setTopLeft(rules()->checkPosition(r.topLeft()));
r.setSize(adjustedSize(r.size(), SizemodeFixedW));
setFrameGeometry(r, geom_mode);
2011-01-30 14:34:42 +00:00
}
info->setState(NET::MaxHoriz, NET::Max);
break;
}
case MaximizeRestore: {
QRect restore = frameGeometry();
2011-01-30 14:34:42 +00:00
// when only partially maximized, geom_restore may not have the other dimension remembered
if (old_mode & MaximizeVertical) {
restore.setTop(geom_restore.top());
restore.setBottom(geom_restore.bottom());
}
if (old_mode & MaximizeHorizontal) {
restore.setLeft(geom_restore.left());
restore.setRight(geom_restore.right());
}
if (!restore.isValid()) {
QSize s = QSize(clientArea.width() * 2 / 3, clientArea.height() * 2 / 3);
if (geom_restore.width() > 0)
s.setWidth(geom_restore.width());
if (geom_restore.height() > 0)
s.setHeight(geom_restore.height());
plainResize(adjustedSize(s));
Placement::self()->placeSmart(this, clientArea);
restore = frameGeometry();
2011-01-30 14:34:42 +00:00
if (geom_restore.width() > 0)
restore.moveLeft(geom_restore.x());
if (geom_restore.height() > 0)
restore.moveTop(geom_restore.y());
geom_restore = restore; // relevant for mouse pos calculation, bug #298646
2011-01-30 14:34:42 +00:00
}
if (m_geometryHints.hasAspect()) {
restore.setSize(adjustedSize(restore.size(), SizemodeAny));
}
setFrameGeometry(restore, geom_mode);
2011-01-30 14:34:42 +00:00
if (!clientArea.contains(geom_restore.center())) // Not restoring to the same screen
Placement::self()->place(this, clientArea);
info->setState(NET::States(), NET::Max);
updateQuickTileMode(QuickTileFlag::None);
2011-01-30 14:34:42 +00:00
break;
}
case MaximizeFull: {
QRect r(clientArea);
r.setTopLeft(rules()->checkPosition(r.topLeft()));
r.setSize(adjustedSize(r.size(), SizemodeMax));
if (r.size() != clientArea.size()) { // to avoid off-by-one errors...
if (isElectricBorderMaximizing() && r.width() < clientArea.width()) {
r.moveLeft(qMax(clientArea.left(), Cursor::pos().x() - r.width()/2));
r.moveRight(qMin(clientArea.right(), r.right()));
} else {
r.moveCenter(clientArea.center());
const bool closeHeight = r.height() > 97*clientArea.height()/100;
const bool closeWidth = r.width() > 97*clientArea.width() /100;
const bool overHeight = r.height() > clientArea.height();
const bool overWidth = r.width() > clientArea.width();
if (closeWidth || closeHeight) {
Position titlePos = titlebarPosition();
const QRect screenArea = workspace()->clientArea(ScreenArea, clientArea.center(), desktop());
if (closeHeight) {
bool tryBottom = titlePos == PositionBottom;
if ((overHeight && titlePos == PositionTop) ||
screenArea.top() == clientArea.top())
r.setTop(clientArea.top());
else
tryBottom = true;
if (tryBottom &&
(overHeight || screenArea.bottom() == clientArea.bottom()))
r.setBottom(clientArea.bottom());
}
if (closeWidth) {
bool tryLeft = titlePos == PositionLeft;
if ((overWidth && titlePos == PositionRight) ||
screenArea.right() == clientArea.right())
r.setRight(clientArea.right());
else
tryLeft = true;
if (tryLeft && (overWidth || screenArea.left() == clientArea.left()))
r.setLeft(clientArea.left());
}
}
}
r.moveTopLeft(rules()->checkPosition(r.topLeft()));
}
setFrameGeometry(r, geom_mode);
if (options->electricBorderMaximize() && r.top() == clientArea.top())
updateQuickTileMode(QuickTileFlag::Maximize);
else
updateQuickTileMode(QuickTileFlag::None);
2011-01-30 14:34:42 +00:00
info->setState(NET::Max, NET::Max);
break;
}
default:
break;
}
2011-01-30 14:34:42 +00:00
updateAllowedActions();
updateWindowRules(Rules::MaximizeVert|Rules::MaximizeHoriz|Rules::Position|Rules::Size);
emit quickTileModeChanged();
2011-01-30 14:34:42 +00:00
}
bool X11Client::userCanSetFullScreen() const
2011-01-30 14:34:42 +00:00
{
if (!isFullScreenable()) {
return false;
}
return isNormalWindow() || isDialog();
2011-01-30 14:34:42 +00:00
}
void X11Client::setFullScreen(bool set, bool user)
2011-01-30 14:34:42 +00:00
{
set = rules()->checkFullScreen(set);
const bool wasFullscreen = isFullScreen();
if (wasFullscreen == set) {
return;
}
if (user && !userCanSetFullScreen()) {
return;
}
2011-01-30 14:34:42 +00:00
setShade(ShadeNone);
if (wasFullscreen) {
workspace()->updateFocusMousePosition(Cursor::pos()); // may cause leave event
} else {
geom_fs_restore = frameGeometry();
}
if (set) {
m_fullscreenMode = FullScreenNormal;
2011-01-30 14:34:42 +00:00
workspace()->raiseClient(this);
} else {
m_fullscreenMode = FullScreenNone;
}
2011-01-30 14:34:42 +00:00
StackingUpdatesBlocker blocker1(workspace());
GeometryUpdatesBlocker blocker2(this);
// active fullscreens get different layer
workspace()->updateClientLayer(this);
info->setState(isFullScreen() ? NET::FullScreen : NET::States(), NET::FullScreen);
2011-01-30 14:34:42 +00:00
updateDecoration(false, false);
if (set) {
if (info->fullscreenMonitors().isSet()) {
setFrameGeometry(fullscreenMonitorsArea(info->fullscreenMonitors()));
} else {
setFrameGeometry(workspace()->clientArea(FullScreenArea, this));
}
} else {
Q_ASSERT(!geom_fs_restore.isNull());
const int currentScreen = screen();
setFrameGeometry(QRect(geom_fs_restore.topLeft(), adjustedSize(geom_fs_restore.size())));
if(currentScreen != screen()) {
workspace()->sendClientToScreen(this, currentScreen);
}
2011-01-30 14:34:42 +00:00
}
updateWindowRules(Rules::Fullscreen | Rules::Position | Rules::Size);
emit clientFullScreenSet(this, set, user);
emit fullScreenChanged();
2011-01-30 14:34:42 +00:00
}
void X11Client::updateFullscreenMonitors(NETFullscreenMonitors topology)
2011-01-30 14:34:42 +00:00
{
int nscreens = screens()->count();
2013-11-01 11:29:05 +00:00
// qDebug() << "incoming request with top: " << topology.top << " bottom: " << topology.bottom
// << " left: " << topology.left << " right: " << topology.right
// << ", we have: " << nscreens << " screens.";
2011-01-30 14:34:42 +00:00
if (topology.top >= nscreens ||
topology.bottom >= nscreens ||
topology.left >= nscreens ||
topology.right >= nscreens) {
qCWarning(KWIN_CORE) << "fullscreenMonitors update failed. request higher than number of screens.";
2011-01-30 14:34:42 +00:00
return;
}
2011-01-30 14:34:42 +00:00
info->setFullscreenMonitors(topology);
if (isFullScreen())
setFrameGeometry(fullscreenMonitorsArea(topology));
2011-01-30 14:34:42 +00:00
}
/**
* Calculates the bounding rectangle defined by the 4 monitor indices indicating the
* top, bottom, left, and right edges of the window when the fullscreen state is enabled.
*/
QRect X11Client::fullscreenMonitorsArea(NETFullscreenMonitors requestedTopology) const
2011-01-30 14:34:42 +00:00
{
QRect top, bottom, left, right, total;
top = screens()->geometry(requestedTopology.top);
bottom = screens()->geometry(requestedTopology.bottom);
left = screens()->geometry(requestedTopology.left);
right = screens()->geometry(requestedTopology.right);
2011-01-30 14:34:42 +00:00
total = top.united(bottom.united(left.united(right)));
2013-11-01 11:29:05 +00:00
// qDebug() << "top: " << top << " bottom: " << bottom
// << " left: " << left << " right: " << right;
2013-11-01 11:29:05 +00:00
// qDebug() << "returning rect: " << total;
return total;
2011-01-30 14:34:42 +00:00
}
static GeometryTip* geometryTip = nullptr;
void X11Client::positionGeometryTip()
2011-01-30 14:34:42 +00:00
{
Q_ASSERT(isMove() || isResize());
// Position and Size display
2011-01-30 14:34:42 +00:00
if (effects && static_cast<EffectsHandlerImpl*>(effects)->provides(Effect::GeometryTip))
return; // some effect paints this for us
2011-01-30 14:34:42 +00:00
if (options->showGeometryTip()) {
if (!geometryTip) {
geometryTip = new GeometryTip(&m_geometryHints);
2011-01-30 14:34:42 +00:00
}
QRect wgeom(moveResizeGeometry()); // position of the frame, size of the window itself
2011-01-30 14:34:42 +00:00
wgeom.setWidth(wgeom.width() - (width() - clientSize().width()));
wgeom.setHeight(wgeom.height() - (height() - clientSize().height()));
if (isShade())
wgeom.setHeight(0);
geometryTip->setGeometry(wgeom);
if (!geometryTip->isVisible())
geometryTip->show();
geometryTip->raise();
}
2011-01-30 14:34:42 +00:00
}
bool AbstractClient::startMoveResize()
2011-01-30 14:34:42 +00:00
{
Q_ASSERT(!isMoveResize());
Q_ASSERT(QWidget::keyboardGrabber() == nullptr);
Q_ASSERT(QWidget::mouseGrabber() == nullptr);
stopDelayedMoveResize();
if (QApplication::activePopupWidget() != nullptr)
return false; // popups have grab
if (isFullScreen() && (screens()->count() < 2 || !isMovableAcrossScreens()))
return false;
if (!doStartMoveResize()) {
return false;
2011-01-30 14:34:42 +00:00
}
2011-03-07 21:31:44 +00:00
invalidateDecorationDoubleClickTimer();
setMoveResize(true);
workspace()->setMoveResizeClient(this);
const Position mode = moveResizePointerMode();
if (mode != PositionCenter) { // means "isResize()" but moveResizeMode = true is set below
if (maximizeMode() == MaximizeFull) { // partial is cond. reset in finishMoveResize
setGeometryRestore(frameGeometry()); // "restore" to current geometry
setMaximize(false, false);
}
2011-01-30 14:34:42 +00:00
}
2011-03-07 21:31:44 +00:00
if (quickTileMode() != QuickTileMode(QuickTileFlag::None) && mode != PositionCenter) { // Cannot use isResize() yet
2011-01-30 14:34:42 +00:00
// Exit quick tile mode when the user attempts to resize a tiled window
updateQuickTileMode(QuickTileFlag::None); // Do so without restoring original geometry
setGeometryRestore(frameGeometry());
emit quickTileModeChanged();
2011-01-30 14:34:42 +00:00
}
updateHaveResizeEffect();
updateInitialMoveResizeGeometry();
checkUnrestrictedMoveResize();
emit clientStartUserMovedResized(this);
if (ScreenEdges::self()->isDesktopSwitchingMovingClients())
ScreenEdges::self()->reserveDesktopSwitching(true, Qt::Vertical|Qt::Horizontal);
2011-01-30 14:34:42 +00:00
return true;
}
bool X11Client::doStartMoveResize()
{
bool has_grab = false;
// This reportedly improves smoothness of the moveresize operation,
// something with Enter/LeaveNotify events, looks like XFree performance problem or something *shrug*
// (https://lists.kde.org/?t=107302193400001&r=1&w=2)
QRect r = workspace()->clientArea(FullArea, this);
m_moveResizeGrabWindow.create(r, XCB_WINDOW_CLASS_INPUT_ONLY, 0, nullptr, rootWindow());
m_moveResizeGrabWindow.map();
m_moveResizeGrabWindow.raise();
updateXTime();
const xcb_grab_pointer_cookie_t cookie = xcb_grab_pointer_unchecked(connection(), false, m_moveResizeGrabWindow,
XCB_EVENT_MASK_BUTTON_PRESS | XCB_EVENT_MASK_BUTTON_RELEASE | XCB_EVENT_MASK_POINTER_MOTION |
XCB_EVENT_MASK_ENTER_WINDOW | XCB_EVENT_MASK_LEAVE_WINDOW,
XCB_GRAB_MODE_ASYNC, XCB_GRAB_MODE_ASYNC, m_moveResizeGrabWindow, Cursor::x11Cursor(cursor()), xTime());
ScopedCPointer<xcb_grab_pointer_reply_t> pointerGrab(xcb_grab_pointer_reply(connection(), cookie, nullptr));
if (!pointerGrab.isNull() && pointerGrab->status == XCB_GRAB_STATUS_SUCCESS) {
has_grab = true;
}
if (!has_grab && grabXKeyboard(frameId()))
has_grab = move_resize_has_keyboard_grab = true;
if (!has_grab) { // at least one grab is necessary in order to be able to finish move/resize
m_moveResizeGrabWindow.reset();
return false;
}
return true;
}
void AbstractClient::finishMoveResize(bool cancel)
2011-01-30 14:34:42 +00:00
{
GeometryUpdatesBlocker blocker(this);
const bool wasResize = isResize(); // store across leaveMoveResize
leaveMoveResize();
if (cancel)
setFrameGeometry(initialMoveResizeGeometry());
else {
const QRect &moveResizeGeom = moveResizeGeometry();
if (wasResize) {
const bool restoreH = maximizeMode() == MaximizeHorizontal &&
moveResizeGeom.width() != initialMoveResizeGeometry().width();
const bool restoreV = maximizeMode() == MaximizeVertical &&
moveResizeGeom.height() != initialMoveResizeGeometry().height();
if (restoreH || restoreV) {
changeMaximize(restoreV, restoreH, false);
}
}
setFrameGeometry(moveResizeGeom);
2011-01-30 14:34:42 +00:00
}
checkScreen(); // needs to be done because clientFinishUserMovedResized has not yet re-activated online alignment
if (screen() != moveResizeStartScreen()) {
workspace()->sendClientToScreen(this, screen()); // checks rule validity
2012-08-24 16:48:50 +00:00
if (maximizeMode() != MaximizeRestore)
checkWorkspacePosition();
}
2011-01-30 14:34:42 +00:00
if (isElectricBorderMaximizing()) {
setQuickTileMode(electricBorderMode());
setElectricBorderMaximizing(false);
} else if (!cancel) {
QRect geom_restore = geometryRestore();
if (!(maximizeMode() & MaximizeHorizontal)) {
geom_restore.setX(frameGeometry().x());
geom_restore.setWidth(frameGeometry().width());
}
if (!(maximizeMode() & MaximizeVertical)) {
geom_restore.setY(frameGeometry().y());
geom_restore.setHeight(frameGeometry().height());
}
setGeometryRestore(geom_restore);
2011-01-30 14:34:42 +00:00
}
// FRAME update();
emit clientFinishUserMovedResized(this);
2011-01-30 14:34:42 +00:00
}
void X11Client::leaveMoveResize()
2011-01-30 14:34:42 +00:00
{
if (needsXWindowMove) {
// Do the deferred move
m_frame.move(geom.topLeft());
needsXWindowMove = false;
}
if (!isResize())
sendSyntheticConfigureNotify(); // tell the client about it's new final position
2011-01-30 14:34:42 +00:00
if (geometryTip) {
geometryTip->hide();
delete geometryTip;
geometryTip = nullptr;
2011-01-30 14:34:42 +00:00
}
if (move_resize_has_keyboard_grab)
ungrabXKeyboard();
move_resize_has_keyboard_grab = false;
2013-09-10 09:34:34 +00:00
xcb_ungrab_pointer(connection(), xTime());
m_moveResizeGrabWindow.reset();
2013-07-31 08:11:39 +00:00
if (syncRequest.counter == XCB_NONE) // don't forget to sanitize since the timeout will no more fire
syncRequest.isPending = false;
delete syncRequest.timeout;
syncRequest.timeout = nullptr;
AbstractClient::leaveMoveResize();
2011-01-30 14:34:42 +00:00
}
// This function checks if it actually makes sense to perform a restricted move/resize.
// If e.g. the titlebar is already outside of the workarea, there's no point in performing
// a restricted move resize, because then e.g. resize would also move the window (#74555).
// NOTE: Most of it is duplicated from handleMoveResize().
void AbstractClient::checkUnrestrictedMoveResize()
2011-01-30 14:34:42 +00:00
{
if (isUnrestrictedMoveResize())
return;
const QRect &moveResizeGeom = moveResizeGeometry();
2011-01-30 14:34:42 +00:00
QRect desktopArea = workspace()->clientArea(WorkArea, moveResizeGeom.center(), desktop());
int left_marge, right_marge, top_marge, bottom_marge, titlebar_marge;
// restricted move/resize - keep at least part of the titlebar always visible
// how much must remain visible when moved away in that direction
left_marge = qMin(100 + borderRight(), moveResizeGeom.width());
right_marge = qMin(100 + borderLeft(), moveResizeGeom.width());
// width/height change with opaque resizing, use the initial ones
titlebar_marge = initialMoveResizeGeometry().height();
top_marge = borderBottom();
bottom_marge = borderTop();
2011-01-30 14:34:42 +00:00
if (isResize()) {
if (moveResizeGeom.bottom() < desktopArea.top() + top_marge)
setUnrestrictedMoveResize(true);
2011-01-30 14:34:42 +00:00
if (moveResizeGeom.top() > desktopArea.bottom() - bottom_marge)
setUnrestrictedMoveResize(true);
2011-01-30 14:34:42 +00:00
if (moveResizeGeom.right() < desktopArea.left() + left_marge)
setUnrestrictedMoveResize(true);
2011-01-30 14:34:42 +00:00
if (moveResizeGeom.left() > desktopArea.right() - right_marge)
setUnrestrictedMoveResize(true);
if (!isUnrestrictedMoveResize() && moveResizeGeom.top() < desktopArea.top()) // titlebar mustn't go out
setUnrestrictedMoveResize(true);
2011-01-30 14:34:42 +00:00
}
if (isMove()) {
if (moveResizeGeom.bottom() < desktopArea.top() + titlebar_marge - 1)
setUnrestrictedMoveResize(true);
// no need to check top_marge, titlebar_marge already handles it
if (moveResizeGeom.top() > desktopArea.bottom() - bottom_marge + 1) // titlebar mustn't go out
setUnrestrictedMoveResize(true);
2011-01-30 14:34:42 +00:00
if (moveResizeGeom.right() < desktopArea.left() + left_marge)
setUnrestrictedMoveResize(true);
2011-01-30 14:34:42 +00:00
if (moveResizeGeom.left() > desktopArea.right() - right_marge)
setUnrestrictedMoveResize(true);
}
2011-01-30 14:34:42 +00:00
}
// When the user pressed mouse on the titlebar, don't activate move immediatelly,
// since it may be just a click. Activate instead after a delay. Move used to be
// activated only after moving by several pixels, but that looks bad.
void AbstractClient::startDelayedMoveResize()
2011-01-30 14:34:42 +00:00
{
Q_ASSERT(!m_moveResize.delayedTimer);
m_moveResize.delayedTimer = new QTimer(this);
m_moveResize.delayedTimer->setSingleShot(true);
connect(m_moveResize.delayedTimer, &QTimer::timeout, this,
[this]() {
Q_ASSERT(isMoveResizePointerButtonDown());
if (!startMoveResize()) {
setMoveResizePointerButtonDown(false);
}
updateCursor();
stopDelayedMoveResize();
}
);
m_moveResize.delayedTimer->start(QApplication::startDragTime());
2011-01-30 14:34:42 +00:00
}
void AbstractClient::stopDelayedMoveResize()
2011-01-30 14:34:42 +00:00
{
delete m_moveResize.delayedTimer;
m_moveResize.delayedTimer = nullptr;
2011-01-30 14:34:42 +00:00
}
void AbstractClient::handleMoveResize(const QPoint &local, const QPoint &global)
{
const QRect oldGeo = frameGeometry();
handleMoveResize(local.x(), local.y(), global.x(), global.y());
if (!isFullScreen() && isMove()) {
if (quickTileMode() != QuickTileMode(QuickTileFlag::None) && oldGeo != frameGeometry()) {
GeometryUpdatesBlocker blocker(this);
setQuickTileMode(QuickTileFlag::None);
const QRect &geom_restore = geometryRestore();
setMoveOffset(QPoint(double(moveOffset().x()) / double(oldGeo.width()) * double(geom_restore.width()),
double(moveOffset().y()) / double(oldGeo.height()) * double(geom_restore.height())));
if (rules()->checkMaximize(MaximizeRestore) == MaximizeRestore)
setMoveResizeGeometry(geom_restore);
handleMoveResize(local.x(), local.y(), global.x(), global.y()); // fix position
} else if (quickTileMode() == QuickTileMode(QuickTileFlag::None) && isResizable()) {
checkQuickTilingMaximizationZones(global.x(), global.y());
}
}
}
bool X11Client::isWaitingForMoveResizeSync() const
2011-01-30 14:34:42 +00:00
{
return syncRequest.isPending && isResize();
}
void AbstractClient::handleMoveResize(int x, int y, int x_root, int y_root)
{
if (isWaitingForMoveResizeSync())
return; // we're still waiting for the client or the timeout
const Position mode = moveResizePointerMode();
2011-01-30 14:34:42 +00:00
if ((mode == PositionCenter && !isMovableAcrossScreens())
|| (mode != PositionCenter && (isShade() || !isResizable())))
return;
if (!isMoveResize()) {
QPoint p(QPoint(x/* - padding_left*/, y/* - padding_top*/) - moveOffset());
if (p.manhattanLength() >= QApplication::startDragDistance()) {
2011-01-30 14:34:42 +00:00
if (!startMoveResize()) {
setMoveResizePointerButtonDown(false);
updateCursor();
return;
}
2011-01-30 14:34:42 +00:00
updateCursor();
} else
return;
2011-01-30 14:34:42 +00:00
}
// ShadeHover or ShadeActive, ShadeNormal was already avoided above
if (mode != PositionCenter && shadeMode() != ShadeNone)
2011-01-30 14:34:42 +00:00
setShade(ShadeNone);
2011-01-30 14:34:42 +00:00
QPoint globalPos(x_root, y_root);
// these two points limit the geometry rectangle, i.e. if bottomleft resizing is done,
// the bottomleft corner should be at is at (topleft.x(), bottomright().y())
QPoint topleft = globalPos - moveOffset();
QPoint bottomright = globalPos + invertedMoveOffset();
QRect previousMoveResizeGeom = moveResizeGeometry();
// TODO move whole group when moving its leader or when the leader is not mapped?
auto titleBarRect = [this](bool &transposed, int &requiredPixels) -> QRect {
const QRect &moveResizeGeom = moveResizeGeometry();
QRect r(moveResizeGeom);
r.moveTopLeft(QPoint(0,0));
switch (titlebarPosition()) {
default:
2011-01-30 14:34:42 +00:00
case PositionTop:
r.setHeight(borderTop());
2011-01-30 14:34:42 +00:00
break;
case PositionLeft:
r.setWidth(borderLeft());
transposed = true;
2011-01-30 14:34:42 +00:00
break;
case PositionBottom:
r.setTop(r.bottom() - borderBottom());
2011-01-30 14:34:42 +00:00
break;
case PositionRight:
r.setLeft(r.right() - borderRight());
transposed = true;
2011-01-30 14:34:42 +00:00
break;
}
// When doing a restricted move we must always keep 100px of the titlebar
// visible to allow the user to be able to move it again.
requiredPixels = qMin(100 * (transposed ? r.width() : r.height()),
moveResizeGeom.width() * moveResizeGeom.height());
return r;
};
bool update = false;
if (isResize()) {
QRect orig = initialMoveResizeGeometry();
Sizemode sizemode = SizemodeAny;
auto calculateMoveResizeGeom = [this, &topleft, &bottomright, &orig, &sizemode, &mode]() {
switch(mode) {
case PositionTopLeft:
setMoveResizeGeometry(QRect(topleft, orig.bottomRight()));
break;
case PositionBottomRight:
setMoveResizeGeometry(QRect(orig.topLeft(), bottomright));
break;
case PositionBottomLeft:
setMoveResizeGeometry(QRect(QPoint(topleft.x(), orig.y()), QPoint(orig.right(), bottomright.y())));
break;
case PositionTopRight:
setMoveResizeGeometry(QRect(QPoint(orig.x(), topleft.y()), QPoint(bottomright.x(), orig.bottom())));
break;
case PositionTop:
setMoveResizeGeometry(QRect(QPoint(orig.left(), topleft.y()), orig.bottomRight()));
sizemode = SizemodeFixedH; // try not to affect height
break;
case PositionBottom:
setMoveResizeGeometry(QRect(orig.topLeft(), QPoint(orig.right(), bottomright.y())));
sizemode = SizemodeFixedH;
break;
case PositionLeft:
setMoveResizeGeometry(QRect(QPoint(topleft.x(), orig.top()), orig.bottomRight()));
sizemode = SizemodeFixedW;
break;
case PositionRight:
setMoveResizeGeometry(QRect(orig.topLeft(), QPoint(bottomright.x(), orig.bottom())));
sizemode = SizemodeFixedW;
break;
case PositionCenter:
default:
abort();
break;
}
};
// first resize (without checking constrains), then snap, then check bounds, then check constrains
calculateMoveResizeGeom();
// adjust new size to snap to other windows/borders
setMoveResizeGeometry(workspace()->adjustClientSize(this, moveResizeGeometry(), mode));
if (!isUnrestrictedMoveResize()) {
// Make sure the titlebar isn't behind a restricted area. We don't need to restrict
// the other directions. If not visible enough, move the window to the closest valid
// point. We bruteforce this by slowly moving the window back to its previous position
QRegion availableArea(workspace()->clientArea(FullArea, -1, 0)); // On the screen
availableArea -= workspace()->restrictedMoveArea(desktop()); // Strut areas
bool transposed = false;
int requiredPixels;
QRect bTitleRect = titleBarRect(transposed, requiredPixels);
int lastVisiblePixels = -1;
QRect lastTry = moveResizeGeometry();
bool titleFailed = false;
2011-01-30 14:34:42 +00:00
for (;;) {
const QRect titleRect(bTitleRect.translated(moveResizeGeometry().topLeft()));
int visiblePixels = 0;
int realVisiblePixels = 0;
for (const QRect &rect : availableArea) {
const QRect r = rect & titleRect;
realVisiblePixels += r.width() * r.height();
if ((transposed && r.width() == titleRect.width()) || // Only the full size regions...
(!transposed && r.height() == titleRect.height())) // ...prevents long slim areas
visiblePixels += r.width() * r.height();
}
if (visiblePixels >= requiredPixels)
break; // We have reached a valid position
if (realVisiblePixels <= lastVisiblePixels) {
if (titleFailed && realVisiblePixels < lastVisiblePixels)
break; // we won't become better
else {
if (!titleFailed)
setMoveResizeGeometry(lastTry);
titleFailed = true;
}
}
lastVisiblePixels = realVisiblePixels;
QRect moveResizeGeom = moveResizeGeometry();
lastTry = moveResizeGeom;
// Not visible enough, move the window to the closest valid point. We bruteforce
// this by slowly moving the window back to its previous position.
// The geometry changes at up to two edges, the one with the title (if) shall take
// precedence. The opposing edge has no impact on visiblePixels and only one of
// the adjacent can alter at a time, ie. it's enough to ignore adjacent edges
// if the title edge altered
bool leftChanged = previousMoveResizeGeom.left() != moveResizeGeom.left();
bool rightChanged = previousMoveResizeGeom.right() != moveResizeGeom.right();
bool topChanged = previousMoveResizeGeom.top() != moveResizeGeom.top();
bool btmChanged = previousMoveResizeGeom.bottom() != moveResizeGeom.bottom();
auto fixChangedState = [titleFailed](bool &major, bool &counter, bool &ad1, bool &ad2) {
counter = false;
if (titleFailed)
major = false;
if (major)
ad1 = ad2 = false;
};
switch (titlebarPosition()) {
default:
case PositionTop:
fixChangedState(topChanged, btmChanged, leftChanged, rightChanged);
break;
case PositionLeft:
fixChangedState(leftChanged, rightChanged, topChanged, btmChanged);
break;
case PositionBottom:
fixChangedState(btmChanged, topChanged, leftChanged, rightChanged);
break;
case PositionRight:
fixChangedState(rightChanged, leftChanged, topChanged, btmChanged);
break;
}
if (topChanged)
moveResizeGeom.setTop(moveResizeGeom.y() + sign(previousMoveResizeGeom.y() - moveResizeGeom.y()));
else if (leftChanged)
moveResizeGeom.setLeft(moveResizeGeom.x() + sign(previousMoveResizeGeom.x() - moveResizeGeom.x()));
else if (btmChanged)
moveResizeGeom.setBottom(moveResizeGeom.bottom() + sign(previousMoveResizeGeom.bottom() - moveResizeGeom.bottom()));
else if (rightChanged)
moveResizeGeom.setRight(moveResizeGeom.right() + sign(previousMoveResizeGeom.right() - moveResizeGeom.right()));
else
break; // no position changed - that's certainly not good
setMoveResizeGeometry(moveResizeGeom);
}
2011-01-30 14:34:42 +00:00
}
// Always obey size hints, even when in "unrestricted" mode
QSize size = adjustedSize(moveResizeGeometry().size(), sizemode);
// the new topleft and bottomright corners (after checking size constrains), if they'll be needed
topleft = QPoint(moveResizeGeometry().right() - size.width() + 1, moveResizeGeometry().bottom() - size.height() + 1);
bottomright = QPoint(moveResizeGeometry().left() + size.width() - 1, moveResizeGeometry().top() + size.height() - 1);
orig = moveResizeGeometry();
// if aspect ratios are specified, both dimensions may change.
// Therefore grow to the right/bottom if needed.
// TODO it should probably obey gravity rather than always using right/bottom ?
if (sizemode == SizemodeFixedH)
orig.setRight(bottomright.x());
else if (sizemode == SizemodeFixedW)
orig.setBottom(bottomright.y());
calculateMoveResizeGeom();
if (moveResizeGeometry().size() != previousMoveResizeGeom.size())
update = true;
2011-01-30 14:34:42 +00:00
} else if (isMove()) {
Q_ASSERT(mode == PositionCenter);
2011-01-30 14:34:42 +00:00
if (!isMovable()) { // isMovableAcrossScreens() must have been true to get here
// Special moving of maximized windows on Xinerama screens
int screen = screens()->number(globalPos);
if (isFullScreen())
setMoveResizeGeometry(workspace()->clientArea(FullScreenArea, screen, 0));
else {
QRect moveResizeGeom = workspace()->clientArea(MaximizeArea, screen, 0);
QSize adjSize = adjustedSize(moveResizeGeom.size(), SizemodeMax);
if (adjSize != moveResizeGeom.size()) {
QRect r(moveResizeGeom);
moveResizeGeom.setSize(adjSize);
moveResizeGeom.moveCenter(r.center());
}
setMoveResizeGeometry(moveResizeGeom);
}
2011-01-30 14:34:42 +00:00
} else {
// first move, then snap, then check bounds
QRect moveResizeGeom = moveResizeGeometry();
2011-01-30 14:34:42 +00:00
moveResizeGeom.moveTopLeft(topleft);
moveResizeGeom.moveTopLeft(workspace()->adjustClientPosition(this, moveResizeGeom.topLeft(),
isUnrestrictedMoveResize()));
setMoveResizeGeometry(moveResizeGeom);
if (!isUnrestrictedMoveResize()) {
const QRegion strut = workspace()->restrictedMoveArea(desktop()); // Strut areas
QRegion availableArea(workspace()->clientArea(FullArea, -1, 0)); // On the screen
availableArea -= strut; // Strut areas
bool transposed = false;
int requiredPixels;
QRect bTitleRect = titleBarRect(transposed, requiredPixels);
2011-01-30 14:34:42 +00:00
for (;;) {
QRect moveResizeGeom = moveResizeGeometry();
const QRect titleRect(bTitleRect.translated(moveResizeGeom.topLeft()));
int visiblePixels = 0;
for (const QRect &rect : availableArea) {
const QRect r = rect & titleRect;
if ((transposed && r.width() == titleRect.width()) || // Only the full size regions...
(!transposed && r.height() == titleRect.height())) // ...prevents long slim areas
visiblePixels += r.width() * r.height();
}
if (visiblePixels >= requiredPixels)
break; // We have reached a valid position
// (esp.) if there're more screens with different struts (panels) it the titlebar
// will be movable outside the movearea (covering one of the panels) until it
// crosses the panel "too much" (not enough visiblePixels) and then stucks because
// it's usually only pushed by 1px to either direction
// so we first check whether we intersect suc strut and move the window below it
// immediately (it's still possible to hit the visiblePixels >= titlebarArea break
// by moving the window slightly downwards, but it won't stuck)
// see bug #274466
// and bug #301805 for why we can't just match the titlearea against the screen
if (screens()->count() > 1) { // optimization
// TODO: could be useful on partial screen struts (half-width panels etc.)
int newTitleTop = -1;
for (const QRect &r : strut) {
if (r.top() == 0 && r.width() > r.height() && // "top panel"
r.intersects(moveResizeGeom) && moveResizeGeom.top() < r.bottom()) {
newTitleTop = r.bottom() + 1;
break;
}
}
if (newTitleTop > -1) {
moveResizeGeom.moveTop(newTitleTop); // invalid position, possibly on screen change
setMoveResizeGeometry(moveResizeGeom);
break;
}
}
int dx = sign(previousMoveResizeGeom.x() - moveResizeGeom.x()),
dy = sign(previousMoveResizeGeom.y() - moveResizeGeom.y());
if (visiblePixels && dx) // means there's no full width cap -> favor horizontally
dy = 0;
else if (dy)
dx = 0;
// Move it back
moveResizeGeom.translate(dx, dy);
setMoveResizeGeometry(moveResizeGeom);
if (moveResizeGeom == previousMoveResizeGeom) {
break; // Prevent lockup
}
}
}
}
if (moveResizeGeometry().topLeft() != previousMoveResizeGeom.topLeft())
2011-01-30 14:34:42 +00:00
update = true;
} else
abort();
if (!update)
return;
if (isResize() && !haveResizeEffect()) {
doResizeSync();
} else
performMoveResize();
if (isMove()) {
ScreenEdges::self()->check(globalPos, QDateTime::fromMSecsSinceEpoch(xTime()));
}
2011-01-30 14:34:42 +00:00
}
void X11Client::doResizeSync()
{
if (!syncRequest.timeout) {
syncRequest.timeout = new QTimer(this);
connect(syncRequest.timeout, &QTimer::timeout, this, &X11Client::performMoveResize);
syncRequest.timeout->setSingleShot(true);
}
if (syncRequest.counter != XCB_NONE) {
syncRequest.timeout->start(250);
sendSyncRequest();
} else { // for clients not supporting the XSYNC protocol, we
syncRequest.isPending = true; // limit the resizes to 30Hz to take pointless load from X11
syncRequest.timeout->start(33); // and the client, the mouse is still moved at full speed
} // and no human can control faster resizes anyway
const QRect &moveResizeGeom = moveResizeGeometry();
m_client.setGeometry(0, 0, moveResizeGeom.width() - (borderLeft() + borderRight()), moveResizeGeom.height() - (borderTop() + borderBottom()));
}
void AbstractClient::performMoveResize()
2011-01-30 14:34:42 +00:00
{
const QRect &moveResizeGeom = moveResizeGeometry();
if (isMove() || (isResize() && !haveResizeEffect())) {
setFrameGeometry(moveResizeGeom);
}
doPerformMoveResize();
if (isResize())
addRepaintFull();
positionGeometryTip();
emit clientStepUserMovedResized(this, moveResizeGeom);
2011-01-30 14:34:42 +00:00
}
void X11Client::doPerformMoveResize()
{
if (syncRequest.counter == XCB_NONE) // client w/o XSYNC support. allow the next resize event
syncRequest.isPending = false; // NEVER do this for clients with a valid counter
// (leads to sync request races in some clients)
}
void AbstractClient::setElectricBorderMode(QuickTileMode mode)
2011-01-30 14:34:42 +00:00
{
if (mode != QuickTileMode(QuickTileFlag::Maximize)) {
2011-03-07 21:31:44 +00:00
// sanitize the mode, ie. simplify "invalid" combinations
if ((mode & QuickTileFlag::Horizontal) == QuickTileMode(QuickTileFlag::Horizontal))
mode &= ~QuickTileMode(QuickTileFlag::Horizontal);
if ((mode & QuickTileFlag::Vertical) == QuickTileMode(QuickTileFlag::Vertical))
mode &= ~QuickTileMode(QuickTileFlag::Vertical);
2011-03-07 21:31:44 +00:00
}
m_electricMode = mode;
2011-01-30 14:34:42 +00:00
}
void AbstractClient::setElectricBorderMaximizing(bool maximizing)
2011-01-30 14:34:42 +00:00
{
m_electricMaximizing = maximizing;
2011-01-30 14:34:42 +00:00
if (maximizing)
outline()->show(electricBorderMaximizeGeometry(Cursor::pos(), desktop()), moveResizeGeometry());
else
outline()->hide();
elevate(maximizing);
2011-01-30 14:34:42 +00:00
}
QRect AbstractClient::electricBorderMaximizeGeometry(QPoint pos, int desktop)
2011-01-30 14:34:42 +00:00
{
if (electricBorderMode() == QuickTileMode(QuickTileFlag::Maximize)) {
2011-01-30 14:34:42 +00:00
if (maximizeMode() == MaximizeFull)
2011-03-07 21:31:44 +00:00
return geometryRestore();
2011-01-30 14:34:42 +00:00
else
2011-03-07 21:31:44 +00:00
return workspace()->clientArea(MaximizeArea, pos, desktop);
2011-01-30 14:34:42 +00:00
}
2011-03-07 21:31:44 +00:00
QRect ret = workspace()->clientArea(MaximizeArea, pos, desktop);
if (electricBorderMode() & QuickTileFlag::Left)
ret.setRight(ret.left()+ret.width()/2 - 1);
else if (electricBorderMode() & QuickTileFlag::Right)
ret.setLeft(ret.right()-(ret.width()-ret.width()/2) + 1);
if (electricBorderMode() & QuickTileFlag::Top)
ret.setBottom(ret.top()+ret.height()/2 - 1);
else if (electricBorderMode() & QuickTileFlag::Bottom)
ret.setTop(ret.bottom()-(ret.height()-ret.height()/2) + 1);
2011-03-07 21:31:44 +00:00
2011-01-30 14:34:42 +00:00
return ret;
}
void AbstractClient::setQuickTileMode(QuickTileMode mode, bool keyboard)
2011-01-30 14:34:42 +00:00
{
// Only allow quick tile on a regular window.
if (!isResizable()) {
2011-01-30 14:34:42 +00:00
return;
}
workspace()->updateFocusMousePosition(Cursor::pos()); // may cause leave event
GeometryUpdatesBlocker blocker(this);
if (mode == QuickTileMode(QuickTileFlag::Maximize)) {
m_quickTileMode = int(QuickTileFlag::None);
if (maximizeMode() == MaximizeFull) {
2011-03-07 21:31:44 +00:00
setMaximize(false, false);
} else {
QRect prev_geom_restore = geometryRestore(); // setMaximize() would set moveResizeGeom as geom_restore
m_quickTileMode = int(QuickTileFlag::Maximize);
2011-03-07 21:31:44 +00:00
setMaximize(true, true);
QRect clientArea = workspace()->clientArea(MaximizeArea, this);
if (frameGeometry().top() != clientArea.top()) {
QRect r(frameGeometry());
r.moveTop(clientArea.top());
setFrameGeometry(r);
}
setGeometryRestore(prev_geom_restore);
2011-03-07 21:31:44 +00:00
}
emit quickTileModeChanged();
2011-03-07 21:31:44 +00:00
return;
}
// sanitize the mode, ie. simplify "invalid" combinations
if ((mode & QuickTileFlag::Horizontal) == QuickTileMode(QuickTileFlag::Horizontal))
mode &= ~QuickTileMode(QuickTileFlag::Horizontal);
if ((mode & QuickTileFlag::Vertical) == QuickTileMode(QuickTileFlag::Vertical))
mode &= ~QuickTileMode(QuickTileFlag::Vertical);
2011-03-07 21:31:44 +00:00
setElectricBorderMode(mode); // used by ::electricBorderMaximizeGeometry(.)
// restore from maximized so that it is possible to tile maximized windows with one hit or by dragging
if (maximizeMode() != MaximizeRestore) {
if (mode != QuickTileMode(QuickTileFlag::None)) {
// decorations may turn off some borders when tiled
const ForceGeometry_t geom_mode = isDecorated() ? ForceGeometrySet : NormalGeometrySet;
m_quickTileMode = int(QuickTileFlag::None); // Temporary, so the maximize code doesn't get all confused
setMaximize(false, false);
setFrameGeometry(electricBorderMaximizeGeometry(keyboard ? frameGeometry().center() : Cursor::pos(), desktop()), geom_mode);
// Store the mode change
m_quickTileMode = mode;
} else {
m_quickTileMode = mode;
setMaximize(false, false);
}
emit quickTileModeChanged();
return;
2011-01-30 14:34:42 +00:00
}
if (mode != QuickTileMode(QuickTileFlag::None)) {
QPoint whichScreen = keyboard ? frameGeometry().center() : Cursor::pos();
// If trying to tile to the side that the window is already tiled to move the window to the next
// screen if it exists, otherwise toggle the mode (set QuickTileFlag::None)
if (quickTileMode() == mode) {
const int numScreens = screens()->count();
const int curScreen = screen();
int nextScreen = curScreen;
QVarLengthArray<QRect> screens(numScreens);
2011-01-30 14:34:42 +00:00
for (int i = 0; i < numScreens; ++i) // Cache
screens[i] = Screens::self()->geometry(i);
2011-01-30 14:34:42 +00:00
for (int i = 0; i < numScreens; ++i) {
2011-01-30 14:34:42 +00:00
if (i == curScreen)
continue;
if (screens[i].bottom() <= screens[curScreen].top() || screens[i].top() >= screens[curScreen].bottom())
continue; // not in horizontal line
const int x = screens[i].center().x();
if ((mode & QuickTileFlag::Horizontal) == QuickTileMode(QuickTileFlag::Left)) {
if (x >= screens[curScreen].center().x() || (curScreen != nextScreen && x <= screens[nextScreen].center().x()))
continue; // not left of current or more left then found next
} else if ((mode & QuickTileFlag::Horizontal) == QuickTileMode(QuickTileFlag::Right)) {
if (x <= screens[curScreen].center().x() || (curScreen != nextScreen && x >= screens[nextScreen].center().x()))
continue; // not right of current or more right then found next
}
nextScreen = i;
2011-01-30 14:34:42 +00:00
}
if (nextScreen == curScreen) {
mode = QuickTileFlag::None; // No other screens, toggle tiling
} else {
// Move to other screen
setFrameGeometry(geometryRestore().translated(screens[nextScreen].topLeft() - screens[curScreen].topLeft()));
whichScreen = screens[nextScreen].center();
// Swap sides
if (mode & QuickTileFlag::Horizontal) {
mode = (~mode & QuickTileFlag::Horizontal) | (mode & QuickTileFlag::Vertical);
}
}
setElectricBorderMode(mode); // used by ::electricBorderMaximizeGeometry(.)
} else if (quickTileMode() == QuickTileMode(QuickTileFlag::None)) {
// Not coming out of an existing tile, not shifting monitors, we're setting a brand new tile.
// Store geometry first, so we can go out of this tile later.
setGeometryRestore(frameGeometry());
}
if (mode != QuickTileMode(QuickTileFlag::None)) {
m_quickTileMode = mode;
// decorations may turn off some borders when tiled
const ForceGeometry_t geom_mode = isDecorated() ? ForceGeometrySet : NormalGeometrySet;
// Temporary, so the maximize code doesn't get all confused
m_quickTileMode = int(QuickTileFlag::None);
setFrameGeometry(electricBorderMaximizeGeometry(whichScreen, desktop()), geom_mode);
}
// Store the mode change
m_quickTileMode = mode;
}
if (mode == QuickTileMode(QuickTileFlag::None)) {
m_quickTileMode = int(QuickTileFlag::None);
// Untiling, so just restore geometry, and we're done.
if (!geometryRestore().isValid()) // invalid if we started maximized and wait for placement
setGeometryRestore(frameGeometry());
// decorations may turn off some borders when tiled
const ForceGeometry_t geom_mode = isDecorated() ? ForceGeometrySet : NormalGeometrySet;
setFrameGeometry(geometryRestore(), geom_mode);
checkWorkspacePosition(); // Just in case it's a different screen
}
emit quickTileModeChanged();
2011-01-30 14:34:42 +00:00
}
void AbstractClient::sendToScreen(int newScreen)
{
newScreen = rules()->checkScreen(newScreen);
if (isActive()) {
screens()->setCurrent(newScreen);
// might impact the layer of a fullscreen window
foreach (AbstractClient *cc, workspace()->allClientList()) {
if (cc->isFullScreen() && cc->screen() == newScreen) {
cc->updateLayer();
}
}
}
if (screen() == newScreen) // Don't use isOnScreen(), that's true even when only partially
return;
GeometryUpdatesBlocker blocker(this);
// operating on the maximized / quicktiled window would leave the old geom_restore behind,
// so we clear the state first
MaximizeMode maxMode = maximizeMode();
QuickTileMode qtMode = quickTileMode();
if (maxMode != MaximizeRestore)
maximize(MaximizeRestore);
if (qtMode != QuickTileMode(QuickTileFlag::None))
setQuickTileMode(QuickTileFlag::None, true);
QRect oldScreenArea = workspace()->clientArea(MaximizeArea, this);
QRect screenArea = workspace()->clientArea(MaximizeArea, newScreen, desktop());
// the window can have its center so that the position correction moves the new center onto
// the old screen, what will tile it where it is. Ie. the screen is not changed
// this happens esp. with electric border quicktiling
if (qtMode != QuickTileMode(QuickTileFlag::None))
keepInArea(oldScreenArea);
QRect oldGeom = frameGeometry();
QRect newGeom = oldGeom;
// move the window to have the same relative position to the center of the screen
// (i.e. one near the middle of the right edge will also end up near the middle of the right edge)
QPoint center = newGeom.center() - oldScreenArea.center();
center.setX(center.x() * screenArea.width() / oldScreenArea.width());
center.setY(center.y() * screenArea.height() / oldScreenArea.height());
center += screenArea.center();
newGeom.moveCenter(center);
setFrameGeometry(newGeom);
// If the window was inside the old screen area, explicitly make sure its inside also the new screen area.
// Calling checkWorkspacePosition() should ensure that, but when moving to a small screen the window could
// be big enough to overlap outside of the new screen area, making struts from other screens come into effect,
// which could alter the resulting geometry.
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
if (oldScreenArea.contains(oldGeom)) {
keepInArea(screenArea);
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
}
// align geom_restore - checkWorkspacePosition operates on it
setGeometryRestore(frameGeometry());
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
checkWorkspacePosition(oldGeom);
fix sendToScreen/checkWorkspaceGeometry Prime target is to preserve the in-screen condition of client AND window.i[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 122517 FIXED-IN: 5.4 Prime target is to preserve the in-screen condition of client AND window.[1] Atm. when the client is fully in sight (but the window is not) - regardless of snapping or screen change - a workspace update (screen change, resolution change, adding/removing a strutting panel) would allow the client to partiall escape screen bounds. This is changed so that if the client is fully in sight, it's kept fully in sight (but not the decoration) If the entire window was fully in sight, it's also kept (as is right now) The code handles inner screen edges (if the client was in sight, the entire window will be if we'd bleed to the other screen) [1] I'd say that handling the client is more relevant, but foresee more complaints if the window wasn't handled anymore ;-) During that, i stumbled across some other issues. - when a window centered on one screen is moved to a screen smaller than the window, the window is shrinked to the dimensions of that screen and now randomly touches eg. left AND right edge. When moved back, the right and bottom edge were preferred (to the window was "moved" into the lower right corner). It's now kept centered. - geom_restore was saved before keeping the window in the new screen area (causing accidental drops on screen changes) BUG: 330968 REVIEW: 116029 FIXED-IN: 5.3
2015-02-06 21:48:12 +00:00
// re-align geom_restore to constrained geometry
setGeometryRestore(frameGeometry());
// finally reset special states
// NOTICE that MaximizeRestore/QuickTileFlag::None checks are required.
// eg. setting QuickTileFlag::None would break maximization
if (maxMode != MaximizeRestore)
maximize(maxMode);
if (qtMode != QuickTileMode(QuickTileFlag::None) && qtMode != quickTileMode())
setQuickTileMode(qtMode, true);
auto tso = workspace()->ensureStackingOrder(transients());
for (auto it = tso.constBegin(), end = tso.constEnd(); it != end; ++it)
(*it)->sendToScreen(newScreen);
2011-01-30 14:34:42 +00:00
}
} // namespace