yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Testing whether m_lastCreatedSettings is not null before calling its method

Browse source 
Summary:
It looks like something was forgotten here - there is
a completely empty body for an if statement that checks
whether the pointer is null.
So this might not be the desired way to fix this.
Should m_lastCreatedSettings be instantiated instead?

Reviewers: graesslin

Reviewed By: graesslin

Subscribers: plasma-devel

Projects: #plasma

Differential Revision: https://phabricator.kde.org/D1348
This commit is contained in:
Ivan Čukić 2016-04-08 09:26:43 +02:00
parent f06dff3390
commit 1fef4760bf
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
View file

@ -199,9 +199,9 @@ void PreviewBridge::configure()
auto save = [this,kcm] {
kcm->save();
if (!m_lastCreatedSettings) {
if (m_lastCreatedSettings) {
emit m_lastCreatedSettings->decorationSettings()->reconfigured();
}
emit m_lastCreatedSettings->decorationSettings()->reconfigured();
// Send signal to all kwin instances
QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KWin"),
QStringLiteral("org.kde.KWin"),