[activities] Fix logic error in user menu blocking activity updates

Summary:
There's an attempt to block updates to activities whilst the popup menu
is showing.

In one of the two code paths for positioning the menu the block is set
but instead of releasing the block at the end of the exec locks it
again.

CCBUG: 335725

Test Plan:
On X11 changed activities with the popup menu near the bottom.
It still flickered like crazy whilst the menu is open (see bug report)
But now at least fixes itself after

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16101
This commit is contained in:
David Edmundson 2018-10-10 14:54:16 +01:00
parent 6724955a76
commit 273a3fabd0

View file

@ -178,7 +178,7 @@ void UserActionsMenu::show(const QRect &pos, const QWeakPointer<AbstractClient>
}
}
if (!m_client.isNull())
m_client.data()->blockActivityUpdates(true);
m_client.data()->blockActivityUpdates(false);
}
}