Remove Workspace::updateOnAllActivitiesOfTransients

Method is more or less just a clone of the Virtual Desktop variant and
not needed as toggleClientOnActivity already takes care of transients.

client.cpp

@@ -1578,8 +1578,6 @@ void Client::updateActivities(bool includeTransients)
     }
     emit activitiesChanged(this);
     m_blockedActivityUpdatesRequireTransients = false; // reset
-    if (includeTransients)
-        workspace()->updateOnAllActivitiesOfTransients(this);
     FocusChain::self()->update(this, FocusChain::MakeFirst);
     updateVisibility();
     updateWindowRules(Rules::Activity);
@@ -1644,7 +1642,6 @@ void Client::setOnAllActivities(bool on)
 
     } else {
         setOnActivity(Workspace::self()->currentActivity(), true);
-        workspace()->updateOnAllActivitiesOfTransients(this);
     }
 }
 

group.cpp

@@ -418,19 +418,6 @@ void Workspace::updateOnAllDesktopsOfTransients(Client* c)
     }
 }
 
-/*!
-  Sets the client \a c's transient windows' on_all_activities property to \a on_all_desktops.
- */
-void Workspace::updateOnAllActivitiesOfTransients(Client* c)
-{
-    for (ClientList::ConstIterator it = c->transients().constBegin();
-            it != c->transients().constEnd();
-            ++it) {
-        if ((*it)->isOnAllActivities() != c->isOnAllActivities())
-            (*it)->setOnAllActivities(c->isOnAllActivities());
-    }
-}
-
 // A new window has been mapped. Check if it's not a mainwindow for some already existing transient window.
 void Workspace::checkTransients(Window w)
 {

workspace.h

@@ -307,7 +307,6 @@ public:
 
     void updateMinimizedOfTransients(Client*);
     void updateOnAllDesktopsOfTransients(Client*);
-    void updateOnAllActivitiesOfTransients(Client*);
     void checkTransients(Window w);
 
     void performWindowOperation(Client* c, WindowOperation op);