yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

screencast: Error out if we request a region without outputs

Browse source 
It makes for a bad development experience and I don't see a good use case
for it right now. If it existed, we can always make sure it works.
This commit is contained in:
Aleix Pol 2023-02-08 19:14:49 +01:00
parent 852d10ddd7
commit 4078fcab2b
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/plugins/screencast/screencastmanager.cpp
View file

@ -179,9 +179,10 @@ void ScreencastManager::streamRegion(KWaylandServer::ScreencastStreamV1Interface
stream->setObjectName(rectToString(geometry));
stream->setCursorMode(mode, scale, geometry);
connect(stream, &ScreenCastStream::startStreaming, waylandStream, [geometry, stream, source] {
connect(stream, &ScreenCastStream::startStreaming, waylandStream, [geometry, stream, source, waylandStream] {
Compositor::self()->scene()->addRepaint(geometry);
bool found = false;
const auto allOutputs = workspace()->outputs();
for (auto output : allOutputs) {
if (output->geometry().intersects(geometry)) {
@ -196,8 +197,12 @@ void ScreencastManager::streamRegion(KWaylandServer::ScreencastStreamV1Interface
stream->recordFrame(scaleRegion(region.translated(-streamRegion.topLeft()).intersected(streamRegion), source->scale()));
};
connect(output, &Output::outputChange, stream, bufferToStream);
found |= true;
}
}
if (!found) {
waylandStream->sendFailed(i18n("Region outside the workspace"));
}
});
integrateStreams(waylandStream, stream);
}