yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tabbox: Remove Xcb::sync()

Browse source 
TabBox::hide() used to contain the following code

    QApplication::syncX();
    XEvent otherEvent;
    while (XCheckTypedEvent(display(), EnterNotify, &otherEvent))
        ;

The purpose of XSync() is to flush any pending requests and wait until
the X server processes them. After that, we can go through event queue
to find relevant events.

Why did tabbox go through the event queue to find the EnterNotify
events? It's unclear. So it was removed in
b4c957b617. However, the XSync() call was
left out. It doesn't make sense on its own. So remove it too.
This commit is contained in:
Vlad Zahorodnii 2022-12-31 13:55:29 +02:00
parent d91e288672
commit 58916aac4e
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/tabbox/tabbox.cpp
View file

@ -725,9 +725,6 @@ void TabBox::hide(bool abort)
qCDebug(KWIN_TABBOX) << "Tab box was not properly closed by an effect"; qCDebug(KWIN_TABBOX) << "Tab box was not properly closed by an effect";
} }
m_tabBox->hide(abort); m_tabBox->hide(abort);
if (kwinApp()->x11Connection()) {
Xcb::sync();
}
} }
void TabBox::reconfigure() void TabBox::reconfigure()