yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

paintTransformedScreen() is broken, disable its usage.

Browse source 
svn path=/trunk/KDE/kdebase/workspace/; revision=805050
This commit is contained in:
Luboš Luňák 2008-05-07 12:54:23 +00:00
parent b06a38a3e0
commit 6142ecbfe0
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
COMPOSITE_TODO
View file

@ -155,6 +155,7 @@ XRender TODO
+ SceneXrender::paintTransformedScreen() doesn't handle properly extending of painted area + SceneXrender::paintTransformedScreen() doesn't handle properly extending of painted area
in window's pre-paint - see the transformedShape() comment in window's pre-paint - see the transformedShape() comment
- and currently seems to be generally broken
Effects framework TODO Effects framework TODO

3
scene_xrender.cpp
View file

@ -183,13 +183,14 @@ void SceneXrender::paint( QRegion damage, ToplevelList toplevels )
void SceneXrender::paintGenericScreen( int mask, ScreenPaintData data ) void SceneXrender::paintGenericScreen( int mask, ScreenPaintData data )
{ {
screen_paint = data; // save, transformations will be done when painting windows screen_paint = data; // save, transformations will be done when painting windows
if( false ) // TODO never needed? if( true ) // as long as paintTransformedScreen() doesn't work properly
Scene::paintGenericScreen( mask, data ); Scene::paintGenericScreen( mask, data );
else else
paintTransformedScreen( mask ); paintTransformedScreen( mask );
} }
/* /*
TODO currently broken
Try to do optimized painting even with transformations. Since only scaling Try to do optimized painting even with transformations. Since only scaling
and translation are supported by the painting code, clipping can be done and translation are supported by the painting code, clipping can be done
manually to avoid having to paint everything in every pass. Whole screen manually to avoid having to paint everything in every pass. Whole screen