yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove some no longer relevant todos.

Browse source 
svn path=/trunk/KDE/kdebase/workspace/; revision=689955
This commit is contained in:
Luboš Luňák 2007-07-19 16:38:46 +00:00
parent 6de4afe39b
commit 63a0120a60
4 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
activation.cpp
View file

@ -862,7 +862,6 @@ void Client::setActive( bool act )
StackingUpdatesBlocker blocker( workspace()); StackingUpdatesBlocker blocker( workspace());
workspace()->updateClientLayer( this ); // active windows may get different layer workspace()->updateClientLayer( this ); // active windows may get different layer
// TODO optimize? mainClients() may be a bit expensive
ClientList mainclients = mainClients(); ClientList mainclients = mainClients();
for( ClientList::ConstIterator it = mainclients.begin(); for( ClientList::ConstIterator it = mainclients.begin();
it != mainclients.end(); it != mainclients.end();

2
client.cpp
View file

@ -1097,7 +1097,7 @@ void Client::killProcess( bool ask, Time timestamp )
::kill( pid, SIGTERM ); ::kill( pid, SIGTERM );
} }
else else
{ // SELI TODO handle the window created by handler specially (on top,urgent?) {
process_killer = new K3Process( this ); process_killer = new K3Process( this );
*process_killer << KStandardDirs::findExe( "kwin_killer_helper" ) *process_killer << KStandardDirs::findExe( "kwin_killer_helper" )
<< "--pid" << QByteArray().setNum( pid ) << "--hostname" << machine << "--pid" << QByteArray().setNum( pid ) << "--hostname" << machine

3
events.cpp
View file

@ -595,7 +595,6 @@ bool Client::windowEvent( XEvent* e )
} }
} }
// TODO move all focus handling stuff to separate file?
switch (e->type) switch (e->type)
{ {
case UnmapNotify: case UnmapNotify:
@ -870,7 +869,7 @@ void Client::configureRequestEvent( XConfigureRequestEvent* e )
if ( e->value_mask & CWStackMode ) if ( e->value_mask & CWStackMode )
restackWindow( e->above, e->detail, NET::FromApplication, userTime(), false ); restackWindow( e->above, e->detail, NET::FromApplication, userTime(), false );
// TODO sending a synthetic configure notify always is fine, even in cases where // Sending a synthetic configure notify always is fine, even in cases where
// the ICCCM doesn't require this - it can be though of as 'the WM decided to move // the ICCCM doesn't require this - it can be though of as 'the WM decided to move
// the window later'. The client should not cause that many configure request, // the window later'. The client should not cause that many configure request,
// so this should not have any significant impact. With user moving/resizing // so this should not have any significant impact. With user moving/resizing

6
manage.cpp
View file

@ -247,12 +247,12 @@ bool Client::manage( Window w, bool isMapped )
if( mainClients().count() >= 1 ) if( mainClients().count() >= 1 )
{ {
#if 1 #if 1
// TODO #78082 - Ok, it seems there are after all some cases when an application has a good // #78082 - Ok, it seems there are after all some cases when an application has a good
// reason to specify a position for its dialog. Too bad other WMs have never bothered // reason to specify a position for its dialog. Too bad other WMs have never bothered
// with placement for dialogs, so apps always specify positions for their dialogs, // with placement for dialogs, so apps always specify positions for their dialogs,
// including such silly positions like always centered on the screen or under mouse. // including such silly positions like always centered on the screen or under mouse.
// Using ignoring requested position in window-specific settings helps, but at least // Using ignoring requested position in window-specific settings helps, and now
// for Qt apps this should work better. // there's also _NET_WM_FULL_PLACEMENT.
usePosition = true; usePosition = true;
#else #else
; // force using placement policy ; // force using placement policy