yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop more (unnecessary) geometry updates blockers

Browse source
This commit is contained in:
Vlad Zahorodnii 2024-04-25 11:01:52 +03:00
parent 351f613ef4
commit 69b8c91655
3 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
autotests/integration/internal_window.cpp
View file

@ -500,16 +500,6 @@ void InternalWindowTest::testMove()
internalWindow->move(QPoint(10, 20));
QCOMPARE(internalWindow->frameGeometry(), QRect(10, 20, 100, 100));
QTRY_COMPARE(win.geometry(), QRect(10, 20, 100, 100));
// now move with a Geometry update blocker
{
GeometryUpdatesBlocker blocker(internalWindow);
internalWindow->move(QPoint(5, 10));
// not synced!
QCOMPARE(win.geometry(), QRect(10, 20, 100, 100));
}
// after destroying the blocker it should be synced
QTRY_COMPARE(win.geometry(), QRect(5, 10, 100, 100));
}
void InternalWindowTest::testSkipCloseAnimation_data()

2
src/window.cpp
View file

@ -88,7 +88,6 @@ Window::Window()
// replace on-screen-display on size changes
connect(this, &Window::frameGeometryChanged, this, [this](const QRectF &old) {
if (isOnScreenDisplay() && !frameGeometry().isEmpty() && old.size() != frameGeometry().size() && isPlaceable()) {
GeometryUpdatesBlocker blocker(this);
workspace()->placement()->place(this, workspace()->clientArea(PlacementArea, this, workspace()->activeOutput()));
}
});
@ -887,7 +886,6 @@ void Window::setShade(ShadeMode mode)
}
Q_ASSERT(isDecorated());
GeometryUpdatesBlocker blocker(this);
doSetShade(previousShadeMode);
updateWindowRules(Rules::Shade);

1
src/x11window.cpp
View file

@ -1353,7 +1353,6 @@ void X11Window::createDecoration()
if (isDeleted()) {
return;
}
GeometryUpdatesBlocker blocker(this);
const QRectF oldGeometry = moveResizeGeometry();
if (!isShade()) {
checkWorkspacePosition(oldGeometry);