yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Disable Unredirect Fullscreen Windows by default

Browse source 
Well we don't have another choice if half of the drivers crash kwin
whenever you watch a fullscreen flash video or use a screen saver.
Unredirect Fullscreen Window was quite useful in case you used
to play heavy OpenGL games, but pretty useless for anything else.
For the game and hd video usecase we nowadays have the better way
of really suspending compositing (either by the client indicating or
with a window specific rule). The plus of suspending compositing is
that the driver doesn't crash.

And yes we are "supposed" to no longer workaround driver bugs.
Good joke, I like to redirect my inbox to everyone who things we
are not allowed to workaround driver bugs.

CCBUG: 252817
This commit is contained in:
Martin Gräßlin 2011-05-15 09:40:19 +02:00
parent 3775616a13
commit a81ddf2949
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
kcmkwin/kwincompositing/main.cpp
View file

@ -392,7 +392,7 @@ void KWinCompositingConfig::loadAdvancedTab()
else // shown, or default
ui.windowThumbnails->setCurrentIndex(1);
ui.disableChecks->setChecked(config.readEntry("DisableChecks", false));
ui.unredirectFullscreen->setChecked(config.readEntry("UnredirectFullscreen", true));
ui.unredirectFullscreen->setChecked(config.readEntry("UnredirectFullscreen", false));
ui.xrScaleFilter->setCurrentIndex((int)config.readEntry("XRenderSmoothScale", false));
ui.glScaleFilter->setCurrentIndex(config.readEntry("GLTextureFilter", 2));
@ -723,7 +723,7 @@ void KWinCompositingConfig::defaults()
ui.compositingType->setCurrentIndex(0);
ui.windowThumbnails->setCurrentIndex(1);
ui.disableChecks->setChecked(false);
ui.unredirectFullscreen->setChecked(true);
ui.unredirectFullscreen->setChecked(false);
ui.xrScaleFilter->setCurrentIndex(0);
ui.glScaleFilter->setCurrentIndex(2);
ui.glDirect->setChecked(mDefaultPrefs.enableDirectRendering());

2
options.cpp
View file

@ -349,7 +349,7 @@ void Options::reloadCompositingSettings(bool force)
else if (hps == 6)
hiddenPreviews = HiddenPreviewsAlways;
unredirectFullscreen = config.readEntry("UnredirectFullscreen", true);
unredirectFullscreen = config.readEntry("UnredirectFullscreen", false);
animationSpeed = qBound(0, config.readEntry("AnimationSpeed", 3), 6);
}