yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

effects: Fix selecting hidden windows using keyboard

Browse source 
WindowHeapDelegate used to have hidden property. It was renamed to
activeHidden, but WindowHeap has not been adjusted to the new name.

BUG: 466120
This commit is contained in:
Vlad Zahorodnii 2023-02-22 10:18:39 +02:00
parent 0e906ec182
commit bc0502b3ca
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/effects/private/qml/WindowHeap.qml
View file

@ -161,7 +161,7 @@ FocusScope {
function findFirstItem() { function findFirstItem() {
for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) {
const candidateItem = windowsInstantiator.objectAt(candidateIndex); const candidateItem = windowsInstantiator.objectAt(candidateIndex);
if (!candidateItem.hidden) { if (!candidateItem.activeHidden) {
return candidateIndex; return candidateIndex;
} }
} }
@ -180,7 +180,7 @@ FocusScope {
case WindowHeap.Direction.Left: case WindowHeap.Direction.Left:
for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) {
const candidateItem = windowsInstantiator.objectAt(candidateIndex); const candidateItem = windowsInstantiator.objectAt(candidateIndex);
if (candidateItem.hidden) { if (candidateItem.activeHidden) {
continue; continue;
} }
@ -205,7 +205,7 @@ FocusScope {
case WindowHeap.Direction.Right: case WindowHeap.Direction.Right:
for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) {
const candidateItem = windowsInstantiator.objectAt(candidateIndex); const candidateItem = windowsInstantiator.objectAt(candidateIndex);
if (candidateItem.hidden) { if (candidateItem.activeHidden) {
continue; continue;
} }
@ -230,7 +230,7 @@ FocusScope {
case WindowHeap.Direction.Up: case WindowHeap.Direction.Up:
for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) {
const candidateItem = windowsInstantiator.objectAt(candidateIndex); const candidateItem = windowsInstantiator.objectAt(candidateIndex);
if (candidateItem.hidden) { if (candidateItem.activeHidden) {
continue; continue;
} }
@ -255,7 +255,7 @@ FocusScope {
case WindowHeap.Direction.Down: case WindowHeap.Direction.Down:
for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) { for (let candidateIndex = 0; candidateIndex < windowsInstantiator.count; ++candidateIndex) {
const candidateItem = windowsInstantiator.objectAt(candidateIndex); const candidateItem = windowsInstantiator.objectAt(candidateIndex);
if (candidateItem.hidden) { if (candidateItem.activeHidden) {
continue; continue;
} }
@ -361,7 +361,7 @@ FocusScope {
// If the window heap has only one visible window, activate it. // If the window heap has only one visible window, activate it.
for (let i = 0; i < windowsInstantiator.count; ++i) { for (let i = 0; i < windowsInstantiator.count; ++i) {
const candidateItem = windowsInstantiator.objectAt(i); const candidateItem = windowsInstantiator.objectAt(i);
if (candidateItem.hidden) { if (candidateItem.activeHidden) {
continue; continue;
} else if (selectedItem) { } else if (selectedItem) {
selectedItem = null; selectedItem = null;