yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

effects: Drop EffectsHandler::screenGeometryChanged()

Browse source 
It's confusing to have two signals (virtualScreenGeometryChanged() and
screenGeometryChanged()) that indicate the same thing.
This commit is contained in:
Vlad Zahorodnii 2021-08-27 10:16:16 +03:00
parent ff87b33a8a
commit fff32f64e6
2 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/effects.cpp
View file

@ -191,9 +191,6 @@ EffectsHandlerImpl::EffectsHandlerImpl(Compositor *compositor, Scene *scene)
connect(Screens::self(), &Screens::countChanged, this, &EffectsHandler::numberScreensChanged); connect(Screens::self(), &Screens::countChanged, this, &EffectsHandler::numberScreensChanged);
connect(Screens::self(), &Screens::sizeChanged, this, &EffectsHandler::virtualScreenSizeChanged); connect(Screens::self(), &Screens::sizeChanged, this, &EffectsHandler::virtualScreenSizeChanged);
connect(Screens::self(), &Screens::geometryChanged, this, &EffectsHandler::virtualScreenGeometryChanged); connect(Screens::self(), &Screens::geometryChanged, this, &EffectsHandler::virtualScreenGeometryChanged);
connect(Screens::self(), &Screens::geometryChanged, this, [this]() {
Q_EMIT screenGeometryChanged(Screens::self()->size());
});
#ifdef KWIN_BUILD_ACTIVITIES #ifdef KWIN_BUILD_ACTIVITIES
if (Activities *activities = Activities::self()) { if (Activities *activities = Activities::self()) {
connect(activities, &Activities::added, this, &EffectsHandler::activityAdded); connect(activities, &Activities::added, this, &EffectsHandler::activityAdded);

9
src/libkwineffects/kwineffects.h
View file

@ -1642,15 +1642,6 @@ Q_SIGNALS:
*/ */
void propertyNotify(KWin::EffectWindow* w, long atom); void propertyNotify(KWin::EffectWindow* w, long atom);
/**
* Signal emitted after the screen geometry changed (e.g. add of a monitor).
* Effects using displayWidth()/displayHeight() to cache information should
* react on this signal and update the caches.
* @param size The new screen size
* @since 4.8
*/
void screenGeometryChanged(const QSize &size);
/** /**
* This signal is emitted when the global * This signal is emitted when the global
* activity is changed * activity is changed