My KWIN fork where I work on features like per-output virtual desktops
Find a file
David Edmundson 04845b6007 [wayland] Avoid compare to unintialised value in keyboard repeat
Summary:
If we get a key event for which

if (m_xkb->shouldKeyRepeat(key) &&
waylandServer()->seat()->keyRepeatDelay() != 0) fails

m_key will be unitialised and on release we have a compare against
unitialised memory.

Won't do any harm, it'll just stop a timer that isn't running, but
valgrind complains.

0 is the value QKeyEvent uses when nativeScanCode is unknown so a safe
initial values.

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D23748
2019-09-23 22:13:54 +02:00
autotests [autotests] Gracefully destroy xdg client 2019-09-23 23:02:21 +03:00
cmake/modules Update URLs to use https 2019-03-25 19:26:23 +01:00
colorcorrection Use nullptr everywhere 2019-09-19 17:48:21 +03:00
data Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
decorations Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
doc Improve comprehensibility and consistency of window placement mode names 2019-09-19 10:34:39 -06:00
effects [effects/slidingpopups] Don't start animation if there is no slide edge 2019-09-23 17:28:56 +03:00
helpers Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
kcmkwin SVN_SILENT made messages (.desktop file) - always resolve ours 2019-09-23 05:28:21 +02:00
kconf_update kconfig_update for auto border size introduction 2019-06-06 22:27:00 +02:00
libinput Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
libkwineffects Use nullptr everywhere 2019-09-19 17:48:21 +03:00
platformsupport Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
plugins Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
qml Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
scripting Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
scripts Emphasize minimization in MinimizeAll script 2019-09-18 18:11:28 +03:00
tabbox Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
tests [tests] Drop wl-shell test client 2019-09-23 17:28:56 +03:00
xwl Use nullptr everywhere 2019-09-19 17:48:21 +03:00
.arcconfig
.arclint
abstract_client.cpp Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
abstract_client.h Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
abstract_opengl_context_attribute_builder.cpp
abstract_opengl_context_attribute_builder.h
abstract_output.cpp Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
abstract_output.h Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
abstract_wayland_output.cpp [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
abstract_wayland_output.h [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
activation.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
activities.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
activities.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
appmenu.cpp
appmenu.h
atoms.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
atoms.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
client.cpp Move supported window type masks to matching cpp files 2019-09-20 22:44:12 +03:00
client.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
client_machine.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
client_machine.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
CMakeLists.txt Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
composite.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
composite.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
config-kwin.h.cmake [platforms/drm] EGLStream DRM Backend Initial Implementation 2019-04-15 07:26:22 -07:00
COPYING
cursor.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
cursor.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
dbusinterface.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
dbusinterface.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
debug_console.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
debug_console.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
debug_console.ui
deleted.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
deleted.h Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
effectloader.cpp
effectloader.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
effects.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
effects.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
egl_context_attribute_builder.cpp
egl_context_attribute_builder.h
events.cpp Don't initialize QFlags<T> with nullptr 2019-09-19 21:42:34 +03:00
fixqopengl.h
focuschain.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
focuschain.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
geometry.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
geometrytip.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
geometrytip.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
gestures.cpp
gestures.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
globalshortcuts.cpp
globalshortcuts.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
group.cpp Don't initialize QFlags<T> with nullptr 2019-09-19 21:42:34 +03:00
group.h Use XCB wherever possible 2019-09-07 19:54:45 +03:00
HACKING.md Introduce a new HACKING.md document to replace the previous HACKING 2018-12-17 18:11:59 +01:00
idle_inhibition.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
idle_inhibition.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
input.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input_event.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event.h Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input_event_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
internal_client.cpp Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
internal_client.h Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
keyboard_input.cpp Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
keyboard_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
keyboard_layout.cpp Make the Keyboard Layout SNI passive 2019-04-09 23:38:52 +02:00
keyboard_layout.h
keyboard_layout_switching.cpp
keyboard_layout_switching.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
keyboard_repeat.cpp
keyboard_repeat.h [wayland] Avoid compare to unintialised value in keyboard repeat 2019-09-23 22:13:54 +02:00
killwindow.cpp
killwindow.h
kwin.kcfg Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-09-17 05:29:51 +02:00
kwinbindings.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
KWinDBusInterfaceConfig.cmake.in
layers.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
logind.cpp remove superfluous code 2019-01-27 12:05:22 +05:30
logind.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
main.cpp Don't notify ksplash in our wayland session 2019-09-23 22:13:43 +02:00
main.h Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
main_wayland.cpp Don't notify ksplash in our wayland session 2019-09-23 22:13:43 +02:00
main_wayland.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
main_x11.cpp Don't notify ksplash in our wayland session 2019-09-23 22:13:43 +02:00
main_x11.h Don't notify ksplash in our wayland session 2019-09-23 22:13:43 +02:00
Mainpage.dox
manage.cpp Don't initialize QFlags<T> with nullptr 2019-09-19 21:42:34 +03:00
Messages.sh
modifier_only_shortcuts.cpp
modifier_only_shortcuts.h
moving_client_x11_filter.cpp Use more accurate name for Workspace::getMovingClient method 2019-04-22 11:12:22 +03:00
moving_client_x11_filter.h
netinfo.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
netinfo.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
onscreennotification.cpp
onscreennotification.h
options.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
options.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
org.kde.kappmenu.xml
org.kde.kwin.ColorCorrect.xml
org.kde.kwin.Compositing.xml
org.kde.kwin.Effects.xml
org.kde.kwin.OrientationSensor.xml
org.kde.KWin.VirtualDesktopManager.xml
org.kde.KWin.xml Add a dbus method getWindowInfo returning same data as queryWindowInfo 2018-12-17 18:12:17 +01:00
orientation_sensor.cpp Fix orientation sensor DBus 2019-09-01 16:15:25 +01:00
orientation_sensor.h Remove unused forward declare 2019-09-01 16:40:08 +01:00
osd.cpp
osd.h
outline.cpp [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
outline.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
outputscreens.cpp Refactor getters in OutputScreens 2019-04-25 11:12:25 +03:00
outputscreens.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
overlaywindow.cpp
overlaywindow.h
placement.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
placement.h Delete unused forward declaration of Client class 2019-09-16 16:31:09 +03:00
platform.cpp Remove unused variable 2019-09-10 14:27:44 +02:00
platform.h [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
pointer_input.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
pointer_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
popup_input_filter.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
popup_input_filter.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
README.md Add a new markdown README 2018-12-22 08:42:38 +01:00
rootinfo_filter.cpp
rootinfo_filter.h
rules.cpp Use XCB wherever possible 2019-09-07 19:54:45 +03:00
rules.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
scene.cpp Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
scene.h Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
screenedge.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
screenedge.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
screenlockerwatcher.cpp Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
screenlockerwatcher.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
screens.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
screens.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
settings.kcfgc
shadow.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
shadow.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
shortcutdialog.ui
sm.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
sm.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
tabletmodemanager.cpp Make it possible to autodetect the tablet mode 2019-03-22 18:29:21 +01:00
tabletmodemanager.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
TESTING.md [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
thumbnailitem.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
thumbnailitem.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
toplevel.cpp Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
toplevel.h Port QPA away from Wayland 2019-09-23 17:28:56 +03:00
touch_hide_cursor_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_hide_cursor_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
udev.cpp [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
udev.h [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
unmanaged.cpp Delete pointless GRAB_SERVER_DURING_CONTEXT macro 2019-09-20 22:44:12 +03:00
unmanaged.h Use XCB wherever possible 2019-09-07 19:54:45 +03:00
useractions.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
useractions.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
utils.cpp Don't initialize QFlags<T> with nullptr 2019-09-19 21:42:34 +03:00
utils.h Delete pointless GRAB_SERVER_DURING_CONTEXT macro 2019-09-20 22:44:12 +03:00
virtual_terminal.cpp Port away from deprecated headers 2019-07-09 23:59:07 +03:00
virtual_terminal.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
virtualdesktops.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
virtualdesktops.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
virtualdesktopsdbustypes.cpp
virtualdesktopsdbustypes.h
virtualkeyboard.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
virtualkeyboard.h Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
virtualkeyboard_dbus.cpp
virtualkeyboard_dbus.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
was_user_interaction_x11_filter.cpp
was_user_interaction_x11_filter.h
wayland_cursor_theme.cpp
wayland_cursor_theme.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
wayland_server.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
wayland_server.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
window_property_notify_x11_filter.cpp
window_property_notify_x11_filter.h
workspace.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
workspace.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
x11eventfilter.cpp
x11eventfilter.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xcbutils.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xcbutils.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xdgshellclient.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
xdgshellclient.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
xkb.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xkb.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xkb_qt_mapping.h

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contacting KWin development team

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Developing on KWin

Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.