My KWIN fork where I work on features like per-output virtual desktops
Find a file
Vlad Zahorodnii 16a07d5df2 wayland: Handle xdg_wm_base being destroyed before surface role
If a client owns several windows (for example it can be the case with
plasmashell) and it crashes, it's possible to encounter the following
case:

- xdg_wm_base resources are destroyed
- xdg_toplevel is destroyed
- another xdg_toplevel is destroyed

When kwin processes the destruction of the first xdg_toplevel, it may
ping the second xdg_toplevel. But the xdg_wm_base is already free()d by
that time, so kwin can access already released memory.

In order to prevent that, make the associated XdgSurfaceInterface
objects inert. Since XdgToplevelInterface and XdgPopupInterface will
become useless after destroying XdgSurfaceInterface, make them inert too.

As the spec states, it's illegal to destroy a bound xdg_wm_base object
while there are still alive xdg surfaces created by it so destroying the
surface role objects should be fine.
2023-03-22 10:56:38 +00:00
autotests cmake: Tidy scripted effect CMakeLists.txt code 2023-03-21 07:18:27 +00:00
cmake/modules Fix some tests not building with Qt 6 2022-10-20 09:37:00 +00:00
data Port to KF6 2023-02-28 18:30:26 +02:00
doc Update decoration kcm docbook 2023-02-05 02:22:14 +00:00
LICENSES Remove unused license file 2022-08-23 17:41:55 +02:00
po GIT_SILENT Sync po/docbooks with svn 2023-03-22 03:09:45 +00:00
src wayland: Handle xdg_wm_base being destroyed before surface role 2023-03-22 10:56:38 +00:00
tests Port to versionless QML module imports 2023-03-12 14:18:34 +00:00
.clang-format Run clang-format 2022-03-25 13:25:15 +02:00
.gitignore Run clang-format 2022-03-25 13:25:15 +02:00
.gitlab-ci.yml Port to KF6 2023-02-28 18:30:26 +02:00
.kde-ci.yml Port to KF6 2023-02-28 18:30:26 +02:00
CMakeLists.txt Drop unused kitemviews dependency 2023-03-21 20:32:04 +02:00
CONTRIBUTING.md add more debugging information to CONTRIBUTING.md 2023-01-09 13:40:31 +00:00
KWinDBusInterfaceConfig.cmake.in Expose org.kde.kwin.ColorCorrect.xml dbus file 2022-01-05 01:33:01 +00:00
logo.png
Mainpage.dox
plasma-kwin_wayland.service.in Re-enable systemd managed kwin 2021-12-02 13:25:50 +00:00
plasma-kwin_x11.service.in [systemd] Fix X11 service file 2022-01-20 16:18:48 +00:00
README.md doc: modernise HACKING -> CONTRIBUTING guidelines and information 2021-08-31 22:10:58 +00:00

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contributing to KWin

Please refer to the contributing document for everything you need to know to get started contributing to KWin.

Contacting KWin development team

  • mailing list: kwin@kde.org
  • IRC: #kde-kwin on irc.libera.chat

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.