3709996f8a
Summary: The KCM has a context property of the currently set theme index. This is set before the decorations model is populated, so it is currently always -1. This model is populated after the constructor but before KCModule::load(). KCModule::load is called from KCModule::showEvent so before QQuickGridView will start doing anything with delegates. This fixes the problem simply and also avoid parsing the config file multiple times. This bug was introduced in 5.9.4: Someone made a (tested) change to make sure the view scrolled to the right place on startup. I then made a (tested) commit fixing the crash on exit The author then updated his patch to my changes, but now in a way that didn't work. Test Plan: Opened system settings module with a million decorations. The correct entry was visible and highlighted. Reviewers: #plasma, graesslin Reviewed By: #plasma, graesslin Subscribers: plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5401
80 lines
2.1 KiB
C++
80 lines
2.1 KiB
C++
/*
|
|
* Copyright 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#ifndef KDECORATIONS_KCM_H
|
|
#define KDECORATIONS_KCM_H
|
|
|
|
#include <kcmodule.h>
|
|
#include <ui_kcm.h>
|
|
#include <QAbstractItemModel>
|
|
|
|
class QSortFilterProxyModel;
|
|
class QQuickView;
|
|
|
|
namespace KDecoration2
|
|
{
|
|
namespace Preview
|
|
{
|
|
class PreviewBridge;
|
|
class ButtonsModel;
|
|
}
|
|
namespace Configuration
|
|
{
|
|
class DecorationsModel;
|
|
|
|
class ConfigurationForm : public QWidget, public Ui::KCMForm
|
|
{
|
|
public:
|
|
explicit ConfigurationForm(QWidget* parent);
|
|
};
|
|
|
|
class ConfigurationModule : public KCModule
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit ConfigurationModule(QWidget *parent = nullptr, const QVariantList &args = QVariantList());
|
|
virtual ~ConfigurationModule();
|
|
|
|
bool eventFilter(QObject *watched, QEvent *e) override;
|
|
|
|
public Q_SLOTS:
|
|
void defaults() override;
|
|
void load() override;
|
|
void save() override;
|
|
|
|
protected:
|
|
void showEvent(QShowEvent *ev) override;
|
|
|
|
private:
|
|
void showKNS(const QString &config);
|
|
void updateColors();
|
|
DecorationsModel *m_model;
|
|
QSortFilterProxyModel *m_proxyModel;
|
|
ConfigurationForm *m_ui;
|
|
QQuickView *m_quickView;
|
|
Preview::ButtonsModel *m_leftButtons;
|
|
Preview::ButtonsModel *m_rightButtons;
|
|
Preview::ButtonsModel *m_availableButtons;
|
|
};
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|