My KWIN fork where I work on features like per-output virtual desktops
Find a file
David Edmundson 3ba33e4b58 Use lambdas for queued invocation of composition suspending
Summary:
Qt's metaobject is rather sensitive with scope resolution.

Foo::Bar and Bar don't always match to a Qt metaobject, even if they
refer to the same thing to a compiler. Here we register
X11Compositor::SuspendReason but Q_ARG uses SuspendReason and they don't
match. This leads to a runtime failure where the method isn't invoked.

Rather than fixing metaobject usage, port the whole thing to lambdas
which does better compile time checking and is generally nicer to read.

BUG: 412353

Test Plan:
Ran xprop to block compositing. Compositing was blocked.
Grepped source code for Q_ARG use

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24244
2019-09-26 16:09:16 +01:00
autotests Undo some recent cmake changes 2019-09-18 13:50:52 +03:00
cmake/modules Update URLs to use https 2019-03-25 19:26:23 +01:00
colorcorrection [nightcolor] Print a debug message upon receiving new location from kded module 2019-09-26 12:10:26 +03:00
data Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
decorations Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
doc Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
effects Use nullptr everywhere 2019-09-19 17:48:21 +03:00
helpers Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
kcmkwin SVN_SILENT made messages (.desktop file) - always resolve ours 2019-09-26 08:55:53 +02:00
kconf_update kconfig_update for auto border size introduction 2019-06-06 22:27:00 +02:00
libinput Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
libkwineffects Use nullptr everywhere 2019-09-19 17:48:21 +03:00
platformsupport Use nullptr everywhere 2019-09-19 17:48:21 +03:00
plugins Use lambdas for queued invocation of composition suspending 2019-09-26 16:09:16 +01:00
qml Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
scripting Use nullptr everywhere 2019-09-19 17:48:21 +03:00
scripts Emphasize minimization in MinimizeAll script 2019-09-18 18:11:28 +03:00
tabbox Use nullptr everywhere 2019-09-19 17:48:21 +03:00
tests Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xwl Use nullptr everywhere 2019-09-19 17:48:21 +03:00
.arcconfig
.arclint Add .arclint 2018-10-02 19:44:07 +03:00
abstract_client.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
abstract_client.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
abstract_opengl_context_attribute_builder.cpp
abstract_opengl_context_attribute_builder.h
abstract_output.cpp Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
abstract_output.h Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
abstract_wayland_output.cpp [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
abstract_wayland_output.h [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
activation.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
activities.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
activities.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
appmenu.cpp
appmenu.h Fix minor EBN issues 2018-08-29 21:02:16 +03:00
atoms.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
atoms.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
client.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
client.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
client_machine.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
client_machine.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
CMakeLists.txt Update version number for 5.16.90 2019-09-19 10:04:51 +01:00
composite.cpp Use lambdas for queued invocation of composition suspending 2019-09-26 16:09:16 +01:00
composite.h Use lambdas for queued invocation of composition suspending 2019-09-26 16:09:16 +01:00
config-kwin.h.cmake [platforms/drm] EGLStream DRM Backend Initial Implementation 2019-04-15 07:26:22 -07:00
COPYING
cursor.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
cursor.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
dbusinterface.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
dbusinterface.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
debug_console.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
debug_console.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
debug_console.ui fixuifiles 2018-09-18 07:52:44 +02:00
deleted.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
deleted.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
effectloader.cpp
effectloader.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
effects.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
effects.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
egl_context_attribute_builder.cpp
egl_context_attribute_builder.h
events.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
fixqopengl.h
focuschain.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
focuschain.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
geometry.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
geometrytip.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
geometrytip.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
gestures.cpp
gestures.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
globalshortcuts.cpp
globalshortcuts.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
group.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
group.h Use XCB wherever possible 2019-09-07 19:54:45 +03:00
HACKING.md Introduce a new HACKING.md document to replace the previous HACKING 2018-12-17 18:11:59 +01:00
idle_inhibition.cpp Use appropriate sequence algorithms in IdleInhibition 2019-01-11 15:28:28 +02:00
idle_inhibition.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
input.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input_event.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event.h Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input_event_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
internal_client.cpp [wayland] Apply window rules only to xdg-shell clients 2019-07-09 15:13:49 +03:00
internal_client.h [wayland] Apply window rules only to xdg-shell clients 2019-07-09 15:13:49 +03:00
keyboard_input.cpp Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
keyboard_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
keyboard_layout.cpp Make the Keyboard Layout SNI passive 2019-04-09 23:38:52 +02:00
keyboard_layout.h
keyboard_layout_switching.cpp
keyboard_layout_switching.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
keyboard_repeat.cpp
keyboard_repeat.h
killwindow.cpp
killwindow.h
kwin.kcfg Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-09-17 05:29:51 +02:00
kwinbindings.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
KWinDBusInterfaceConfig.cmake.in
layers.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
logind.cpp remove superfluous code 2019-01-27 12:05:22 +05:30
logind.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
main.cpp Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
main.h Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
main_wayland.cpp [platforms/drm] Early platform and outputs teardown 2019-09-05 17:00:40 +02:00
main_wayland.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
main_x11.cpp Port away from deprecated QString::sprintf 2019-09-18 16:20:06 +03:00
main_x11.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
Mainpage.dox
manage.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
Messages.sh Fix untranslatable strings in debug_console.ui shortcutdialog.ui 2018-09-17 11:39:47 +02:00
modifier_only_shortcuts.cpp
modifier_only_shortcuts.h
moving_client_x11_filter.cpp Use more accurate name for Workspace::getMovingClient method 2019-04-22 11:12:22 +03:00
moving_client_x11_filter.h
netinfo.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
netinfo.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
onscreennotification.cpp
onscreennotification.h
options.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
options.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
org.kde.kappmenu.xml
org.kde.kwin.ColorCorrect.xml
org.kde.kwin.Compositing.xml
org.kde.kwin.Effects.xml
org.kde.kwin.OrientationSensor.xml
org.kde.KWin.VirtualDesktopManager.xml [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
org.kde.KWin.xml Add a dbus method getWindowInfo returning same data as queryWindowInfo 2018-12-17 18:12:17 +01:00
orientation_sensor.cpp Fix orientation sensor DBus 2019-09-01 16:15:25 +01:00
orientation_sensor.h Remove unused forward declare 2019-09-01 16:40:08 +01:00
osd.cpp
osd.h
outline.cpp [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
outline.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
outputscreens.cpp Refactor getters in OutputScreens 2019-04-25 11:12:25 +03:00
outputscreens.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
overlaywindow.cpp
overlaywindow.h
placement.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
placement.h Delete unused forward declaration of Client class 2019-09-16 16:31:09 +03:00
platform.cpp Remove unused variable 2019-09-10 14:27:44 +02:00
platform.h [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
pointer_input.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
pointer_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
popup_input_filter.cpp
popup_input_filter.h
README.md Add a new markdown README 2018-12-22 08:42:38 +01:00
rootinfo_filter.cpp
rootinfo_filter.h
rules.cpp Use XCB wherever possible 2019-09-07 19:54:45 +03:00
rules.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
scene.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
scene.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
screenedge.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
screenedge.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
screenlockerwatcher.cpp Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
screenlockerwatcher.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
screens.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
screens.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
settings.kcfgc
shadow.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
shadow.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
shell_client.cpp Pass area by const reference to placeFoo methods 2019-09-16 16:26:58 +03:00
shell_client.h Pass area by const reference to placeFoo methods 2019-09-16 16:26:58 +03:00
shortcutdialog.ui
sm.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
sm.h Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
tabletmodemanager.cpp Make it possible to autodetect the tablet mode 2019-03-22 18:29:21 +01:00
tabletmodemanager.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
TESTING.md [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
thumbnailitem.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
thumbnailitem.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
toplevel.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
toplevel.h Use XCB wherever possible 2019-09-07 19:54:45 +03:00
touch_hide_cursor_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_hide_cursor_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
udev.cpp [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
udev.h [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
unmanaged.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
unmanaged.h Use XCB wherever possible 2019-09-07 19:54:45 +03:00
useractions.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
useractions.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
utils.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
utils.h Make iterating over Layer enum simple 2019-08-11 16:23:08 +02:00
virtual_terminal.cpp Port away from deprecated headers 2019-07-09 23:59:07 +03:00
virtual_terminal.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
virtualdesktops.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
virtualdesktops.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
virtualdesktopsdbustypes.cpp [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualdesktopsdbustypes.h [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualkeyboard.cpp Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
virtualkeyboard.h Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
virtualkeyboard_dbus.cpp
virtualkeyboard_dbus.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
was_user_interaction_x11_filter.cpp
was_user_interaction_x11_filter.h
wayland_cursor_theme.cpp
wayland_cursor_theme.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
wayland_server.cpp Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
wayland_server.h Remove unused function declaration 2019-08-28 19:41:36 +02:00
window_property_notify_x11_filter.cpp Clean up includes 2018-08-31 22:58:11 +03:00
window_property_notify_x11_filter.h
workspace.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
workspace.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
x11eventfilter.cpp
x11eventfilter.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xcbutils.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xcbutils.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xkb.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xkb.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xkb_qt_mapping.h

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contacting KWin development team

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Developing on KWin

Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.