47343fb8f7
Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152 |
||
---|---|---|
.. | ||
CMakeLists.txt | ||
drm.json | ||
drm_backend.cpp | ||
drm_backend.h | ||
drm_buffer.cpp | ||
drm_buffer.h | ||
drm_buffer_gbm.cpp | ||
drm_buffer_gbm.h | ||
drm_inputeventfilter.cpp | ||
drm_inputeventfilter.h | ||
drm_object.cpp | ||
drm_object.h | ||
drm_object_connector.cpp | ||
drm_object_connector.h | ||
drm_object_crtc.cpp | ||
drm_object_crtc.h | ||
drm_object_plane.cpp | ||
drm_object_plane.h | ||
drm_output.cpp | ||
drm_output.h | ||
drm_pointer.h | ||
egl_gbm_backend.cpp | ||
egl_gbm_backend.h | ||
gbm_surface.cpp | ||
gbm_surface.h | ||
logging.cpp | ||
logging.h | ||
scene_qpainter_drm_backend.cpp | ||
scene_qpainter_drm_backend.h | ||
screens_drm.cpp | ||
screens_drm.h |