47343fb8f7
Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152
31 lines
740 B
CMake
31 lines
740 B
CMake
set(DRM_SOURCES
|
|
drm_backend.cpp
|
|
drm_object.cpp
|
|
drm_object_connector.cpp
|
|
drm_object_crtc.cpp
|
|
drm_object_plane.cpp
|
|
drm_output.cpp
|
|
drm_buffer.cpp
|
|
drm_inputeventfilter.cpp
|
|
logging.cpp
|
|
scene_qpainter_drm_backend.cpp
|
|
screens_drm.cpp
|
|
)
|
|
|
|
if(HAVE_GBM)
|
|
set(DRM_SOURCES ${DRM_SOURCES} egl_gbm_backend.cpp drm_buffer_gbm.cpp gbm_surface.cpp)
|
|
endif()
|
|
|
|
add_library(KWinWaylandDrmBackend MODULE ${DRM_SOURCES})
|
|
target_link_libraries(KWinWaylandDrmBackend kwin Libdrm::Libdrm SceneQPainterBackend)
|
|
|
|
if(HAVE_GBM)
|
|
target_link_libraries(KWinWaylandDrmBackend gbm::gbm)
|
|
endif()
|
|
|
|
install(
|
|
TARGETS
|
|
KWinWaylandDrmBackend
|
|
DESTINATION
|
|
${PLUGIN_INSTALL_DIR}/org.kde.kwin.waylandbackends/
|
|
)
|