My KWIN fork where I work on features like per-output virtual desktops
Find a file
Burkhard Lück 720d10cee8 Update kwintabbox kcm docbook to plasma 5
Note:
The diff is completely misleading, because the latest docbook in kde 4 has <date>2014-03-10</date> + <releaseinfo>&kde; 4.11</releaseinfo>
but kwin master in kf5 has <date>2010-10-28</date> + <date>2015-07-24</date> <releaseinfo>&kde; 4.5</releaseinfo>
The diff against the latest kde4 docbook version 4.11 has only 4 or 5 lines
REVIEW:124475
2015-07-28 09:49:29 +02:00
autotests Drop KF5::Service dependency where it's no longer needed 2015-07-07 09:53:48 +02:00
backends [backends/drm] Drm backend support syncsToVBlank 2015-07-17 20:39:37 +02:00
clients Clean debug output 2015-07-20 13:36:27 +02:00
cmake/modules [backends/hwcomper] Initial support for input handling 2015-05-09 16:22:27 +02:00
data Install a categories file for kdebugsettings 2015-07-15 12:02:31 +02:00
decorations Switch decoration loading to KPluginLoader::findPluginsById 2015-07-07 08:06:34 +02:00
doc Update kwintabbox kcm docbook to plasma 5 2015-07-28 09:49:29 +02:00
effects Clean debug output 2015-07-20 13:36:27 +02:00
kcmkwin Remove obsolete kwincompositing kcm docbook 2015-07-25 09:06:43 +02:00
killer Drop explicit Qt5Widgets_EXECUTABLE_COMPILE_FLAGS 2014-07-12 09:27:36 +02:00
libinput [libinput] Bind libinput support to VirtualTerminal 2015-04-24 12:03:19 +02:00
libkwineffects Clean debug output 2015-07-20 13:36:27 +02:00
plugins Change supported platforms of kglobalaccel plugin to "org.kde.kwin" 2015-07-07 13:36:27 +02:00
qml [kwin] Provide composited outline as QML instead of hand drawn FrameSvg 2014-03-10 09:16:16 +01:00
scripting Disable Activities support on Wayland 2015-07-07 11:48:42 +02:00
scripts SVN_SILENT made messages (.desktop file) - always resolve ours 2015-07-09 11:30:25 +00:00
shaders
tabbox Clean debug output 2015-07-20 13:36:27 +02:00
tests Fix screenedgeshow manual test 2015-07-01 14:06:30 +01:00
.reviewboardrc Add reviewboardrc 2014-04-03 10:46:33 +02:00
16-apps-kwin.png Fix installing of icons 2014-06-02 14:56:42 +02:00
32-apps-kwin.png Fix installing of icons 2014-06-02 14:56:42 +02:00
48-apps-kwin.png Fix installing of icons 2014-06-02 14:56:42 +02:00
abstract_backend.cpp [wayland] Support pointer warping in the backends 2015-06-06 17:43:13 +02:00
abstract_backend.h [wayland] Support pointer warping in the backends 2015-06-06 17:43:13 +02:00
abstract_client.cpp [wayland] Pass appId to PlasmaWindow interface 2015-07-20 09:37:36 +02:00
abstract_client.h Move Q_PROPERTY wantsInput from Client to AbstractClient 2015-07-22 08:42:48 +02:00
abstract_egl_backend.cpp [wayland] Properly handle case that EGL_WAYLAND_Y_INVERTED_WL is not supported 2015-05-21 15:49:46 +02:00
abstract_egl_backend.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
activation.cpp Clean debug output 2015-07-20 13:36:27 +02:00
activities.cpp Windows retain their assigned activities on kwin restart 2015-02-16 00:01:04 +01:00
activities.h Windows retain their assigned activities on kwin restart 2015-02-16 00:01:04 +01:00
atoms.cpp [xwayland] Add support for WL_SURFACE_ID 2015-03-17 10:03:04 +01:00
atoms.h [xwayland] Add support for WL_SURFACE_ID 2015-03-17 10:03:04 +01:00
client.cpp [wayland] Improve creation of KWayland::Server::PlasmaWindowInterface 2015-07-09 09:10:33 +02:00
client.h Move Q_PROPERTY wantsInput from Client to AbstractClient 2015-07-22 08:42:48 +02:00
client_machine.cpp [clientmachine] Use NETWinInfo instead of KWindowInfo 2015-02-17 13:59:04 +01:00
client_machine.h
CMakeLists.txt Port away from KToolInvocation 2015-07-07 17:35:57 +02:00
COMPLIANCE Fix typo in COMPLIANCE file. 2014-06-20 21:27:12 -03:00
composite.cpp [wayland] Not visible windows should not trigger a repaint 2015-07-17 20:39:57 +02:00
composite.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
compositingprefs.cpp Introduce categorized logging for kwin core 2014-12-05 14:27:15 +01:00
compositingprefs.h
config-kwin.h.cmake Port away from KToolInvocation 2015-07-07 17:35:57 +02:00
CONFIGURING
COPYING Put licence files on each repo, removing from root. 2014-03-26 19:01:09 +01:00
COPYING.DOC Put licence files on each repo, removing from root. 2014-03-26 19:01:09 +01:00
cursor.cpp [wayland] Add support for pointer warping in InputRedirectionCursor 2015-06-06 17:43:13 +02:00
cursor.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
dbusinterface.cpp Disable Activities support on Wayland 2015-07-07 11:48:42 +02:00
dbusinterface.h Announce KWin's dbus service name on a root window property 2015-01-27 07:25:31 +01:00
deleted.cpp Toplevel::windowRole becomes virtual and is copied to Deleted 2015-05-08 12:43:44 +02:00
deleted.h Toplevel::windowRole becomes virtual and is copied to Deleted 2015-05-08 12:43:44 +02:00
effectloader.cpp PluginEffectLoader doesn't use KPluginTrader any more 2015-07-07 09:36:15 +02:00
effectloader.h PluginEffectLoader doesn't use KPluginTrader any more 2015-07-07 09:36:15 +02:00
effects.cpp EffectsHandlerImpl::activateWindow operates on AbstractClient 2015-07-07 16:12:27 +02:00
effects.h Port scripted effect loading from KService to KPackage 2015-07-06 16:50:33 +02:00
eglonxbackend.cpp [wayland] Don't call into X11WindowedBackend from EglOnXBackend 2015-05-05 15:35:12 +02:00
eglonxbackend.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
events.cpp Move logic to handle mouse buttons on windows to AbstractClient 2015-07-09 16:34:19 +02:00
ExtraDesktop.sh
focuschain.cpp Remove remaining Client usage from FocusChain 2015-05-08 12:43:46 +02:00
focuschain.h Remove remaining Client usage from FocusChain 2015-05-08 12:43:46 +02:00
geometry.cpp [wayland] Add support for PanelBehavior in ShellClient 2015-06-20 00:14:49 +02:00
geometrytip.cpp Use Xcb::GeometryHints instead of XGetWMNormalHints 2015-01-27 12:48:03 +01:00
geometrytip.h Use Xcb::GeometryHints instead of XGetWMNormalHints 2015-01-27 12:48:03 +01:00
globalshortcuts.cpp Change supported platforms of kglobalaccel plugin to "org.kde.kwin" 2015-07-07 13:36:27 +02:00
globalshortcuts.h [wayland] Add a plugin for kglobalaccel 2015-07-02 13:42:29 +02:00
glxbackend.cpp Clean debug output 2015-07-20 13:36:27 +02:00
glxbackend.h [wayland] Support creating Texture from Wayland shm buffer 2015-03-17 10:08:27 +01:00
group.cpp Clean debug output 2015-07-20 13:36:27 +02:00
group.h Improve updating user timestamp 2014-06-03 13:59:10 +02:00
HACKING
input.cpp [wayland] Improve pointer movements at screen edges 2015-07-20 12:35:46 +02:00
input.h [wayland] Announce modifier changes to clients 2015-07-13 14:25:09 +02:00
killwindow.cpp Use Cursor::x11Cursor from KillWindow 2015-01-29 09:02:23 +01:00
killwindow.h
kwin.kcfg remove secret showDesktopIsMinimizeAll feature 2015-04-07 23:59:16 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2015-04-07 13:20:00 +00:00
kwinbindings.cpp Add Quick Tile Window to the Top and Bottom shortcuts 2015-03-31 11:10:13 +02:00
KWinDBusInterfaceConfig.cmake.in Use ecm_configure_package_config_file instead of configure_file 2014-03-27 12:38:36 +01:00
lanczosfilter.cpp Add an internalFormat parameter to the GLTexture ctor 2014-12-30 21:19:49 +01:00
lanczosfilter.h
layers.cpp [wayland] Track the internal ShellClients in WaylandServer 2015-05-21 13:34:26 +02:00
logind.cpp Connect to Logind's PauseDevice signal 2015-04-24 12:03:20 +02:00
logind.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
main.cpp Install a categories file for kdebugsettings 2015-07-15 12:02:31 +02:00
main.h Install a categories file for kdebugsettings 2015-07-15 12:02:31 +02:00
main_wayland.cpp [wayland] Determine whether libinput is needed from plugin metadata 2015-07-16 10:54:29 +02:00
main_wayland.h Port away from KToolInvocation 2015-07-07 17:35:57 +02:00
main_x11.cpp Install a categories file for kdebugsettings 2015-07-15 12:02:31 +02:00
main_x11.h Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
Mainpage.dox
manage.cpp Disable Activities support on Wayland 2015-07-07 11:48:42 +02:00
Messages.sh Adjust kwin and killer to new ki18n 2014-05-05 08:03:54 +02:00
netinfo.cpp Move skipTaskbar from Client to AbstractClient 2015-06-06 22:11:10 +02:00
netinfo.h [kwin] Remove support for _NET_WM_TAKE_ACTIVITY protocol 2014-03-25 15:03:21 +01:00
options.cpp use mode based freq calc on all drivers 2015-05-15 23:55:28 +02:00
options.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
org.freedesktop.ScreenSaver.xml Add a copy of org.freedesktop.ScreenSaver.xml for KWin 2014-03-24 16:30:22 +01:00
org.kde.kwin.Compositing.xml Create dedicated class for CompositorDBusInterface 2014-06-10 10:52:25 +02:00
org.kde.kwin.Effects.xml [kwin] Add a new EffectLoader 2014-03-28 14:04:55 +01:00
org.kde.KWin.xml
outline.cpp Introduce categorized logging for kwin core 2014-12-05 14:27:15 +01:00
outline.h [outline] Use QScopedPointer for created QML item 2014-05-30 15:54:24 +02:00
overlaywindow.cpp Remove displayWidth and displayHeight from the compositor 2014-11-27 09:00:19 +01:00
overlaywindow.h
placement.cpp Placement fully operates on AbstractClient 2015-05-27 14:20:12 +02:00
placement.h Placement fully operates on AbstractClient 2015-05-27 14:20:12 +02:00
README
resources.qrc
rules.cpp Port away from KToolInvocation 2015-07-07 17:35:57 +02:00
rules.h RuleBook::edit operates on AbstractClient 2015-05-08 12:43:45 +02:00
sc-apps-kwin.svgz Fix installing of icons 2014-06-02 14:56:42 +02:00
scene.cpp [wayland] Unreference the buffer when destroying the WindowPixmap 2015-06-12 16:22:41 +02:00
scene.h Drop Workspace dependency from Scene 2015-03-17 10:20:19 +01:00
scene_opengl.cpp Clean debug output 2015-07-20 13:36:27 +02:00
scene_opengl.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
scene_qpainter.cpp [wayland] Move X11WindowedQPainterBackend into backends/x11 2015-05-05 15:23:53 +02:00
scene_qpainter.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
scene_xrender.cpp [wayland] Drop Wayland support in SceneXRender 2015-03-23 13:47:21 +01:00
scene_xrender.h [wayland] Drop Wayland support in SceneXRender 2015-03-23 13:47:21 +01:00
screenedge.cpp Merge branch 'Plasma/5.3' 2015-06-03 21:40:08 +02:00
screenedge.h Do not include utils.h in xcbutils.h 2014-11-27 09:00:19 +01:00
screens.cpp Silence unused variable warnings in Screens 2015-05-19 08:15:30 +02:00
screens.h add Screens::name(int screen); STUB but for XRandr 2015-05-15 23:55:27 +02:00
screens_xrandr.cpp add Screens::name(int screen); STUB but for XRandr 2015-05-15 23:55:27 +02:00
screens_xrandr.h add Screens::name(int screen); STUB but for XRandr 2015-05-15 23:55:27 +02:00
settings.kcfgc
shadow.cpp Fix build without wayland 2015-07-20 08:53:55 +02:00
shadow.h [wayland] Shadow gains support for a Wayland protocol 2015-07-15 11:25:16 +02:00
shell_client.cpp Fix naming 2015-07-22 08:38:00 +02:00
shell_client.h Fix naming 2015-07-22 08:38:00 +02:00
shortcutdialog.ui [kwin] Use ui-file for ShortcutDialog 2014-02-27 10:18:37 +01:00
sm.cpp port session management to KF5 2015-06-18 00:18:53 +02:00
sm.h port session management to KF5 2015-06-18 00:18:53 +02:00
tabgroup.cpp Workspace::activeClient returns an AbstractClient 2015-05-08 12:43:45 +02:00
tabgroup.h Drop kdecoration.h include from tabgroup.h 2014-12-02 11:48:13 +01:00
thumbnailitem.cpp [wayland] ThumbnailItem supports ShellClients 2015-05-21 13:34:26 +02:00
thumbnailitem.h ThumbnailItem operates on AbstractClient 2015-05-21 13:34:26 +02:00
toplevel.cpp [wayland] Pass appId to PlasmaWindow interface 2015-07-20 09:37:36 +02:00
toplevel.h [wayland] Pass appId to PlasmaWindow interface 2015-07-20 09:37:36 +02:00
udev.cpp [udev] Add wrapper for udev_monitor 2015-04-24 12:03:20 +02:00
udev.h Create a plugin for each of the wayland backends 2015-05-06 10:31:39 +02:00
unmanaged.cpp [wayland] Drop methods on Toplevel to send input events 2015-03-17 10:20:20 +01:00
unmanaged.h [wayland] Drop methods on Toplevel to send input events 2015-03-17 10:20:20 +01:00
useractions.cpp Provide a base implementation for performMouseCommand in AbstractClient 2015-07-09 16:34:19 +02:00
useractions.h don't offer to set window shortcut if rule forced 2015-06-19 19:47:51 +02:00
utils.cpp Migrate away from QX11Info::appTime 2015-02-23 11:02:59 +01:00
utils.h enable wayland clients to go fullscreen 2015-05-28 10:58:40 +01:00
virtual_terminal.cpp [wayland] Don't break if we try to vt-switch to vt we're on 2015-07-20 11:49:41 +02:00
virtual_terminal.h [wayland] Don't break if we try to vt-switch to vt we're on 2015-07-20 11:49:41 +02:00
virtualdesktops.cpp Update x11Time when a global shortcut is pressed 2015-02-25 08:15:53 +01:00
virtualdesktops.h [kwin] Add missing includes 2014-03-18 14:37:01 +01:00
wayland_cursor_theme.cpp [wayland] Split out WaylandCursorTheme into own header/implementation 2015-05-05 13:05:04 +02:00
wayland_cursor_theme.h [wayland] Split out WaylandCursorTheme into own header/implementation 2015-05-05 13:05:04 +02:00
wayland_server.cpp [wayland] Shadow gains support for a Wayland protocol 2015-07-15 11:25:16 +02:00
wayland_server.h [wayland] Improve creation of KWayland::Server::PlasmaWindowInterface 2015-07-09 09:10:33 +02:00
workspace.cpp Disable Activities support on Wayland 2015-07-07 11:48:42 +02:00
workspace.h Workspace::gotFocusIn and ::shouldGetFocusIn changed to operate on AbstractClient 2015-07-09 16:34:19 +02:00
x11eventfilter.cpp [screens] Replace DesktopWidgetScreens by XRandRScreens 2014-11-27 09:00:19 +01:00
x11eventfilter.h Add an X11EventFilter class 2014-09-18 20:21:20 +02:00
xcbutils.cpp Clean debug output 2015-07-20 13:36:27 +02:00
xcbutils.h add OutputInfo class to obtain output names 2015-05-15 23:55:27 +02:00

- A collection of various documents and links related to KWin is at http://techbase.kde.org/Projects/KWin .


- The mailing list for KWin is kwin@kde.org (https://mail.kde.org/mailman/listinfo/kwin).

- If you want to develop KWin, see file HACKING.

- If you want to check KWin's compliance with specifications, see file COMPLIANCE.

- File CONFIGURATION includes some details on configuring KWin.

- Below is some info for application developers about application interaction
  with the window manager, but it'd need some cleanup.








 This README is meant as an explanation of various window manager related
mechanisms that application developers need to be aware of. As some of these
concepts may be difficult to understand for people not having the required
background knowledge (since sometimes it's difficult even for people who
do have the knowledge), the mechanisms are first briefly explained, and
then an example of fixing the various problems is given.

 For comments, questions, suggestions and whatever use the kwin@kde.org
mailing list.


Table of contents:
==================

- Window relations
    - how to make the window manager know which windows belong together
- Focus stealing prevention
    - how to solve cases where focus stealing prevention doesn't work
      properly automatically



Window relations:
=================

(For now, this explanation of window relations is mainly meant for
focus stealing prevention. To be extended later.)

 All windows created by an application should be organized in a tree
with the root being the application's main window. Note that this is about
toplevel windows, not widgets inside the windows. For example, if you
have KWrite running, with a torn-off toolbar (i.e. a standalone toolbar),
a file save dialog open, and the file save dialog showing a dialog
for creating a directory, the window hiearchy should look like this:


             KWrite mainwindow
              /             \
             /               \
      file save dialog      torn-off toolbar
            \
             \
          create directory dialog

 Each subwindow (i.e. all except for the KWrite mainwindow) points to its
main window (which in turn may have another main window, as in the case
of the file save dialog). When the window manager knows these relations,
it can better arrange the windows (keeping subwindows above their
main windows, preventing activation of a main window of a modal dialog,
and similar). Failing to provide this information to the window manager
may have various results, for example having dialogs positioned below
the main window,

The window property used by subwindows to point to their mainwindows is
called WM_TRANSIENT_FOR. It can be seen by running
'xprop | grep WM_TRANSIENT_FOR' and clicking on a window. If the property
is not present, the window does not (claim to) have any mainwindow.
If the property is present, it's value is the window id of its main window;
window id of any window can be found out by running 'xwininfo'. A window
having WM_TRANSIENT_FOR poiting to another window is said to be transient
for that window.

 In some cases, the WM_TRANSIENT_FOR property may not point to any other
existing window, having value of 0, or pointing to the screen number
('xwininfo -root'). These special values mean that the window is transient
for all other windows in its window group. This should be used only
in rare cases, everytime a specific main window is known, WM_TRANSIENT_FOR
should be pointing to it instead of using one of these special values.
(The explanation why is beyond the scope of this document - just accept it
as a fact.)

 With Qt, the WM_TRANSIENT_FOR property is set by Qt automatically, based
on the toplevel widget's parent. If the toplevel widget is of a normal
type (i.e. not a dialog, toolbar, etc.), Qt doesn't set WM_TRANSIENT_FOR
on it. For special widgets, such as dialogs, WM_TRANSIENT_FOR is set
to point to the widget's parent, if it has a specific parent, otherwise
WM_TRANSIENT_FOR points to the root window.

 As already said above, WM_TRANSIENT_FOR poiting to the root window should
be usually avoided, so everytime the widget's main widget is known, the widget
should get it passed as a parent in its constructor.
(TODO KDialog etc. classes should not have a default argument for the parent
argument, and comments like 'just pass 0 as the parent' should go.)



Focus stealing prevention:
==========================

 Since KDE3.2 KWin has a feature called focus stealing prevention. As the name
suggests, it prevents unexpected changes of focus. With older versions of KWin,
if any application opened a new dialog, it became active, and
if the application's main window was on another virtual desktop, also
the virtual desktop was changed. This was annoying, and also sometimes led
to dialogs mistakenly being closed because they received keyboard input that
was meant for the previously active window.

 The basic principle of focus stealing prevention is that the window with most
recent user activity wins. Any window of an application will become active
when being shown only if this application was the most recently used one.
KWin itself, and some of the related kdecore classes should take care
of the common cases, so usually there's no need for any special handling
in applications. Qt/KDE applications, that is. Applications using other
toolkits should in most cases work fine too. If they don't support
the window property _NET_WM_USER_TIME, the window manager may fail to detect
the user timestamp properly, resulting either in other windows becoming active
while the user works with this application, or this application may sometimes
steal focus (this second case should be very rare though).

 There are also cases where KDE applications needs special handling. The two
most common cases are when windows relations are not setup properly to make
KWin realize that they belong to the same application, and when the user
activity is not represented by manipulating with the application windows
themselves.

 Also note that focus stealing prevention implemented in the window manager
can only help with focus stealing between different applications.
If an application itself suddenly pops up a dialog, KWin cannot do anything about
it, and its the application's job to handle this case.


Window relations:
-----------------

 The common case here is when a dialog is shown for an application, but this
dialog is not provided by the application itself, but by some other process.
For example, dialogs with warnings about accepted cookies are provided
by KCookieJar, instead of being shown by Konqueror. In the normal case,
from KWin's point of view the cookie dialog would be an attempt of another
application to show a dialog, and KWin wouldn't allow activation of this
window.

 The solution is to tell the window manager about the relation between
the Konqueror main window and the cookie dialog, by making the dialog
point to the mainwindow. Note that this is not special to focus stealing
prevention, subwindows such as dialogs, toolbars and similar should always
point to their mainwindow. See the section on window relations for full
description.

 The WM_TRANSIENT_FOR property that's set on dialogs to point to their
mainwindow should in the cookie dialog case point to the Konqueror window
for which it has been shown. This is solved in kcookiejar by including
the window id in the DCOP call. When the cookie dialog is shown, its
WM_TRANSIENT_FOR property is manually set using the XSetTransientForHint()
call (see kdelibs/kioslave/http/kcookiejar/kcookiewin.cpp). The arguments
to XSetTransientForHint() call are the X display (i.e. QX11Info::display()),
the window id on which the WM_TRANSIENT_FOR property is to be set
(i.e. use QWidget::winId()), and the window id of the mainwindow.


  Simple short HOWTO:
  
 To put it simply: Let's say you have a daemon application that has
DCOP call "showDialog( QString text )", and when this is called, it shows
a dialog with the given text. This won't work properly with focus stealing
prevention. The DCOP call should be changed to
"showDialog( QString text, long id )". The caller should pass something like
myMainWindow->winId() as the second argument. In the daemon, before
the dialog is shown, a call to XSetTransientHint() should be added:

 XSetTransientForHint( QX11Info::display(), dialog->winId(), id_of_mainwindow );
 
 That's it.

Non-standard user activity:
---------------------------

 The most common case in KDE will be DCOP calls. For example, KDesktop's DCOP
call "KDesktopIface popupExecuteCommand". Executing this DCOP call e.g.
from Konsole as 'dcop kdesktop KDesktopIface popupExecuteCommand" will lead
to showing the minicli, but the last user activity timestamp gained from events
sent by X server will be older than user activity timestamp of Konsole, and
would normally result in minicli not being active. Therefore, before showing
the minicli, kdesktop needs to call KApplication::updateUserTimestamp().

 However, this shouldn't be done with all DCOP calls. If a DCOP call is not
a result of direct user action, calling KApplication::updateUserTimestamp()
would lead to focus stealing. For example, let's assume for a moment
that KMail would use this DCOP call in case it detects the modem is not
connected, allowing to you to start KPPP or whatever tool you use. If KMail
would be configured to check mail every 10 minutes, this would lead to minicli
possibly suddenly showing up at every check. Basically, doing the above change
to kdesktop's minicli means that the popupExecuteCommand() DCOP call is only
for user scripting. (TODO write about focus transferring?)

 Simply said, KApplication::updateUserTimestamp() should be called only
as a result of user action. Unfortunately, I'm not aware of any universal
way how to handle this, so every case will have to be considered separately.