yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration
History
Vlad Zahorodnii 9d4a32596c Drop some custom list typedefs 
Summary:
Qt has its own thing where a type might also have corresponding list
alias, e.g. QObject and QObjectList, QWidget and QWidgetList. I don't
know why Qt does that, maybe for some historical reasons, but what
matters is that we copy this pattern here in KWin. While this pattern
might be useful with some long list types, for example

    QList<QWeakPointer<TabBoxClient>> TabBoxClientList

in general, it causes more harm than good. For example, we've got two
new client types, do we need corresponding list typedefs for them? If
no, why do we have ClientList and so on?

Another problem with these typedefs is that you need to include utils.h
header in order to use them. A better way to handle such things is to
just forward declare a client class (if that's possible) and use it
directly with QList or QVector. This way translation units don't get
"bloated" with utils.h stuff for no apparent reason.

So, in order to make code more consistent and easier to follow, this
change drops some of our custom typedefs. Namely ConstClientList,
ClientList, DeletedList, UnmanagedList, ToplevelList, and GroupList.

Test Plan: Compiles.

Reviewers: #kwin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24950
2019-11-27 15:54:08 +02:00
..
data Add support for desktopFileName provided by NETWinInfo 2016-10-31 13:19:46 +01:00
effects Use URL with transport encryption 2019-11-26 19:39:20 +02:00
fakes Update my last name 2019-09-29 17:03:25 +03:00
helper Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
scripting Merge branch 'Plasma/5.17' 2019-10-25 17:50:13 +03:00
activation_test.cpp Drop some custom list typedefs 2019-11-27 15:54:08 +02:00
activities_test.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
buffer_size_change_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
CMakeLists.txt Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
colorcorrect_nightcolor_test.cpp [autotests] Fix failing autotests 2019-08-28 19:20:50 +03:00
dbus_interface_test.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
debug_console_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
decoration_input_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
desktop_window_x11_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
dont_crash_aurorae_destroy_deco.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
dont_crash_cancel_animation.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
dont_crash_cursor_physical_size_empty.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
dont_crash_empty_deco.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
dont_crash_glxgears.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
dont_crash_no_border.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
dont_crash_reinitialize_compositor.cpp Update my last name 2019-09-29 17:03:25 +03:00
dont_crash_useractions_menu.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
generic_scene_opengl_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
generic_scene_opengl_test.h [autotests] Test creating core context profile 2017-06-25 09:48:46 +02:00
globalshortcuts_test.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
idle_inhibition_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
input_stacking_order.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
internal_window.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
keyboard_layout_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
keymap_creation_failure_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
kwin_wayland_test.cpp Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
kwin_wayland_test.h Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
kwinbindings_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
lockscreen.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
maximize_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
modifier_only_shortcut_test.cpp Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
move_resize_window_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
no_global_shortcuts_test.cpp Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
no_xdg_runtime_dir_test.cpp Handle situation of no XDG_RUNTIME_DIR gracefully 2016-07-13 10:00:46 +02:00
placement_test.cpp [wayland] Make sure fullscreen windows aren't repositioned 2019-10-11 10:46:43 +02:00
plasma_surface_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
plasmawindow_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
platformcursor.cpp Handle situation of no XDG_RUNTIME_DIR gracefully 2016-07-13 10:00:46 +02:00
pointer_constraints_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
pointer_input.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
quick_tiling_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
scene_opengl_es_test.cpp [autotests] Introduce a SceneOpenGL ES test 2017-06-24 21:05:49 +02:00
scene_opengl_shadow_test.cpp Update my last name 2019-09-29 17:03:25 +03:00
scene_opengl_test.cpp [autotests] Introduce a SceneOpenGL ES test 2017-06-24 21:05:49 +02:00
scene_qpainter_shadow_test.cpp Update my last name 2019-09-29 17:03:25 +03:00
scene_qpainter_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
screen_changes_test.cpp Add XDG Output support 2018-05-18 14:16:13 +01:00
screenedge_client_show_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
shade_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
showing_desktop_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
stacking_order_test.cpp Drop some custom list typedefs 2019-11-27 15:54:08 +02:00
struts_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
tabbox_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
test_helpers.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
touch_input_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
transient_placement.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
virtual_desktop_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00
window_rules_test.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
window_selection_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
x11_client_test.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
xdgshellclient_rules_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
xdgshellclient_test.cpp [wayland] Implement window geometry more properly 2019-11-27 14:12:30 +02:00
xwayland_input_test.cpp Rename geometry property to frameGeometry 2019-10-02 11:46:37 +03:00
xwayland_selections_test.cpp Rename ShellClient to XdgShellClient 2019-09-23 17:28:56 +03:00