My KWIN fork where I work on features like per-output virtual desktops
Find a file
Roman Gilg b0d1689722 Remove Client fullscreen hack
Summary:
This hack seems to be deactivated by default nowadays and I did not find an
option in the KCMs to activate it. Git blame shows some last commits from
around 2012 to the functions, but they only deal with code style.

Also even if it would be enabled, in light of Wayland we don't want some
roque XWayland client go bonkers via this hack.

This patch removes the code path in order to decrease complexity and ease
future changes to the fullscreen handling overall.

Test Plan: Manually and autotests pass.

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: zzag, graesslin, kwin

Tags: #kwin

Maniphest Tasks: T11098

Differential Revision: https://phabricator.kde.org/D18157
2019-07-09 10:41:51 +02:00
autotests Partly remove Compositor restart functionality 2019-07-04 15:31:40 +02:00
cmake/modules Update URLs to use https 2019-03-25 19:26:23 +01:00
colorcorrection Backport Night Color feature to X11 2019-06-17 12:09:04 +03:00
data Use new logging category directory when ECM>=5.59 2019-06-13 13:31:51 +02:00
decorations [autotests] Fix decoration input test 2019-06-07 14:48:45 +02:00
doc Update URLs to use https 2019-03-25 19:26:23 +01:00
effects Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
helpers Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
kcmkwin Hide some of kwin kcm on mobile 2019-07-09 12:30:59 +05:30
kconf_update kconfig_update for auto border size introduction 2019-06-06 22:27:00 +02:00
libinput Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
libkwineffects Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
platformsupport [platformsupport] Minor code style and class variables access changes 2019-06-27 15:22:40 +02:00
plugins Remove composite reset timer 2019-07-04 19:15:36 +02:00
qml fix virtual keyboard on Plasma Mobile 2018-12-10 16:50:06 +01:00
scripting [scripting] Emit clientAdded for Wayland clients 2019-05-24 00:27:32 +03:00
scripts [scripts] Drop enforcedeco script 2019-06-29 01:21:42 +03:00
tabbox [tabbox] Properly determine depressed modifiers on X11 2019-06-30 15:46:18 +03:00
tests Use locked cursor position hint 2018-07-27 17:19:33 +02:00
xwl [xwl] Fix coding style issues 2019-07-03 00:54:55 +03:00
.arcconfig
.arclint Add .arclint 2018-10-02 19:44:07 +03:00
abstract_client.cpp Keep internal clients in the unmanaged layer 2019-05-17 11:45:19 +03:00
abstract_client.h Split up fullscreen able check into AbstractClient subclasses 2019-07-06 16:00:32 +02:00
abstract_opengl_context_attribute_builder.cpp Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
abstract_opengl_context_attribute_builder.h Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
abstract_output.cpp Overhaul AbstractOutput 2019-06-17 16:34:38 +03:00
abstract_output.h Overhaul AbstractOutput 2019-06-17 16:34:38 +03:00
abstract_wayland_output.cpp Fix xdg-output creation 2019-06-14 12:10:28 +02:00
abstract_wayland_output.h [platforms/x11/standalone] Port to AbstractOutput 2019-06-13 11:39:25 +02:00
activation.cpp Support NET_WM_STATE_FOCUSED 2019-05-10 15:32:55 +01:00
activities.cpp
activities.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
appmenu.cpp Don't try to open application menu when client doesn't have one 2018-04-23 15:42:02 +02:00
appmenu.h Fix minor EBN issues 2018-08-29 21:02:16 +03:00
atoms.cpp [xwl] text/x-uri converter for selected X url list format targets 2019-02-19 13:17:08 +01:00
atoms.h [xwl] text/x-uri converter for selected X url list format targets 2019-02-19 13:17:08 +01:00
client.cpp Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
client.h Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
client_machine.cpp
client_machine.h
CMakeLists.txt Update version number for 5.16.2 2019-06-25 12:15:02 +01:00
composite.cpp Save Compositor state in single variable 2019-07-04 22:52:05 +02:00
composite.h Save Compositor state in single variable 2019-07-04 22:52:05 +02:00
config-kwin.h.cmake [platforms/drm] EGLStream DRM Backend Initial Implementation 2019-04-15 07:26:22 -07:00
COPYING
cursor.cpp Drop XFixes include in cursor.cpp 2019-01-09 22:29:45 +02:00
cursor.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
dbusinterface.cpp Partly remove Compositor restart functionality 2019-07-04 15:31:40 +02:00
dbusinterface.h Use new slot syntax in Compositor class 2019-07-04 14:22:04 +02:00
debug_console.cpp Support CriticalNotification type and place it in a CriticalNotificationLayer 2019-05-02 10:29:38 +02:00
debug_console.h
debug_console.ui fixuifiles 2018-09-18 07:52:44 +02:00
deleted.cpp [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
deleted.h [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
effectloader.cpp
effectloader.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
effects.cpp Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
effects.h Support CriticalNotification type and place it in a CriticalNotificationLayer 2019-05-02 10:29:38 +02:00
egl_context_attribute_builder.cpp Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
egl_context_attribute_builder.h
events.cpp Correct code style of Client fullscreen control 2019-07-08 12:51:57 +02:00
fixqopengl.h Fix the build on armhf/aarch64 2018-03-06 09:25:33 +05:30
focuschain.cpp Use explicit Chain type in the focus chain 2018-07-30 11:23:43 +03:00
focuschain.h Use explicit Chain type in the focus chain 2018-07-30 11:23:43 +03:00
geometry.cpp Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
geometrytip.cpp
geometrytip.h
gestures.cpp
gestures.h Fix minor Doxygen issues 2019-01-12 12:31:32 +02:00
globalshortcuts.cpp Don't try to filter null key combinations 2018-04-24 16:35:23 +02:00
globalshortcuts.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
group.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
group.h
HACKING.md Introduce a new HACKING.md document to replace the previous HACKING 2018-12-17 18:11:59 +01:00
idle_inhibition.cpp Use appropriate sequence algorithms in IdleInhibition 2019-01-11 15:28:28 +02:00
idle_inhibition.h Use appropriate sequence algorithms in IdleInhibition 2019-01-11 15:28:28 +02:00
input.cpp Implement the keystate protocol 2019-06-22 12:34:06 +02:00
input.h Delayed focus updates for Toplevels without surface 2019-06-06 23:34:49 +02:00
input_event.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event.h Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event_spy.cpp
input_event_spy.h
internal_client.cpp Drop QOffscreenSurface guard 2019-07-01 22:34:41 +03:00
internal_client.h [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
keyboard_input.cpp Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
keyboard_input.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
keyboard_layout.cpp Make the Keyboard Layout SNI passive 2019-04-09 23:38:52 +02:00
keyboard_layout.h
keyboard_layout_switching.cpp
keyboard_layout_switching.h
keyboard_repeat.cpp
keyboard_repeat.h
killwindow.cpp
killwindow.h
kwin.kcfg Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-16 09:09:19 +01:00
kwinbindings.cpp Use new slot syntax in Compositor class 2019-07-04 14:22:04 +02:00
KWinDBusInterfaceConfig.cmake.in
layers.cpp Support CriticalNotification type and place it in a CriticalNotificationLayer 2019-05-02 10:29:38 +02:00
logind.cpp remove superfluous code 2019-01-27 12:05:22 +05:30
logind.h
main.cpp [autotests] Use Xwayland class in WaylandTestApplication 2019-02-19 12:18:33 +01:00
main.h KSelectionOwner usage in ApplicationX11 and Compositor classes 2019-06-27 18:08:12 +02:00
main_wayland.cpp Forward and log exit code of the nested process 2019-05-29 17:00:44 +02:00
main_wayland.h [wayland] Keep application startup flow inside main_wayland 2019-02-23 12:18:09 +00:00
main_x11.cpp KSelectionOwner usage in ApplicationX11 and Compositor classes 2019-06-27 18:08:12 +02:00
main_x11.h KSelectionOwner usage in ApplicationX11 and Compositor classes 2019-06-27 18:08:12 +02:00
Mainpage.dox
manage.cpp Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
Messages.sh Fix untranslatable strings in debug_console.ui shortcutdialog.ui 2018-09-17 11:39:47 +02:00
modifier_only_shortcuts.cpp
modifier_only_shortcuts.h
moving_client_x11_filter.cpp Use more accurate name for Workspace::getMovingClient method 2019-04-22 11:12:22 +03:00
moving_client_x11_filter.h
netinfo.cpp Support NET_WM_STATE_FOCUSED 2019-05-10 15:32:55 +01:00
netinfo.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
onscreennotification.cpp
onscreennotification.h
options.cpp Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
options.h Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
org.kde.kappmenu.xml
org.kde.kwin.ColorCorrect.xml
org.kde.kwin.Compositing.xml
org.kde.kwin.Effects.xml
org.kde.kwin.OrientationSensor.xml
org.kde.KWin.VirtualDesktopManager.xml [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
org.kde.KWin.xml Add a dbus method getWindowInfo returning same data as queryWindowInfo 2018-12-17 18:12:17 +01:00
orientation_sensor.cpp Initialise the orientation sensor at start 2019-04-23 14:46:23 +02:00
orientation_sensor.h Initialise the orientation sensor at start 2019-04-23 14:46:23 +02:00
osd.cpp
osd.h
outline.cpp [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
outline.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
outputscreens.cpp Refactor getters in OutputScreens 2019-04-25 11:12:25 +03:00
outputscreens.h Refactor getters in OutputScreens 2019-04-25 11:12:25 +03:00
overlaywindow.cpp
overlaywindow.h
placement.cpp [placement] Avoid smart placement strategy with invalid client sizes 2019-06-24 22:59:21 +02:00
placement.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
platform.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
platform.h Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
pointer_input.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
pointer_input.h Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
popup_input_filter.cpp
popup_input_filter.h
README.md Add a new markdown README 2018-12-22 08:42:38 +01:00
rootinfo_filter.cpp
rootinfo_filter.h
rules.cpp Make sure we don't resize clients before they've been set up 2019-06-23 19:59:19 +02:00
rules.h Port away from deprecated qFind 2019-05-15 11:03:29 +03:00
scene.cpp Verify that there is no scene windows when Scene is about to be destroyed 2019-03-05 15:19:19 +02:00
scene.h Add addToplevel and removeToplevel to Scene 2019-02-14 14:43:11 +02:00
screenedge.cpp Fix corner screen glows that suddenly pop up 2019-04-23 23:57:13 +03:00
screenedge.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
screenlockerwatcher.cpp Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
screenlockerwatcher.h Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
screens.cpp Remove BasicScreens class 2019-06-14 14:22:29 +02:00
screens.h Remove BasicScreens class 2019-06-14 14:22:29 +02:00
settings.kcfgc
shadow.cpp Avoid crash without XWayland 2019-06-23 17:58:49 +02:00
shadow.h Update URLs to use https 2019-03-25 19:26:23 +01:00
shell_client.cpp Rework ShellClient fullscreen control 2019-07-08 12:44:13 +02:00
shell_client.h Split up fullscreen able check into AbstractClient subclasses 2019-07-06 16:00:32 +02:00
shortcutdialog.ui
sm.cpp Make session loading/saving helpers local to sm.cpp 2019-05-03 21:24:07 +03:00
sm.h
tabgroup.cpp Port TabGroup from Client to AbstractClient 2018-05-20 19:50:29 +02:00
tabgroup.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
tabletmodemanager.cpp Make it possible to autodetect the tablet mode 2019-03-22 18:29:21 +01:00
tabletmodemanager.h Make it possible to autodetect the tablet mode 2019-03-22 18:29:21 +01:00
TESTING.md [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
thumbnailitem.cpp Remove Compositor created check 2019-07-04 20:18:28 +02:00
thumbnailitem.h Switch ThumbnailItem to internal uuid instead of WId 2019-01-27 09:52:15 +01:00
toplevel.cpp Move non-Compositor functions out of composite.cpp source file 2019-06-22 12:02:54 +02:00
toplevel.h Pedantic whitespace additions 2019-07-03 19:56:36 +03:00
touch_hide_cursor_spy.cpp Hide mouse cursor when interacting with touch screen 2018-12-13 18:55:46 +01:00
touch_hide_cursor_spy.h Hide mouse cursor when interacting with touch screen 2018-12-13 18:55:46 +01:00
touch_input.cpp Leave decoration on touch up only once 2018-12-13 11:06:08 +01:00
touch_input.h Unset touch targets on no current touch points 2018-12-13 10:59:07 +01:00
udev.cpp [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
udev.h [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
unmanaged.cpp Move Unmanaged-specific hack away from Toplevel::setupCompositing 2019-04-16 10:12:30 +03:00
unmanaged.h Move Unmanaged-specific hack away from Toplevel::setupCompositing 2019-04-16 10:12:30 +03:00
useractions.cpp Use more accurate name for Workspace::getMovingClient method 2019-04-22 11:12:22 +03:00
useractions.h [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
utils.cpp Make it easier to debug the virtualkeyboard 2018-12-10 16:28:13 +05:30
utils.h Support CriticalNotification type and place it in a CriticalNotificationLayer 2019-05-02 10:29:38 +02:00
virtual_terminal.cpp
virtual_terminal.h
virtualdesktops.cpp Send done event after the number of rows has been changed 2019-01-25 14:07:07 +02:00
virtualdesktops.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
virtualdesktopsdbustypes.cpp [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualdesktopsdbustypes.h [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualkeyboard.cpp Fix crash on closing 2019-03-20 17:35:14 +01:00
virtualkeyboard.h virtualkeyboard: resize the focused window to make room for the keyboard 2019-03-20 11:05:06 +01:00
virtualkeyboard_dbus.cpp
virtualkeyboard_dbus.h
was_user_interaction_x11_filter.cpp
was_user_interaction_x11_filter.h
wayland_cursor_theme.cpp Load Kwin's internal cursors for the highest resolution of attached monitors 2018-06-23 23:26:54 +01:00
wayland_cursor_theme.h Set specific edge cursor shape when resizing 2018-06-11 10:05:07 +01:00
wayland_server.cpp Implement the keystate protocol 2019-06-22 12:34:06 +02:00
wayland_server.h Implement the keystate protocol 2019-06-22 12:34:06 +02:00
window_property_notify_x11_filter.cpp Clean up includes 2018-08-31 22:58:11 +03:00
window_property_notify_x11_filter.h
workspace.cpp Use new slot syntax in Compositor class 2019-07-04 14:22:04 +02:00
workspace.h Remove unused signal from Workspace 2019-07-02 13:47:08 +02:00
x11eventfilter.cpp
x11eventfilter.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
xcbutils.cpp Don't call << in a temporary vector 2019-07-08 21:05:25 +02:00
xcbutils.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
xkb.cpp Support enabling numlock on startup 2018-11-01 17:49:58 +01:00
xkb.h Support enabling numlock on startup 2018-11-01 17:49:58 +01:00
xkb_qt_mapping.h

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contacting KWin development team

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Developing on KWin

Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.