yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/effects
History
Vlad Zagorodniy e9ab34854d [effects] Ignore previous state of WindowForceBlurRole 
Summary:
Currently, effects like Maximize, Slide Back have problems with setting
WindowForceBlurRole. They store previous state of WindowForceBlurRole.
This is wrong. Instead they should either ignore previous state of
WindowForceBlur or refcount forced role.

There's no need for refcounting right now. For example, if several effects
force blur or background contrast, they are most likely in a conflict.
Please notice that the Desktop Grid effect uses the Present Windows
effect only to calculate transformations.

Some other problems with the code that sets WindowForceBlurRole:
* Maximize effect stores previous state of WindowForceBlurRole only
  for one window. It ignores the fact that there could be several
  active maximize animations;
* Desktop Grid/Present Windows/Slide back don't clean after themselves.
  So, after using those effects for good amount of times, memory usage
  will bump.

Test Plan:
* Enabled blur for Konsole
* Maximized Konsole
* Activated Present Windows
* Activated Desktop Grid
* Raised another window(to trigger Slide Back)

Reviewers: #kwin, fredrik

Reviewed By: fredrik

Subscribers: fredrik, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13479
2018-06-19 15:23:41 +03:00
..
backgroundcontrast [effects/backgroundcontrast] Calculate correct y-coord of the copy rect 2018-05-17 02:51:50 -07:00
blur [effects/blur] Clean up shader code 2018-06-18 15:50:52 +03:00
colorpicker Scaling support in ColorPicker effect 2017-04-28 10:23:13 +01:00
coverswitch SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
cube [effects/cube] Fix animation and reflection issues 2018-06-01 18:32:27 +03:00
desktopgrid [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
dialogparent SVN_SILENT made messages (.desktop file) - always resolve ours 2017-03-25 06:02:34 +01:00
diminactive SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
dimscreen [effects/dimscreen] Use QSet for checking whether activated window asks for permissions 2018-06-09 12:27:52 +03:00
eyeonscreen SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
fade SVN_SILENT made messages (.desktop file) - always resolve ours 2017-06-04 05:39:14 +02:00
fadedesktop SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
fallapart [effects/fallapart] Fade out window parts 2018-06-14 16:38:12 +03:00
flipswitch SVN_SILENT made messages (.desktop file) - always resolve ours 2018-02-12 07:04:02 +01:00
frozenapp SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
glide [effects/glide] Do not animate logout screen 2018-06-01 19:15:26 +03:00
highlightwindow [effects] Support xcbConnectionChanged for support properties 2017-09-12 18:53:31 +02:00
invert SVN_SILENT made messages (.desktop file) - always resolve ours 2018-02-12 07:04:02 +01:00
kscreen [KScreen Effect] Fix fade to black 2018-04-26 11:15:38 +02:00
login SVN_SILENT made messages (.desktop file) - always resolve ours 2018-05-18 05:45:28 +02:00
logout SVN_SILENT made messages (.desktop file) - always resolve ours 2018-02-12 07:04:02 +01:00
lookingglass [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
magiclamp [effects/magiclamp] Don't reset timeline 2018-04-20 21:10:47 +03:00
magnifier [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
maximize [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
minimizeanimation Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
morphingpopups SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
mouseclick SVN_SILENT made messages (.desktop file) - always resolve ours 2017-12-25 04:44:28 +01:00
mousemark SVN_SILENT made messages (.desktop file) - always resolve ours 2017-12-25 04:44:28 +01:00
presentwindows [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
resize Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
scalein SVN_SILENT made messages (.desktop file) - always resolve ours 2017-04-16 04:05:25 +02:00
screenedge [ScreenEdgeEffect] Create glow Svg on demand 2017-09-28 10:18:36 +02:00
screenshot Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
sheet [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
showfps Fix build with a KWindowSystem framework that doesn't pull QWidget 2017-11-17 17:30:58 +01:00
showpaint [effects] Use shader traits in ShowPaint effect 2016-01-25 14:11:54 +01:00
slide [effects/slide] Add "Slide desktop background" option 2018-06-19 12:35:53 +03:00
slideback [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
slidingpopups Correctly check forcebackgroundcontrastrule 2018-06-11 10:44:05 +01:00
snaphelper [effects] Use shader traits in SnapHelper effect 2016-01-25 14:11:54 +01:00
startupfeedback Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
thumbnailaside [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
touchpoints Fix unused-parameter warnings as reported by GCC 2017-07-28 21:31:09 +02:00
trackmouse SVN_SILENT made messages (.desktop file) - always resolve ours 2017-12-25 04:44:28 +01:00
translucency SVN_SILENT made messages (.desktop file) - always resolve ours 2017-08-10 04:56:42 +02:00
windowaperture SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
windowgeometry SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
wobblywindows SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 05:35:02 +02:00
zoom Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
CMakeLists.txt [effects/slide] Add 'Duration' option 2018-01-01 16:54:02 +02:00
effect_builtins.cpp [effects] Use more effectData() in BuiltInEffects 2018-06-18 16:28:57 +03:00
effect_builtins.h [effects] Add a colorpicker effect 2016-11-25 09:30:34 +01:00
kwineffect.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2017-03-25 06:02:34 +01:00
logging.cpp pedantic fixes 2016-07-16 13:14:44 -04:00
Messages.sh Remove temporary file 2008-07-02 07:04:51 +00:00
shaders.qrc Removed the "fastblur" path 2018-02-03 19:04:11 +01:00