Commit graph

164 commits

Author SHA1 Message Date
Lucas Murray
5821e6f9d7 Reverted all code relating to automatic X crash detection with agreement
from David. Due to an elusive bug somewhere in kdelibs we have not been
able to find out how to fix the issues that some people were having.
There seems to be a race condition as I cannot reproduce at all, David
can reproduce sporadically and some reporters can always reproduce.

This commit attempts to also keep the code style changes that were made
at the same time as the original commit as well as some minor bug fixes
that were made between then and now. Hopefully I didn't miss anything.

We will be revisit this in KDE 4.3.

BUG: 177178

svn path=/trunk/KDE/kdebase/workspace/; revision=894182
2008-12-08 05:08:31 +00:00
David Nadlinger
21f64ffffe kcmkwincompositing: Brought back a slot which I recently removed because it was seemingly unneeded (at least nobody could tell why it was there in the first place).
I don't expect this to fix the plugin selection bug, but it could aid in tracking the issue down.

svn path=/trunk/KDE/kdebase/workspace/; revision=893015
2008-12-05 18:41:24 +00:00
David Nadlinger
81966b29e9 Removed now unneeded temporary config workaround from kcmkwincompositing.
If there appears any new, possibly related bug, be quick to suspect this commit, because it is not really tested, but should help to track the plugin selection bug down.

svn path=/trunk/KDE/kdebase/workspace/; revision=893010
2008-12-05 18:13:42 +00:00
Lucas Murray
01d167d463 Reverted part of r890193 as it didn't fix the problem.
svn path=/trunk/KDE/kdebase/workspace/; revision=890200
2008-11-28 15:23:28 +00:00
Lucas Murray
eca9561ab7 Possible fix for corrupting KWin settings on some systems.
Also fixed setting revert message to only display when actually
reverting.

svn path=/trunk/KDE/kdebase/workspace/; revision=890193
2008-11-28 14:57:22 +00:00
Lucas Murray
141dae20ed Reload decorations when enabling or disabling compositing as well.
svn path=/trunk/KDE/kdebase/workspace/; revision=890055
2008-11-28 12:34:41 +00:00
Lucas Murray
7c0628f337 Reload decorations when any shadow-related settings are changed.
svn path=/trunk/KDE/kdebase/workspace/; revision=888747
2008-11-25 10:06:44 +00:00
David Nadlinger
5f835b7c31 Modified a few comments; changed indenting to comply with the KWin coding standards.
svn path=/trunk/KDE/kdebase/workspace/; revision=888660
2008-11-25 01:45:09 +00:00
David Nadlinger
d79ef83183 When modifying the compositing settings, save a backup of kwinrc to another file to be able to revert if the X server crashes while testing the new config.
Also fixed a little bug in kcmkwincompositing (dropdowns on the general tab were not updated correctly) and cleaned up the code a bit (removed a few unneeded function calls and stale connects).

See the conversation on the mailing list ("Patch for bug 174769", http://lists.kde.org/?l=kwin&m=122696916611602) for further information.

BUG 174769


svn path=/trunk/KDE/kdebase/workspace/; revision=888659
2008-11-25 01:42:30 +00:00
Stephan Binner
7929582374 i18n style guide fixes
svn path=/trunk/KDE/kdebase/workspace/; revision=885677
2008-11-17 18:35:18 +00:00
Lucas Murray
b0ed226d94 Fixed hideen previews and smooth scaling advanced options not triggering
a compositing reinitialization when changed.

svn path=/trunk/KDE/kdebase/workspace/; revision=884221
2008-11-14 13:18:03 +00:00
Lucas Murray
ff8c9c2468 SVN_SILENT Disable the advanced tab when desktop effects are disabled.
svn path=/trunk/KDE/kdebase/workspace/; revision=884200
2008-11-14 12:46:11 +00:00
Lucas Murray
2cfcdf66f7 Moved desktop effect advanced options GUI from a dialog into a tab.
svn path=/trunk/KDE/kdebase/workspace/; revision=884186
2008-11-14 12:36:59 +00:00
Lucas Murray
a3f7f13f70 Cleaned up desktop effect GUI, moved screen edges to a separate tab.
svn path=/trunk/KDE/kdebase/workspace/; revision=884135
2008-11-14 11:53:25 +00:00
Martin Gräßlin
585addb450 Add a widget to assign an effect to screen edges in the kwincompositing dialog.
Remove the previous configuration for assigning screen edges from the config dialogs of the single effects.

svn path=/trunk/KDE/kdebase/workspace/; revision=880728
2008-11-06 10:42:36 +00:00
Enrique Matías Sánchez
f5efd9ca28 SVN_SILENT Fix typos in kdebase
svn path=/trunk/KDE/kdebase/workspace/; revision=875089
2008-10-23 09:31:44 +00:00
Davide Bettio
ae957480a0 usability++
see "kwin's KCM usability" mail.

svn path=/trunk/KDE/kdebase/workspace/; revision=871309
2008-10-14 13:23:50 +00:00
Luboš Luňák
1d2c54edcc Support for proper effect reconfiguration instead of reloading them.
Fixes e.g. the global animation combo not taking effect.


svn path=/trunk/KDE/kdebase/workspace/; revision=866903
2008-10-02 09:27:32 +00:00
Luboš Luňák
0ca1edbfe8 Read default values from .desktop files when finding out whether an effect is enabled,
otherwise the effect-for-alt+tab combo resets to no effect when the dialog is used the first time.


svn path=/trunk/KDE/kdebase/workspace/; revision=866648
2008-10-01 15:21:21 +00:00
Lucas Murray
a3e834fb99 Reorganized effect categories.
svn path=/trunk/KDE/kdebase/workspace/; revision=861851
2008-09-17 10:36:28 +00:00
Luboš Luňák
2a87593638 Add a global configuration option for animation speed. See description
of Effect::animationTime() for how-to-use.
TODO: Effects need to reload config after doing the change in the kcm.
NOTE: Default TimeLine constructor now creates invalid object, it is
necessary to explicitly call setDuration() in order to ensure all
animations respect this setting.

CCMAIL: kwin@kde.org


svn path=/trunk/KDE/kdebase/workspace/; revision=854690
2008-08-30 07:25:54 +00:00
Luboš Luňák
3528630f80 Qt4/KDE4 dialog ctors don't accept object name or modal flag.
svn path=/trunk/KDE/kdebase/workspace/; revision=854326
2008-08-29 12:03:12 +00:00
Martin Gräßlin
e197a53ca9 Easy to use config options to select the effect for window switching (alt+tab) and for desktop switching. So now more searching through all effects to enable one effect and disable the conflicting effects.
svn path=/trunk/KDE/kdebase/workspace/; revision=852627
2008-08-26 07:31:57 +00:00
Luboš Luňák
49660876c1 When confirming compositing in the configuration module,
wait for KWin to initialize it and report if it fails.
FEATURE: 161900


svn path=/trunk/KDE/kdebase/workspace/; revision=847403
2008-08-15 11:09:07 +00:00
Luboš Luňák
b099f15cee Fix last commit.
svn path=/trunk/KDE/kdebase/workspace/; revision=842502
2008-08-05 12:41:31 +00:00
Luboš Luňák
45c3b4dc0c Tracking mouse is no window management.
svn path=/trunk/KDE/kdebase/workspace/; revision=842489
2008-08-05 12:01:57 +00:00
Sebastian Sauer
6792f27535 switch to general tab before setting defauls else the defaults are not set.
svn path=/trunk/KDE/kdebase/workspace/; revision=835329
2008-07-20 12:59:23 +00:00
Sebastian Sauer
70c0a1a3c7 don't switch changed-state by just switching tabs
svn path=/trunk/KDE/kdebase/workspace/; revision=835311
2008-07-20 12:38:33 +00:00
Lucas Murray
1d6da823a0 Corrected number of default effects. Can someone please backport this.
BUG: 166720
CCMAIL: kwin@kde.org

svn path=/trunk/KDE/kdebase/workspace/; revision=833261
2008-07-16 15:00:53 +00:00
Sebastian Kügler
a822eadc64 Enable the mouse tracking plugin by default.
svn path=/trunk/KDE/kdebase/workspace/; revision=829757
2008-07-09 02:27:07 +00:00
Luboš Luňák
a59f0a7f5e Revert r768755. There apparently is a need to have two calls.
The wonders of dbus ...


svn path=/trunk/KDE/kdebase/workspace/; revision=768770
2008-01-30 16:08:23 +00:00
Luboš Luňák
47bf19d978 There's really no need to have two dbus functions for reconfiguring.
svn path=/trunk/KDE/kdebase/workspace/; revision=768755
2008-01-30 15:31:44 +00:00
Thomas Zander
4b32f3820b Better fix
svn path=/trunk/KDE/kdebase/workspace/; revision=754680
2007-12-30 14:34:04 +00:00
Thomas Zander
72ea36acce Fix problem(s) that the revert to previous config didn't actually work
for the items on the global tab. So enabling compositing made the whole
screen black for me with no way out.

svn path=/trunk/KDE/kdebase/workspace/; revision=754669
2007-12-30 14:07:38 +00:00
Aurélien Gâteau
35eff66c1f One less double margin.
svn path=/trunk/KDE/kdebase/workspace/; revision=749474
2007-12-17 08:26:19 +00:00
Thomas Zander
539275e0df BUG:153554
Make the checkbox a tri-state when not all items it represents were selected

svn path=/trunk/KDE/kdebase/workspace/; revision=746970
2007-12-10 19:04:21 +00:00
Rivo Laks
652713eac9 Sync tabs before saving.
Prevents settings of one tab from overwriting those of another one.

svn path=/trunk/KDE/kdebase/workspace/; revision=742683
2007-11-28 15:42:40 +00:00
Luboš Luňák
01bf6cbb4c License cleanup - add headers where missing, be explicit about GPL
being v2+ (right now it says just GPL, which according to GPL itself
means any GPL). Decoration clients will come later.
CCMAIL: kwin@kde.org


svn path=/trunk/KDE/kdebase/workspace/; revision=742302
2007-11-27 19:40:25 +00:00
Luboš Luňák
2fd0261c03 i18n messages for effects.
svn path=/trunk/KDE/kdebase/workspace/; revision=736200
2007-11-13 17:29:46 +00:00
Rivo Laks
c4e55307ce Show reason (extensions not available or kwin support disabled at compile time)
when compositing cannot be used.

svn path=/trunk/KDE/kdebase/workspace/; revision=735788
2007-11-12 16:32:25 +00:00
Luboš Luňák
138428a2be There's a slight difference between & and &&.
svn path=/trunk/KDE/kdebase/workspace/; revision=727083
2007-10-19 18:07:52 +00:00
Rivo Laks
6e2967b573 Use KTimerDialog from randr kcm instead of our own dialog.
svn path=/trunk/KDE/kdebase/workspace/; revision=721602
2007-10-05 16:36:17 +00:00
Luboš Luňák
490531046a A confirmation dialog with timeout does not really make that much sense
when turning compositing off.


svn path=/trunk/KDE/kdebase/workspace/; revision=719249
2007-09-30 17:36:59 +00:00
Rivo Laks
5bc7142bff No newline
svn path=/trunk/KDE/kdebase/workspace/; revision=717760
2007-09-27 14:02:55 +00:00
Rivo Laks
c71b5539cf Show a message when compositing isn't supported
svn path=/trunk/KDE/kdebase/workspace/; revision=717750
2007-09-27 13:26:55 +00:00
Rivo Laks
841780d0a7 Check if compositing is supported and disable everything if it isn't
svn path=/trunk/KDE/kdebase/workspace/; revision=717332
2007-09-26 16:35:30 +00:00
Robert Knight
a0f8c2b681 Remove the Cancel button as there are only two ways out of the 'Confirm' situation.
svn path=/trunk/KDE/kdebase/workspace/; revision=715665
2007-09-22 20:35:35 +00:00
Robert Knight
d22dac6661 Change 'Compositing settings' to 'Dekstop effects settings' in the confirmation dialog.
svn path=/trunk/KDE/kdebase/workspace/; revision=715661
2007-09-22 20:19:17 +00:00
Rivo Laks
69058845e6 Add reinitCompositing dbus signal that reinits compositing (reconfigure signal doesn't and
shouldn't cause that) and use it when advanced compositing settings change.

svn path=/trunk/KDE/kdebase/workspace/; revision=714813
2007-09-20 17:19:19 +00:00
Rivo Laks
45aab602ef Actually restart KWin when new config is rejected
svn path=/trunk/KDE/kdebase/workspace/; revision=714811
2007-09-20 17:14:26 +00:00
Rivo Laks
a93826681a Synchronize effect checkboxes with the effect selector widget by using a
temporary config file for communication when active tab changes.

svn path=/trunk/KDE/kdebase/workspace/; revision=714742
2007-09-20 13:21:49 +00:00
Rivo Laks
3074e126e7 Remove debug line
svn path=/trunk/KDE/kdebase/workspace/; revision=714129
2007-09-18 19:53:30 +00:00
Rivo Laks
36d804a0f5 Set focus to No button initially, so enter = revert changes.
I'm not completely sure about this, but it could help to prevent accidential confirms

svn path=/trunk/KDE/kdebase/workspace/; revision=714128
2007-09-18 19:51:54 +00:00
Rivo Laks
5feeb3f483 Add Cancel button to confirmation dialog
svn path=/trunk/KDE/kdebase/workspace/; revision=714125
2007-09-18 19:47:54 +00:00
Rivo Laks
d32b4a3130 Use KDialog instead of QMessageBox for confirmation dialog (can't use KMessageBox)
svn path=/trunk/KDE/kdebase/workspace/; revision=714120
2007-09-18 19:38:57 +00:00
Rivo Laks
d965cdee99 Beginnings of confirmation dialog shown when critical compositing settings
are changed.
When user doesn't click Yes in 10 secs then changes are reverted.

svn path=/trunk/KDE/kdebase/workspace/; revision=714104
2007-09-18 19:00:23 +00:00
Rivo Laks
9f95efdc27 Use CompositingPrefs here as well for default options autodetection
svn path=/trunk/KDE/kdebase/workspace/; revision=714012
2007-09-18 14:32:37 +00:00
Rivo Laks
86831ca7a8 Add Effects tab to the compositing config module.
It contains the list of all effects which has it's separate module ATM.

svn path=/trunk/KDE/kdebase/workspace/; revision=713933
2007-09-18 10:09:07 +00:00
Matthias Kretz
4a629bebe9 port to KPluginFactory
svn path=/trunk/KDE/kdebase/workspace/; revision=705731
2007-08-28 13:01:13 +00:00
Thiago Macieira
d2aee14a35 Remove use of k_funcinfo
svn path=/trunk/KDE/kdebase/workspace/; revision=702583
2007-08-20 21:33:48 +00:00
Laurent Montel
994c800d79 Adapt to new KWarning/kFatal/kDebug api
svn path=/trunk/KDE/kdebase/workspace/; revision=695877
2007-08-03 06:59:24 +00:00
Rivo Laks
0845552315 - Make the effects section even easier to use
- Actually save/load effects config

svn path=/trunk/KDE/kdebase/workspace/; revision=690688
2007-07-21 20:54:50 +00:00
Rivo Laks
887caff1c4 Make compositing config more user friendly by renaming Compositing to Desktop Effects and
putting advanced options into separate dialog.

svn path=/trunk/KDE/kdebase/workspace/; revision=690288
2007-07-20 16:19:09 +00:00
Rivo Laks
824f005f58 Add beginnings of kwincompositing config module, meant to replace kwintranslucency one
svn path=/trunk/KDE/kdebase/workspace/; revision=689947
2007-07-19 16:20:05 +00:00