My KWIN fork where I work on features like per-output virtual desktops
Find a file
Martin Gräßlin 4eadc9daef [auto-tests] Add an initial test for Screens
This is a very interesting auto test as Screens uses both Workspace
and Client. Thus it operates in the "impossible to mock" area.

The solution is to provide mock includes in autotests and ensure that
when building the auto-test the mock header includes will be picked
first. There is now a mock class for Workspace and Client providing
just the API pieces used inside Screens.

As Screens is abstract and we cannot properly interact with
QDesktopWidget there is also a MockScreens class inheriting from Screens
and mocking the required functionality (by just operating on a list of
QRects).

The auto-test itself is only performing checks on the abstract class.
The mock class is indirectly tested by Screens calling into the virtual
methods. The test case is not yet complete, but looking quite good
already.
2014-09-17 10:29:03 +02:00
autotests [auto-tests] Add an initial test for Screens 2014-09-17 10:29:03 +02:00
clients Merge branch 'Plasma/5.0' 2014-09-08 10:07:57 +02:00
cmake/modules Add Findepoxy.cmake 2014-07-14 12:04:37 +02:00
data [data] Rename kwin_update_default_rules to kwin5_update_default_rules 2014-05-07 11:50:22 +02:00
doc rename kcmshell4 to kcmshell5 2014-05-02 17:24:47 +02:00
effects SVN_SILENT made messages (.desktop file) 2014-09-01 09:18:50 +00:00
kcmkwin Fix misaligned combo box in window rules kcm 2014-09-15 16:19:50 +02:00
killer Drop explicit Qt5Widgets_EXECUTABLE_COMPILE_FLAGS 2014-07-12 09:27:36 +02:00
libkdecorations use standard way to version applications in Plasma 2014-08-20 15:43:27 +02:00
libkwineffects Add XRenderUtils::findPictFormat() and findPictFormatInfo() 2014-09-01 17:45:58 +02:00
qml [kwin] Provide composited outline as QML instead of hand drawn FrameSvg 2014-03-10 09:16:16 +01:00
scripting [scripting] Drop qmlRegisterType for QQuickWindow 2014-09-03 09:47:21 +02:00
scripts SVN_SILENT made messages (.desktop file) 2014-09-11 08:46:22 +00:00
shaders
tabbox SVN_SILENT made messages (.desktop file) 2014-09-02 11:19:59 +00:00
tests Fix target dependencies. 2014-08-29 12:49:04 +02:00
wayland_client [kwin_wayland] Initial addition of the WaylandServer module 2014-09-02 09:52:16 +02:00
wayland_server [kwin_wayland] Add assert in Display::setRunning 2014-09-03 20:04:31 +02:00
.reviewboardrc Add reviewboardrc 2014-04-03 10:46:33 +02:00
16-apps-kwin.png Fix installing of icons 2014-06-02 14:56:42 +02:00
32-apps-kwin.png Fix installing of icons 2014-06-02 14:56:42 +02:00
48-apps-kwin.png Fix installing of icons 2014-06-02 14:56:42 +02:00
activation.cpp Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
activities.cpp KWin activities usage ported to the new library paradigm 2014-06-01 18:58:36 +02:00
activities.h KWin activities usage ported to the new library paradigm 2014-06-01 18:58:36 +02:00
appmenu.cpp [kwin] Use std::find_if and lambda functions for Workspace::findClient 2014-03-25 15:17:11 +01:00
appmenu.h [kwin] Generate dbus interface for Appmenu 2014-01-07 14:06:56 +01:00
atoms.cpp Add a script to enforce window decorations for GTK windows 2014-07-03 16:03:22 +02:00
atoms.h Add a script to enforce window decorations for GTK windows 2014-07-03 16:03:22 +02:00
bridge.cpp [kwin] Remove cursorPos() from utils.h 2014-03-25 15:25:40 +01:00
bridge.h Hide the OnAllDesktops button if there is only one virtual desktop 2014-03-05 13:02:32 +01:00
client.cpp Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
client.h Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
client_machine.cpp Use KWindowInfo::clientMachine in ClientMachine::resolve 2014-04-10 15:55:17 +02:00
client_machine.h
CMakeLists.txt Split out WaylandScreens into own header and source file 2014-09-17 09:05:11 +02:00
COMPLIANCE Fix typo in COMPLIANCE file. 2014-06-20 21:27:12 -03:00
composite.cpp Add support for explicit command stream synchronization 2014-09-12 14:50:12 +02:00
composite.h Create dedicated class for CompositorDBusInterface 2014-06-10 10:52:25 +02:00
compositingprefs.cpp [kwin] Fix includes of kde4support headers 2014-03-18 14:34:36 +01:00
compositingprefs.h [kwin] Drop testapp for detecting whether direct rendering works on glx 2013-11-05 14:48:40 +01:00
config-kwin.h.cmake use standard way to version applications in Plasma 2014-08-20 15:43:27 +02:00
CONFIGURING
COPYING Put licence files on each repo, removing from root. 2014-03-26 19:01:09 +01:00
COPYING.DOC Put licence files on each repo, removing from root. 2014-03-26 19:01:09 +01:00
cursor.cpp Port XQueryPointer usage to XCB 2014-05-05 08:09:09 +02:00
cursor.h InputRedirection emits a signal when the modifiers change 2014-03-19 14:14:56 +01:00
dbusinterface.cpp Create dedicated class for CompositorDBusInterface 2014-06-10 10:52:25 +02:00
dbusinterface.h Create dedicated class for CompositorDBusInterface 2014-06-10 10:52:25 +02:00
decorations.cpp Properly remove KWIN_BUILD_OXYGEN 2014-03-31 13:20:39 +02:00
decorations.h Introduce a compositingChanged signal in KDecorationOptions 2013-09-12 09:27:38 +02:00
deleted.cpp Adjust kde-workspace to introduction of flags in NET classes 2014-02-05 17:40:19 +01:00
deleted.h Toplevel::frameId() becomes virtual 2013-09-10 15:30:10 +02:00
effectloader.cpp Drop "kwin4_effect_" prefix for BuiltIn Effects 2014-04-28 13:52:50 +02:00
effectloader.h Improve specifying the data about the built-in effects 2014-04-28 13:48:50 +02:00
effects.cpp Do not register dbus service org.kde.kwin.Effects 2014-05-15 10:55:29 +02:00
effects.h [effects] Get xcb_connection_t* and rootWindow through EffectsHandler API 2014-04-16 16:05:05 +02:00
egl_wayland_backend.cpp Add support for EGL_EXT_platform_wayland 2014-09-13 12:07:33 +02:00
egl_wayland_backend.h Add support for EGL_EXT_platform_wayland 2014-09-13 12:07:33 +02:00
eglonxbackend.cpp Add support for EGL_EXT_platform_x11 2014-09-13 12:07:32 +02:00
eglonxbackend.h Remove SceneOpenGL::Texture::findTarget() 2014-09-01 17:45:58 +02:00
events.cpp Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
ExtraDesktop.sh
focuschain.cpp
focuschain.h
geometry.cpp allow FS mapping of geometry restricted windows 2014-07-10 13:36:50 +02:00
geometrytip.cpp
geometrytip.h
globalshortcuts.cpp Share implementation for adding shortcut (keyboard/pointer/axis) 2014-03-19 14:14:57 +01:00
globalshortcuts.h Share implementation for adding shortcut (keyboard/pointer/axis) 2014-03-19 14:14:57 +01:00
glxbackend.cpp Match the fbconfig visual depth to the window 2014-09-03 19:52:56 +02:00
glxbackend.h Match the fbconfig visual depth to the window 2014-09-03 19:52:56 +02:00
group.cpp Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
group.h Improve updating user timestamp 2014-06-03 13:59:10 +02:00
HACKING
input.cpp Fix unused variable warnings for compilation without xkbcommon 2014-04-28 16:57:35 +02:00
input.h Don't include xkbcommon/xkbcommon.h in input.h, forward-declare instead 2014-03-28 09:42:02 +01:00
killwindow.cpp Port XQueryPointer usage to XCB 2014-05-05 08:09:09 +02:00
killwindow.h
kwin.kcfg Introduce config option for OpenGLPlatformInterface 2014-05-13 09:23:03 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) 2014-09-02 10:43:26 +00:00
kwinbindings.cpp [kwin] Do not use a KActionCollection for Workspace's global shortcut actions 2013-12-10 10:01:13 +01:00
KWinDBusInterfaceConfig.cmake.in Use ecm_configure_package_config_file instead of configure_file 2014-03-27 12:38:36 +01:00
lanczosfilter.cpp Do not check graphicsEffectsLevel for LanczosFilter 2013-09-09 06:03:35 +02:00
lanczosfilter.h
layers.cpp [kwin] Use std::find_if and lambda functions for Workspace::findClient 2014-03-25 15:17:11 +01:00
main.cpp Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
main.h Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
main_wayland.cpp [kwin_wayland] Cleanup wayland_backend.[h|cpp] 2014-08-27 08:57:06 +02:00
main_wayland.h Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
main_x11.cpp Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
main_x11.h Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
Mainpage.dox
manage.cpp Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
Messages.sh Adjust kwin and killer to new ki18n 2014-05-05 08:03:54 +02:00
netinfo.cpp Add WM2Activities to supported properties 2014-09-16 08:07:32 +02:00
netinfo.h [kwin] Remove support for _NET_WM_TAKE_ACTIVITY protocol 2014-03-25 15:03:21 +01:00
options.cpp Introduce config option for OpenGLPlatformInterface 2014-05-13 09:23:03 +02:00
options.h Introduce config option for OpenGLPlatformInterface 2014-05-13 09:23:03 +02:00
org.freedesktop.ScreenSaver.xml Add a copy of org.freedesktop.ScreenSaver.xml for KWin 2014-03-24 16:30:22 +01:00
org.kde.kwin.Compositing.xml Create dedicated class for CompositorDBusInterface 2014-06-10 10:52:25 +02:00
org.kde.kwin.Effects.xml [kwin] Add a new EffectLoader 2014-03-28 14:04:55 +01:00
org.kde.KWin.xml
outline.cpp [outline] Use QScopedPointer for created QML item 2014-05-30 15:54:24 +02:00
outline.h [outline] Use QScopedPointer for created QML item 2014-05-30 15:54:24 +02:00
overlaywindow.cpp
overlaywindow.h
paintredirector.cpp [PaintRedirector] Fix typo 2014-09-08 14:41:07 +02:00
paintredirector.h Use a single texture atlas for the decoration 2014-07-17 09:39:17 +02:00
placement.cpp [kwin] Remove cursorPos() from utils.h 2014-03-25 15:25:40 +01:00
placement.h [kwin] Make KWin place the OSD 2014-02-12 10:53:10 +01:00
README
resources.qrc
rules.cpp Remove opacity from Rules::update 2014-05-05 08:14:01 +02:00
rules.h Adjust kde-workspace to introduction of flags in NET classes 2014-02-05 17:40:19 +01:00
sc-apps-kwin.svgz Fix installing of icons 2014-06-02 14:56:42 +02:00
scene.cpp Add support for explicit command stream synchronization 2014-09-12 14:50:12 +02:00
scene.h Add support for explicit command stream synchronization 2014-09-12 14:50:12 +02:00
scene_opengl.cpp Add support for explicit command stream synchronization 2014-09-12 14:50:12 +02:00
scene_opengl.h Add support for explicit command stream synchronization 2014-09-12 14:50:12 +02:00
scene_qpainter.cpp [kwin_wayland] Split out Buffer and ShmPool into dedicated files 2014-08-27 08:57:06 +02:00
scene_qpainter.h [kwin] Remove unused config-workspace.h includes 2014-03-18 09:23:25 +01:00
scene_xrender.cpp xrender: Remove findFormatForVisual() 2014-09-01 17:45:58 +02:00
scene_xrender.h [kwin/scene_xrender] Use size of shell surface as xpixmap size in XRender/Wayland 2014-03-19 14:14:39 +01:00
screenedge.cpp block warps after warping for VD switch 2014-08-28 20:30:00 +02:00
screenedge.h block warps after warping for VD switch 2014-08-28 20:30:00 +02:00
screens.cpp [auto-tests] Add an initial test for Screens 2014-09-17 10:29:03 +02:00
screens.h Split out WaylandScreens into own header and source file 2014-09-17 09:05:11 +02:00
screens_wayland.cpp Split out WaylandScreens into own header and source file 2014-09-17 09:05:11 +02:00
screens_wayland.h Split out WaylandScreens into own header and source file 2014-09-17 09:05:11 +02:00
settings.kcfgc
shadow.cpp [Xcb::Wrapper] Introduce a Property and StringProperty Wrapper subclass 2014-04-17 07:41:33 +02:00
shadow.h Port reading the shadow property to XCB 2013-09-11 08:21:44 +02:00
shortcutdialog.ui [kwin] Use ui-file for ShortcutDialog 2014-02-27 10:18:37 +01:00
sm.cpp Merge branch 'KDE/4.11' 2014-01-29 20:28:27 +01:00
sm.h Create dedicated kwin_x11 and kwin_wayland binaries 2014-08-18 08:50:44 +02:00
tabgroup.cpp [kwin] Use a QIcon in Client for the icons instead of Pixmaps 2013-12-06 14:41:23 +01:00
tabgroup.h
thumbnailitem.cpp [kwin] Use std::find_if and lambda functions for Workspace::findClient 2014-03-25 15:17:11 +01:00
thumbnailitem.h Remove parent window id from ThumbnailItem 2013-08-13 09:57:51 +02:00
toplevel.cpp Toplevel::vis becomes Toplevel::m_visual and is xcb_visualid_t 2014-05-05 08:09:10 +02:00
toplevel.h Toplevel::vis becomes Toplevel::m_visual and is xcb_visualid_t 2014-05-05 08:09:10 +02:00
unmanaged.cpp Port Unmanaged::track to XCB 2014-05-05 08:09:10 +02:00
unmanaged.h Try to wait for DESTROY_NOTIFY before releasing an Unmanaged 2014-04-16 13:32:11 +02:00
useractions.cpp Remove Client::getWMHints in favor of functionality in NETWinInfo 2014-09-15 16:29:47 +02:00
useractions.h [kwin] Use new connect syntax in useractions.cpp 2014-03-27 18:11:19 +01:00
utils.cpp [Xcb::Wrapper] Introduce a Property and StringProperty Wrapper subclass 2014-04-17 07:41:33 +02:00
utils.h Add a bitCount() util function 2014-09-01 17:45:58 +02:00
virtualdesktops.cpp Add default shortcuts for virtual desktop switching actions 2014-07-03 16:02:34 +02:00
virtualdesktops.h [kwin] Add missing includes 2014-03-18 14:37:01 +01:00
wayland_backend.cpp [kwin_wayland] Cleanup wayland_backend.[h|cpp] 2014-08-27 08:57:06 +02:00
wayland_backend.h [kwin_wayland] Cleanup wayland_backend.[h|cpp] 2014-08-27 08:57:06 +02:00
workspace.cpp Move creating WaylandBackend into ApplicationWayland 2014-08-18 08:50:44 +02:00
workspace.h WORKAROUND bug #335926 2014-07-03 18:39:38 +02:00
xcbutils.cpp Print better error messages for XCB errors from extensions 2014-04-16 13:30:31 +02:00
xcbutils.h Distinguish empty and non existent properties 2014-06-11 11:08:02 +02:00

- A collection of various documents and links related to KWin is at http://techbase.kde.org/Projects/KWin .


- The mailing list for KWin is kwin@kde.org (https://mail.kde.org/mailman/listinfo/kwin).

- If you want to develop KWin, see file HACKING.

- If you want to check KWin's compliance with specifications, see file COMPLIANCE.

- File CONFIGURATION includes some details on configuring KWin.

- Below is some info for application developers about application interaction
  with the window manager, but it'd need some cleanup.








 This README is meant as an explanation of various window manager related
mechanisms that application developers need to be aware of. As some of these
concepts may be difficult to understand for people not having the required
background knowledge (since sometimes it's difficult even for people who
do have the knowledge), the mechanisms are first briefly explained, and
then an example of fixing the various problems is given.

 For comments, questions, suggestions and whatever use the kwin@kde.org
mailing list.


Table of contents:
==================

- Window relations
    - how to make the window manager know which windows belong together
- Focus stealing prevention
    - how to solve cases where focus stealing prevention doesn't work
      properly automatically



Window relations:
=================

(For now, this explanation of window relations is mainly meant for
focus stealing prevention. To be extended later.)

 All windows created by an application should be organized in a tree
with the root being the application's main window. Note that this is about
toplevel windows, not widgets inside the windows. For example, if you
have KWrite running, with a torn-off toolbar (i.e. a standalone toolbar),
a file save dialog open, and the file save dialog showing a dialog
for creating a directory, the window hiearchy should look like this:


             KWrite mainwindow
              /             \
             /               \
      file save dialog      torn-off toolbar
            \
             \
          create directory dialog

 Each subwindow (i.e. all except for the KWrite mainwindow) points to its
main window (which in turn may have another main window, as in the case
of the file save dialog). When the window manager knows these relations,
it can better arrange the windows (keeping subwindows above their
main windows, preventing activation of a main window of a modal dialog,
and similar). Failing to provide this information to the window manager
may have various results, for example having dialogs positioned below
the main window,

The window property used by subwindows to point to their mainwindows is
called WM_TRANSIENT_FOR. It can be seen by running
'xprop | grep WM_TRANSIENT_FOR' and clicking on a window. If the property
is not present, the window does not (claim to) have any mainwindow.
If the property is present, it's value is the window id of its main window;
window id of any window can be found out by running 'xwininfo'. A window
having WM_TRANSIENT_FOR poiting to another window is said to be transient
for that window.

 In some cases, the WM_TRANSIENT_FOR property may not point to any other
existing window, having value of 0, or pointing to the screen number
('xwininfo -root'). These special values mean that the window is transient
for all other windows in its window group. This should be used only
in rare cases, everytime a specific main window is known, WM_TRANSIENT_FOR
should be pointing to it instead of using one of these special values.
(The explanation why is beyond the scope of this document - just accept it
as a fact.)

 With Qt, the WM_TRANSIENT_FOR property is set by Qt automatically, based
on the toplevel widget's parent. If the toplevel widget is of a normal
type (i.e. not a dialog, toolbar, etc.), Qt doesn't set WM_TRANSIENT_FOR
on it. For special widgets, such as dialogs, WM_TRANSIENT_FOR is set
to point to the widget's parent, if it has a specific parent, otherwise
WM_TRANSIENT_FOR points to the root window.

 As already said above, WM_TRANSIENT_FOR poiting to the root window should
be usually avoided, so everytime the widget's main widget is known, the widget
should get it passed as a parent in its constructor.
(TODO KDialog etc. classes should not have a default argument for the parent
argument, and comments like 'just pass 0 as the parent' should go.)



Focus stealing prevention:
==========================

 Since KDE3.2 KWin has a feature called focus stealing prevention. As the name
suggests, it prevents unexpected changes of focus. With older versions of KWin,
if any application opened a new dialog, it became active, and
if the application's main window was on another virtual desktop, also
the virtual desktop was changed. This was annoying, and also sometimes led
to dialogs mistakenly being closed because they received keyboard input that
was meant for the previously active window.

 The basic principle of focus stealing prevention is that the window with most
recent user activity wins. Any window of an application will become active
when being shown only if this application was the most recently used one.
KWin itself, and some of the related kdecore classes should take care
of the common cases, so usually there's no need for any special handling
in applications. Qt/KDE applications, that is. Applications using other
toolkits should in most cases work fine too. If they don't support
the window property _NET_WM_USER_TIME, the window manager may fail to detect
the user timestamp properly, resulting either in other windows becoming active
while the user works with this application, or this application may sometimes
steal focus (this second case should be very rare though).

 There are also cases where KDE applications needs special handling. The two
most common cases are when windows relations are not setup properly to make
KWin realize that they belong to the same application, and when the user
activity is not represented by manipulating with the application windows
themselves.

 Also note that focus stealing prevention implemented in the window manager
can only help with focus stealing between different applications.
If an application itself suddenly pops up a dialog, KWin cannot do anything about
it, and its the application's job to handle this case.


Window relations:
-----------------

 The common case here is when a dialog is shown for an application, but this
dialog is not provided by the application itself, but by some other process.
For example, dialogs with warnings about accepted cookies are provided
by KCookieJar, instead of being shown by Konqueror. In the normal case,
from KWin's point of view the cookie dialog would be an attempt of another
application to show a dialog, and KWin wouldn't allow activation of this
window.

 The solution is to tell the window manager about the relation between
the Konqueror main window and the cookie dialog, by making the dialog
point to the mainwindow. Note that this is not special to focus stealing
prevention, subwindows such as dialogs, toolbars and similar should always
point to their mainwindow. See the section on window relations for full
description.

 The WM_TRANSIENT_FOR property that's set on dialogs to point to their
mainwindow should in the cookie dialog case point to the Konqueror window
for which it has been shown. This is solved in kcookiejar by including
the window id in the DCOP call. When the cookie dialog is shown, its
WM_TRANSIENT_FOR property is manually set using the XSetTransientForHint()
call (see kdelibs/kioslave/http/kcookiejar/kcookiewin.cpp). The arguments
to XSetTransientForHint() call are the X display (i.e. QX11Info::display()),
the window id on which the WM_TRANSIENT_FOR property is to be set
(i.e. use QWidget::winId()), and the window id of the mainwindow.


  Simple short HOWTO:
  
 To put it simply: Let's say you have a daemon application that has
DCOP call "showDialog( QString text )", and when this is called, it shows
a dialog with the given text. This won't work properly with focus stealing
prevention. The DCOP call should be changed to
"showDialog( QString text, long id )". The caller should pass something like
myMainWindow->winId() as the second argument. In the daemon, before
the dialog is shown, a call to XSetTransientHint() should be added:

 XSetTransientForHint( QX11Info::display(), dialog->winId(), id_of_mainwindow );
 
 That's it.

Non-standard user activity:
---------------------------

 The most common case in KDE will be DCOP calls. For example, KDesktop's DCOP
call "KDesktopIface popupExecuteCommand". Executing this DCOP call e.g.
from Konsole as 'dcop kdesktop KDesktopIface popupExecuteCommand" will lead
to showing the minicli, but the last user activity timestamp gained from events
sent by X server will be older than user activity timestamp of Konsole, and
would normally result in minicli not being active. Therefore, before showing
the minicli, kdesktop needs to call KApplication::updateUserTimestamp().

 However, this shouldn't be done with all DCOP calls. If a DCOP call is not
a result of direct user action, calling KApplication::updateUserTimestamp()
would lead to focus stealing. For example, let's assume for a moment
that KMail would use this DCOP call in case it detects the modem is not
connected, allowing to you to start KPPP or whatever tool you use. If KMail
would be configured to check mail every 10 minutes, this would lead to minicli
possibly suddenly showing up at every check. Basically, doing the above change
to kdesktop's minicli means that the popupExecuteCommand() DCOP call is only
for user scripting. (TODO write about focus transferring?)

 Simply said, KApplication::updateUserTimestamp() should be called only
as a result of user action. Unfortunately, I'm not aware of any universal
way how to handle this, so every case will have to be considered separately.