yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/effects
History
Vlad Zagorodniy 59e3e21c47 [effects/sheet] Drop IsSheetWindow hack 
Summary:
When the Sheet effect was written, isModal worked only for Client
windows, not Deleted windows:

    bool EffectWindowImpl::isModal() const
        {
        if( Client* c = dynamic_cast< Client* >( toplevel ))
            return c->isModal();
        return false;
        }

so the Sheet effect had to track windows by using WindowInfo class, e.g.

    class WindowInfo
        {
        public:
            bool deleted;
            bool added;
            bool closed;
        };

the biggest drawback of that method is that WindowInfo for each modal kept around
as long as those modals existed. It also was adding little overhead, e.g.

    void SheetEffect::paintWindow( EffectWindow* w, int mask, QRegion region, WindowPaintData& data )
        {
        if( windows.contains( w ) && ( windows[ w ].added || windows[ w ].closed ) )

Things changed with a8160b3c31afa1db24084147ad4ce50cf3c0314a. With that
commit, WindowInfo kept only for modals that are currently being
animated, but isModal still worked only with Client windows, so
IsSheetWindow hack had been introduced.

Long story short: we don't need IsSheetWindow hack anymore because
isModal now works with Deleted windows.

Test Plan: Pressed Ctrl+O in Kate.

Reviewers: #kwin, graesslin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D14246
2018-07-21 10:44:18 +03:00
..
backgroundcontrast [effects/backgroundcontrast] Calculate correct y-coord of the copy rect 2018-05-17 02:51:50 -07:00
blur Fix multimonitor blur 2018-06-18 19:05:23 +01:00
colorpicker Scaling support in ColorPicker effect 2017-04-28 10:23:13 +01:00
coverswitch SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
cube [effects/cube] Change type of the rotationDuration property to int 2018-07-02 12:46:38 +03:00
desktopgrid Merge branch 'Plasma/5.13' 2018-07-11 16:42:09 +03:00
dialogparent SVN_SILENT made messages (.desktop file) - always resolve ours 2017-03-25 06:02:34 +01:00
diminactive SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
dimscreen [effects/dimscreen] Use QSet for checking whether activated window asks for permissions 2018-06-09 12:27:52 +03:00
eyeonscreen SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
fade SVN_SILENT made messages (.desktop file) - always resolve ours 2017-06-04 05:39:14 +02:00
fadedesktop SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
fallapart [effects/fallapart] Fade out window parts 2018-06-14 16:38:12 +03:00
flipswitch SVN_SILENT made messages (.desktop file) - always resolve ours 2018-02-12 07:04:02 +01:00
frozenapp SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-21 07:15:30 +02:00
glide [effects/glide] Do not animate logout screen 2018-06-01 19:15:26 +03:00
highlightwindow [effects] Support xcbConnectionChanged for support properties 2017-09-12 18:53:31 +02:00
invert SVN_SILENT made messages (.desktop file) - always resolve ours 2018-02-12 07:04:02 +01:00
kscreen [effects/kscreen] Port to TimeLine 2018-07-05 23:00:27 +03:00
login SVN_SILENT made messages (.desktop file) - always resolve ours 2018-05-18 05:45:28 +02:00
logout SVN_SILENT made messages (.desktop file) - always resolve ours 2018-07-15 05:21:01 +02:00
lookingglass [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
magiclamp [effects/magiclamp] Eliminate unnecessary reallocations 2018-07-15 01:41:37 +03:00
magnifier [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
maximize [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
minimizeanimation [effects/minimizeanimation] Port to TimeLine 2018-06-30 10:41:14 +03:00
morphingpopups SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
mouseclick SVN_SILENT made messages (.desktop file) - always resolve ours 2017-12-25 04:44:28 +01:00
mousemark SVN_SILENT made messages (.desktop file) - always resolve ours 2017-12-25 04:44:28 +01:00
presentwindows [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
resize Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
scalein SVN_SILENT made messages (.desktop file) - always resolve ours 2017-04-16 04:05:25 +02:00
screenedge [ScreenEdgeEffect] Create glow Svg on demand 2017-09-28 10:18:36 +02:00
screenshot Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
sheet [effects/sheet] Drop IsSheetWindow hack 2018-07-21 10:44:18 +03:00
showfps Fix build with a KWindowSystem framework that doesn't pull QWidget 2017-11-17 17:30:58 +01:00
showpaint [effects] Use shader traits in ShowPaint effect 2016-01-25 14:11:54 +01:00
slide [effects/slide] Clean up 2018-07-11 17:06:59 +03:00
slideback [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
slidingpopups [effects/slidingpopups] Use range-based for loops 2018-07-14 22:06:28 +03:00
snaphelper [effects] Use shader traits in SnapHelper effect 2016-01-25 14:11:54 +01:00
startupfeedback Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
thumbnailaside [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
touchpoints Fix unused-parameter warnings as reported by GCC 2017-07-28 21:31:09 +02:00
trackmouse SVN_SILENT made messages (.desktop file) - always resolve ours 2017-12-25 04:44:28 +01:00
translucency SVN_SILENT made messages (.desktop file) - always resolve ours 2017-08-10 04:56:42 +02:00
windowaperture SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
windowgeometry SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
wobblywindows SVN_SILENT made messages (.desktop file) - always resolve ours 2018-06-18 07:25:30 +02:00
zoom Remove Qt module declarations in includes 2018-06-05 18:07:23 +01:00
CMakeLists.txt [effects/slide] Add 'Duration' option 2018-01-01 16:54:02 +02:00
effect_builtins.cpp [effects] Use more effectData() in BuiltInEffects 2018-06-18 16:28:57 +03:00
effect_builtins.h [effects] Add a colorpicker effect 2016-11-25 09:30:34 +01:00
kwineffect.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2017-03-25 06:02:34 +01:00
logging.cpp pedantic fixes 2016-07-16 13:14:44 -04:00
Messages.sh
shaders.qrc Removed the "fastblur" path 2018-02-03 19:04:11 +01:00