My KWIN fork where I work on features like per-output virtual desktops
Find a file
Nate Graham 85b9aea5b4 Position OSD a bit farther down
Summary:
A common user complains is that our OSDs--particularly the volume OSD--are too intrusive
and get in the way of the screen content. For example when adjusting the volume while
watching a full-screen video, the volume change OSD will typically appear right in the
middle of an actor's face.

D20569 was an attempt to use a horizontal OSD to alleviate this issue. It mostly worked,
but IMO it was still positioned too high up.

This patch moved the placement down a little bit to make the OSD appear even farther from
the center of the screen to make it less likely to

I tried not to move it down too far or else it would interfere with subtitles in videos.

Test Plan:
With D20569:

{F8269172}
{F8269164}
{F8269163}

Reviewers: #kwin, #vdg, broulik, ndavis, zzag

Reviewed By: #kwin, #vdg, ndavis, zzag

Subscribers: meven, ndavis, niccolove, baberts, davidedmundson, filipf, zzag, kori, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D29263
2020-05-22 08:38:11 -06:00
autotests Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows 2020-05-13 16:41:33 +02:00
cmake/modules Properly include private Qt5 targets 2020-05-15 12:24:23 +02:00
colorcorrection Revert "[kcm/effects] Clip ListView" 2020-02-22 11:53:59 +01:00
data Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
decorations Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
doc Remove the "Candy" category and fold its contents into "Appearance" 2020-02-25 11:26:27 -07:00
effects [effects/showfps] Calculate "correct" FPS 2020-05-07 09:17:02 +03:00
helpers Cleanup style in CMakeLists.txt files 2019-09-17 16:03:05 +03:00
kcmkwin Merge branch 'Plasma/5.19' 2020-05-21 14:26:28 +05:30
kconf_update Fix kwin.upd not running if python 2 not installed 2020-01-27 16:11:46 +01:00
libinput Wayland: Allow to set a scroll Factor for input devices 2020-04-07 19:08:49 +02:00
libkwineffects Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
platformsupport Revert "Reload Shm texture when buffer size changes" 2020-05-04 15:36:55 +03:00
plugins Merge branch 'Plasma/5.19' 2020-05-21 14:26:28 +05:30
qml Move from Quad to Cubic 2020-03-04 19:40:35 +01:00
scripting scripting: Provide methods to create and remove virtual desktops 2020-05-21 09:14:55 +03:00
scripts [scripting] Introduce writable frameGeometry property 2020-05-12 08:35:18 +03:00
tabbox Move core shade code to AbstractClient 2020-05-07 22:03:31 +03:00
tests Remove orientation sensor 2020-02-29 09:59:30 +05:30
xwl Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
abstract_client.cpp Fix TestXdgShellClient::testDesktopFileName 2020-05-14 17:25:36 +02:00
abstract_client.h [scripting] Introduce writable frameGeometry property 2020-05-12 08:35:18 +03:00
abstract_opengl_context_attribute_builder.cpp
abstract_opengl_context_attribute_builder.h
abstract_output.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
abstract_output.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
abstract_wayland_output.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
abstract_wayland_output.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
activation.cpp Make it possible to have a separate cursor for the tablet 2020-04-03 01:16:45 +02:00
activities.cpp Store normal clients and desktop clients in the same list 2020-05-14 16:21:47 +03:00
activities.h Rename Client to X11Client 2019-09-25 21:11:37 +03:00
appmenu.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
appmenu.h
atoms.cpp [x11] Add support for _GTK_FRAME_EXTENTS 2019-11-27 14:12:30 +02:00
atoms.h [x11] Add support for _GTK_FRAME_EXTENTS 2019-11-27 14:12:30 +02:00
client_machine.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
client_machine.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
CMakeLists.txt Update version number for 5.19.80 2020-05-15 16:50:46 +01:00
composite.cpp Store normal clients and desktop clients in the same list 2020-05-14 16:21:47 +03:00
composite.h Revert "[platforms/x11] Never block on retrace, always present after paint" 2020-01-16 10:00:08 +01:00
config-kwin.h.cmake fix: make hwdata truly a runtime dependency 2020-03-17 15:39:17 +01:00
COPYING
cursor.cpp Set cursor size default to 24 to align with KCM 2020-04-17 14:43:51 +02:00
cursor.h Make it possible to have a separate cursor for the tablet 2020-04-03 01:16:45 +02:00
dbusinterface.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
dbusinterface.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
debug_console.cpp Store normal clients and desktop clients in the same list 2020-05-14 16:21:47 +03:00
debug_console.h Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
debug_console.ui
deleted.cpp Drop Toplevel::decorationRect() 2020-01-29 12:58:54 +02:00
deleted.h Drop Toplevel::decorationRect() 2020-01-29 12:58:54 +02:00
effectloader.cpp
effectloader.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
effects.cpp Emit Workspace::clientAdded() with AbstractClient 2020-05-12 08:38:01 +03:00
effects.h Merge setting up abstractclient and x11client connections in EffectsHandler 2020-05-11 13:27:45 +03:00
egl_context_attribute_builder.cpp
egl_context_attribute_builder.h
events.cpp Move core shade code to AbstractClient 2020-05-07 22:03:31 +03:00
fixqopengl.h
focuschain.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
focuschain.h Rename Client to X11Client 2019-09-25 21:11:37 +03:00
geometrytip.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
geometrytip.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
gestures.cpp Improve tests behaviour on set ups with high dpi 2020-03-24 00:16:04 +01:00
gestures.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
globalshortcuts.cpp
globalshortcuts.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
group.cpp Split group.cpp topic file 2019-12-03 19:43:47 +02:00
group.h Drop some custom list typedefs 2019-11-27 15:54:08 +02:00
HACKING.md Revert "[kcm/effects] Clip ListView" 2020-02-22 11:53:59 +01:00
idle_inhibition.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
idle_inhibition.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
input.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
input.h Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
input_event.cpp Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
input_event.h Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
input_event_spy.cpp Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
input_event_spy.h Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
internal_client.cpp Remove overloads on virtual methods 2020-03-26 16:10:10 +01:00
internal_client.h Remove overloads on virtual methods 2020-03-26 16:10:10 +01:00
keyboard_input.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
keyboard_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
keyboard_layout.cpp Port away from a deprecated signal 2020-01-25 23:13:53 +02:00
keyboard_layout.h
keyboard_layout_switching.cpp
keyboard_layout_switching.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
keyboard_repeat.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
keyboard_repeat.h [wayland] Avoid compare to unintialised value in keyboard repeat 2019-09-23 22:13:54 +02:00
killwindow.cpp
killwindow.h
kwin.kcfg Revert "Improve partial maximization strings" 2020-05-14 12:46:40 +03:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-10-23 09:29:41 +02:00
kwinbindings.cpp Remove disabled TabGroup feature 2019-09-14 10:58:48 +02:00
KWinDBusInterfaceConfig.cmake.in
layers.cpp Store normal clients and desktop clients in the same list 2020-05-14 16:21:47 +03:00
linux_dmabuf.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
linux_dmabuf.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
logind.cpp remove superfluous code 2019-01-27 12:05:22 +05:30
logind.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
logo.png GIT_SILENT: add KWin icon as repository logo 2020-05-20 12:47:52 +00:00
main.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
main.h Remove QSessionManager usage 2020-04-06 11:51:47 +02:00
main_wayland.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
main_wayland.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
main_x11.cpp Remove QSessionManager usage 2020-04-06 11:51:47 +02:00
main_x11.h Don't notify ksplash in our wayland session 2019-09-23 22:13:43 +02:00
Mainpage.dox
Messages.sh Extract messages from cpp files in colorcorrection/ 2020-01-12 21:24:17 +02:00
modifier_only_shortcuts.cpp Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
modifier_only_shortcuts.h
moving_client_x11_filter.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
moving_client_x11_filter.h
netinfo.cpp [x11] Add support for _GTK_FRAME_EXTENTS 2019-11-27 14:12:30 +02:00
netinfo.h Rename Client to X11Client 2019-09-25 21:11:37 +03:00
onscreennotification.cpp Move from Quad to Cubic 2020-03-04 19:40:35 +01:00
onscreennotification.h
options.cpp Revert "Improve partial maximization strings" 2020-05-14 12:46:40 +03:00
options.h Revert "Remove vsync detection and configurability" 2020-01-16 10:00:12 +01:00
org.kde.kappmenu.xml
org.kde.kwin.ColorCorrect.xml [nightcolor] Expose transition timings to d-bus 2020-01-15 21:15:26 +02:00
org.kde.kwin.Compositing.xml
org.kde.kwin.Effects.xml
org.kde.KWin.Session.xml Remove QSessionManager usage 2020-04-06 11:51:47 +02:00
org.kde.KWin.VirtualDesktopManager.xml
org.kde.KWin.xml Add a dbus method getWindowInfo returning same data as queryWindowInfo 2018-12-17 18:12:17 +01:00
osd.cpp
osd.h
outline.cpp [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
outline.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
outputscreens.cpp Associate output transforms and orientations 2019-11-26 22:29:40 +01:00
outputscreens.h Associate output transforms and orientations 2019-11-26 22:29:40 +01:00
overlaywindow.cpp
overlaywindow.h
placement.cpp Position OSD a bit farther down 2020-05-22 08:38:11 -06:00
placement.h Delete unused forward declaration of Client class 2019-09-16 16:31:09 +03:00
platform.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
platform.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
pointer_input.cpp Follow scale of drag surfaces 2020-05-13 14:44:27 +01:00
pointer_input.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
popup_input_filter.cpp Use AbstractClient instead of XdgShellClient wherever possible 2020-03-04 09:57:13 +02:00
popup_input_filter.h Use AbstractClient instead of XdgShellClient wherever possible 2020-03-04 09:57:13 +02:00
README.md Add a new markdown README 2018-12-22 08:42:38 +01:00
rootinfo_filter.cpp
rootinfo_filter.h
rulebooksettings.cpp Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
rulebooksettings.h Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
rulebooksettingsbase.kcfg Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
rulebooksettingsbase.kcfgc Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
rules.cpp Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
rules.h Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
rulesettings.kcfg Fix minor typo: inital -> initial 2020-03-17 09:41:12 +02:00
rulesettings.kcfgc Port kwinrules kcm to kconfigxt 2020-03-16 13:21:43 +01:00
scene.cpp [scene] Re-build window quads after creating a WindowPixmap 2020-05-19 14:06:06 +03:00
scene.h [scene] Generate window quads for sub-surfaces 2020-05-04 15:36:30 +03:00
screenedge.cpp Make it possible to have a separate cursor for the tablet 2020-04-03 01:16:45 +02:00
screenedge.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
screenlockerwatcher.cpp Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
screenlockerwatcher.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
screens.cpp Make it possible to have a separate cursor for the tablet 2020-04-03 01:16:45 +02:00
screens.h Improve tests behaviour on set ups with high dpi 2020-03-24 00:16:04 +01:00
settings.kcfgc
shadow.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
shadow.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
shortcutdialog.ui
sm.cpp Remove QSessionManager usage 2020-04-06 11:51:47 +02:00
sm.h Remove QSessionManager usage 2020-04-06 11:51:47 +02:00
subsurfacemonitor.cpp [scene] Rebuild window quads when sub-surface tree changes 2020-05-04 15:36:40 +03:00
subsurfacemonitor.h [scene] Rebuild window quads when sub-surface tree changes 2020-05-04 15:36:40 +03:00
syncalarmx11filter.cpp [x11] Enable synchronized resizing for Xwayland clients 2020-04-29 16:37:23 +03:00
syncalarmx11filter.h [x11] Enable synchronized resizing for Xwayland clients 2020-04-29 16:37:23 +03:00
tablet_input.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
tablet_input.h Implement the tablet wayland protocol in kwin 2020-03-20 03:05:41 +01:00
tabletmodemanager.cpp Fix the tablet mode manager 2020-03-11 13:06:57 +05:30
tabletmodemanager.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
TESTING.md [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
thumbnailitem.cpp Use AbstractClient instead of XdgShellClient wherever possible 2020-03-04 09:57:13 +02:00
thumbnailitem.h Use nullptr everywhere 2019-09-19 17:48:21 +03:00
toplevel.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
toplevel.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
touch_hide_cursor_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_hide_cursor_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
touch_input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
udev.cpp [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
udev.h [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
unmanaged.cpp Revert "[kcm/effects] Clip ListView" 2020-02-22 11:53:59 +01:00
unmanaged.h [wayland] Implement window geometry more properly 2019-11-27 14:12:30 +02:00
useractions.cpp Move core shade code to AbstractClient 2020-05-07 22:03:31 +03:00
useractions.h Rename Client to X11Client 2019-09-25 21:11:37 +03:00
utils.cpp Reduce the amount of objects that are compiled several times 2020-04-02 00:41:55 +02:00
utils.h Reduce the amount of objects that are compiled several times 2020-04-02 00:41:55 +02:00
virtual_terminal.cpp Port away from deprecated headers 2019-07-09 23:59:07 +03:00
virtual_terminal.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
virtualdesktops.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
virtualdesktops.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
virtualdesktopsdbustypes.cpp
virtualdesktopsdbustypes.h
virtualkeyboard.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
virtualkeyboard.h Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
virtualkeyboard_dbus.cpp
virtualkeyboard_dbus.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
was_user_interaction_x11_filter.cpp
was_user_interaction_x11_filter.h
wayland_cursor_theme.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
wayland_cursor_theme.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
wayland_server.cpp wayland_server: Improve debug message, reduce duplicates 2020-05-14 17:25:13 +02:00
wayland_server.h drop unused headers 2020-05-01 16:13:33 +01:00
window_property_notify_x11_filter.cpp Rename Client to X11Client 2019-09-25 21:11:37 +03:00
window_property_notify_x11_filter.h
workspace.cpp Store normal clients and desktop clients in the same list 2020-05-14 16:21:47 +03:00
workspace.h Store normal clients and desktop clients in the same list 2020-05-14 16:21:47 +03:00
x11client.cpp Move core shade code to AbstractClient 2020-05-07 22:03:31 +03:00
x11client.h Move core shade code to AbstractClient 2020-05-07 22:03:31 +03:00
x11eventfilter.cpp
x11eventfilter.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xcbutils.cpp Use nullptr everywhere 2019-09-19 17:48:21 +03:00
xcbutils.h Adjust scene for client-side decorated clients 2019-11-27 14:12:30 +02:00
xdgshellclient.cpp drop unused headers 2020-05-01 16:13:33 +01:00
xdgshellclient.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
xkb.cpp Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
xkb.h Port KWin to KWaylandServer 2020-04-30 12:56:08 +02:00
xkb_qt_mapping.h Set Qt::KeypadModifier depending on current keysym 2019-12-30 14:41:26 +01:00
xwaylandclient.cpp [x11] Disable synchronized resizing for Xwayland < 1.21 2020-04-29 16:37:31 +03:00
xwaylandclient.h [x11] Disable synchronized resizing for Xwayland < 1.21 2020-04-29 16:37:31 +03:00

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contacting KWin development team

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Developing on KWin

Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.