My KWIN fork where I work on features like per-output virtual desktops
Find a file
Vlad Zagorodniy 96ac6a506b Drop redundant Compositor::hasScene()
Summary:
Compositor::hasScene() is redundant. Depending on use case, it can be
replaced by checking either m_state or Compositor::scene().

Reviewers: #kwin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D23744
2019-09-07 10:19:04 +03:00
autotests Traverse the stacking order backwards when switching between windows 2019-08-31 13:47:15 +03:00
cmake/modules Update URLs to use https 2019-03-25 19:26:23 +01:00
colorcorrection Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
data Use new logging category directory when ECM>=5.59 2019-06-13 13:31:51 +02:00
decorations Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
doc Update icon PNGs 2019-08-13 12:17:26 +03:00
effects Delete unused includes 2019-09-06 16:07:55 +03:00
helpers Port away from deprecated headers 2019-07-09 23:59:07 +03:00
kcmkwin Delete unused includes 2019-09-06 16:07:55 +03:00
kconf_update kconfig_update for auto border size introduction 2019-06-06 22:27:00 +02:00
libinput Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
libkwineffects Delete unused includes 2019-09-06 16:07:55 +03:00
platformsupport Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
plugins Delete unused includes 2019-09-06 16:07:55 +03:00
qml Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
scripting Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
scripts SVN_SILENT made messages (.desktop file) - always resolve ours 2019-08-07 08:44:46 +02:00
tabbox Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
tests Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
xwl Revert "wayland: Terminate client connections before Workspace is destroyed" 2019-08-07 11:21:30 +03:00
.arcconfig Adding .arcconfig 2016-03-15 13:37:47 +01:00
.arclint Add .arclint 2018-10-02 19:44:07 +03:00
abstract_client.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
abstract_client.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
abstract_opengl_context_attribute_builder.cpp Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
abstract_opengl_context_attribute_builder.h Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
abstract_output.cpp Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
abstract_output.h Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
abstract_wayland_output.cpp [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
abstract_wayland_output.h [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
activation.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
activities.cpp Revert "Remove saving and loading (and client matching by) WM_COMMAND." 2016-06-23 21:07:03 +02:00
activities.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
appmenu.cpp Don't try to open application menu when client doesn't have one 2018-04-23 15:42:02 +02:00
appmenu.h Fix minor EBN issues 2018-08-29 21:02:16 +03:00
atoms.cpp [xwl] text/x-uri converter for selected X url list format targets 2019-02-19 13:17:08 +01:00
atoms.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
client.cpp Delete commented Xlib code 2019-08-31 22:22:17 +03:00
client.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
client_machine.cpp
client_machine.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
CMakeLists.txt Update version number for 5.16.4 2019-07-30 10:48:38 +01:00
composite.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
composite.h Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
config-kwin.h.cmake [platforms/drm] EGLStream DRM Backend Initial Implementation 2019-04-15 07:26:22 -07:00
COPYING
cursor.cpp Drop XFixes include in cursor.cpp 2019-01-09 22:29:45 +02:00
cursor.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
dbusinterface.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
dbusinterface.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
debug_console.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
debug_console.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
debug_console.ui fixuifiles 2018-09-18 07:52:44 +02:00
deleted.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
deleted.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
effectloader.cpp Introduce an EffectsHandler::animationsSupported -> bool 2016-08-15 17:38:33 +02:00
effectloader.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
effects.cpp Delete unused includes 2019-09-06 16:07:55 +03:00
effects.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
egl_context_attribute_builder.cpp Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
egl_context_attribute_builder.h [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context 2017-07-17 16:53:37 +02:00
events.cpp Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
fixqopengl.h Fix the build on armhf/aarch64 2018-03-06 09:25:33 +05:30
focuschain.cpp Use explicit Chain type in the focus chain 2018-07-30 11:23:43 +03:00
focuschain.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
geometry.cpp Quick tile only resizeable clients 2019-09-05 10:37:39 +03:00
geometrytip.cpp
geometrytip.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
gestures.cpp Fix build with clang and GCC6 2017-03-29 14:45:44 +02:00
gestures.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
globalshortcuts.cpp Don't try to filter null key combinations 2018-04-24 16:35:23 +02:00
globalshortcuts.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
group.cpp Delete unused includes 2019-09-06 16:07:55 +03:00
group.h
HACKING.md Introduce a new HACKING.md document to replace the previous HACKING 2018-12-17 18:11:59 +01:00
idle_inhibition.cpp Use appropriate sequence algorithms in IdleInhibition 2019-01-11 15:28:28 +02:00
idle_inhibition.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
input.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input_event.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event.h Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
input_event_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
input_event_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
internal_client.cpp [wayland] Apply window rules only to xdg-shell clients 2019-07-09 15:13:49 +03:00
internal_client.h [wayland] Apply window rules only to xdg-shell clients 2019-07-09 15:13:49 +03:00
keyboard_input.cpp Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
keyboard_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
keyboard_layout.cpp Make the Keyboard Layout SNI passive 2019-04-09 23:38:52 +02:00
keyboard_layout.h Introduce support for keyboard layout switching policies 2017-04-22 08:15:25 +02:00
keyboard_layout_switching.cpp Use end() instead of constEnd() for where we compare to an iterator 2017-04-22 20:28:12 +02:00
keyboard_layout_switching.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
keyboard_repeat.cpp Split Keyboard Repeat handling into a dedicated InputEventSpy 2017-01-27 16:03:37 +01:00
keyboard_repeat.h Split Keyboard Repeat handling into a dedicated InputEventSpy 2017-01-27 16:03:37 +01:00
killwindow.cpp Use OnScreenNotification in kill window 2016-12-21 19:45:02 +01:00
killwindow.h Support interactive window selection through the Platform 2016-11-17 08:08:56 +01:00
kwin.kcfg Remove Client fullscreen hack 2019-07-09 10:41:51 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-08-04 08:53:00 +02:00
kwinbindings.cpp Be consistent in undefining macros 2019-08-11 12:09:23 +02:00
KWinDBusInterfaceConfig.cmake.in
layers.cpp Delete unused includes 2019-09-06 16:07:55 +03:00
logind.cpp remove superfluous code 2019-01-27 12:05:22 +05:30
logind.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
main.cpp Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
main.h Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
main_wayland.cpp [platforms/drm] Early platform and outputs teardown 2019-09-05 17:00:40 +02:00
main_wayland.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
main_x11.cpp Don't use deprecated toAscii() method 2019-07-10 22:50:00 +03:00
main_x11.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
Mainpage.dox
manage.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
Messages.sh Fix untranslatable strings in debug_console.ui shortcutdialog.ui 2018-09-17 11:39:47 +02:00
modifier_only_shortcuts.cpp Track the actual pressed keys in ModifierOnlyShortcuts 2017-02-23 16:55:41 +01:00
modifier_only_shortcuts.h Track the actual pressed keys in ModifierOnlyShortcuts 2017-02-23 16:55:41 +01:00
moving_client_x11_filter.cpp Use more accurate name for Workspace::getMovingClient method 2019-04-22 11:12:22 +03:00
moving_client_x11_filter.h Move X11 movingClient handling into a dedicated X11EventFilter 2017-09-01 16:57:43 +02:00
netinfo.cpp Support NET_WM_STATE_FOCUSED 2019-05-10 15:32:55 +01:00
netinfo.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
onscreennotification.cpp Drop invalid .moc file inclusion 2018-03-04 16:10:18 +01:00
onscreennotification.h Add support for skip close animation to OnScreenMessage 2017-01-25 13:54:34 +01:00
options.cpp Don't use deprecated toAscii() method 2019-07-10 22:50:00 +03:00
options.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
org.kde.kappmenu.xml Restore global menu support 2017-01-11 10:21:03 +01:00
org.kde.kwin.ColorCorrect.xml [colorcorrection] Night Color - blue light filter at nighttime 2017-12-11 10:58:40 +01:00
org.kde.kwin.Compositing.xml [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required 2016-09-13 15:47:42 +02:00
org.kde.kwin.Effects.xml
org.kde.kwin.OrientationSensor.xml Add DBus interface to OrientationSensor and a persistent configuration 2017-12-26 22:02:47 +01:00
org.kde.KWin.VirtualDesktopManager.xml [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
org.kde.KWin.xml Add a dbus method getWindowInfo returning same data as queryWindowInfo 2018-12-17 18:12:17 +01:00
orientation_sensor.cpp Fix orientation sensor DBus 2019-09-01 16:15:25 +01:00
orientation_sensor.h Remove unused forward declare 2019-09-01 16:40:08 +01:00
osd.cpp Add support for skip close animation to OnScreenMessage 2017-01-25 13:54:34 +01:00
osd.h Add support for skip close animation to OnScreenMessage 2017-01-25 13:54:34 +01:00
outline.cpp [wayland] Make sure that only the fading popups effect animates outline 2019-04-09 14:21:22 +03:00
outline.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
outputscreens.cpp Refactor getters in OutputScreens 2019-04-25 11:12:25 +03:00
outputscreens.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
overlaywindow.cpp Move the X11 specific OverlayWindow into the platform/x11 2017-08-12 11:32:29 +02:00
overlaywindow.h Move the X11 specific OverlayWindow into the platform/x11 2017-08-12 11:32:29 +02:00
placement.cpp Delete unused includes 2019-09-06 16:07:55 +03:00
placement.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
platform.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
platform.h [platforms/drm] Rework enablement and dpms switching 2019-09-05 17:36:21 +02:00
pointer_input.cpp Send axis_source, axis_discrete, and axis_stop 2019-05-17 12:06:10 +03:00
pointer_input.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
popup_input_filter.cpp Cancel popup if the user clicked window decoration of parent window 2017-04-11 20:22:32 +02:00
popup_input_filter.h Initial support for popup window handling 2017-04-07 16:14:50 +02:00
README.md Add a new markdown README 2018-12-22 08:42:38 +01:00
rootinfo_filter.cpp Create a dedicated X11EventFilter for the events used by RootInfo 2017-09-30 12:57:21 +02:00
rootinfo_filter.h Create a dedicated X11EventFilter for the events used by RootInfo 2017-09-30 12:57:21 +02:00
rules.cpp Make sure we don't resize clients before they've been set up 2019-06-23 19:59:19 +02:00
rules.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
scene.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
scene.h Split Compositor class in Wayland and X11 child classes 2019-08-07 21:06:53 +02:00
screenedge.cpp Port away from QRegion::rects 2019-07-10 01:00:51 +03:00
screenedge.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
screenlockerwatcher.cpp Close screen grabbing effect when screensaver starts 2019-06-23 18:00:47 +02:00
screenlockerwatcher.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
screens.cpp Remove BasicScreens class 2019-06-14 14:22:29 +02:00
screens.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
settings.kcfgc
shadow.cpp Avoid crash without XWayland 2019-06-23 17:58:49 +02:00
shadow.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
shell_client.cpp [wayland] Don't update margins in ShellClient::finishInit 2019-09-07 10:17:26 +03:00
shell_client.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
shortcutdialog.ui
sm.cpp Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
sm.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
tabgroup.cpp Port TabGroup from Client to AbstractClient 2018-05-20 19:50:29 +02:00
tabgroup.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
tabletmodemanager.cpp Make it possible to autodetect the tablet mode 2019-03-22 18:29:21 +01:00
tabletmodemanager.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
TESTING.md [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
thumbnailitem.cpp Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent 2019-08-10 16:25:12 +02:00
thumbnailitem.h Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent 2019-08-10 16:25:12 +02:00
toplevel.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
toplevel.h Delete unused includes 2019-09-06 16:07:55 +03:00
touch_hide_cursor_spy.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_hide_cursor_spy.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.cpp Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
touch_input.h Be consistent about touch point id type: use qint32 2019-08-11 22:15:05 +02:00
udev.cpp [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
udev.h [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
unmanaged.cpp Move Unmanaged-specific hack away from Toplevel::setupCompositing 2019-04-16 10:12:30 +03:00
unmanaged.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
useractions.cpp Switch to Q_ASSERT 2019-08-31 20:07:05 +03:00
useractions.h Remove usage of QWeakPointer for QObject 2019-08-10 11:18:16 +02:00
utils.cpp Delete unused includes 2019-09-06 16:07:55 +03:00
utils.h Make iterating over Layer enum simple 2019-08-11 16:23:08 +02:00
virtual_terminal.cpp Port away from deprecated headers 2019-07-09 23:59:07 +03:00
virtual_terminal.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
virtualdesktops.cpp Fix -Wsign-compare 2019-09-01 00:42:59 +03:00
virtualdesktops.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
virtualdesktopsdbustypes.cpp [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualdesktopsdbustypes.h [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualkeyboard.cpp Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
virtualkeyboard.h Revert "Load the keyboard on-demand" 2019-08-09 11:40:22 +05:30
virtualkeyboard_dbus.cpp Add DBus protocol to virtual keyboard 2017-10-19 17:59:19 +02:00
virtualkeyboard_dbus.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
was_user_interaction_x11_filter.cpp Create a dedicated X11EventFilter for recognizing first user interaction 2017-08-19 10:14:53 +02:00
was_user_interaction_x11_filter.h Create a dedicated X11EventFilter for recognizing first user interaction 2017-08-19 10:14:53 +02:00
wayland_cursor_theme.cpp Load Kwin's internal cursors for the highest resolution of attached monitors 2018-06-23 23:26:54 +01:00
wayland_cursor_theme.h Run clang-tidy with modernize-use-override check 2019-07-22 20:03:22 +03:00
wayland_server.cpp Lift output enablement into Platform 2019-09-05 17:22:44 +02:00
wayland_server.h Remove unused function declaration 2019-08-28 19:41:36 +02:00
window_property_notify_x11_filter.cpp Clean up includes 2018-08-31 22:58:11 +03:00
window_property_notify_x11_filter.h Add a dedicated X11EventFilter for forwarding property events to the effect system 2017-09-25 20:36:45 +02:00
workspace.cpp Drop redundant Compositor::hasScene() 2019-09-07 10:19:04 +03:00
workspace.h Cleanup the order of things in workspace.h file 2019-07-29 22:24:43 +03:00
x11eventfilter.cpp Support multiple event types in X11EventFilter 2016-11-16 07:48:19 +01:00
x11eventfilter.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xcbutils.cpp Don't call << in a temporary vector 2019-07-08 21:05:25 +02:00
xcbutils.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xkb.cpp Support enabling numlock on startup 2018-11-01 17:49:58 +01:00
xkb.h Use more traditional doxygen style 2019-07-29 22:06:19 +03:00
xkb_qt_mapping.h Support mapping QKeyEvent to xkb_keysym_t 2017-09-19 19:09:17 +02:00

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contacting KWin development team

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Developing on KWin

Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.