Summary:
If an effect is installed or removed, then all not yet committed changes
will be lost. This is undesired behaviour.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D18705
Summary:
The main motivation for adding this method is to avoid code duplication.
Both virtual desktops kcm and desktop effects kcm have their own logic
to create configuration dialogs for effects.
On the bright side, if we add support for declarative effect kcms, we
will need to change only this method.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D18704
Summary:
A while ago desktop effects and compositing settings lived under the
same roof
{F6584639}
{F6584642}
but time has passed and now those two have their own kcms. This causes
some issues:
* for newcomers it's harder to find code of the Desktop Effects KCM;
* git history doesn't look good, e.g. "[kcmkwin/compositing] Add some
bugs to Desktop Effects KCM to fix later";
* in general, the mix of two doesn't look good in the code.
This change splits out the Desktop Effects KCM. Unfortunately, in order
to have more nicer code I had to refactor EffectModel a little bit.
Before:
{F6584669}
After:
{F6587570}
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, ltoscano, mart, ngraham, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D18703
svn path=/trunk/KDE/kdebase/workspace/; revision=711906
The following changes were in SVN, but were removed from git:
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/triplegears.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=710142
The following changes were in SVN, but were removed from git:
M wallpapers/kde_box.png.desktop
M wallpapers/konqui.svgz.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=706753
The following changes were in SVN, but were removed from git:
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/andes-venezolanos.svgz.desktop
M wallpapers/default_gears.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
M wallpapers/triplegears.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=702200
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/KDE34.png.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/blue-bend.jpg.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/moon.svgz.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=701736
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/KDE34.png.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/Won-Ton-Soup-3.jpg.desktop
M wallpapers/aurora.svgz.desktop
M wallpapers/blue-bend.jpg.desktop
M wallpapers/celtic.svgz.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/default_gears.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
M wallpapers/triplegears.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=700288
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/KDE34.png.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/Won-Ton-Soup-3.jpg.desktop
M wallpapers/alta-badia.jpg.desktop
M wallpapers/andes-venezolanos.svgz.desktop
M wallpapers/aurora.svgz.desktop
M wallpapers/blue-bend.jpg.desktop
M wallpapers/celtic.svgz.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/default_gears.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/konqui.svgz.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/stelvio.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
M wallpapers/triplegears.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=699436
The following changes were in SVN, but were removed from git:
M wallpapers/KDE34.png.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=698492
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/KDE34.png.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/kde_box.png.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=693808
The following changes were in SVN, but were removed from git:
M wallpapers/KDE34.png.desktop
M wallpapers/kde_box.png.desktop
specification style. KInfoCenter KCMs left out for now,
but I think I got hold of all other KCMs in workspace.
If you want to see some of those icons (in System Settings or
for single KCMs), do a kbuildsycoca4. In order to function
correctly, we still need fallbacks implemented.
CCMAIL: kde-artists@kde.org
svn path=/trunk/KDE/kdebase/workspace/; revision=693746
svn path=/trunk/KDE/kdebase/workspace/; revision=693473
The following changes were in SVN, but were removed from git:
M wallpapers/KDE34.png.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=688104
The following changes were in SVN, but were removed from git:
M wallpapers/KDE34.png.desktop
M wallpapers/kde_box.png.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=685927
The following changes were in SVN, but were removed from git:
M wallpapers/sunshine-after-the-rain.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=681732
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/KDE34.png.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/Won-Ton-Soup-3.jpg.desktop
M wallpapers/andes-venezolanos.svgz.desktop
M wallpapers/blue-bend.jpg.desktop
M wallpapers/celtic.svgz.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/default_gears.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
M wallpapers/triplegears.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=680394
The following changes were in SVN, but were removed from git:
M wallpapers/default_gears.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=676131
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/Won-Ton-Soup-3.jpg.desktop
M wallpapers/andes-venezolanos.svgz.desktop
M wallpapers/blue-bend.jpg.desktop
M wallpapers/celtic.svgz.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/default_gears.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
M wallpapers/triplegears.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=675092
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/KDE34.png.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/Won-Ton-Soup-3.jpg.desktop
M wallpapers/aurora.svgz.desktop
M wallpapers/celtic.svgz.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/kde_box.png.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
svn path=/trunk/KDE/kdebase/workspace/; revision=669344
The following changes were in SVN, but were removed from git:
M wallpapers/All-Good-People-1.jpg.desktop
M wallpapers/Chicken-Songs-2.jpg.desktop
M wallpapers/No-Ones-Laughing-3.jpg.desktop
M wallpapers/Time-For-Lunch-2.jpg.desktop
M wallpapers/Totally-New-Product-1.jpg.desktop
M wallpapers/Won-Ton-Soup-3.jpg.desktop
M wallpapers/alta-badia.jpg.desktop
M wallpapers/andes-venezolanos.svgz.desktop
M wallpapers/blue-bend.jpg.desktop
M wallpapers/celtic.svgz.desktop
M wallpapers/default_blue.jpg.desktop
M wallpapers/default_gears.jpg.desktop
M wallpapers/floating-leaves.jpg.desktop
M wallpapers/globe.svgz.desktop
M wallpapers/here-gear.svgz.desktop
M wallpapers/konqui.svgz.desktop
M wallpapers/lineart.svgz.desktop
M wallpapers/moon.svgz.desktop
M wallpapers/seaofconero.jpg.desktop
M wallpapers/soft-green.jpg.desktop
M wallpapers/sunshine-after-the-rain.jpg.desktop
M wallpapers/triplegears.jpg.desktop
As effect's full internal name is used when looking up the effect, you now need to provide the full name
(e.g. kwin4_effect_blur instead of just blur) when loading effects via dcop.
svn path=/trunk/KDE/kdebase/workspace/; revision=669032
ATM you can toggle them on/off, but KWin part isn't done yet, so KWin doesn't care about your changes yet.
You can try it with 'kcmshell kwineffects'
svn path=/trunk/KDE/kdebase/workspace/; revision=668251
